Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…
This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…
Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…
Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…
Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …
No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…
Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …
Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…
Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…
This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…
Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…
Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…
Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …
New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…
Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…
Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…
Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…
Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…
Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…
P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …
File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedMerge pull request #11626by tobtoht · c489e3bd · Nov 7, 2026 · 5 filesMessage 58 · ThinInformational 23Details
Commit message · tobtoht
Merge pull request #11626
8774306 wallet-rpc: query addresses and incoming outputs across accounts (Samy)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This commit adds an optional 'all_accounts' flag to two Monero wallet RPC commands: one that lists wallet addresses and one that lists incoming funds. When enabled, the command returns data across every account instead of just one. The change is a feature addition, not a fix for a vulnerability. It does include a minor validation relaxation: if 'all_accounts' is true, the provided account index is ignored rather than checked against the number of accounts. This is intentional and documented by the new tests.
AI review queuedMerge pull request #11560by tobtoht · 12ee4b23 · Nov 7, 2026 · 1 fileMessage 58 · ThinLow 37Details
Commit message · tobtoht
Merge pull request #11560
663c26b wallet2: reject NUL bytes in reserve proof messages (selsta)
ACKs: jpk68, thomasbuilds
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100
This commit adds a guard in Monero's wallet software that rejects reserve proof messages containing a NUL (zero) byte. Reserve proofs are cryptographic receipts that prove a wallet controls certain funds. The change prevents messages with embedded NUL bytes from being used, likely to avoid ambiguity or manipulation when the message is later parsed, displayed, or signed. The exact attack is not described in the commit, but NUL-byte injection is a common source of parsing and verification bugs.
AI review queuedMerge pull request #11295by tobtoht · 7479eb00 · Nov 7, 2026 · 4 filesMessage 58 · ThinModerate 65Details
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 65/100
This update puts hard caps on transaction fee values that a Monero wallet will accept from a connected daemon (node). Before this change, a malicious or compromised node could tell the wallet to use extremely high fees, potentially draining a user's balance through excessive transaction costs. After the change, the wallet clamps any daemon-supplied fee parameter to safe maximums and logs a warning when it does so. The change also fixes a related bug where the wallet sometimes asked for the wrong fee type (per-byte vs per-kilobyte).
AI review queuedMerge pull request #11654by tobtoht · 2ae78ba3 · Nov 7, 2026 · 3 filesMessage 58 · ThinLow 44Details
Commit message · tobtoht
Merge pull request #11654
0a92dbe wallet: refetch full v1 transactions for tx proofs (Samy)
ACKs: jeffro256, selsta, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100
This Monero wallet update fixes a bug where transaction proofs for older 'version 1' transactions could be generated or checked using incomplete (pruned) transaction data. The wallet now automatically re-fetches the full unpruned transaction when it detects a pruned v1 transaction, ensuring proofs are based on complete data. The change also removes duplicated transaction-fetching code by introducing a shared helper function.
AI review queuedMerge pull request #11620by tobtoht · 39f79666 · Nov 7, 2026 · 2 filesMessage 58 · ThinModerate 59Details
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This change fixes a bug in Monero's wallet recovery process. Previously, if wallet recovery from keys failed partway through, the wallet software could leave the existing wallet file in a broken or overwritten state. The fix marks such failures as critical and, based on the added test, ensures a failed recovery does not overwrite or corrupt an existing wallet file. For users, this means attempting to recover a wallet with wrong or mismatched keys is less likely to destroy an existing wallet.
AI review queuedMerge pull request #11598by tobtoht · 98f4e0f4 · Nov 2, 2026 · 2 filesMessage 58 · ThinInformational 15Details
Commit message · tobtoht
Merge pull request #11598
e915b0f simplewallet: improve --help descriptions for wallet CLI options (daumega)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only updates user-facing help text for command-line options in the Monero wallet. It clarifies what certain options do (for example, adding 'for daemon RPC' to SSL option descriptions and adding a missing description for the --command option). No code behavior, defaults, or security logic was changed.
AI review queuedMerge pull request #11594by tobtoht · 9ab5f101 · Nov 2, 2026 · 1 fileMessage 58 · ThinInformational 21Details
Commit message · tobtoht
Merge pull request #11594
c217885 simplewallet: match --mnemonic-language case-insensitively (daumega)
ACKs: selsta, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This change makes the Monero wallet command-line tool accept mnemonic seed language names regardless of capitalization (for example, 'English' vs 'english'). Previously, only exact-case matches were accepted, which could cause a user's language preference to be silently ignored and fall back to the default language. This is a minor usability fix with very limited security implications.
AI review queuedMerge pull request #11558by tobtoht · 7c5e02c1 · Nov 2, 2026 · 2 filesMessage 58 · ThinModerate 54Details
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 54/100
This change fixes a bug in the Monero wallet software where legacy wallet keys could be encrypted twice during an automatic upgrade, which could corrupt the wallet file or prevent it from loading correctly. The patch removes two unnecessary encrypt/decrypt steps during the save process and adds a test to ensure legacy keys are upgraded to the new encrypted format properly.
AI review queuedMerge pull request #11327by tobtoht · c7284159 · Nov 2, 2026 · 8 filesMessage 58 · ThinInformational 15Details
Commit message · tobtoht
Merge pull request #11327
4712d39 cmake: use relative source/binary project paths (jeffro256)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a build-system cleanup. It replaces absolute top-level CMake path variables (CMAKE_SOURCE_DIR, CMAKE_BINARY_DIR) with project-relative ones (PROJECT_SOURCE_DIR, PROJECT_BINARY_DIR, CMAKE_CURRENT_SOURCE_DIR, CMAKE_CURRENT_BINARY_DIR). This makes the Monero project behave better when it is included as a subdirectory inside another CMake project, but it does not change any runtime code, network protocol, wallet logic, or cryptography. There is no security-relevant change visible in the diff.
AI review queuedMerge pull request #11587by tobtoht · c17c0fdc · Nov 2, 2026 · 1 fileMessage 58 · ThinModerate 60Details
Commit message · tobtoht
Merge pull request #11587
9805a82 simplewallet: clear recovery seed arguments after parsing (Samy)
ACKs: 0xFFFC0000*, jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 60/100
This update changes the Monero command-line wallet so that when a user types their secret recovery seed directly on the command line, the wallet now tries to erase that seed from the program's argument list in memory right after reading it. Before this change, the seed could sit in memory and also be visible to other users on the same machine through process listings or shell history. The change also adds a warning in the help text that command-line seeds may appear in process listings or shell history.
AI review queuedwallet_rpc_server: reopen log file on `SIGUSR1`by Samy · 01dfcd6d · Nov 1, 2026 · 2 filesMessage 45 · ThinInformational 18Details
Commit message · Samy
wallet_rpc_server: reopen log file on `SIGUSR1`
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This change adds a feature to the Monero wallet RPC server that lets administrators rotate log files on Unix-like systems by sending a SIGUSR1 signal. It mirrors an existing log-rotation capability already present in the main Monero daemon. There is no indication in the commit that this fixes a security vulnerability; it is a usability/operational improvement.
AI review queuedMerge pull request #11396by tobtoht · 3fd0f88c · Oct 25, 2026 · 4 filesMessage 58 · ThinInformational 19Details
Commit message · tobtoht
Merge pull request #11396
bcd1791 wallet: batch account balances for RPC (Samy)
ACKs: selsta, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit refactors how the Monero wallet RPC server reports account balances. Instead of asking the wallet one account at a time for its balance, it adds a new internal batching helper that scans all relevant transactions once and returns balances for all requested accounts. The change is accompanied by unit tests that verify the new batch result matches the old per-account result. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a performance and consistency improvement.
AI review queuedMerge pull request #10866by tobtoht · 76d425f8 · Oct 25, 2026 · 6 filesMessage 58 · ThinLow 47Details
Commit message · tobtoht
Merge pull request #10866
8e3b4b7 mnemonics: decode seeds with explicit language (Samy)
ACKs: thomasbuilds, jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 47/100
This Monero update lets wallet software decode a recovery seed using a specific language the user provides, rather than always guessing the language automatically. Some words exist in multiple language word lists, so the same seed phrase can produce different wallets depending on which language is used. The change is meant to prevent users from accidentally restoring the wrong wallet when their seed is valid in more than one language. It also lets the wallet RPC server try alternative languages when verifying a seed against an existing wallet.
AI review queuedMerge pull request #11573by tobtoht · 36946ea9 · Oct 24, 2026 · 1 fileMessage 58 · ThinLow 32Details
Commit message · tobtoht
Merge pull request #11573
0006899 simplewallet: serialize account, address and output commands with refresh (Samy)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 32/100
This Monero wallet command-line patch adds or moves idle locks around several account, address, and output commands. The goal appears to be preventing the wallet's background refresh thread from running at the same time as these commands, which could otherwise read or modify wallet state while it is being updated. The commit message frames it as serialization with refresh, not as a security fix. There is no direct evidence in the diff of an exploitable vulnerability, crash, or incorrect balance/address result, but missing or misplaced locks are a classic source of race-condition bugs.
AI review queuedMerge pull request #11572by tobtoht · fbc36ef8 · Oct 24, 2026 · 2 filesMessage 58 · ThinModerate 57Details
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 57/100
This patch fixes how Monero validates the number of participants in a multisig wallet. It replaces hand-rolled math for counting combinations with a safer library function and corrects a check that was looking at the wrong variable (threshold instead of total). The old code could allow invalid or oversized multisig setups, which might cause wallet creation failures or incorrect multisig behavior.
AI review queuedMerge pull request #11565by tobtoht · ffdb8a73 · Oct 24, 2026 · 2 filesMessage 58 · ThinModerate 59Details
Commit message · tobtoht
Merge pull request #11565
b0d90b7 wallet2: bind incoming transaction proofs to recipient outputs (selsta)
ACKs: jpk68, UkoeHB
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This Monero wallet code change refactors how transaction proofs are generated. Previously, incoming transaction proofs could be linked to outputs that were not actually destined for the recipient. The patch binds each proof to only the specific recipient output(s), and replaces shared secrets with random values when no matching output exists. This appears to fix a privacy weakness where a proof might incorrectly or over-broadly demonstrate receipt of funds.
AI review queuedMerge pull request #11563by tobtoht · d622e631 · Oct 24, 2026 · 2 filesMessage 58 · ThinInformational 23Details
Commit message · tobtoht
Merge pull request #11563
c3a3aec wallet: use tail subsidy for suggested confirmations (selsta)
ACKs: Ap4sh, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This commit changes how Monero wallets estimate how many confirmations a transaction should have before it is considered safe. Previously, the wallet used the actual reward from the most recent block, which can vary. Now it uses a fixed long-term reference reward. This makes the suggested confirmation count more stable and predictable, and removes the need for the wallet to query the latest block reward. It is a correctness/usability fix rather than a direct security patch, though bad confirmation advice could theoretically lead users to trust a transaction before it is fully settled.
AI review queuedMerge pull request #11557by tobtoht · c3ab634a · Oct 24, 2026 · 2 filesMessage 58 · ThinModerate 54Details
Commit message · tobtoht
Merge pull request #11557
00aad61 wallet: relock keys before multisig save (Samy)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 54/100
This patch fixes a bug in Monero's multisig wallet setup. Previously, when exchanging multisig key data, the wallet would sometimes save its keys file while the keys were still temporarily decrypted. The fix ensures the keys are re-locked before writing the wallet file. A new test confirms a wallet can be safely saved and reloaded during an intermediate multisig exchange step.
AI review queuedMerge pull request #11551by tobtoht · 25d4adc9 · Oct 24, 2026 · 5 filesMessage 68 · AdequateModerate 62Details
Commit message · tobtoht
Merge pull request #11551
0467659 wallet: use parsed daemon host for proxy verification (Samy)
ACKs: jpk68, selsta
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 62/100
This Monero wallet update fixes how the wallet checks whether a daemon address is a special privacy-protected .onion or .i2p address when using a proxy or SSL. Before the fix, the wallet could be tricked by unusual addresses containing spaces, tabs, null characters, or IPv6 scope symbols into thinking an ordinary internet address was a trusted .onion/.i2p address, which would let it skip required SSL certificate checks. That could allow a malicious daemon to impersonate a trusted node and potentially spy on or manipulate wallet traffic. The patch now properly parses the URL and rejects suspicious characters before deciding whether strong verification is needed.
AI review queuedMerge pull request #11548by tobtoht · 11dc667e · Oct 24, 2026 · 2 filesMessage 68 · AdequateInformational 15Details
Commit message · tobtoht
Merge pull request #11548
4746009 tests: fix compiler warning about dangling-else (SNeedlewoods)
ACKs: jpk68, jeffro256
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit fixes two compiler warnings about 'dangling else' statements in test code. It adds curly braces so that the intended code is clearly grouped with the 'if' statement. There is no change to the actual behavior of the tests or the Monero software, and no security issue is present.
AI review queuedMerge pull request #11547by tobtoht · 8a48fc88 · Oct 24, 2026 · 2 filesMessage 68 · AdequateModerate 59Details
Commit message · tobtoht
Merge pull request #11547
8e03f7e wallet: verify password before encrypt_keys (SNeedlewoods)
ACKs: jpk68, selsta
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This change adds a password check inside the wallet's key-encryption routine so that the wallet refuses to encrypt keys if the caller supplies the wrong password. Before, supplying an incorrect password could still trigger encryption, potentially leaving the wallet file in a state where the stored keys do not match the password the user actually knows. The patch is small and includes a new test that confirms the wrong-password case now throws an error.
AI review queuedMerge pull request #11546by tobtoht · 42dff4e5 · Oct 24, 2026 · 1 fileMessage 68 · AdequateModerate 57Details
Commit message · tobtoht
Merge pull request #11546
1388f36 wallet: verify password before make/exchange multisig (SNeedlewoods)
ACKs: jpk68, selsta
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This change adds a password check at the start of two wallet operations that create or modify multisignature ('multisig') wallets. Before the fix, these functions would proceed to decrypt the wallet's private keys using whatever password was supplied, even if it was wrong. With the fix, the password is verified first, so an incorrect password stops the operation before any sensitive key material is touched. This reduces the risk that an attacker with brief access to an unlocked wallet, or who supplies a wrong password, could trigger multisig operations or cause key-handling errors.
AI review queuedMerge pull request #11545by tobtoht · 539c5056 · Oct 24, 2026 · 2 filesMessage 58 · ThinModerate 59Details
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This change fixes a bug in how Monero wallets import 'outputs' (records of received funds). Previously, if an import failed part-way through—because the wallet lacked a needed subaddress—the code could leave behind partially-created records. These incomplete records could later be mistaken for valid, spendable money, potentially causing the wallet to build transactions that fail or behave incorrectly. The patch now only adds fully validated records and cleans up properly if the total number shrinks. A new test confirms that a failed import does not leave incomplete transfers behind.
AI review queuedMerge pull request #11539by tobtoht · 179aaf39 · Oct 24, 2026 · 2 filesMessage 58 · ThinLow 44Details
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100
This change fixes how a Monero cold wallet handles imported output files that are empty or in an older format. Previously, the wallet could misread an empty export and either fail to clear stale outputs or incorrectly treat the old format as valid, which could lead to a cold wallet showing wrong balances or accepting incomplete state. The patch makes the logic clearer: try the new format first, and only if that fails try the old format. New tests confirm that after a blockchain reorganization an empty export correctly clears outputs, and that an empty incremental export cannot be used to rebuild a cold wallet from scratch.
AI review queuedMerge pull request #11505by tobtoht · 0eb5a4d2 · Oct 24, 2026 · 2 filesMessage 58 · ThinInformational 19Details
Commit message · tobtoht
Merge pull request #11505
f3ebca3 wallet2: save address files for in-memory non-mainnet wallets (selsta)
ACKs: jpk68, plowsof
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This change fixes a small inconsistency in how Monero wallets are saved. When a wallet was created only in memory and then saved to disk on a test or staging network, it was missing the plain-text '.address.txt' file that normally gets created alongside mainnet wallets. The patch makes sure that address file is also written for non-mainnet wallets. It is a bug-fix for file output consistency, not a vulnerability that lets an attacker steal funds or keys.