AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Cryptographic libraries

Merge pull request #11603

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11603

6874328 wallet2: keep inputs spent by a confirmed tx when a pending tx fails (woodser)

ACKs: jpk68, selsta
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet try to spend the same coins again, leading to failed transactions, confusion, or in the worst case creation of a double-spend attempt that the network would reject. The fix tells the wallet to leave the 'spent' flag alone when a failure occurs if the coins were already spent by a confirmed transaction.

Recommended action

Apply the patch. Users who had pending transactions fail while the same inputs were spent by confirmed transactions should rescan their wallet or refresh to ensure spent-status and balance are consistent. Monitor for any related reports of balance discrepancies or failed spends.

Security signals we found

01

Incorrect state reset on failure path

02

Potential double-spend attempt caused by stale UTXO selection

03

Wallet balance/availability inconsistency after failed pending tx

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.