AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 65 Cryptographic libraries

Merge pull request #11295

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11295

3ed8e69 wallet2: bound daemon fee parameters (selsta)

ACKs: thomasbuilds, jpk68
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update puts hard caps on transaction fee values that a Monero wallet will accept from a connected daemon (node). Before this change, a malicious or compromised node could tell the wallet to use extremely high fees, potentially draining a user's balance through excessive transaction costs. After the change, the wallet clamps any daemon-supplied fee parameter to safe maximums and logs a warning when it does so. The change also fixes a related bug where the wallet sometimes asked for the wrong fee type (per-byte vs per-kilobyte).

Recommended action

Users should upgrade to a wallet release containing this commit, especially when connecting to untrusted or third-party daemons. Until upgraded, avoid using remote nodes you do not control for fee-sensitive operations, and review transaction fees before signing.

Security signals we found

01

Daemon-supplied fee parameters are now clamped to wallet-side maxima

02

New clamp_fee_parameter helper logs when daemon values exceed safe bounds

03

Fee quantization mask is bounded to a hardcoded power-of-ten constant

04

Per-byte vs per-kB fee path is correctly propagated to get_base_fee

05

NodeRPCProxy now caches the full fee vector for later clamped lookups

Risk score

Why this scored 65/100

Our methodology →
Potential impact 18/30
Exploitability 14/25
Stealth signal 10/15
Affected reach 12/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.