AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Cryptographic libraries

Merge pull request #11654

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11654

0a92dbe wallet: refetch full v1 transactions for tx proofs (Samy)

ACKs: jeffro256, selsta, jpk68
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This Monero wallet update fixes a bug where transaction proofs for older 'version 1' transactions could be generated or checked using incomplete (pruned) transaction data. The wallet now automatically re-fetches the full unpruned transaction when it detects a pruned v1 transaction, ensuring proofs are based on complete data. The change also removes duplicated transaction-fetching code by introducing a shared helper function.

Recommended action

Review the new get_tx_for_proof loop to ensure it cannot be induced to loop indefinitely by a malicious or misbehaving daemon, and confirm that error handling covers malformed full-transaction responses. Consider whether the fix should be backported to supported release branches.

Security signals we found

01

Correctness fix for cryptographic proof generation/verification relying on incomplete transaction data

02

Refactoring to reduce duplicated daemon RPC transaction-fetching code

03

Addition of unit test covering v1 pruned-tx fallback and v2 no-fallback behavior

04

Potential denial-of-service vector: loop re-requests daemon on pruned v1 tx; no explicit retry limit

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.