XMR
← All projectsMonero Project

Monero

Reference Monero node, command-line wallet, consensus, networking, and cryptographic protocol implementation.

Cryptographic librariesMoneroNode implementationsPrivacy protocolsNormal
Repository coverage

743 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

219security candidates228second-pass queue447AI analyses
119commits · 30 days
240commits · 60 days
644commits · 180 days
742commits · 365 days
Backfill bands
Sep 27 → Mar 3192 seen34 candidatesComplete
Mar 31 → Jul 29369 seen101 candidatesComplete
Jul 29 → Aug 28128 seen36 candidatesComplete
Aug 28 → Sep 2788 seen21 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
20Strong · 80–100
123Adequate · 60–79
534Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
jeffro256633850257
koe313259
tobtoht1823283150
Cole Munz424177
Masamune222164
SNeedlewoods805152
selsta1744997051
j-berman432934058
jpk68881452046
Samy371023048
Thomas271015057
SChernykh1188062
Analysis record

Published AI watches

Last scanned 4 minutes ago

Low 42 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11462

This Monero wallet update fixes a bookkeeping bug. When a wallet imported a list of its owned outputs and that list was smaller than a previous import, internal lookup maps (key images and public keys) could still point to entries that no …

Internal index/cache consistency fix in wallet output handlingPrevents out-of-range references after transfer list resizeAdds defensive repair on wallet cache load for unrefreshed wallets
160e2150by tobtoht+29−02 files
No security note in commit
Low 26 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11460

This commit simplifies how Monero's simplewallet decides whether a payment ID is a real encrypted ID or a dummy placeholder. Previously, the wallet checked both the payment ID value and whether any destination was an integrated address, an…

Removal of a CHECK_AND_ASSERT_MES consistency check between destination flags and payment ID valueChange from dual-factor classification (address type + payload) to payload-only classificationPotential for previously rejected transactions to be accepted if the old check was overly strict
4b84712eby tobtoht+1−91 file
No security note in commit
Low 42 AI analysisMessage 50 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

wallet2: trim stale transfer maps after output imports

This Monero wallet patch cleans up internal lookup tables (key-image and public-key indexes) when the list of owned transaction outputs is shrunk, for example during an output import. Without the cleanup, those indexes could point to entri…

Out-of-bounds index retained in wallet lookup maps after container shrinkPotential wallet crash or incorrect spend selection due to stale key-image / public-key mappingRepair-on-load for legacy wallet caches that predate the fix
80f75eaaby selsta+29−02 files
No security note in commit
Low 25 AI analysisMessage 50 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

simplewallet: classify payment IDs by their payload

This small change removes a consistency check in Monero's command-line wallet when loading a saved transaction. Previously, the wallet verified that a 'dummy' payment ID label matched a special zero-value payment ID. Now it labels the paym…

Removal of a CHECK_AND_ASSERT_MES consistency checkRemoval of integrated-address validation for payment ID classificationChange in UI/labeling logic for loaded transactions
5937d5cfby selsta+1−91 file
No security note in commit
Informational 22 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11161

This commit updates Monero's built-in blockchain checkpoints to match the v0.18.5.3 release. Checkpoints are hard-coded reference points that help nodes quickly verify they are following the correct chain and resist certain attacks. The ch…

Hard-coded blockchain checkpoint data updated to a newer height/hashExpected compiled-in block hashes digest changedNo new code paths, cryptographic changes, or bug fixes visible in the diff
b0a9d51eby tobtoht+7−74 files
No security note in commit
Low 38 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11448

This is a small code fix in Monero's wallet that keeps the recorded breakdown of received amounts consistent when a transaction output is 'burnt' (replaced or spent as part of a transaction the wallet is processing). The change adds a chec…

Defensive consistency check added (THROW_WALLET_EXCEPTION_IF)Fixes internal accounting of received output amountsNo explicit security claim in commit or supplied references
24a01223by tobtoht+7−01 file
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11443

This patch fixes a spot in the Monero wallet where an untrusted remote server (daemon) could supply a misleading 'status' field. Previously, the wallet used that raw status directly in its error handling, which could potentially make a mal…

Untrusted input from remote daemon used in error-handling pathMissing trust check on daemon-reported RPC statusSingle-call-site hardening patch
c03c1f15by tobtoht+1−11 file
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11406

This commit adds two new read-only options to the wallet's remote procedure call (RPC) interface so users can request their public view key and public spend key. Public keys are meant to be shared openly and are not secrets, so exposing th…

717a4235by tobtoht+17−03 files
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11394

This commit only updates a submodule pointer for the external polyseed library from one commit hash to another. The actual code changes inside the submodule are not shown in the diff, and no public references were supplied. There is no vis…

c437e73fby tobtoht+1−11 file
No security note in commit
Moderate 64 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11391

This patch fixes a size-limit accounting bug in Monero's built-in HTTP server. When a client sends multiple HTTP requests back-to-back on the same connection (pipelining), leftover buffered data from the next request was not being counted …

Request size limit bypass via pipelined HTTP cachingDenial-of-service / memory pressure potential from oversized requestsFix in low-level network protocol handler
9b24b744by tobtoht+2−11 file
No security note in commit
Moderate 51 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11386

This patch fixes a privacy leak in Monero's wallet RPC server. Previously, the --no-dns flag was ignored when no wallet was loaded, so the validate_address RPC call could still perform a DNS lookup (OpenAlias) even though the user had expl…

Privacy leak: RPC ignored --no-dns when no wallet loadedDNS lookup performed despite explicit user opt-outOpenAlias resolution could disclose queried addresses/aliases to DNS resolvers
9df95286by tobtoht+33−25 files
No security note in commit
Low 48 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11385

This commit adds cleanup of three additional memory buffers in Monero's seed-phrase key-stretching code. Before the change, leftover copies of intermediate secrets could remain in stack memory after the function finished. An attacker who c…

Sensitive intermediate key material left in stack memory after function returnUse of sodium_memzero to clear cryptographic buffersPBKDF2 implementation handling mnemonic-derived secrets
1cd8ae93by tobtoht+3−01 file
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11383

This update improves the Monero wallet's command that connects to a network node (daemon). It lets users supply a username/password and a proxy address when switching daemons, and it replaces an older one-step connection method with a newe…

Added mutex lock in wallet2::set_proxy to protect concurrent access to proxy and HTTP client stateset_daemon now passes RPC login credentials and proxy settings through the proper wallet2::set_daemon APITrust heuristic changed to only auto-trust local daemons when no proxy is in use
07e23b8fby tobtoht+78−172 files
No security note in commit
Low 42 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11253

This change alters how Monero creates a view-only wallet copy. Previously, the code exported outputs using a method that could strip some metadata. Now it copies the full internal transfer records directly, then wipes and clears the multi-…

Sensitive field sanitization before export (memwipe + clear of m_multisig_k)Change in data export path for view-only wallet creationPreservation of 'complete output metadata' implying previous path was incomplete
ff738959by tobtoht+9−31 file
No security note in commit
Moderate 69 AI analysisMessage 66 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11333

This Monero update hardens how public keys and transaction pubkeys are handled. It moves a low-level 'torsion clearing' routine into the core crypto library, adds checks that wallet/destination addresses are valid points on the main subgro…

Adds main-subgroup membership validation for public address keys (spend/view)Normalizes transaction public keys before use in payment-ID decryption and tx proofsMoves torsion-clearing primitive into core crypto layer to ensure consistent behavior
6f4b99abby tobtoht+178−15016 files
No security note in commit
Moderate 63 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11268

This Monero update fixes a networking bug where the server could accidentally block all of its worker threads while waiting for slow clients to accept data. If all workers became stuck this way, the node could stop processing any network t…

Removal of blocking condition-variable wait in network send pathFail-fast on send-queue overflow instead of parking worker threadsHTTP handler now propagates send failures and enters error state
dba16f07by tobtoht+205−3025 files
No security note in commit
Moderate 59 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11260

This Monero wallet patch adds stronger safety checks when a wallet prepares, signs, or loads multi-step transactions (unsigned transactions, multisig transactions, and cold-device transactions). It verifies that money going into the transa…

Adds duplicate-input detection across transaction setsAdds destination address type consistency checksAdds uint64 overflow guard for summed input amounts
66dd773eby tobtoht+265−454 files
No security note in commit
Low 34 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11144

This Monero update makes the network layer clean up leftover block download records when a peer connection fails or is rejected. Previously, rejected or disconnected peers could leave stale block spans in a queue, which might cause the nod…

Denial-of-service resistance: stale block spans from malicious or faulty peers could prevent a node from obtaining valid blocksState cleanup on peer disconnection/rejectionNo authentication or memory-safety bug evident in diff
ddfa2279by tobtoht+2−01 file
No security note in commit
Low 46 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11362

This small patch fixes a bug in the Monero wallet where, if an output had already been scanned once, the wallet would return early without clearing an error flag. In rare cases this could leave a stale 'error' state attached to a transacti…

Stale error-state propagation in wallet scanning logicMissing reset of tx_scan_info.error on cached/short-circuit code pathPotential for incorrect received-payment or scan-failure reporting
30860a26by tobtoht+3−01 file
No security note in commit
Low 34 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11366

This change fixes a binary search in the Monero wallet that previously could loop forever or behave incorrectly if something went wrong. The old code used an unbounded 'while (true)' loop and a midpoint calculation that could overflow. The…

Unbounded loop replaced with bounded iterationInteger overflow mitigation in midpoint calculationDefensive error handling added for search failure
c16cd3f7by tobtoht+4−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge pull request #11462by tobtoht · 160e2150 · Oct 2, 2026 · 2 filesMessage 58 · ThinLow 42Details
Commit message · tobtoht

Merge pull request #11462

80f75ea wallet2: trim stale transfer maps after output imports (selsta)

ACKs: jpk68, j-berman, plowsof

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100

This Monero wallet update fixes a bookkeeping bug. When a wallet imported a list of its owned outputs and that list was smaller than a previous import, internal lookup maps (key images and public keys) could still point to entries that no longer existed. The patch trims those stale pointers whenever the transfer list is shrunk, and also repairs them when loading an older wallet cache that has never been refreshed from a node. The main risk is that stale indices could cause the wallet to crash or behave incorrectly, but the code already threw an error if an out-of-range index was detected, so this is more of a robustness/correctness fix than an obvious exploit path.

AI review queuedwallet2: trim stale transfer maps after output importsby selsta · 80f75eaa · Oct 2, 2026 · 2 filesMessage 50 · ThinLow 42Details
Commit message · selsta

wallet2: trim stale transfer maps after output imports

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 42/100

This Monero wallet patch cleans up internal lookup tables (key-image and public-key indexes) when the list of owned transaction outputs is shrunk, for example during an output import. Without the cleanup, those indexes could point to entries that no longer exist, which could cause the wallet to crash or behave incorrectly when it later tries to spend or display funds. The patch also repairs any stale indexes when loading an older wallet cache that has never been refreshed from a node.

AI review queuedMerge pull request #11448by tobtoht · 24a01223 · Oct 2, 2026 · 1 fileMessage 58 · ThinLow 38Details
Commit message · tobtoht

Merge pull request #11448

ab343dc wallet2: keep received amount breakdown consistent (selsta)

ACKs: plowsof, jpk68, j-berman, PyXMR2025

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 38/100

This is a small code fix in Monero's wallet that keeps the recorded breakdown of received amounts consistent when a transaction output is 'burnt' (replaced or spent as part of a transaction the wallet is processing). The change adds a check that throws an internal wallet error if the expected amount cannot be found in the wallet's tracking list, and updates the tracked value to the remaining 'extra' amount. The commit message does not describe this as a security fix, and there is no direct evidence in the diff or supplied references that this is exploitable by an attacker.

AI review queuedMerge pull request #11443by tobtoht · c03c1f15 · Oct 2, 2026 · 1 fileMessage 58 · ThinModerate 60Details
Commit message · tobtoht

Merge pull request #11443

ff1157b wallet2: sanitize untrusted daemon status in sweep unmixable (selsta)

ACKs: SNeedlewoods, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 60/100

This patch fixes a spot in the Monero wallet where an untrusted remote server (daemon) could supply a misleading 'status' field. Previously, the wallet used that raw status directly in its error handling, which could potentially make a malicious daemon's response look trustworthy or cause the wallet to misbehave. The fix passes the status through a helper that treats the daemon as untrusted unless the user has explicitly marked it trusted.

AI review queuedMerge pull request #11391by tobtoht · 9b24b744 · Oct 2, 2026 · 1 fileMessage 58 · ThinModerate 64Details
Commit message · tobtoht

Merge pull request #11391

497984e epee: count buffered pipelined data against the request size limit (xmrack)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 64/100

This patch fixes a size-limit accounting bug in Monero's built-in HTTP server. When a client sends multiple HTTP requests back-to-back on the same connection (pipelining), leftover buffered data from the next request was not being counted toward the server's maximum allowed request size. A malicious or misbehaving client could therefore sneak in a request larger than the configured limit, potentially causing excessive memory use or a denial of service. The fix makes the server count that already-buffered data against the limit when it starts processing the next request.

AI review queuedMerge pull request #11386by tobtoht · 9df95286 · Oct 2, 2026 · 5 filesMessage 58 · ThinModerate 51Details
Commit message · tobtoht

Merge pull request #11386

0e2b994 wallet-rpc: honor --no-dns without a wallet (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 51/100

This patch fixes a privacy leak in Monero's wallet RPC server. Previously, the --no-dns flag was ignored when no wallet was loaded, so the validate_address RPC call could still perform a DNS lookup (OpenAlias) even though the user had explicitly disabled DNS. This could leak which address or alias a user was checking to DNS servers. The fix makes the RPC server honor --no-dns and --offline flags even without a wallet open.

AI review queuedMerge pull request #11383by tobtoht · 07e23b8f · Oct 2, 2026 · 2 filesMessage 58 · ThinInformational 21Details
Commit message · tobtoht

Merge pull request #11383

f4efec8 simplewallet: use set_daemon instead of init (SNeedlewoods)

ACKs: selsta, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This update improves the Monero wallet's command that connects to a network node (daemon). It lets users supply a username/password and a proxy address when switching daemons, and it replaces an older one-step connection method with a newer, more complete setup method. A small thread-safety lock was also added to the proxy-setting function. There is no clear security bug being fixed; it looks like a usability and consistency improvement.

AI review queuedMerge pull request #11253by tobtoht · ff738959 · Oct 2, 2026 · 1 fileMessage 58 · ThinLow 42Details
Commit message · tobtoht

Merge pull request #11253

7d702bf wallet_api: preserve output metadata in view-only wallet exports (selsta)

ACKs: jpk68, plowsof

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100

This change alters how Monero creates a view-only wallet copy. Previously, the code exported outputs using a method that could strip some metadata. Now it copies the full internal transfer records directly, then wipes and clears the multi-signature key field to avoid leaking a signing secret. The intent appears to be a security fix: preserving more metadata in view-only wallets while scrubbing data that should not be exported. However, the patch is small and the commit message does not explicitly call it a security fix, so the classification is uncertain.

AI review queuedMerge pull request #11268by tobtoht · dba16f07 · Oct 2, 2026 · 5 filesMessage 58 · ThinModerate 63Details
Commit message · tobtoht

Merge pull request #11268

a34b2a7 epee: avoid blocking RPC workers on full send queues (selsta)

ACKs: PyXMR2025*, jpk68, plowsof

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 63/100

This Monero update fixes a networking bug where the server could accidentally block all of its worker threads while waiting for slow clients to accept data. If all workers became stuck this way, the node could stop processing any network traffic, effectively causing a denial-of-service. The patch removes the blocking wait and instead drops connections that exceed send limits. It also makes HTTP response failures propagate correctly so a failed send stops further request processing instead of continuing blindly.

AI review queuedMerge pull request #11260by tobtoht · 66dd773e · Oct 2, 2026 · 4 filesMessage 58 · ThinModerate 59Details
Commit message · tobtoht

Merge pull request #11260

1c7ba69 tx/partial tx validation hardening (koe)

ACKs: selsta, thomasbuilds, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This Monero wallet patch adds stronger safety checks when a wallet prepares, signs, or loads multi-step transactions (unsigned transactions, multisig transactions, and cold-device transactions). It verifies that money going into the transaction is not counted twice, that change addresses really belong to the wallet, that outputs do not exceed inputs, and that destination address types stay consistent. These are defensive hardening measures against mistakes or maliciously crafted transaction files that could otherwise make the wallet sign an invalid or harmful transaction.

AI review queuedMerge pull request #11362by tobtoht · 30860a26 · Oct 2, 2026 · 1 fileMessage 58 · ThinLow 46Details
Commit message · tobtoht

Merge pull request #11362

9663a86 wallet2: reset scan status for already processed outputs (selsta)

ACKs: jpk68, plowsof, j-berman, thomasbuilds

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 46/100

This small patch fixes a bug in the Monero wallet where, if an output had already been scanned once, the wallet would return early without clearing an error flag. In rare cases this could leave a stale 'error' state attached to a transaction output, potentially causing the wallet to misreport whether a payment was received or whether scanning succeeded. It is a defensive correctness fix rather than a clear exploit, but stale error state in financial software can have security-adjacent consequences.

AI review queuedMerge pull request #11366by tobtoht · c16cd3f7 · Sep 30, 2026 · 1 fileMessage 58 · ThinLow 34Details
Commit message · tobtoht

Merge pull request #11366

109b58b wallet2: bound the timestamp-to-height search (Thomas)

ACKs: jpk68, SNeedlewoods

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 34/100

This change fixes a binary search in the Monero wallet that previously could loop forever or behave incorrectly if something went wrong. The old code used an unbounded 'while (true)' loop and a midpoint calculation that could overflow. The patch limits the loop to 64 iterations (enough for any blockchain height) and switches to a safer midpoint formula. In the worst case, the old loop might never terminate, causing the wallet to hang when looking up a blockchain height from a timestamp.

AI review queuedwallet2: sanitize untrusted daemon status in sweep unmixableby selsta · ff1157b1 · Sep 30, 2026 · 1 fileMessage 50 · ThinLow 46Details
Commit message · selsta

wallet2: sanitize untrusted daemon status in sweep unmixable

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 46/100

This commit changes how a Monero wallet handles error status codes returned by a remote daemon during a cleanup operation called 'sweep unmixable.' Previously, the wallet trusted the daemon's raw status response. Now it passes that status through a helper that treats certain errors differently when the daemon is not trusted. This is a hardening fix: a malicious or compromised remote node could potentially return a misleading status code that the wallet would treat as a fatal error, possibly disrupting the operation or influencing wallet behavior. The patch narrows what the wallet believes from an untrusted daemon.

AI review queuedMerge pull request #11364by tobtoht · 2f9d1bbb · Sep 28, 2026 · 1 fileMessage 58 · ThinLow 45Details
Commit message · tobtoht

Merge pull request #11364

be2cd75 wallet2: ignore long PIDs when block version is unknown (selsta)

ACKs: jpk68, tobtoht

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 45/100

This tiny change adjusts how the Monero wallet treats old-style unencrypted payment IDs when it cannot determine the block version of the transaction. Previously, if the block version was unknown (reported as 0), the wallet would still process the long payment ID. Now it ignores it, matching the intended privacy-preserving behavior for modern blocks. The risk is reduced privacy or accidental information leakage in edge cases, not theft of funds.

AI review queuedMerge pull request #11368by tobtoht · b5ab65c3 · Sep 28, 2026 · 4 filesMessage 66 · AdequateInformational 19Details
Commit message · tobtoht

Merge pull request #11368

5626dfc wallet2: restore from a Polyseed with --generate-from-json (Thomas)
0214b32 simplewallet: keep the restore height from --generate-from-json (Thomas)

ACKs: jpk68, selsta

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit fixes a wallet-creation bug: when restoring a Monero wallet from a special newer-style seed (called a Polyseed) using a JSON configuration file, the wallet software previously treated it like an older Electrum-style seed. This could cause the restore height to be set incorrectly and could apply an optional seed passphrase to the wrong key derivation path. The patch makes the JSON restore path recognize Polyseeds and handle their passphrase and birthday height correctly. It also preserves the restore height in the simplewallet command-line tool when no explicit restore height is provided.

AI review queuedMerge pull request #11365by tobtoht · 74ab3773 · Sep 28, 2026 · 7 filesMessage 66 · AdequateInformational 23Details
Commit message · tobtoht

Merge pull request #11365

af7d613 wallet_rpc: add get_wallet_info (SNeedlewoods)
67dc8ea wallet: add get_proxy (SNeedlewoods)

ACKs: selsta, jpk68

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100

This commit adds a new read-only wallet command called get_wallet_info that lets an authenticated user ask the wallet for basic metadata such as the wallet file name, address, wallet type, which network it is on, the daemon address, and any configured proxy. It also fixes a small consistency bug where the stored proxy setting was not updated when set_proxy was called. The change is informational only: it does not move, spend, or expose private keys, and it is blocked in restricted RPC mode. The main security consideration is that it makes it slightly easier for a logged-in RPC user to learn the wallet's network setup, which could help target further attacks if the RPC endpoint is already compromised.

AI review queuedMerge pull request #11346by tobtoht · 1019b788 · Sep 26, 2026 · 1 fileMessage 58 · ThinLow 42Details
Commit message · tobtoht

Merge pull request #11346

7e2e857 wallet2: validate block hash when repairing empty hashchain (selsta)

ACKs: PyXMR2025, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100

This patch adds a safety check in Monero's wallet code when it asks the connected node (daemon) for a block hash to repair an empty local record of past blocks. Previously, if the daemon returned malformed or invalid data, the wallet would silently treat the conversion as successful and use an uninitialized or corrupted hash. Now the wallet explicitly checks whether the conversion succeeded and throws an error if it did not. This is a defensive hardening fix that prevents the wallet from accepting an invalid block hash during a recovery operation.

AI review queuedMerge pull request #11350by tobtoht · cc6fb1d2 · Sep 26, 2026 · 5 filesMessage 58 · ThinInformational 24Details
Commit message · tobtoht

Merge pull request #11350

3e727c6 Expose wallet exist as rpc command (Deverick)

ACKs: PyXMR2025, jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This commit adds a new wallet RPC command called wallet_exists that lets a caller check whether a wallet file or its keys file already exists in the configured wallet directory. It also refactors existing filename validation into a shared helper. The new command is blocked in restricted RPC mode and reuses the same path-separator checks as create/open wallet, so it does not appear to introduce a new security vulnerability. It could, however, make it slightly easier for an authenticated RPC user to probe for wallet names.

AI review queuedMerge pull request #11263by tobtoht · 0ac3a540 · Sep 25, 2026 · 2 filesMessage 66 · AdequateModerate 59Details
Commit message · tobtoht

Merge pull request #11263

cbf3331 wallet2: validate key data in password and device checks (selsta)
923ee54 wallet2: check reserve proof additional key index (selsta)
4c82440 wallet2: validate legacy transfer output indices (selsta)
b76c4b7 wallet2: normalize account tags before assignment (selsta)

ACKs: thomasbuilds*, jpk68

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This Monero wallet update adds several safety checks to prevent the wallet software from crashing or behaving incorrectly when handling unusual wallet files, transaction proofs, or old account data. It does not appear to be a remote money-stealing bug, but rather hardening against malformed inputs that could cause errors or unexpected behavior.

AI review queuedMerge pull request #11319by tobtoht · e478eb5a · Sep 25, 2026 · 5 filesMessage 66 · AdequateLow 48Details
Commit message · tobtoht

Merge pull request #11319

fe371dd wallet2: filter unchecked RPC error statuses (selsta)
dab064f wallet2: validate public node addresses before display (selsta)
5834007 common: sanitize message writer console output (selsta)

ACKs: SNeedlewoods, thomasbuilds, jpk68

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 48/100

This Monero wallet update fixes three separate issues: it prevents weird or malicious text from log/console messages from confusing the terminal (terminal escape-sequence injection), it stops the wallet from trusting and displaying invalid public node addresses from the network, and it improves error handling when the wallet talks to a daemon so that untrusted RPC responses are not silently accepted. None of these directly steal funds, but they reduce ways an attacker could trick a user or hide problems.

AI review queuedMerge pull request #11274by tobtoht · d5ad72e5 · Sep 24, 2026 · 2 filesMessage 58 · ThinLow 37Details
Commit message · tobtoht

Merge pull request #11274

a319868 wallet2: validate account tags before mutation (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100

This commit fixes a bug in Monero's wallet software where the program would partially change account labels before checking whether all requested accounts actually exist. The fix moves the boundary check to the very beginning so the operation either fully succeeds or fully fails, and no partial changes are saved. The practical security impact is limited because the bug only affects account tagging metadata, not balances or transactions.

AI review queuedMerge pull request #11265by tobtoht · 3b18aeb1 · Sep 24, 2026 · 2 filesMessage 58 · ThinModerate 59Details
Commit message · tobtoht

Merge pull request #11265

3f7dc4e wallet2: reject malformed multisig_info on import (jpk68)

ACKs: UkoeHB, SNeedlewoods

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This Monero wallet update adds safety checks when a wallet imports 'multisig_info' data shared between co-signers in a multi-signature wallet. It now rejects files where the declared signer doesn't match the file header, or where the number of partial key images or signing nonces is wrong. These checks prevent malformed or mismatched multisig data from being processed further. The change includes new unit tests that confirm the rejections work.

AI review queuedMerge pull request #11244by tobtoht · c0944a04 · Sep 24, 2026 · 1 fileMessage 58 · ThinModerate 61Details
Commit message · tobtoht

Merge pull request #11244

bf54d18 wallet2: validate scan_tx daemon responses (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 61/100

This update adds a safety check in the Monero wallet software. When the wallet asks a network node (daemon) for details about specific transactions, it now verifies that the transactions it gets back are actually the ones it asked for. Without this check, a malicious or compromised node could potentially return the wrong transactions, which might confuse the wallet about balances or transaction history. The fix makes the wallet reject any response where the returned transaction IDs do not match the requested ones.

AI review queuednet: detect half-closed sockets before connection reuseby Guoqiang Liu · bb8f10c4 · Sep 22, 2026 · 5 filesMessage 83 · StrongModerate 63Details
Commit message · Guoqiang Liu

net: detect half-closed sockets before connection reuse

Track peer EOF and TLS closure before reusing idle connections. Make disconnect idempotent while preserving buffered data and pending operation lifetimes. Add loopback coverage for EOF, socket modes, and TLS shutdown behavior.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 63/100

This patch fixes a connection-reuse bug in Monero's networking helper. Previously, the client could reuse a TCP connection that the peer had already half-closed (for example, after sending data and shutting down its send side). That could lead to sending new requests over a dead connection, reading stale or truncated data, or reusing a TLS session after the peer sent a close alert. The change makes the client check for peer EOF and TLS close-notify before declaring a connection reusable, and makes disconnect safe to call multiple times without crashing or corrupting buffered data.

AI review queuedwallet: persist set_daemon params across wallet loads. - allow set_daemon without a wallet loadedby nahuhh · de19ff65 · Sep 20, 2026 · 6 filesMessage 65 · AdequateLow 27Details
Commit message · nahuhh

wallet: persist set_daemon params across wallet loads.
- allow set_daemon without a wallet loaded

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This Monero commit changes how the wallet remembers which daemon (server) it should connect to. Previously, if you told the wallet RPC server to use a specific daemon before any wallet was open, that setting was lost as soon as you opened or created a wallet. Now that setting is saved and automatically applied to wallets opened or created later. The change also lets you call set_daemon even when no wallet is loaded. There is one small security-relevant side effect: because the daemon settings now persist, a test helper that temporarily switches to a wrong daemon had to explicitly restore the 'trusted' flag afterward, otherwise the restored daemon would be treated as untrusted. The commit itself is a feature/fix for configuration persistence, not an exploit.