What changed, and why it matters
This change removes an old Apple-only workaround that forced Monero wallet software to use just one thread by default. On macOS, the wallet will now use the same default (0, meaning automatic) as other operating systems. This is a cleanup of stale code, not a fix for an active security vulnerability.
No security action required. Treat as routine maintenance. If the old workaround was still protecting against a real macOS threading issue, monitor for related bug reports after release.
Security signals we found
No security-related keywords in commit title or message
Change removes platform-specific threading workaround
No bug, CVE, or advisory references present
No functional hardening or input validation added
Evidence from the diff
The commit deletes the DEFAULT_MAX_CONCURRENCY macro that set max concurrency to 1 on APPLE and 0 elsewhere, replacing it with a plain 0 default. The original comment described it as a workaround for a ‘suspected bug in pthread/kernel on MacOS X’. No security relevance is stated in the commit or title.
Changed components
src/wallet/wallet_args.cppmax-concurrency default on macOS wallet buildsInspect captured patch +1 / −8
### src/wallet/wallet_args.cpp
@@ -43,13 +43,6 @@
#undef MONERO_DEFAULT_LOG_CATEGORY
#define MONERO_DEFAULT_LOG_CATEGORY "wallet.wallet2"
-// workaround for a suspected bug in pthread/kernel on MacOS X
-#ifdef __APPLE__
-#define DEFAULT_MAX_CONCURRENCY 1
-#else
-#define DEFAULT_MAX_CONCURRENCY 0
-#endif
-
namespace
{
class Print
@@ -107,7 +100,7 @@ namespace wallet_args
const command_line::arg_descriptor<std::string> arg_log_level = {"log-level", "0-4 or categories", ""};
const command_line::arg_descriptor<std::size_t> arg_max_log_file_size = {"max-log-file-size", "Specify maximum log file size [B]", MAX_LOG_FILE_SIZE};
const command_line::arg_descriptor<std::size_t> arg_max_log_files = {"max-log-files", "Specify maximum number of rotated log files to be saved (no limit by setting to 0)", MAX_LOG_FILES};
- const command_line::arg_descriptor<uint32_t> arg_max_concurrency = {"max-concurrency", wallet_args::tr("Max number of threads to use for a parallel job"), DEFAULT_MAX_CONCURRENCY};
+ const command_line::arg_descriptor<uint32_t> arg_max_concurrency = {"max-concurrency", wallet_args::tr("Max number of threads to use for a parallel job"), 0};
const command_line::arg_descriptor<std::string> arg_log_file = {"log-file", wallet_args::tr("Specify log file"), ""};
const command_line::arg_descriptor<std::string> arg_config_file = {"config-file", wallet_args::tr("Config file"), "", true};
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.