AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Cryptographic libraries

Merge pull request #11655

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11655

bf8d372 wallet2: refuse InProofs for transactions the wallet sent (Thomas)

ACKs: selsta, jpk68
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a transaction it sent, a user might trick someone into believing they had received funds when they had actually sent them to themselves (including change outputs). The patch adds a guard that refuses to create such proofs and updates tests to verify the refusal.

Recommended action

Review the completeness of the guard: ensure the spends_one_of_ours and get_tx_key_cached checks cover all cases where a wallet could generate an InProof for an outgoing transaction, and consider whether check_tx_proof verification should also reject such proofs for defense in depth.

Security signals we found

01

Prevents generation of misleading InProofs for outgoing/self-sent transactions

02

Adds explicit runtime guard in wallet proof generation path

03

Functional tests updated to assert refusal behavior

04

Potential proof-forgery/misrepresentation scenario mitigated

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.