AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 61 Cryptographic libraries

Merge pull request #11724

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11724

0cacd83 wallet_rpc_server: harden wallet filename validation (selsta)

ACKs: jpk68, thomasbuilds
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Windows also '\' and ':'). This prevents callers from tricking the server into opening or creating wallet files outside the intended directory, which could lead to files being written in unexpected places or existing wallets being accessed.

Recommended action

Treat this as a security hardening fix and include it in the next maintenance release. RPC server operators should upgrade; in the meantime, restrict RPC access to trusted clients and avoid exposing the wallet RPC port to untrusted networks. No immediate incident response is required unless the RPC interface is already exposed to adversaries.

Security signals we found

01

Path-traversal defense: blocks directory separators and parent-directory references in wallet filenames

02

Null-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handling

03

RPC input validation hardening in wallet_rpc_server

04

Platform-specific Windows path separator and drive-colon filtering

Risk score

Why this scored 61/100

Our methodology →
Potential impact 18/30
Exploitability 14/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.