AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 60 Cryptographic libraries

Merge pull request #11686

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11686

090d6d8 simplewallet: keep multisig info and tx keys out of logs (Samy)

ACKs: selsta, jpk68
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update changes the Monero wallet so that two especially sensitive pieces of information—multisig setup data and transaction secret keys—are still shown to the user on screen but are no longer written to the wallet's log files. Before, the same on-screen message routine also saved those messages to disk, which could leave private key material in persistent logs. The patch adds an 'unlogged' message writer and uses it for these two cases, plus adds a test to confirm the behavior.

Recommended action

Users and operators running `monero-wallet-cli` should upgrade to a version containing this commit and review existing log files for accidental retention of multisig info or tx keys, rotating or purging those logs if necessary. Developers should adopt `unlogged_success_msg_writer` for any future sensitive console output.

Security signals we found

01

Sensitive cryptographic material (multisig key-exchange data, transaction secret keys) removed from persistent log output

02

New 'unlogged' message writer primitive added to control log exposure

03

Unit test added to enforce the unlogged behavior

04

Pull request title explicitly frames change as keeping secrets out of logs

Risk score

Why this scored 60/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 8/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.