What changed, and why it matters
This change adds a password check at the start of two wallet operations that create or modify multisignature ('multisig') wallets. Before the fix, these functions would proceed to decrypt the wallet's private keys using whatever password was supplied, even if it was wrong. With the fix, the password is verified first, so an incorrect password stops the operation before any sensitive key material is touched. This reduces the risk that an attacker with brief access to an unlocked wallet, or who supplies a wrong password, could trigger multisig operations or cause key-handling errors.
Treat this as a security hardening fix and include it in the next release. Users running multisig wallets should upgrade. Wallet developers should audit other functions that construct wallet_keys_unlocker to ensure they all verify the password first.
Security signals we found
Missing authentication/authorization check before sensitive operation
Private key decryption reachable without prior password verification
Security-hardening patch adding pre-condition password validation
Multisig wallet operations protected by additional authentication step
Evidence from the diff
In src/wallet/wallet2.cpp, the patch inserts verify_password_with_cached_key(password) at the top of wallet2::make_multisig() and wallet2::exchange_multisig_keys(). Both functions then construct a wallet_keys_unlocker with the password to decrypt account keys. The added call ensures the supplied password matches the cached key before decryption is attempted. The commit message frames this as a security hardening measure: ‘verify password before make/exchange multisig’.
Changed components
src/wallet/wallet2.cppwallet2::make_multisig()wallet2::exchange_multisig_keys()Monero wallet multisig key exchange flowInspect captured patch +2 / −0
### src/wallet/wallet2.cpp
@@ -6205,6 +6205,7 @@ std::string wallet2::make_multisig(const epee::wipeable_string &password,
const std::vector<std::string> &initial_kex_msgs,
const std::uint32_t threshold)
{
+ verify_password_with_cached_key(password);
// decrypt account keys
std::optional<wallet_keys_unlocker> unlocker(std::in_place, *this, &password);
@@ -6303,6 +6304,7 @@ std::string wallet2::exchange_multisig_keys(const epee::wipeable_string &passwor
const std::vector<std::string> &kex_messages,
const bool force_update_use_with_caution /*= false*/)
{
+ verify_password_with_cached_key(password);
const multisig::multisig_account_status ms_status{this->get_multisig_status()};
CHECK_AND_ASSERT_THROW_MES(ms_status.multisig_is_active, "The wallet is not multisig");
Why this scored 57/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.