AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 23 Cryptographic libraries

Merge pull request #11626

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11626

8774306 wallet-rpc: query addresses and incoming outputs across accounts (Samy)

ACKs: jpk68, selsta
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds an optional 'all_accounts' flag to two Monero wallet RPC commands: one that lists wallet addresses and one that lists incoming funds. When enabled, the command returns data across every account instead of just one. The change is a feature addition, not a fix for a vulnerability. It does include a minor validation relaxation: if 'all_accounts' is true, the provided account index is ignored rather than checked against the number of accounts. This is intentional and documented by the new tests.

Recommended action

No immediate security action is required. Wallet RPC operators should review whether callers authorized for a single account should be allowed to use the new all_accounts flag, and ensure RPC authentication and access controls remain appropriate now that these endpoints can enumerate all accounts and incoming outputs.

Security signals we found

01

New optional RPC parameter changes access scope from single account to all accounts

02

Validation of account_index is skipped when all_accounts is true

03

RPC API version incremented, signaling a behavioral change

04

Functional tests explicitly pass account_index=99/subaddr_indices=[999] with all_accounts=true and expect success

Risk score

Why this scored 23/100

Our methodology →
Potential impact 2/30
Exploitability 3/25
Stealth signal 2/15
Affected reach 4/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.