AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Cryptographic libraries

Merge pull request #11572

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11572

a3ba012 wallet2: fix multisig participant count validation (selsta)

ACKs: jpk68, UkoeHB
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes how Monero validates the number of participants in a multisig wallet. It replaces hand-rolled math for counting combinations with a safer library function and corrects a check that was looking at the wrong variable (threshold instead of total). The old code could allow invalid or oversized multisig setups, which might cause wallet creation failures or incorrect multisig behavior.

Recommended action

Review the new tools::combinator implementation for overflow safety and correctness, ensure config::MULTISIG_MAX_SIGNERS is consistently enforced across all multisig entry points, and add regression tests for edge-case participant counts (e.g., total > threshold near the maximum).

Security signals we found

01

Incorrect variable used in input validation (threshold vs total)

02

Use of floating-point arithmetic for combinatorial counts replaced with integer library function

03

Manual factorial-based combination formula replaced with audited utility

04

Validation bound tied to config constant rather than hardcoded literal

05

Potential for malformed multisig seed to pass size check due to wrong participant count validation

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.