AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 54 Cryptographic libraries

Merge pull request #11557

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11557

00aad61 wallet: relock keys before multisig save (Samy)

ACKs: jpk68, selsta
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a bug in Monero's multisig wallet setup. Previously, when exchanging multisig key data, the wallet would sometimes save its keys file while the keys were still temporarily decrypted. The fix ensures the keys are re-locked before writing the wallet file. A new test confirms a wallet can be safely saved and reloaded during an intermediate multisig exchange step.

Recommended action

Apply the patch. It is a targeted fix with a regression test. Users creating or exchanging multisig wallets should update to a version containing this fix to avoid potential plaintext key material in wallet files.

Security signals we found

01

Keys may be written to disk in a decrypted state during multisig wallet save

02

Fix moves key re-encryption before wallet file write

03

New regression test covers intermediate multisig exchange save/reload

Risk score

Why this scored 54/100

Our methodology →
Potential impact 18/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.