AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 59 Cryptographic libraries

Merge pull request #11545

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11545

4143a92 wallet2: avoid caching incomplete outputs (Samy)

ACKs: jpk68, selsta
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change fixes a bug in how Monero wallets import 'outputs' (records of received funds). Previously, if an import failed part-way through—because the wallet lacked a needed subaddress—the code could leave behind partially-created records. These incomplete records could later be mistaken for valid, spendable money, potentially causing the wallet to build transactions that fail or behave incorrectly. The patch now only adds fully validated records and cleans up properly if the total number shrinks. A new test confirms that a failed import does not leave incomplete transfers behind.

Recommended action

Apply the patch and run the new cold_signing functional test. Wallet users who have imported outputs on cold wallets should rescan/refresh after upgrading to ensure no stale incomplete transfer records remain.

Security signals we found

01

Partial/incomplete state left in wallet database after an exception

02

Key image generation failure could create transfer records missing critical fields

03

Mismatch between m_transfers size and actual successfully imported outputs

04

Functional test added to verify no incomplete transfers survive a failed import

Risk score

Why this scored 59/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.