Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…
This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…
Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…
Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…
Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …
No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…
Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …
Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…
Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…
This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…
Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…
Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…
Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …
New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…
Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…
Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…
Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…
Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…
Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…
P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …
File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedMerge pull request #11451by tobtoht · 1795c1c6 · Oct 24, 2026 · 2 filesMessage 58 · ThinModerate 65Details
Commit message · tobtoht
Merge pull request #11451
262d2b7 wallet2: harden ring size and output distribution checks (selsta)
ACKs: jpk68, SNeedlewoods
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 65/100
This Monero wallet patch fixes two related issues. First, it prevents the wallet from ever estimating a ring size of zero, which could have caused fee or transaction-building errors. Second, it tightens a check that validates the number of available spendable outputs reported by a remote daemon, making it harder for a malicious or buggy daemon to trick the wallet with a suspicious output distribution. The changes are defensive hardening rather than a clear remote exploit fix.
AI review queuedMerge pull request #11500by tobtoht · 5b5a6f50 · Oct 24, 2026 · 2 filesMessage 66 · AdequateInformational 18Details
Commit message · tobtoht
Merge pull request #11500
d9f462a simplewallet: calculate balance from account history in filtered exports (Samy)
ACKs: amin404ala*, jpk68, selsta
66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This change fixes a bookkeeping quirk in Monero's command-line wallet export. Previously, when you filtered your transfer history (for example, showing only a date range or specific addresses), the running balance column was calculated only from the visible rows, so it could look wrong or misleading. Now the wallet secretly includes all confirmed transfers in the account when computing the running balance, while still only exporting the rows that match your filter. This is a user-experience/data-integrity fix, not a vulnerability that lets someone steal funds or break the blockchain.
AI review queuedMerge pull request #11208by tobtoht · 9b580ca7 · Oct 24, 2026 · 25 filesMessage 66 · AdequateInformational 20Details
This commit swaps Monero's command-line input library from the external GNU readline to a vendored copy of linenoise. It is primarily a build-system and dependency-maintenance change. The new library is included directly in the repository, so Monero no longer relies on the system's readline/ncurses packages. There is no direct evidence in the commit message or diff that this fixes a specific security vulnerability; it looks like a routine dependency replacement.
AI review queuedMerge pull request #11447by tobtoht · 92886478 · Oct 17, 2026 · 2 filesMessage 58 · ThinInformational 19Details
Commit message · tobtoht
Merge pull request #11447
a3860e7 fix: wallet_info for non-deterministic wallets (SNeedlewoods)
ACKs: PyXMR2025*, jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This change only improves how wallet software reports what kind of wallet and seed type the user has. It adds labels for hardware wallets and non-deterministic wallets, and fixes cases where a watch-only or hardware wallet was previously mislabeled. There is no security vulnerability here—just better, more accurate user-facing text.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 56/100
This change fixes a bug in the Monero wallet where legacy (older format) wallet keys could be encrypted twice during an upgrade, which could corrupt the wallet file or make it unusable. The fix removes an unnecessary encrypt/decrypt step and adds a test to ensure legacy wallets upgrade correctly and end up with the expected single layer of encryption.
AI review queuedMerge pull request #11524by tobtoht · c371e42a · Oct 15, 2026 · 2 filesMessage 58 · ThinInformational 20Details
Commit message · tobtoht
Merge pull request #11524
101aa63 simplewallet: add --seed and deprecate --electrum-seed (selsta)
ACKs: jpk68*, SNeedlewoods
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100
This change renames the wallet command-line option --electrum-seed to --seed, keeps --electrum-seed as a deprecated alias, and adds a warning when the old name is used. It is a user-interface cleanup, not a security fix.
AI review queuedMerge pull request #11522by tobtoht · 56fc9c82 · Oct 15, 2026 · 1 fileMessage 58 · ThinInformational 15Details
Commit message · tobtoht
Merge pull request #11522
f664d96d docs: fix broken anchor in LEVIN_PROTOCOL.md (mikeua)
ACKs: selsta, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathdocumentation-only discountmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a tiny documentation fix. It corrects two broken internal links (anchor references) in a Markdown file describing Monero's network protocol. There is no code change and no security impact.
AI review queuedMerge pull request #11520by tobtoht · 83d48388 · Oct 15, 2026 · 5 filesMessage 58 · ThinInformational 15Details
Commit message · tobtoht
Merge pull request #11520
f399ef9 wallet: use neutral seed wording (selsta)
ACKs: rbrunner7*, SNeedlewoods, jpk68, amin404ala
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes user-facing text strings in the Monero wallet software. It replaces phrases like 'Electrum-style mnemonic seed' with more neutral wording such as 'mnemonic seed' or 'wallet seed' across command-line help, error messages, and shell completion descriptions. There are no code logic changes, no cryptographic changes, and no security fixes.
AI review queuedMerge pull request #11409by tobtoht · 8308dee6 · Oct 13, 2026 · 1 fileMessage 66 · AdequateModerate 57Details
Commit message · tobtoht
Merge pull request #11409
5b729e2 wallet-rpc: write login file after binding (Samy) 4dc4b8a wallet-rpc: bind before loading the wallet (Samy)
ACKs: amin404ala*, jpk68*, selsta
66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 57/100
This patch changes the Monero wallet RPC server so that it binds to its network port and starts listening before loading the wallet, and writes the auto-generated RPC login password file only after successfully binding. Previously, the server generated and wrote the password file before binding and before loading the wallet. The main practical effect is to reduce the window during which the generated password file exists on disk before the RPC service is actually ready, and to avoid creating the password file if binding fails. It also moves background-mining checks earlier. The change is a hardening improvement rather than a clear-cut fix for an active vulnerability, but it reduces exposure of sensitive credentials on disk and avoids serving RPC before the wallet is loaded.
AI review queuedMerge pull request #11256by tobtoht · 746fd383 · Oct 13, 2026 · 1 fileMessage 58 · ThinLow 35Details
Commit message · tobtoht
Merge pull request #11256
703f844 wallet2: skip canonicalization when saving to the current filename (selsta)
ACKs: jpk68, tobtoht
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 35/100
This change adjusts how the Monero wallet decides whether it is saving to the same file. Previously, the wallet only skipped certain path checks when no new path was provided. Now it also skips those checks when the requested path is exactly the current wallet file. The likely goal is to avoid path canonicalization, which can fail or behave unexpectedly on unusual filesystems, symlinks, or restricted environments. The patch is very small and defensive, and there is no direct evidence it fixes an active security vulnerability.
AI review queuedMerge pull request #11494by tobtoht · 0af81a41 · Oct 13, 2026 · 1 fileMessage 58 · ThinModerate 59Details
Commit message · tobtoht
Merge pull request #11494
8a097cf levin: prevent m_connects erase during iteration in delete_connections (Jackie)
ACKs: selsta, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This patch fixes a bug in Monero's network connection cleanup code. When the program was walking through its list of active connections and dropping unused ones, destroying a connection could sometimes trigger code that modified the same list while it was still being walked. That could corrupt the list, crash the program, or cause unpredictable behavior. The fix keeps those other connections alive until the walk is finished, so their cleanup happens safely afterward.
AI review queuedMerge pull request #11465by tobtoht · be518c28 · Oct 13, 2026 · 1 fileMessage 58 · ThinLow 37Details
Commit message · tobtoht
Merge pull request #11465
1b4a36b wallet2: filter untrusted spend proof status (Samy)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100
This small change updates how Monero's wallet handles error responses from a remote node when creating or verifying a 'spend proof'. Before, the wallet would treat certain node-reported errors as fatal even when using an untrusted node. Now it filters those status codes through a trust-aware helper, so untrusted nodes cannot as easily disrupt or mislead spend-proof operations with crafted error responses. In practical terms, it makes the wallet more cautious about what it believes from a node it does not trust.
AI review queuedMerge pull request #11392by tobtoht · 66b4890d · Oct 13, 2026 · 1 fileMessage 58 · ThinLow 40Details
Commit message · tobtoht
Merge pull request #11392
bcbedbb wallet: persist rings before relaying a transaction (xmrack)
ACKs: selsta, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 40/100
This change makes the Monero wallet save ring-signature data to its local database before sending a transaction to the network. If the first broadcast fails and the wallet later rebuilds the transaction, it can reuse the same ring members instead of accidentally picking a new set. Reusing rings helps preserve privacy by avoiding two different-looking transactions that could be linked together.
AI review queuedsimplewallet: add --seed and deprecate --electrum-seedby selsta · 101aa635 · Oct 8, 2026 · 2 filesMessage 50 · ThinInformational 18Details
Commit message · selsta
simplewallet: add --seed and deprecate --electrum-seed
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit renames a command-line option in Monero's wallet program. The old option '--electrum-seed' is kept working but marked as deprecated, while a new '--seed' option is introduced. It is a routine user-interface cleanup, not a security fix.
AI review queuedMerge pull request #11432by tobtoht · 42757be7 · Oct 8, 2026 · 2 filesMessage 58 · ThinModerate 58Details
Commit message · tobtoht
Merge pull request #11432
97d682b wallet2: erase all matching payments in import_key_images (jpk68)
ACKs: selsta, PyXMR2025
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 58/100
This patch fixes a bookkeeping bug in Monero's wallet. When a user spent funds from one of their own accounts and the same transaction also sent change or payments to other subaddresses within that same account, the wallet was only removing the first matching incoming record instead of all matching ones. This could leave phantom 'incoming' payments showing money that was actually the user's own change, making the wallet balance and history look wrong. The fix now removes all matching records that belong to the spending account while preserving genuine incoming payments to other accounts. A new functional test confirms the corrected behavior.
AI review queuedMerge pull request #11414by tobtoht · e3dd61d9 · Oct 8, 2026 · 1 fileMessage 58 · ThinLow 41Details
Commit message · tobtoht
Merge pull request #11414
edba670 simplewallet: hold export lock through CSV write (Samy)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 41/100
This patch changes how Monero's command-line wallet holds internal locks while exporting transaction history to a CSV file. Previously, the code briefly released a lock during the export process. The fix keeps the lock held continuously while sensitive wallet data is being written out. The change is defensive and prevents potential race conditions or use of partially-unlocked wallet state during an export that includes private keys.
AI review queuedMerge pull request #11286by tobtoht · b3215a3b · Oct 8, 2026 · 3 filesMessage 58 · ThinModerate 66Details
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 66/100
This update tightens how Monero's built-in HTTP server reads incoming request headers. It now rejects requests that have conflicting Content-Length values, oversized numbers, or any Transfer-Encoding header. These rules prevent attackers from tricking the server into misreading where a request body ends, which can lead to request smuggling or desync attacks against the node.
AI review queuedMerge pull request #11468by tobtoht · e62d1986 · Oct 8, 2026 · 2 filesMessage 58 · ThinInformational 15Details
Commit message · tobtoht
Merge pull request #11468
d1b7cd4 contrib: remove rlwrap files (jpk68)
ACKs: selsta, tobtoht, PyXMR2025
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathdocumentation-only discountmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply deletes two text files from the 'contrib/rlwrap' directory. These files were lists of command names used by a third-party command-line helper tool (rlwrap) to provide auto-completion for Monero's command-line programs. Removing them has no effect on Monero's actual code, network, wallets, or blockchain, and does not change any security behavior.
AI review queuedMerge pull request #11446by tobtoht · 84bed73c · Oct 8, 2026 · 6 filesMessage 58 · ThinInformational 23Details
Commit message · tobtoht
Merge pull request #11446
ee18421 daemon: expose `generate_blocks` in regtest (Samy)
ACKs: PyXMR2025*, jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This commit adds a new developer/testing command called `generate_blocks` that lets a Monero daemon operator quickly create blocks in 'regtest' mode (a local-only test mode). It does not change normal mainnet or testnet behavior. The command is only useful for testing and is not a security fix or a vulnerability.
AI review queuedMerge pull request #11421by tobtoht · 3e40fe82 · Oct 8, 2026 · 2 filesMessage 58 · ThinModerate 57Details
Commit message · tobtoht
Merge pull request #11421
efce358 wallet: count change from the spending account (Samy)
ACKs: selsta, jpk68, PyXMR2025
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 57/100
This patch fixes a bug in Monero's wallet software that could misreport the amount of money involved when a user spent funds from one account and received change in a different account. Previously, the wallet only tracked a single total for received amounts, which could lead to incorrect balance or transaction history display when change went to a different subaddress account. The fix tracks received amounts separately per account and uses only the change belonging to the spending account when recording the outgoing transaction. A new functional test verifies this scenario.
AI review queuedMerge pull request #11419by tobtoht · a18c9078 · Oct 8, 2026 · 3 filesMessage 58 · ThinInformational 23Details
Commit message · tobtoht
Merge pull request #11419
0d8d3bf Add virtual destructor to Monero::WalletManager interface (Lee *!* Clagett)
ACKs: jpk68, PyXMR2025, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This change adds a virtual destructor to a C++ interface class (WalletManager) and its implementation (WalletManagerImpl). In C++, an interface used as a base class without a virtual destructor can cause undefined behavior when an object is deleted through a base-class pointer, typically leading only to memory corruption or crashes rather than direct code execution. The patch is a defensive correctness fix.
AI review queuedMerge pull request #11358by tobtoht · bd517bdf · Oct 8, 2026 · 2 filesMessage 58 · ThinModerate 58Details
Commit message · tobtoht
Merge pull request #11358
03f5f73 wallet_rpc_server: autosave before in-memory key generation (Samy)
ACKs: jpk68, selsta, amin404ala
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 58/100
This change fixes a bug in the Monero wallet's remote-control interface (RPC server). When creating a new wallet from provided keys, the server now saves the current wallet to disk before generating the new in-memory wallet. Previously, if a wallet file was already open, unsaved changes could be lost because the code only saved when it thought a file was associated. The patch removes an unnecessary check so the save always happens, and a test confirms that an existing wallet's custom data survives the operation.
AI review queueddaemon: expose `generate_blocks` in regtestby Samy · ee18421d · Oct 8, 2026 · 6 filesMessage 45 · ThinInformational 21Details
Commit message · Samy
daemon: expose `generate_blocks` in regtest
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This commit adds a new developer/testing command called `generate_blocks` that is only usable when Monero is running in regtest mode (a private, local-only test network). It does not change normal mainnet or testnet behavior. The command simply wires an existing internal RPC endpoint to the daemon's interactive command line and adds a functional test for it. There is no indication it introduces a security vulnerability.
AI review queuedepee: replace readline with linenoiseby jpk68 · 58a7ae62 · Oct 5, 2026 · 24 filesMessage 60 · AdequateLow 35Details
Commit message · jpk68
epee: replace readline with linenoise
Co-authored-by: Thomas <thomas.giudici@proton.me>
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 35/100
This commit swaps Monero's command-line input library from GNU readline to a bundled, customized version of linenoise. The stated goal is to reduce external dependencies, but the change also removes several risky behaviors: bracketed-paste handling that could execute pasted commands, terminal control-character passthrough, and UTF-8 parsing that could read past buffer ends. The new code adds input sanitization, caps paste sizes, and makes Ctrl+C/\ signal handling more predictable. It is a large refactor, so it may introduce new bugs even while fixing old ones.
AI review queuedMerge pull request #11462by tobtoht · 160e2150 · Oct 2, 2026 · 2 filesMessage 58 · ThinLow 42Details
Commit message · tobtoht
Merge pull request #11462
80f75ea wallet2: trim stale transfer maps after output imports (selsta)
ACKs: jpk68, j-berman, plowsof
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100
This Monero wallet update fixes a bookkeeping bug. When a wallet imported a list of its owned outputs and that list was smaller than a previous import, internal lookup maps (key images and public keys) could still point to entries that no longer existed. The patch trims those stale pointers whenever the transfer list is shrunk, and also repairs them when loading an older wallet cache that has never been refreshed from a node. The main risk is that stale indices could cause the wallet to crash or behave incorrectly, but the code already threw an error if an out-of-range index was detected, so this is more of a robustness/correctness fix than an obvious exploit path.