What changed, and why it matters
This commit only changes user-facing text strings in the Monero wallet software. It replaces phrases like 'Electrum-style mnemonic seed' with more neutral wording such as 'mnemonic seed' or 'wallet seed' across command-line help, error messages, and shell completion descriptions. There are no code logic changes, no cryptographic changes, and no security fixes.
No security action needed. This is a terminology/UX cleanup. Reviewers may optionally verify that no translated string keys or downstream documentation depend on the old wording.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is a pure string-label refactor in five files. It updates CLI argument descriptions, RPC error messages, and fish-shell completion descriptions to use neutral terminology (‘mnemonic seed’, ‘multisig seed’, ‘wallet seed’) instead of ‘Electrum-style’ wording. No functional code, validation logic, or cryptographic handling is modified.
Changed components
src/simplewallet/simplewallet.cppsrc/wallet/api/wallet.cppsrc/wallet/wallet2.cppsrc/wallet/wallet_rpc_server.cpputils/fish/monero-wallet-cli.fishInspect captured patch +16 / −16
### src/simplewallet/simplewallet.cpp
@@ -167,9 +167,9 @@ namespace
const auto arg_generate_from_json = wallet_args::arg_generate_from_json();
const command_line::arg_descriptor<std::string> arg_mnemonic_language = {"mnemonic-language", sw::tr("Language for mnemonic"), ""};
const command_line::arg_descriptor<std::string> arg_electrum_seed = {"electrum-seed", sw::tr("Specify Electrum seed for wallet recovery/creation"), ""};
- const command_line::arg_descriptor<bool> arg_restore_deterministic_wallet = {"restore-deterministic-wallet", sw::tr("Recover wallet using Electrum-style mnemonic seed"), false};
+ const command_line::arg_descriptor<bool> arg_restore_deterministic_wallet = {"restore-deterministic-wallet", sw::tr("Recover wallet using a mnemonic seed"), false};
const command_line::arg_descriptor<bool> arg_restore_from_seed = {"restore-from-seed", sw::tr("alias for --restore-deterministic-wallet"), false};
- const command_line::arg_descriptor<bool> arg_restore_multisig_wallet = {"restore-multisig-wallet", sw::tr("Recover multisig wallet using Electrum-style mnemonic seed"), false};
+ const command_line::arg_descriptor<bool> arg_restore_multisig_wallet = {"restore-multisig-wallet", sw::tr("Recover multisig wallet using a multisig seed"), false};
const command_line::arg_descriptor<bool> arg_non_deterministic = {"non-deterministic", sw::tr("Generate non-deterministic view and spend keys"), false};
const command_line::arg_descriptor<uint64_t> arg_restore_height = {"restore-height", sw::tr("Restore from specific blockchain height"), 0};
const command_line::arg_descriptor<std::string> arg_restore_date = {"restore-date", sw::tr("Restore from estimated blockchain height on specified date"), ""};
@@ -3188,7 +3188,7 @@ simple_wallet::simple_wallet()
tr("Display the private spend key."));
m_cmd_binder.set_handler("seed",
boost::bind(&simple_wallet::on_command, this, &simple_wallet::seed, _1),
- tr("Display the Electrum-style mnemonic seed"));
+ tr("Display the wallet seed"));
m_cmd_binder.set_handler("legacy_seed",
boost::bind(&simple_wallet::on_command, this, &simple_wallet::legacy_seed, _1),
tr("Display a Polyseed as a legacy seed"));
@@ -3271,7 +3271,7 @@ simple_wallet::simple_wallet()
" How many seconds to wait before locking the wallet (0 to disable)."));
m_cmd_binder.set_handler("encrypted_seed",
boost::bind(&simple_wallet::on_command, this, &simple_wallet::encrypted_seed, _1),
- tr("Display the encrypted Electrum-style mnemonic seed."));
+ tr("Display the encrypted legacy or multisig seed."));
m_cmd_binder.set_handler("rescan_spent",
boost::bind(&simple_wallet::on_command, this, &simple_wallet::rescan_spent, _1),
tr("Rescan the blockchain for spent outputs."));
@@ -4013,7 +4013,7 @@ bool simple_wallet::init(const boost::program_options::variables_map& vm)
else
{
m_electrum_seed = "";
- const char *prompt = "Specify Electrum seed";
+ const char *prompt = "Specify mnemonic seed";
epee::wipeable_string electrum_seed = input_secure_line(prompt);
if (std::cin.eof())
return false;
@@ -4040,7 +4040,7 @@ bool simple_wallet::init(const boost::program_options::variables_map& vm)
{
if (!crypto::ElectrumWords::words_to_bytes_ex(m_electrum_seed, m_recovery_key, old_language, is_polyseed, polyseed))
{
- fail_msg_writer() << tr("Electrum-style word list failed verification");
+ fail_msg_writer() << tr("Mnemonic seed failed verification");
return false;
}
}
### src/wallet/api/wallet.cpp
@@ -776,8 +776,8 @@ bool WalletImpl::recover(const std::string &path, const std::string &password, c
clearStatus();
m_errorString.clear();
if (seed.empty()) {
- LOG_ERROR("Electrum seed is empty");
- setStatusError(tr("Electrum seed is empty"));
+ LOG_ERROR("Mnemonic seed is empty");
+ setStatusError(tr("Mnemonic seed is empty"));
return false;
}
@@ -788,7 +788,7 @@ bool WalletImpl::recover(const std::string &path, const std::string &password, c
bool is_polyseed;
polyseed::data polyseed(POLYSEED_MONERO);
if (!crypto::ElectrumWords::words_to_bytes_ex(seed, recovery_key, old_language, is_polyseed, polyseed)) {
- setStatusError(tr("Electrum-style word list failed verification"));
+ setStatusError(tr("Mnemonic seed failed verification"));
return false;
}
if (is_polyseed) {
### src/wallet/wallet2.cpp
@@ -639,7 +639,7 @@ std::pair<std::unique_ptr<tools::wallet2>, tools::password_container> generate_f
{
if (!crypto::ElectrumWords::words_to_bytes_ex(field_seed, recovery_key, old_language, is_polyseed, polyseed))
{
- THROW_WALLET_EXCEPTION(tools::error::wallet_internal_error, tools::wallet2::tr("Electrum-style word list failed verification"));
+ THROW_WALLET_EXCEPTION(tools::error::wallet_internal_error, tools::wallet2::tr("Mnemonic seed failed verification"));
}
restore_deterministic_wallet = true;
@@ -655,11 +655,11 @@ std::pair<std::unique_ptr<tools::wallet2>, tools::password_container> generate_f
// compatibility checks
if (!field_seed_found && !field_viewkey_found && !field_spendkey_found)
{
- THROW_WALLET_EXCEPTION(tools::error::wallet_internal_error, tools::wallet2::tr("At least one of either an Electrum-style word list, private view key, or private spend key must be specified"));
+ THROW_WALLET_EXCEPTION(tools::error::wallet_internal_error, tools::wallet2::tr("At least one of a mnemonic seed, private view key, or private spend key must be specified"));
}
if (field_seed_found && (field_viewkey_found || field_spendkey_found))
{
- THROW_WALLET_EXCEPTION(tools::error::wallet_internal_error, tools::wallet2::tr("Both Electrum-style word list and private key(s) specified"));
+ THROW_WALLET_EXCEPTION(tools::error::wallet_internal_error, tools::wallet2::tr("Both mnemonic seed and private key(s) specified"));
}
// if an address was given, we check keys against it, and deduce the spend
### src/wallet/wallet_rpc_server.cpp
@@ -2551,7 +2551,7 @@ namespace tools
if (!crypto::ElectrumWords::words_to_bytes_ex(req.seed, recovery_key, language, is_polyseed, polyseed))
{
er.code = WALLET_RPC_ERROR_CODE_UNKNOWN_ERROR;
- er.message = "Electrum-style word list failed verification";
+ er.message = "Mnemonic seed failed verification";
return false;
}
@@ -4261,7 +4261,7 @@ namespace tools
if (!crypto::ElectrumWords::words_to_bytes_ex(req.seed, recovery_key, old_language, is_polyseed, polyseed))
{
er.code = WALLET_RPC_ERROR_CODE_UNKNOWN_ERROR;
- er.message = "Electrum-style word list failed verification";
+ er.message = "Mnemonic seed failed verification";
return false;
}
}
### utils/fish/monero-wallet-cli.fish
@@ -42,9 +42,9 @@ complete -c monero-wallet-cli -l generate-from-multisig-keys -r -d "Generate a m
complete -c monero-wallet-cli -l generate-from-json -r -k -a "(__fish_complete_suffix .json)" -d "Generate wallet from JSON format file"
complete -c monero-wallet-cli -l mnemonic-language -r -d "Language for mnemonic"
complete -c monero-wallet-cli -l command -d ""
-complete -c monero-wallet-cli -l restore-deterministic-wallet -d "Recover wallet using Electrum-style mnemonic seed"
+complete -c monero-wallet-cli -l restore-deterministic-wallet -d "Recover wallet using a mnemonic seed"
complete -c monero-wallet-cli -l restore-from-seed -d "alias for --restore-deterministic-wallet"
-complete -c monero-wallet-cli -l restore-multisig-wallet -d "Recover multisig wallet using Electrum-style mnemonic seed"
+complete -c monero-wallet-cli -l restore-multisig-wallet -d "Recover multisig wallet using a multisig seed"
complete -c monero-wallet-cli -l non-deterministic -d "Generate non-deterministic view and spend keys"
complete -c monero-wallet-cli -l electrum-seed -r -d "Specify Electrum seed for wallet recovery/creation"
complete -c monero-wallet-cli -l restore-height -r -d "Restore from specific blockchain height. Default: 0"Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.