simplewallet: add --seed and deprecate --electrum-seed
What changed, and why it matters
This commit renames a command-line option in Monero's wallet program. The old option '--electrum-seed' is kept working but marked as deprecated, while a new '--seed' option is introduced. It is a routine user-interface cleanup, not a security fix.
No security action needed. Users and scripts may optionally migrate from --electrum-seed to --seed before the alias is removed in a future release.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds a new ‘seed’ argument to monero-wallet-cli and makes the existing ‘electrum-seed’ argument a deprecated alias. It updates help text, fish-shell completions, and error messages. Logic is added to reject using both flags at once and to warn when the deprecated alias is used. The underlying wallet recovery behavior is unchanged.
Changed components
src/simplewallet/simplewallet.cpputils/fish/monero-wallet-cli.fishInspect captured patch +19 / −5
### src/simplewallet/simplewallet.cpp
@@ -166,7 +166,8 @@ namespace
const command_line::arg_descriptor<std::string> arg_generate_from_multisig_keys = {"generate-from-multisig-keys", sw::tr("Generate a master wallet from multisig wallet keys"), ""};
const auto arg_generate_from_json = wallet_args::arg_generate_from_json();
const command_line::arg_descriptor<std::string> arg_mnemonic_language = {"mnemonic-language", sw::tr("Language for mnemonic"), ""};
- const command_line::arg_descriptor<std::string> arg_electrum_seed = {"electrum-seed", sw::tr("Specify Electrum seed for wallet recovery/creation"), ""};
+ const command_line::arg_descriptor<std::string> arg_seed = {"seed", sw::tr("Specify seed for wallet recovery"), ""};
+ const command_line::arg_descriptor<std::string> arg_electrum_seed = {"electrum-seed", sw::tr("Deprecated alias for --seed"), ""};
const command_line::arg_descriptor<bool> arg_restore_deterministic_wallet = {"restore-deterministic-wallet", sw::tr("Recover wallet using a mnemonic seed"), false};
const command_line::arg_descriptor<bool> arg_restore_from_seed = {"restore-from-seed", sw::tr("alias for --restore-deterministic-wallet"), false};
const command_line::arg_descriptor<bool> arg_restore_multisig_wallet = {"restore-multisig-wallet", sw::tr("Recover multisig wallet using a multisig seed"), false};
@@ -4006,7 +4007,7 @@ bool simple_wallet::init(const boost::program_options::variables_map& vm)
return false;
if (m_electrum_seed.empty())
{
- fail_msg_writer() << tr("specify a recovery parameter with the --electrum-seed=\"multisig seed here\"");
+ fail_msg_writer() << tr("specify a recovery parameter with the --seed=\"multisig seed here\"");
return false;
}
}
@@ -4019,7 +4020,7 @@ bool simple_wallet::init(const boost::program_options::variables_map& vm)
return false;
if (electrum_seed.empty())
{
- fail_msg_writer() << tr("specify a recovery parameter with the --electrum-seed=\"words list here\"");
+ fail_msg_writer() << tr("specify a recovery parameter with the --seed=\"words list here\"");
return false;
}
m_electrum_seed = electrum_seed;
@@ -4615,7 +4616,7 @@ bool simple_wallet::handle_command_line(const boost::program_options::variables_
m_generate_from_multisig_keys = command_line::get_arg(vm, arg_generate_from_multisig_keys);
m_generate_from_json = command_line::get_arg(vm, arg_generate_from_json);
m_mnemonic_language = command_line::get_arg(vm, arg_mnemonic_language);
- m_electrum_seed = command_line::get_arg(vm, arg_electrum_seed);
+ m_electrum_seed = command_line::get_arg(vm, arg_seed);
m_restore_deterministic_wallet = command_line::get_arg(vm, arg_restore_deterministic_wallet) || command_line::get_arg(vm, arg_restore_from_seed);
m_restore_multisig_wallet = command_line::get_arg(vm, arg_restore_multisig_wallet);
m_non_deterministic = command_line::get_arg(vm, arg_non_deterministic);
@@ -4634,6 +4635,17 @@ bool simple_wallet::handle_command_line(const boost::program_options::variables_
m_restore_deterministic_wallet ||
m_restore_multisig_wallet;
+ if (!command_line::is_arg_defaulted(vm, arg_electrum_seed))
+ {
+ if (!command_line::is_arg_defaulted(vm, arg_seed))
+ {
+ fail_msg_writer() << tr("can't specify both --seed and --electrum-seed");
+ return false;
+ }
+ message_writer(console_color_yellow, false) << tr("Warning: --electrum-seed is deprecated and will be removed in a future version. Use --seed instead.");
+ m_electrum_seed = command_line::get_arg(vm, arg_electrum_seed);
+ }
+
if (!command_line::is_arg_defaulted(vm, arg_restore_date))
{
uint16_t year;
@@ -10562,6 +10574,7 @@ int main(int argc, char* argv[])
command_line::add_arg(desc_params, arg_restore_from_seed );
command_line::add_arg(desc_params, arg_restore_multisig_wallet );
command_line::add_arg(desc_params, arg_non_deterministic );
+ command_line::add_arg(desc_params, arg_seed);
command_line::add_arg(desc_params, arg_electrum_seed );
command_line::add_arg(desc_params, arg_restore_height);
command_line::add_arg(desc_params, arg_restore_date);
### utils/fish/monero-wallet-cli.fish
@@ -46,7 +46,8 @@ complete -c monero-wallet-cli -l restore-deterministic-wallet -d "Recover wallet
complete -c monero-wallet-cli -l restore-from-seed -d "alias for --restore-deterministic-wallet"
complete -c monero-wallet-cli -l restore-multisig-wallet -d "Recover multisig wallet using a multisig seed"
complete -c monero-wallet-cli -l non-deterministic -d "Generate non-deterministic view and spend keys"
-complete -c monero-wallet-cli -l electrum-seed -r -d "Specify Electrum seed for wallet recovery/creation"
+complete -c monero-wallet-cli -l seed -r -d "Specify seed for wallet recovery"
+complete -c monero-wallet-cli -l electrum-seed -r -d "Deprecated alias for --seed"
complete -c monero-wallet-cli -l restore-height -r -d "Restore from specific blockchain height. Default: 0"
complete -c monero-wallet-cli -l restore-date -r -d "Restore from estimated blockchain height on specified date"
complete -c monero-wallet-cli -l do-not-relay -d "The newly created transaction will not be relayed to the monero network"Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.