AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Cryptographic libraries

Merge pull request #11421

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11421

efce358 wallet: count change from the spending account (Samy)

ACKs: selsta, jpk68, PyXMR2025
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a bug in Monero's wallet software that could misreport the amount of money involved when a user spent funds from one account and received change in a different account. Previously, the wallet only tracked a single total for received amounts, which could lead to incorrect balance or transaction history display when change went to a different subaddress account. The fix tracks received amounts separately per account and uses only the change belonging to the spending account when recording the outgoing transaction. A new functional test verifies this scenario.

Recommended action

Review and merge the patch. Users relying on view-only or cold wallets with multiple subaddress accounts should update and rescan/re-import key images if they have performed cross-account self-transfers, to ensure balances and transaction histories are accurate.

Security signals we found

01

Incorrect aggregation of change outputs across subaddress accounts in import_key_images

02

Potential balance or transaction-history misreporting in view-only / cold-signing wallets

03

Fix scoped to per-account received amount tracking

04

New functional test covering cross-account self-transfer

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.