What changed, and why it matters
This change only improves how wallet software reports what kind of wallet and seed type the user has. It adds labels for hardware wallets and non-deterministic wallets, and fixes cases where a watch-only or hardware wallet was previously mislabeled. There is no security vulnerability here—just better, more accurate user-facing text.
No security action needed. Treat as a routine UI/UX improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit updates the wallet_info output in both the simplewallet CLI and the wallet RPC server. It refines wallet type classification by checking key_on_device() and !is_deterministic() before falling back to ‘Normal’, and adjusts seed type classification to report ‘None’ for non-deterministic, watch-only, and hardware wallets. It also removes tr() wrappers from RPC string fields and renames ‘Background wallet’ to ‘Background’. These are cosmetic/functional UI improvements with no cryptographic, consensus, or access-control changes.
Changed components
src/simplewallet/simplewallet.cppsrc/wallet/wallet_rpc_server.cppInspect captured patch +22 / −6
### src/simplewallet/simplewallet.cpp
@@ -9966,10 +9966,15 @@ bool simple_wallet::wallet_info(const std::vector<std::string> &args)
else if (ms_status.multisig_is_active)
type = (boost::format(tr("%u/%u multisig%s")) % ms_status.threshold % ms_status.total % (ms_status.is_ready ? "" : " (not yet finalized)")).str();
else if (m_wallet->is_background_wallet())
- type = tr("Background wallet");
+ type = tr("Background");
+ else if (m_wallet->key_on_device())
+ type = tr("Hardware");
+ // check other wallet types before is_deterministic(), because it also returns false for e.g. watch-only and HW wallets
+ else if (!m_wallet->is_deterministic())
+ type = tr("Non-deterministic");
else
type = tr("Normal");
- message_writer() << tr("Type: ") << type;
+ message_writer() << tr("Wallet Type: ") << type;
message_writer() << tr("Network type: ") << (
m_wallet->nettype() == cryptonote::TESTNET ? tr("Testnet") :
m_wallet->nettype() == cryptonote::STAGENET ? tr("Stagenet") : tr("Mainnet"));
@@ -9983,6 +9988,11 @@ bool simple_wallet::wallet_info(const std::vector<std::string> &args)
{
type = tr("Polyseed");
}
+ // e.g. watch-only and HW wallets also fall into this category
+ else if (!m_wallet->is_deterministic())
+ {
+ type = tr("None");
+ }
else
{
type = tr("Legacy");
### src/wallet/wallet_rpc_server.cpp
@@ -653,7 +653,11 @@ namespace tools
else if (ms_status.multisig_is_active)
res.wallet_type = (boost::format("%u/%u multisig%s") % ms_status.threshold % ms_status.total % (ms_status.is_ready ? "" : " (not yet finalized)")).str();
else if (m_wallet->is_background_wallet())
- res.wallet_type = "Background wallet";
+ res.wallet_type = "Background";
+ else if (m_wallet->key_on_device())
+ res.wallet_type = "Hardware";
+ else if (!m_wallet->is_deterministic())
+ res.wallet_type = "Non-deterministic";
else
res.wallet_type = "Normal";
res.network_type = m_wallet->nettype() == cryptonote::TESTNET ? "Testnet"
@@ -675,11 +679,13 @@ namespace tools
}
if (ms_status.multisig_is_active)
- res.seed_type = tr("Multisig");
+ res.seed_type = "Multisig";
else if (m_wallet->is_polyseed())
- res.seed_type = tr("Polyseed");
+ res.seed_type = "Polyseed";
+ else if (!m_wallet->is_deterministic())
+ res.seed_type = "None";
else
- res.seed_type = tr("Legacy");
+ res.seed_type = "Legacy";
return true;
}Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.