AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 58 Cryptographic libraries

Merge pull request #11432

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11432

97d682b wallet2: erase all matching payments in import_key_images (jpk68)

ACKs: selsta, PyXMR2025
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a bookkeeping bug in Monero's wallet. When a user spent funds from one of their own accounts and the same transaction also sent change or payments to other subaddresses within that same account, the wallet was only removing the first matching incoming record instead of all matching ones. This could leave phantom 'incoming' payments showing money that was actually the user's own change, making the wallet balance and history look wrong. The fix now removes all matching records that belong to the spending account while preserving genuine incoming payments to other accounts. A new functional test confirms the corrected behavior.

Recommended action

Review and merge the fix; run the updated cold_signing functional test to confirm multi-subaddress self-payments are cleaned up correctly. Users relying on view-only or cold wallets should update to avoid balance/history discrepancies.

Security signals we found

01

Incorrect state cleanup in wallet transaction processing

02

Self-payment / change records incorrectly retained as incoming payments

03

Functional test added to reproduce multi-subaddress self-payment scenario

Risk score

Why this scored 58/100

Our methodology →
Potential impact 18/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.