BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 52 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEYby Ava Chow · 8c360f08 · Nov 20, 2026 · 2 filesMessage 86 · StrongModerate 62Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

bab579e56aa8b80a6f2923285e55cbcb2a7730b8 wallet: reject recipient amounts outside MoneyRange (Bruce0X)

Pull request description:

`CreateTransaction` checks that recipient amounts aren't negative, but not that they're within `MAX_MONEY`. `CreateTransactionInternal` then sums them into `recipients_sum` (spend.cpp:1100) with no range check, and that sum can overflow.

Easiest way to hit it is `fundrawtransaction` with a raw tx that has two outputs of 2^62 sat. It can also be reached with only valid amounts through `walletcreatefundedpsbt`/`send`/`sendmany` and a few thousand 21M BTC outputs. The "Transaction too large" check only runs after coin selection, so it doesn't stop this. On master the node aborts:

```
Assertion failed: (!m_selected_inputs.empty()), function RecalculateWaste, file coinselection.cpp, line 904.
```

UBSan reports the overflow at spend.cpp:1100 first. With other values the sum wraps to a small positive number instead, and `fundrawtransaction` returns success for a tx with outputs of 46116860184 BTC each.

This checks every amount and the running sum against `MoneyRange` in the existing recipients loop of `CreateTransactionInternal`, before the amount is added to `recipients_sum`, and returns "Transaction output amount must be valid" before coin selection starts. The same check rejects negative amounts, so the separate negative check in `CreateTransaction` is removed. The new `test_outputs_above_max_money` in `wallet_fundrawtransaction.py` covers a single output above MAX_MONEY, two outputs whose sum is above it, a sum that overflows int64, and a negative output. On master the first case returns "Insufficient funds" and the overflow case crashes the node; with the fix all of them get the new error. `wallet_fundrawtransaction.py`, `wallet_send.py`, `wallet_basic.py` and `rpc_psbt.py` pass.

ACKs for top commit:
maflcko:
lgtm ACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8
Zippo76:
tACK bab579e56a
furszy:
utACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8
achow101:
ACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8

Tree-SHA512: 068c3bd19e37c2c3da237ddcf28cd88f3792a23c39ab1fa0469fdef9745117edc0ca5382174c184cef82155c725aac29b44df7b1d5f90b0c48ec94a9f0087a2b

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymemory safetysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 62/100

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to more than the maximum allowed bitcoin amount (about 21 million BTC), leading to incorrect math, a failed internal assertion, or a successful but invalid transaction. The fix now rejects such oversized or overflowing amounts early with a clear error message.

Security candidateMerge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.by Ava Chow · f98888ef · Nov 20, 2026 · 19 filesMessage 100 · StrongLow 30Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

820120eb466ff2242d99f4c77ae6f8fa77f4bc9c wallet: rpc: Deprecate `encryptwallet` (David Gumberg)
86c8fa615409617099b709c78f3f58204e7e8cad refactor: test: signrawtransaction isolate encrypted wallet test (David Gumberg)
8a3c12cea705c8956ca2af0e46a6191492c5e462 refactor: test: wallet_multiwallet.py use a new encrypted wallet (David Gumberg)
bb78fcca7f6590f5ef0a73a9dc914f86db55e7ee refactor: test: wallet_listdescriptors.py extract encrypted wallet test (David Gumberg)
7af91e41a050426cce9ff43e59c6f862df9dbad0 refactor: test: wallet_fundrawtransaction.py avoid encryptwallet (David Gumberg)
c9b9ff4fe4330f695f6b7c3600ad48ad99749416 refactor: test: wallet_bumpfee.py isolate encrypted wallet tests (David Gumberg)
18ca5225b048f570788da6ea6192530a13064c1a refactor: test: rpc_psbt.py extract encrypted wallet signing (David Gumberg)
2354ff7b7e81845e86b05e0c61407099e92be02a refactor: test: Avoid encryptwallet in interface_bitcoin_cli.py (David Gumberg)

Pull request description:

For more context, see: #36027

Encrypting existing wallets that are unencrypted is fraught with footguns and complexity both for users and for developers.

For example:

- No efforts are made to ensure that remnants of unencrypted key material are not left on the user's disk, as attempting to ensure this would be difficult and dangerous, and for some SSD's infeasible.

- Encrypting a wallet that has manually imported descriptors will cause the wallet to change the spending conditions out from under the user. (https://github.com/bitcoin/bitcoin/issues/26607)

- Because new keys are made after encryption, restoring from a backup made before encryption may result in loss of funds.

_LLM Disclosure: Used gemma4-26B and qwen3.8-next-flash as research and drafting tools, but all code and text present here were written by me._

ACKs for top commit:
achow101:
ACK 820120eb466ff2242d99f4c77ae6f8fa77f4bc9c
w0xlt:
reACK 820120eb466ff2242d99f4c77ae6f8fa77f4bc9c

Tree-SHA512: 9ab4bb4c70510e9d16634b40f8a1e1339510c58147d554d3261050b64a524e25cee00930cbc5a9d08ba58b8396d4d461e6cbc7a3dbcfb3fffe7e51a47a2a8629

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 30/100

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bitcoins when trying to add a password to an already-created wallet. The safer path is to create a new wallet with a password from the start. This is a defensive usability change, not a fix for a remote hack.

Security candidateMerge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declarativelyby merge-script · a690300e · Nov 20, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f test: construct coinselection_tests output declaratively (yuvicc)

Pull request description:

Part of #36692:

Build the funding output in `MakeCoin()` from `coinselection_tests` with a `CTxOut` constructor instead of `vout.resize(1)` followed by assigning `nValue`. Test-only change, the constructed txns are unchanged and the empty `scriptPubKey` that `resize()` left implicit is now explicit.

ACKs for top commit:
maflcko:
review ACK 77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f 🍰
alexanderwiederin:
ACK 77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f

Tree-SHA512: 1898d76fd6bad8d6ae92cebdd99472cc8b01504a6f348775d9695ff60e11eb32d1b3af1c77e07b6bc8fbc8eb0c1ff9698d233c07c9519869b86545cd6a4e45de

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and the transactions being simulated are unchanged. There is no security issue.

Security candidateMerge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest masterby merge-script · c3d1b4c0 · Nov 20, 2026 · 34 filesMessage 81 · StrongLow 35Details
Commit message · merge-script

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

b3dcf1931b922c916b1fedb8b985063f8037962e Squashed 'src/secp256k1/' changes from a7f264373e..659f03b076 (Hennadii Stepanov)

Pull request description:

This PR updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/a0e2e23a71bf2aaae910f81cb2bd8aa0ae49d544, which includes the following changes:

- bitcoin-core/secp256k1#1893
- bitcoin-core/secp256k1#1935
- bitcoin-core/secp256k1#1918
- bitcoin-core/secp256k1#1840
- bitcoin-core/secp256k1#1934
- bitcoin-core/secp256k1#1942
- bitcoin-core/secp256k1#1947
- bitcoin-core/secp256k1#1948
- bitcoin-core/secp256k1#1949
- bitcoin-core/secp256k1#1933
- bitcoin-core/secp256k1#1946
- bitcoin-core/secp256k1#1950
- bitcoin-core/secp256k1#1953
- bitcoin-core/secp256k1#1963
- bitcoin-core/secp256k1#1866
- bitcoin-core/secp256k1#1929
- bitcoin-core/secp256k1#1943
- bitcoin-core/secp256k1#1952
- bitcoin-core/secp256k1#1965
- bitcoin-core/secp256k1#1975
- bitcoin-core/secp256k1#1961
- bitcoin-core/secp256k1#1978
- bitcoin-core/secp256k1#1937
- bitcoin-core/secp256k1#1983
- bitcoin-core/secp256k1#1974
- bitcoin-core/secp256k1#1986
- bitcoin-core/secp256k1#1992
- bitcoin-core/secp256k1#1972
- bitcoin-core/secp256k1#1995
- bitcoin-core/secp256k1#1999
- bitcoin-core/secp256k1#1898
- bitcoin-core/secp256k1#1998
- bitcoin-core/secp256k1#1996

The update is prompted by:
1. New warnings introduced in Clang 24. bitcoin-core/secp256k1#1998 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36869.
2. New warnings in CMake >=4.5. bitcoin-core/secp256k1#1996 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36889.

Fixes https://github.com/bitcoin/bitcoin/issues/36913 and unlocks the CI.

ACKs for top commit:
fanquake:
ACK 830cca99046b880dd79ff8e09ba161decb15f572

Tree-SHA512: 952a2d30e17abc81f006904b03a88481b02b9b1f1aabf1281bba1200c004643cd4417c825b2e9059955fec376bbe277a86f861703a7fdde93e3d7f8d46022298

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 35/100

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes make the Silent Payments module behave better when a transaction has no relevant inputs or outputs, and make ECDH/MuSig code more careful about clearing secret intermediate values from memory. There is no evidence in the commit message or diff of an active security vulnerability being patched.

Security candidateMerge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNodeby merge-script · 6832a273 · Nov 18, 2026 · 3 filesMessage 81 · StrongModerate 68Details
Commit message · merge-script

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

d63068c58ec9fcc94876bce30865d1a7266d64d4 net_processing: set fDisconnect instead of calling DisconnectNode (Eugene Siegel)

Pull request description:

`MaybeDiscourageAndDisconnect` calls `DisconnectNode` which creates a `CSubNet` containing only the `CNode`'s address. This will disconnect every `CNode` with the same IP address. This is normally not a problem, except for clearnet-over-tor. If a node has an honest clearnet-over-tor inbound connection, the IP of the inbound peer will be the exit node's IP address. If an attacker connects to the node through the same exit node and sends an invalid message, they can cause every inbound peer sharing the exit node's IP to get disconnected. Fix this by only disconnecting the misbehaving `CNode` rather than every `CNode` sharing the IP.

ACKs for top commit:
Husteem:
Approach ACK / tACK d63068c
maflcko:
lgtm ACK d63068c58ec9fcc94876bce30865d1a7266d64d4
ajtowns:
re utACK d63068c58ec9fcc94876bce30865d1a7266d64d4
darosior:
utACK d63068c58ec9fcc94876bce30865d1a7266d64d4

Tree-SHA512: 4001678d95b70ca26992e46bf3211abceb12b60e51b6852741f01b1a41203a7bb6f3e89c8141aa940209d4f8a32fbcf0d72c7e8b0bfd091e4713f1e5d9426f16

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languagemerge-commit duplicate discount
AI analysis · Moderate 68/100

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set of public 'exit nodes.' An attacker could use the same Tor exit node as honest users, send an invalid message, and get every honest inbound peer using that exit node kicked off. The fix makes the node disconnect only the specific misbehaving connection while still discouraging (reducing trust in) that IP address.

Security candidatenet_processing: set fDisconnect instead of calling DisconnectNodeby Eugene Siegel · d63068c5 · Nov 16, 2026 · 3 filesMessage 73 · AdequateModerate 62Details
Commit message · Eugene Siegel

net_processing: set fDisconnect instead of calling DisconnectNode

MaybeDiscourageAndDisconnect calls DisconnectNode which creates a
CSubNet containing only the CNode's address. This will disconnect
every CNode with the same IP address. This is normally not a problem,
except for clearnet-over-tor. If a node has an honest clearnet-over-tor
inbound connection, the IP of the inbound peer will be the exit node's
IP address. If an attacker connects to the node through the same exit
node and sends an invalid message, they can cause every inbound peer
sharing the exit node's IP to get disconnect. Fix this by only
disconnecting the misbehaving CNode rather than every CNode sharing
the IP.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
explicit security language
AI analysis · Moderate 62/100

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehave and force the node to disconnect innocent users arriving through the same Tor exit. The fix makes the node disconnect only the specific misbehaving peer instead of all peers with that IP.

Security candidateMerge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includesby merge-script · 1fbb5253 · Nov 16, 2026 · 65 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

53561d803747567fc01ca1513ecfb280a01aa5a9 lint: Update `lint_includes_build_config` function (Hennadii Stepanov)
04108a0dbb4633a861232238a53008f15906b953 scripted-diff: Drop `IWYU pragma: keep` from build config includes (Hennadii Stepanov)

Pull request description:

This PR marks the `bitcoin-build-config.h` header with the dedicated [`IWYU pragma: always_keep`](https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#iwyu-pragma-always_keep), which makes the per-include `IWYU pragma: keep` comments redundant.

As a result, grepping for `IWYU pragma: keep` returns only the genuine use cases, each of which should be properly documented.

ACKs for top commit:
l0rinc:
code review and diff reACK 53561d803747567fc01ca1513ecfb280a01aa5a9
vasild:
ACK 53561d803747567fc01ca1513ecfb280a01aa5a9

Tree-SHA512: e7c41a0bddff816effd10fba706fd07aea383b63bae23d117fa1c4a8fa270db6a063d09caadcc96bcf4add1fd9694240cc3a9a09ec830dbe26c2db21994fbfa5

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. There is no functional change to Bitcoin Core, no bug fix, and no security impact.

Security candidateMerge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amountby merge-script · dd9d016b · Nov 12, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

050409b2c5522eff0dc37c00a6d1225a8a437e17 test: allow 3 bytes of fee overestimate in assert_fee_amount (Ferdinando Ametrano)

Pull request description:

The wallet sizes a transaction assuming a 71-byte low-R ECDSA signature. A signature whose r or s has leading zero bytes is shorter, so the fee can cover a few bytes more than the signed transaction needs. In #36394 the wallet estimated 219 bytes and paid 438 sat at 2 sat/vB, but the signed transaction was 216 bytes: the signature was 3 bytes short. That happens about once in 4 million signatures. `assert_fee_amount` allows only 2 bytes of overestimate, so the test failed.

I raise the allowance to 3 bytes, which makes the failure about 200 times rarer. The check that the fee is not too low is unchanged. maflcko suggested 3 bytes in #24151 and #25164.

Fixes #36394.

*Made with my usual tools: a computer, the Internet and an LLM. The mistakes, as usual, are all mine.*

ACKs for top commit:
Ayoazeez26:
tACK 050409b2c5522eff0dc37c00a6d1225a8a437e17
ismaelsadeeq:
ACK 050409b2c5522eff0dc37c00a6d1225a8a437e17
sedited:
ACK 050409b2c5522eff0dc37c00a6d1225a8a437e17

Tree-SHA512: d75ddf117a87a4e2e7e6d85e3c63c1ef2c9e5c12cf50b51f2016392da0c4c4172e1333d9a287f6c28f171f49b99a88505093083c2928391a760c552812f9e45e

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Informational 15/100

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare random test failure occurs.

Security candidateMerge bitcoin/bitcoin#36224: test: Add test coverage for `PartiallySignedTransaction::Merge()`by merge-script · 791173ae · Nov 12, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36224: test: Add test coverage for `PartiallySignedTransaction::Merge()`

7b124184394e016d6e3c119c50ff08d1512dfab9 test: merge PSBT `m_tx_modifiable` coverage and renaming bit positions with BIP370 flags (nebula-21)
776fb263759693a5db6aa11a8a464662d5f36da4 test: merge PSBT `fallback_locktime` coverage (nebula-21)
6fc2ebd5216975de40e9ef3b1dea1de623268794 test: only merge PSBTs with same version (nebula-21)

Pull request description:

This PR adds test coverage for `PartiallySignedTransaction::Merge()` divided into 3 tests:

Only merge PSBTs with same version: The test can be triggered with this mutant as an example:

```diff
diff --git a/src/psbt.cpp b/src/psbt.cpp
index 51fb19591a..cf5eef0089 100644
--- a/src/psbt.cpp
+++ b/src/psbt.cpp
@@ -43,7 +43,7 @@ bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)
return false;
}
if (GetVersion() != psbt.GetVersion()) {
- return false;
+ return true;
}

for (unsigned int i = 0; i < inputs.size(); ++i) {
```

Merge PSBT `fallback_locktime` coverage: If the psbt has no fallback locktime, it adopts the one from the psbt it is merging. The test can be triggered with this mutant as an example:

```diff
diff --git a/src/psbt.cpp b/src/psbt.cpp
index 51fb19591a..ce909eb062 100644
--- a/src/psbt.cpp
+++ b/src/psbt.cpp
@@ -53,7 +53,7 @@ bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)
outputs[i].Merge(psbt.outputs[i]);
}
MergeGlobalXPubs(psbt);
- if (fallback_locktime == std::nullopt && psbt.fallback_locktime != std::nullopt) fallback_locktime = psbt.fallback_locktime;
+ if (fallback_locktime == std::nullopt || psbt.fallback_locktime != std::nullopt) fallback_locktime = psbt.fallback_locktime;

// Set m_tx_modifiable only if either PSBT had it set
if (m_tx_modifiable.has_value() || psbt.m_tx_modifiable.has_value()) {
```

While writing this test I had a question: If both PSBTs have a `fallback_locktime` value, the "this" (receiving side) wins silently. Is this the expected behavior? Why not keep the max or directly fail merging if we have two conflicting fallback_locktimes? The test can be triggered with this mutant as one of the various examples:

```diff
diff --git a/src/psbt.cpp b/src/psbt.cpp
index 51fb19591a..29eb910014 100644
--- a/src/psbt.cpp
+++ b/src/psbt.cpp
@@ -56,7 +56,7 @@ bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)
if (fallback_locktime == std::nullopt && psbt.fallback_locktime != std::nullopt) fallback_locktime = psbt.fallback_locktime;

// Set m_tx_modifiable only if either PSBT had it set
- if (m_tx_modifiable.has_value() || psbt.m_tx_modifiable.has_value()) {
+ if (m_tx_modifiable.has_value() && psbt.m_tx_modifiable.has_value()) {
// In general, we AND the modifiable flags
std::bitset<8> this_modifiable = m_tx_modifiable.value_or(0);
std::bitset<8> psbt_modifiable = psbt.m_tx_modifiable.value_or(0);
```

ACKs for top commit:
polespinasa:
ACK 7b124184394e016d6e3c119c50ff08d1512dfab9
fametrano:
reACK 7b124184394e016d6e3c119c50ff08d1512dfab9
sedited:
ACK 7b124184394e016d6e3c119c50ff08d1512dfab9

Tree-SHA512: 216746a77e8967441d55bb2b988a0a069292a993476afb2f33daa66356df2b8e837ad9d3fdde550623f106c9ba0fe3333230a844cafc62e772364dd8a2bf3d4f

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds new unit tests for an existing PSBT merging function and renames some hard-coded bit numbers to named constants. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly.

Security candidateMerge bitcoin/bitcoin#36068: fuzz: reuse one fuzzed wallet across inputsby merge-script · c68583ab · Nov 11, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36068: fuzz: reuse one fuzzed wallet across inputs

fd3b09e8bcb83351c30b37505501c2a9756d907e fuzz: reuse one fuzzed wallet across inputs (brunoerg)
2553b4cd9678f9d7ba78be3573eb3cd095ab3ea6 wallet: add test-only helper to clear in-memory transaction state (brunoerg)

Pull request description:

FuzzedWallet was rebuilt for every input. That imports eight
descriptors, and each address it then hands out costs a BIP32
derivation plus three separate WalletBatch transactions (see
DescriptorScriptPubKeyMan::GetNewDestination) - all paid before the
target reaches the code under test.

This PR changes it to build the wallet once in the target's .init hook and
reset it perinput instead. I benchmarked on my Ubuntu machine without
sanitizers and got a ~6x speedup.

ACKs for top commit:
frankomosh:
reACK fd3b09e8bcb83351c30b37505501c2a9756d907e
maflcko:
re-ACK fd3b09e8bcb83351c30b37505501c2a9756d907e 👕

Tree-SHA512: 73ab582c1a054525ef4c101d4cd14741b4bbf57315db5db8982640ec499d8047701d3ab5e4442b386a55ef65a1bb7ecee2d8e407c749ea1d2ce032b10e75a6bf

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialdefensive validationfuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a performance improvement for Bitcoin Core's internal fuzz testing (automated randomized testing). It reuses a single test wallet across many fuzz inputs instead of rebuilding it each time, and adds a test-only helper to clear in-memory transaction state. There is no indication this fixes a security vulnerability or affects production wallet behavior.

Security candidateMerge bitcoin/bitcoin#36556: depends: fix non-atomic reads in capnp debug assertionsby merge-script · 117c54d4 · Nov 10, 2026 · 3 filesMessage 81 · StrongLow 29Details
Commit message · merge-script

Merge bitcoin/bitcoin#36556: depends: fix non-atomic reads in capnp debug assertions

6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec depends: fix non-atomic reads in capnp debug assertions (xyzconstant)

Pull request description:

KJ's debug assertions read the mutex futex word and `AtomicRefcounted` refcounts non-atomically. The TSan job builds capnp without optimization, which automatically enables these assertions, and TSan reports these reads as data races the moment KJ objects start communicating across threads.

libmultiprocess enables cross-thread communication for the first time in bitcoin-core/libmultiprocess#376, which replaces the pipe used in `EventLoop::sync()` with `kj::Executor::executeSync()`. This is what triggered the [failure](https://github.com/bitcoin-core/libmultiprocess/actions/runs/38094008438/job/114336046070?pr=376).

Patches are the upstream commits capnproto/capnproto@b91a6ba7c7 and capnproto/capnproto@cc13c8c45f, which are backports of the v2 fixes in capnproto/capnproto#2781 and capnproto/capnproto#2843 (backport PR: capnproto/capnproto#2855).

ACKs for top commit:
Sjors:
ACK 6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec
ryanofsky:
Code review ACK 6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec. Thanks for tracking down the race and getting the fix merged upstream first, which makes the patches easy to check.

Tree-SHA512: 07bc877c39b9e598b29eba73d066561dfd981ddf2d750d1cab383697084ecea497b6c7e7d1925fb4eed59bd7ccadfc05eef734b46e83b654a2e31033d34189ab

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Low 29/100

This commit adds two upstream patches to Bitcoin Core's build of the Cap'n Proto library. The patches fix debug-only assertions that read shared memory values without using atomic operations. These non-atomic reads were flagged by ThreadSanitizer as data races once KJ objects communicate across threads. The fix only affects debug/TSan builds and does not change release behavior; it is a correctness and testing-infrastructure improvement rather than a user-facing security bug.

Security candidateMerge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertionsby merge-script · 232cb541 · Nov 10, 2026 · 95 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertions

fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4 scripted-diff: [test] Sort includes (MarcoFalke)
fa3d6b0cf1e37f87b063edc6a159f96b35701884 scripted-diff: [fuzz] Add util/check.h includes for Assert (MarcoFalke)

Pull request description:

In test code, `assert` is used. This is perfectly fine, but sometimes confusion arises, when it is unclear whether `NDEBUG` can disable the assertions, or whether to use `assert` or `Assert`.

Avoid that confusion in test code with a scripted replacement to add the util/check.h include. The changes here will also make it easier to run IWYU.

Scope: This change is only about test code (fuzz), other code can be done later, if there is need to.

ACKs for top commit:
hebasto:
ACK fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4.

Tree-SHA512: ca0d180adc67ddff2e571393dbd35345917137699e44a8b67da653e6b75419593c4b7f78229c4cd46a48973af0cae64887ae5fcb0fdade5d9f1e5415dbe288d1

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencecryptography-sensitive pathsigning or wallet pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine cleanup of Bitcoin Core's fuzz test files. It adds the include for util/check.h (which provides the project's own Assert macro) and removes or reorders some standard C assert includes. The changes only affect test/fuzz code, not the live Bitcoin node software, and the commit message explicitly says the goal is to reduce developer confusion and improve automated include checking. There is no security fix or vulnerability here.

Security candidateMerge bitcoin/bitcoin#36788: test, bench: construct inputs/outputs declaratively in txpackage, duplicate_inputs and p2sh testsby merge-script · 4ef7904c · Nov 8, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36788: test, bench: construct inputs/outputs declaratively in txpackage, duplicate_inputs and p2sh tests

a4a2647834ad0cc4576b2eb38bddf02c42081173 test: construct script_p2sh_tests inputs/outputs declaratively (yuvicc)
7fc7d26e7507ad753cbcab2698404debcf63ca71 bench: construct duplicate_inputs inputs/outputs declaratively (yuvicc)
5336eaa7fa70c55fe4a137df721e691e61b80131 test: construct txpackage_tests inputs/outputs declaratively (yuvicc)

Pull request description:

Part of #36692. Follow-up to #36750

Replaces field-by-field construction of inputs and outputs with `COutPoint`, `CTxIn` and `CTxOut` ctor calls in `txpackage_tests`, `bench/duplicate_inputs` and `script_p2sh_tests`.

`CMutableTransaction` is kept as the builder while a `CTransaction` constructor is discussed in #36696. Witnesses are still assigned after `vin`, since `CTxIn` has no witness argument yet.

Test-only; the constructed transactions are unchanged.

- `script_p2sh_tests`: two outputs created by `vout.resize(1)` never had a value, so their null `nValue` (`-1`) is now explicit.
- Intentional mutations are left as they are: the `scriptSig` swap in `sign`, the dummy signing in `ValidateInputsStandardness`, and the witness-only copies in `txpackage_tests` (`mtx_child2`, `mtx_parent2_v2`).

ACKs for top commit:
alexanderwiederin:
ACK a4a2647834a
purpleKarrot:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173
maflcko:
review ACK a4a2647834ad0cc4576b2eb38bddf02c42081173 👒
janb84:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173
jpk68:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173

Tree-SHA512: ca452697a5bcccfbed2778785906f75c22e95fea04a1e79fb2d6fdae80ebe4badf5d8cb49a8b6add6e80a480b4826436caaee43ec534d4e6aae22f6584935b86

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydefensive validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a cleanup of Bitcoin Core's internal test and benchmark code only. It changes how dummy transactions are built in three test files, making the code more readable without changing what the transactions actually are. There is no change to the live Bitcoin network code, no security fix, and no vulnerability introduced.

Security candidateMerge bitcoin/bitcoin#36591: test: deduplicate PSBT unknown-field coverage in `rpc_psbt.py`by merge-script · 654d74cc · Nov 6, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36591: test: deduplicate PSBT unknown-field coverage in `rpc_psbt.py`

ef4310097bd651497a98a9d1bb59560a7055ae01 test: combine redundant PSBT unknown field merge cases into `test_combinepsbt_preserves_unknown_fields` (nebula-21)
40eba5eb20ba0041a6328ba3482fcc26ddbe0185 test: extract unknown fields passthrough to its own method (nebula-21)

Pull request description:

I've tested some mutations related to test coverage for PSBT unknown field merging and discovered an inconsistency.
<details>

If line 71 of `psbt.cpp` "`unknown.insert(psbt.unknown.begin(), psbt.unknown.end());`" (inside `bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)` function) is removed then, the expected test fails: *"Test that combining PSBTs preserves unknown fields with the same and with distinct values per map."*

If line 434 of `psbt.cpp` "`unknown.insert(input.unknown.begin(), input.unknown.end());`" (inside `bool PSBTInput::Merge(const PSBTInput& input)` function), is removed, a different unexpected test fails: "*Test that unknown values are just passed through*".

If line 537 of `psbt.cpp` "`unknown.insert(output.unknown.begin(), output.unknown.end());`" (inside `bool PSBTOutput::Merge(const PSBTOutput& output)` function), is removed, the expected test fails: "*Test that combining PSBTs preserves unknown fields with the same and with distinct values per map.*".
</details>

This PR solves this inconsistency.
The old code did 3 different things:
1. Test the pass-through of unknown values for `walletprocesspsbt`.
2. Combine two v0 PSBTs with different unknown input keys and check that both keys survive.
3. Combine implicit v0 PSBT with explicit v0 and check that both keys survive.

Case 2 is already fully covered by the existing `test_combinepsbt_preseves_unknown_fields` so keeping it is redundant and misleading.

Commit 40eba5eb20ba0041a6328ba3482fcc26ddbe0185 moves the old code into a new method called `test_unknown_fields_passthrough` and commit ef4310097bd651497a98a9d1bb59560a7055ae01 removes the redundant code of Case 2 and moves Case 3 inside `test_combinepsbt_preserves_unknown_fields`.

ACKs for top commit:
Naomi-Gift:
tACK ef4310097bd651497a98a9d1bb59560a7055ae01
polespinasa:
ACK ef4310097bd651497a98a9d1bb59560a7055ae01

Tree-SHA512: 14476cffc28a8548fe58e42d8862d4fdb300c36d81679551fa8f9af83b49da3c65c2fe3283e9a4ec3e5c45abe3f34b8270dc2208a4f0534ff1f6062948bfcae9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only reorganizes existing test code in Bitcoin Core's functional test suite. It moves and deduplicates tests that check how unknown PSBT fields are preserved when PSBTs are combined or processed by the wallet. No production code was changed, and no security bug was fixed or introduced.

Security candidateMerge bitcoin/bitcoin#36783: Update minisketch subtree to latest masterby merge-script · f12cc4ae · Nov 6, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36783: Update minisketch subtree to latest master

be064af99df3870d3d01d9969da7268cc3881375 Squashed 'src/minisketch/' changes from a12f5de1c9..d44dca4e3f (fanquake)

Pull request description:

Includes:
* https://github.com/bitcoin-core/minisketch/pull/106

Used in #36623.

ACKs for top commit:
willcl-ark:
utACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3
sedited:
ACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3

Tree-SHA512: 8464382c5bab000ce347136b67e0966aa97f388af0d864ee0c38306aab9ba7c7a91fb96d6e4b14dee3b58a99501c62ec52d596a392857afac07deb9ada32fa84

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 19/100

This is a routine update of an internal math library (minisketch) used by Bitcoin Core. The visible code change removes an unreachable 'break' statement that followed a 'return' inside a switch case. That kind of cleanup is cosmetic and does not change program behavior. There is no indication in the commit message or diff that this fixes a security vulnerability.

Security candidateMerge bitcoin/bitcoin#36731: test: use monotonic clock for durations in test framework and http_interfaceby merge-script · 521bbaf4 · Nov 6, 2026 · 6 filesMessage 91 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36731: test: use monotonic clock for durations in test framework and http_interface

a7d3a4297321274ced64294e0bbd3252167e8879 test: use monotonic clock in interface_http (ViniciusCestarii)
eccca10e6460507e553e61a1cdaf664fa7738375 test: use monotonic clock for durations in test framework (ViniciusCestarii)

Pull request description:

Replace `time.time()` used to measure durations by `time.monotonic()` in test framework and http_interface.

This helps preventing future clock jump flakiness (same class of bug as #36529) on tests and fix:

```
faketime --exclude-monotonic -f "+0 x0.5" build/test/functional/feature_torcontrol.py
faketime --exclude-monotonic -f "+0 x0.1" build/test/functional/interface_http.py
```

ACKs for top commit:
nervana21:
tACK a7d3a4297321274ced64294e0bbd3252167e8879
maflcko:
review ACK a7d3a4297321274ced64294e0bbd3252167e8879 🕐
sedited:
ACK a7d3a4297321274ced64294e0bbd3252167e8879

Tree-SHA512: d1c6b98ceab4c4bf5b97a44b4a4577b0868292d2aaa359aa67a807be469700737f0d330da83e8b6f85403635db6809c41dcd4041a84f3ab6dad9ef16e50a44d1

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
authentication pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit only changes the test code that runs Bitcoin Core's automated tests. It swaps the clock used to measure how long things take from the regular system clock (which can jump forward or backward, for example when the system time is adjusted) to a monotonic clock (which only ever moves forward steadily). This makes the tests more reliable and less likely to fail randomly due to clock jumps, but it does not change the actual Bitcoin Core software that users run, nor does it fix any security vulnerability in the live network or node software.

Security candidateMerge bitcoin/bitcoin#36725: refactor: Use u64 consistently for flatfile sizesby merge-script · 6996cf7a · Nov 5, 2026 · 10 filesMessage 96 · StrongLow 27Details
Commit message · merge-script

Merge bitcoin/bitcoin#36725: refactor: Use u64 consistently for flatfile sizes

fa2c8df1810f23e1c510e310eb246fd5abd3a066 Add test coverage for varint overflow (MarcoFalke)
faed02f6d0aba80e1f99842fcd575625d9e89fc1 refactor: Use LARGE_INTEGER QuadPart on Windows (MarcoFalke)
faf8d0e33ad000f72539aeedf4ab47c2e25b97ba refactor: Use u64 consistently for flatfile sizes (MarcoFalke)

Pull request description:

`unsigned` is a 32-bit integer (even on 64-bit platforms). File sizes are generally measured in 64-bit integers and using 32-bit integers or architecture-dependent integers is brittle and confusing.

So use u64 consistently for flatfile sizes in this refactor.

Also, use `LARGE_INTEGER`'s `QuadPart` on Windows, which is recommended since C++11.

Also, unit test VarInt overflow errors.

ACKs for top commit:
darosior:
utACK fa2c8df1810f23e1c510e310eb246fd5abd3a066
frankomosh:
ACK fa2c8df1810f23e1c510e310eb246fd5abd3a066
sedited:
ACK fa2c8df1810f23e1c510e310eb246fd5abd3a066

Tree-SHA512: f79593a6d01296177e432a25d9ce2af0fb8a2cbcea3a2ba8160f6ac03c16ea6a26ba97341475bf9a22c3bc4a28f7fce741bc544b82d604fe209c43786508966d

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Low 27/100

This is a code cleanup (refactor) that switches file-size variables from 32-bit or platform-dependent types to a consistent 64-bit unsigned type. It also adds unit tests for variable-integer overflow and simplifies a Windows file-size API call. The changes reduce the risk of future bugs related to very large files or integer overflow, but they do not by themselves fix a known exploitable vulnerability.

Security candidateMerge bitcoin/bitcoin#36384: rpc: Use self.Arg<_>(name) helper over manual and duplicate parsingby merge-script · 9f03a91c · Nov 5, 2026 · 15 filesMessage 81 · StrongInformational 21Details
Commit message · merge-script

Merge bitcoin/bitcoin#36384: rpc: Use self.Arg<_>(name) helper over manual and duplicate parsing

fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b doc: Fix typo in walletcreatefundedpsbt dev comment (MarcoFalke)
fa62bc2b42f129495541f122707183185da1062b refactor: rpc: Use self.Arg<_>(name) helper over manual isNull() ? fallback : getter() (MarcoFalke)
faee904d88faa33aeac317119b245730e5e0fcfe rpc: Align psbt_version parsing (MarcoFalke)
fab17591d5155dc5e903025ff8d021f9ac3e42de rpc: Parse generatetoaddress maxtries as u64 (MarcoFalke)
fa105f82c3cb4b48c992cdb3e04096c86a34f2c9 rpc: doc: Use proper RPCArg::Default in verifychain (MarcoFalke)
6666c799b956c0403cb68a85fe9f1d8a3935ed76 rpc: Use the first arg name in GetParamIndex (MarcoFalke)

Pull request description:

The `Arg()` helper has many benefits:

* It does not require manual `isNull` checks
* It does not require hard-coding the fallback/default value a second time
* It does not require manually specifying the getter for the type. Specifying the type is enough.

So use it more broadly.

ACKs for top commit:
stickies-v:
re-ACK fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b
fanquake:
ACK fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b

Tree-SHA512: d057a5be92656cc6b5d4104e7adc43075e9e78852ce99c3ded73a967e08c51d0eba5d02442c57f19b7c62b0ae368031581e10677bbad29f87de1ed0af2498d27

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 21/100

This is a code cleanup change in Bitcoin Core's RPC (remote procedure call) handling. It replaces manual argument parsing with a helper called self.Arg<_>(name). The goal is to reduce duplicated code and make defaults easier to maintain. There is no obvious security vulnerability introduced, but any refactor touching many RPC commands carries a small risk of subtle behavior changes.

Security candidateMerge bitcoin/bitcoin#36192: test: cover unsatisfiable mining timestampby merge-script · b4f341a9 · Nov 5, 2026 · 6 filesMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36192: test: cover unsatisfiable mining timestamp

c000f6ef15e06856b9111ee433877a2b1bf31eb4 test: assert Murch-Zawy period boundaries (Sjors Provoost)
9b4f05a240a3feaf99976fd14952a21b3f96e029 test: cover unsatisfiable mining timestamp (Sjors Provoost)
2137b7b2ee3ae3c39aa74a9ac7e26d821c1b4988 test: share block timing constants through blocktools (Sjors Provoost)
bb32ef4d541d14752f2dca9b1a633aecea9d40a7 test: drop REGTEST_ prefix from block difficulty constants (Sjors Provoost)
9f34ea1605bd0c8726cc69ecf5686cc6d3d0d125 test: rename REGTEST_RETARGET_PERIOD to HALVING_INTERVAL (Sjors Provoost)

Pull request description:

This PR adds test coverage for what happens in the (extremely unlikely) event that the miner can't satisfy the constraints. This is inspired by the recently added timewarp-protection and Murch-Zawy rules (for the miner, not for consensus, see #30681 and #35949), but this is a pre-existing issue. It is not made worse by these rules.

The test has an attacker mine 6 blocks, which set MTP at the victim's future-time limit. It calls `getblocktemplate` and the equivalent IPC method, which both fail. It then moves mock time one second forward, and demonstrates mining works again (and we don't drop the IPC connection).

This (impractical) attack can be done at any height, be we illustrate it for blocks 142, 143 and 0 of a retarget period, to clarify that the timewarp-protection and Murch-Zawy rules do not matter.

The test was added to `ipc_mining.py`, to avoid having to add IPC support to `mining_basic.py`. Mining coverage is currently split between various test files and not always mirrored between RPC and IPC. A followup could unify these, while still skipping the IPC side when that's not compiled.

A few refactor commits to prepare:

- fix incorrect name: `REGTEST_RETARGET_PERIOD` -> `HALVING_INTERVAL`
- drop `REGTEST_` prefix from `REGTEST_N_BITS` and `REGTEST_TARGET` (consistent with `HALVING_INTERVAL`, `DIFFICULTY_ADJUSTMENT_INTERVAL` and `TIME_GENESIS_BLOCK`).
- move `DIFFICULTY_ADJUSTMENT_INTERVAL` to the framework

The last commit picks up a Murch-Zawy followup suggested in https://github.com/bitcoin/bitcoin/pull/35949#discussion_r3944011135 and takes advantage of our refactor, but is otherwise unrelated.

ACKs for top commit:
fjahr:
reACK c000f6ef15e06856b9111ee433877a2b1bf31eb4
ismaelsadeeq:
reACK c000f6ef15e06856b9111ee433877a2b1bf31eb4
sedited:
ACK c000f6ef15e06856b9111ee433877a2b1bf31eb4

Tree-SHA512: e92c46ba5366024eca6d2af5569f3665bea22db232608ca8b94abf3c921a2cc39e70af1aa2612c972a4ad2838da0d9ad47941d676b6f802bbc8987ed8ac6639c

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languageconsensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds and reorganizes Bitcoin Core's own functional tests. It renames some test constants, moves a shared constant into the test framework, and adds a new test that checks how the mining code behaves when an attacker manipulates block timestamps to make template creation temporarily fail. The commit does not change any production consensus, networking, or wallet code, and the pull request description explicitly calls the scenario an 'impractical' test-case. There is no security patch or vulnerability fix here.

Security candidateMerge bitcoin/bitcoin#36592: build: Bump macOS SDK version to 15.0by merge-script · fefea34e · Nov 5, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36592: build: Bump macOS SDK version to 15.0

eaa8d1f5a5fcfeefcb3ff432aeb969e8f8f14a7d build: Bump macOS SDK version to 15.0 (Hennadii Stepanov)

Pull request description:

Qt 6.12, which supports deployment targets up to macOS 26, requires the macOS 15 SDK or higher.

See https://doc.qt.io/qt-6.12/macos.html.

This is a prerequisite for the upcoming update of Qt in depends from 6.8 LTS to 6.12 LTS.

My partial Guix build:
```console
$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
x86_64
727bcc7343afc599cadad3891a6aaa73883594a5feea6695b81056eaf1881914 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/SHA256SUMS.part
cea76395e4761c9cc6c1e7fc0eae52abd3bb024caeed62a3461a9cf0de2f4b08 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-codesigning.tar.gz
8886c05cca9f518441284be4cb415d275b7d118e8150e441d053e3fc61d27807 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-unsigned.tar.gz
7c6c4423e6272a821fd6adefaac6dd4a1e09f7f85ecf9efa6bd7e97c0ddc79bc guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-unsigned.zip
a74db20b1a8acd1a570a733d02ea7e3aa28ac8902462e9be9fac10e0f84e4ca1 guix-build-eaa8d1f5a5fc/output/dist-archive/bitcoin-eaa8d1f5a5fc.tar.gz
f708d94dc0343a5057d3b8791242acd67dbb1f481b2da7fc778aa981e9fc2e42 guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/SHA256SUMS.part
98ddcc471b967208e491c06f697e94d09005631da463e085ee88e281c035180e guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-codesigning.tar.gz
7aeb9b6f84679f11d22ffe1faf4b0aa386c09f641a6d742f70ef727466b24d0f guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-unsigned.tar.gz
de23e46dbe3c0886fd689b16ab345120907445212ffb6fcb41ccca8cfc8d628e guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-unsigned.zip
```

ACKs for top commit:
maflcko:
lgtm ACK eaa8d1f5a5fcfeefcb3ff432aeb969e8f8f14a7d

Tree-SHA512: 6dd679e9dfdae60e4a2cb6f891c3779699dc27045fe877a820dd839972fd0771dcdf9d0a432a0cb64a1de58b138e4e5fe24d1ab43af7cd8aa3fe632f4717cab4

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Informational 15/100

This commit simply updates the version number of the Apple macOS software development kit (SDK) used to build Bitcoin Core from 14.0 to 15.0. It is a routine build-system change needed to support a future Qt GUI library upgrade. There is no indication of a security vulnerability, bug fix, or behavior change in the running software.

Security candidateMerge bitcoin/bitcoin#36747: Update libmultiprocess subtree to add nonunix platform support and fix race conditionsby merge-script · 93bd4e1d · Nov 5, 2026 · 68 filesMessage 100 · StrongModerate 59Details
Commit message · merge-script

Merge bitcoin/bitcoin#36747: Update libmultiprocess subtree to add nonunix platform support and fix race conditions

d5f7524897dd5ec638cebf7d61607c561c3b9e2b doc: Bump minimum required Cap'n Proto version to 0.9.2 (Ryan Ofsky)
4898199d8f97cad75cfd54a9caed3ffd3ce2948c build: suppress -Wc++23-lambda-attributes in warn_interface (Ryan Ofsky)
270f5dbe3ddac5191ec6b21ceb17c3dddb79b12f Squashed 'src/ipc/libmultiprocess/' changes from e8de5c7b68e..acded1aafae (Ryan Ofsky)

Pull request description:

The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh).

Changes since last subtree update (#35720):

- Adds support for nonunix platforms, making API changes that are not backwards compatible ([#274](https://github.com/bitcoin-core/libmultiprocess/pull/274)). Follow-ups add a `CurrentThread()` accessor matching compatibility code in [bitcoin/bitcoin#35084](https://github.com/bitcoin/bitcoin/pull/35084) ([#323](https://github.com/bitcoin-core/libmultiprocess/pull/323)) and remove code for Cap'n Proto versions before 0.9 ([#331](https://github.com/bitcoin-core/libmultiprocess/pull/331)).
- Fixes a data race between IPC calls running on worker threads and disconnects, found by Antithesis ([#349](https://github.com/bitcoin-core/libmultiprocess/pull/349)).
- Fixes a use-after-free when a socket disconnects before `ConnectStream` connects, and leaks and hangs when a client `construct()` call throws ([#298](https://github.com/bitcoin-core/libmultiprocess/pull/298)).
- Fixes a race where file descriptors from `SpawnProcess` could leak into processes forked at the same time by other threads, by clearing `FD_CLOEXEC` in the child after forking ([#311](https://github.com/bitcoin-core/libmultiprocess/pull/311)).
- Makes `SpawnProcess` report `exec` failures back to the parent and throw, reaping the child ([#312](https://github.com/bitcoin-core/libmultiprocess/pull/312)).
- Adds support for `std::chrono::time_point` fields ([#303](https://github.com/bitcoin-core/libmultiprocess/pull/303)) and for serializing lists of interface objects that need to be moved from ([#304](https://github.com/bitcoin-core/libmultiprocess/pull/304)), both needed by [bitcoin/bitcoin#10102](https://github.com/bitcoin/bitcoin/pull/10102).
- Accepts container fields and parameters with any comparator, hash, and allocator types, like Bitcoin Core's `GCSFilter::ElementSet`, needed by [bitcoin/bitcoin#29409](https://github.com/bitcoin/bitcoin/pull/29409) ([#379](https://github.com/bitcoin-core/libmultiprocess/pull/379)).
- Finds the `capnp` tool in vcpkg and Windows builds, needed by [bitcoin/bitcoin#32387](https://github.com/bitcoin/bitcoin/pull/32387) ([#317](https://github.com/bitcoin-core/libmultiprocess/pull/317)).
- Adds a `destroy_connection` option to `ServeStream` and `ConnectStream`, lets `ServeStream` take ownership of the init object and return the new server and its connection, and adds an `EventLoop::incomingConnections()` accessor, simplifying test setup in both repositories and needed by [bitcoin/bitcoin#35932](https://github.com/bitcoin/bitcoin/pull/35932) ([#365](https://github.com/bitcoin-core/libmultiprocess/pull/365)).
- Replaces `EventLoop::post()` with `sync()` taking a `kj::FunctionParam`, avoiding a heap allocation per call ([#347](https://github.com/bitcoin-core/libmultiprocess/pull/347)).
- Names threads spawned by the event loop so they can be told apart in tools and logs ([#324](https://github.com/bitcoin-core/libmultiprocess/pull/324)).
- Fixes warnings that Bitcoin Core enables or plans to enable: adds `[[noreturn]]` attributes for `-Wmissing-noreturn` ([#339](https://github.com/bitcoin-core/libmultiprocess/pull/339), for [bitcoin/bitcoin#35911](https://github.com/bitcoin/bitcoin/pull/35911)), and fixes `-Wunused` ([#362](https://github.com/bitcoin-core/libmultiprocess/pull/362), for [bitcoin/bitcoin#36167](https://github.com/bitcoin/bitcoin/pull/36167)), `-Wunused-const-variable` and `-Wundef` ([#370](https://github.com/bitcoin-core/libmultiprocess/pull/370)), and `-Wmissing-prototypes` ([#386](https://github.com/bitcoin-core/libmultiprocess/pull/386), for [bitcoin/bitcoin#36743](https://github.com/bitcoin/bitcoin/pull/36743)) warnings.
- Fails at compile time with a suggested workaround when Cap'n Proto misdetects exception support (`KJ_NO_EXCEPTIONS`), as happens on NetBSD ([#364](https://github.com/bitcoin-core/libmultiprocess/pull/364)).
- Build improvements: fixes stale generated code when the `mpgen` binary changes ([#316](https://github.com/bitcoin-core/libmultiprocess/pull/316)), fixes `mpgen` link order for static Cap'n Proto builds ([#367](https://github.com/bitcoin-core/libmultiprocess/pull/367)), links `mpgen` against `kj-async` instead of `capnp-rpc` ([#327](https://github.com/bitcoin-core/libmultiprocess/pull/327)), shows Cap'n Proto `find_package` diagnostics ([#325](https://github.com/bitcoin-core/libmultiprocess/pull/325)), installs `type-unordered-set.h` and `version.h` ([#350](https://github.com/bitcoin-core/libmultiprocess/pull/350)), and shows include-what-you-use errors instead of failing silently ([#371](https://github.com/bitcoin-core/libmultiprocess/pull/371)).
- Test, CI, documentation, and minor code improvements: fix for a startup race in the example program ([#315](https://github.com/bitcoin-core/libmultiprocess/pull/315)), new test for immediate client disconnects in `ListenConnections` ([#310](https://github.com/bitcoin-core/libmultiprocess/pull/310)), `ReadList` return value check ([#338](https://github.com/bitcoin-core/libmultiprocess/pull/338)), connect test race fix ([#343](https://github.com/bitcoin-core/libmultiprocess/pull/343)) and cleanups ([#344](https://github.com/bitcoin-core/libmultiprocess/pull/344)), `std::ranges::copy` follow-ups ([#307](https://github.com/bitcoin-core/libmultiprocess/pull/307)), trailing whitespace removal ([#345](https://github.com/bitcoin-core/libmultiprocess/pull/345)), Cap'n Proto version documentation fix ([#357](https://github.com/bitcoin-core/libmultiprocess/pull/357)), clang-tidy updates ([#358](https://github.com/bitcoin-core/libmultiprocess/pull/358), [#360](https://github.com/bitcoin-core/libmultiprocess/pull/360), [#380](https://github.com/bitcoin-core/libmultiprocess/pull/380), [#389](https://github.com/bitcoin-core/libmultiprocess/pull/389)), new CI job testing newer cmake and Cap'n Proto versions ([#212](https://github.com/bitcoin-core/libmultiprocess/pull/212), [#359](https://github.com/bitcoin-core/libmultiprocess/pull/359)), CI coverage for the minimum supported g++ ([#330](https://github.com/bitcoin-core/libmultiprocess/pull/330), [#366](https://github.com/bitcoin-core/libmultiprocess/pull/366)), new CI warnings ([#332](https://github.com/bitcoin-core/libmultiprocess/pull/332), [#341](https://github.com/bitcoin-core/libmultiprocess/pull/341)), CI parallelism ([#334](https://github.com/bitcoin-core/libmultiprocess/pull/334), [#356](https://github.com/bitcoin-core/libmultiprocess/pull/356)), CI diagnostics ([#351](https://github.com/bitcoin-core/libmultiprocess/pull/351), [#352](https://github.com/bitcoin-core/libmultiprocess/pull/352)), Nix and LLVM updates ([#296](https://github.com/bitcoin-core/libmultiprocess/pull/296), [#363](https://github.com/bitcoin-core/libmultiprocess/pull/363)), NetBSD and OpenBSD CI fixes ([#321](https://github.com/bitcoin-core/libmultiprocess/pull/321), [#340](https://github.com/bitcoin-core/libmultiprocess/pull/340), [#381](https://github.com/bitcoin-core/libmultiprocess/pull/381)), building Cap'n Proto with GCC in the 32-bit CI job to avoid an ABI mismatch ([#383](https://github.com/bitcoin-core/libmultiprocess/pull/383)), and GitHub Actions updates ([#387](https://github.com/bitcoin-core/libmultiprocess/pull/387)).

The second commit suppresses the clang `-Wc++23-lambda-attributes` warning, which the new `[[noreturn]]` lambda attribute in `mp/proxy-types.h` triggers in C++20 builds. Since #31507 the Windows build uses clang-cl, so the same flag covers it.

The third commit updates the minimum Cap'n Proto version in `doc/dependencies.md` to 0.9.2 (1.0 with Clang). This update raises libmultiprocess's own minimum from 0.7 to 0.9 (bitcoin-core/libmultiprocess#331), and libmultiprocess rejects 0.9.0 and 0.9.1 for CVE-2022-46149 and, with Clang 16 or newer, every version before 1.0.

ACKs for top commit:
fanquake:
ACK d5f7524897dd5ec638cebf7d61607c561c3b9e2b
willcl-ark:
ACK d5f7524897dd5ec638cebf7d61607c561c3b9e2b

Tree-SHA512: 4064944f4d8bb6c1665ddc7d5fae838492235d7dfdafab88b19b687ff6892460a3f450b90a145b287866330c569b862d748c941a70c65abc7f273ef13e490fd7

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languagesigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 59/100

This is a routine subtree update that pulls in a newer version of the libmultiprocess inter-process communication library used by Bitcoin Core. The commit message and code changes explicitly describe several bug fixes for race conditions, use-after-free, and file-descriptor leaks in the IPC layer. It also raises the minimum required Cap'n Proto version because older versions have a known memory-safety vulnerability (CVE-2022-46149). The changes are defensive: they fix bugs rather than introduce new attack surface, but the bugs being fixed are in security-relevant areas (cross-process communication, threading, and process spawning).

Security candidateMerge bitcoin/bitcoin#35170: test: Better test coverage for ParseHDKeypath()by merge-script · e0b4592e · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35170: test: Better test coverage for ParseHDKeypath()

3ce364124c09157722781720ee60aabb5a99e133 test: bip32_tests: Add some more tests cases (optout)
72414a709d57308e4fe69d5d96188beeeebb6855 test: bip32_tests: Add round-trip tests (optout)
60bdfdb19e98b7574b0a2c565f81c8dfec514e2f test: bip32_tests: Add expected result checks (optout)
7b5ce9c529bd38f29c1216a93fd44ae62edb56bb test: Refactor in bip32_tests: extract test data in an array (optout)

Pull request description:

Background: The `ParseHDKeypath` method (`src/util/bip32.cpp`) is used directly only in a limited way: when loading legacy wallets. However, it shares internals with parsing within descriptors (`ParseKeyPath`, `ParseKeyPathNum` in `src/script/descriptor.cpp`, c.f. #35069).

Deficiencies: The method has a unit test, but it checks only the bool result, and not the parsed keypath. This can be demonstrated by breaking the implementation by adding a `keypath.clear();` statement just before the final `return true;`. With this obviously broken implementation the tests pass.

Solution proposed: Extend the tests with checks (without modifying the behavior).

Changes:

- Extend the unit tests with checks for the returned parsed keypath. Add the expected parsed numerical keypath as test data. Note: breaking the production code as described above now results in test failure.

- In the unit test also perform round-trip conversion: convert to string, then parse again, and convert to string again. In the last two steps the results should match the input before the round-trip (note: this is not true for the first roundtrip). Additionally, add negative tests for the unsupported 'h' hardened delimiter.

ACKs for top commit:
Sjors:
re-ACK 3ce3641
achow101:
ACK 3ce364124c09157722781720ee60aabb5a99e133

Tree-SHA512: 4b0450da1c5cccf12e15aeb272c927ef3b119466ae14d9fcea3e34c5ef6e02068c43e22d68a4433c9d1a4f3c111c799f8165c13147a7317706b03e056dfb86dd

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialdefensive validationcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds and improves unit tests for the ParseHDKeypath() function. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. The change makes the tests verify the actual parsed output and adds round-trip checks, which improves test quality but has no runtime security impact on its own.

Security candidateMerge bitcoin/bitcoin#36142: net: validate Tor onion service replies and cached keysby merge-script · fdd93cbb · Nov 5, 2026 · 3 filesMessage 96 · StrongHigh 70Details
Commit message · merge-script

Merge bitcoin/bitcoin#36142: net: validate Tor onion service replies and cached keys

0a53d12589c3116495a50a694006ce5ee220fb2d torcontrol: reject invalid service IDs (Lőrinc)
d0b447cf7f11d791622c919d2a0731bf33a7d33f torcontrol: validate returned and cached keys (Lőrinc)
3413d17028da5f5658af5637297013f8e396bafa torcontrol: discard replies missing a service ID (Lőrinc)
3601a1d1086b132f11db3b5e969d8fac9203decc test: characterize ADD_ONION reply handling (Lőrinc)
d63a8576d9beef910c54aabc388278897c16a41f refactor: prepare ADD_ONION validation (Lőrinc)

Pull request description:

**Problem:** A node creates its onion service through Tor's control protocol and caches the returned `PrivateKey` value for reconnects.
Tor reply parsing unescapes quoted values, so a control endpoint can return a value containing a line break or space.
On reconnect, the node inserts that value unquoted into an `ADD_ONION` command.
CRLF frames the remainder as a separate command, while a space adds further arguments.
An unprivileged local process can exploit this by impersonating the default loopback endpoint while Tor is unavailable, seeding the cache, and releasing the port before Tor is available again.
A compromised operator-configured endpoint can return the same malicious value.
The reply handler also continues after receiving an invalid service ID, logging it and caching the key before attempting to advertise the invalid address.
A later reply without a service ID can reuse an ID left by an earlier reply.

**Fix:** This PR validates the returned service ID as a Tor v3 onion address before logging it, caching the key, or advertising the service.
Each reply must provide its own service ID, and reply fields stay local until validation succeeds.
Key validation accepts `NEW:ED25519-V3` or an `ED25519-V3` key whose Base64 payload decodes to 64 bytes.
Returned keys are validated before adoption or caching, and cached keys are validated before reuse.
A malformed cached key leaves the onion service unavailable until the operator removes the file and restarts the node. It cannot inject another command or argument.

ACKs for top commit:
jpk68:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d
vasild:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d
winterrdog:
tACK 0a53d12589c3116495a50a694006ce5ee220fb2d
sedited:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d

Tree-SHA512: ce3d75da56d9d2ef52655c15b8c85995cdec38305abc4c7af6baf45e03288e08e8ab13b67925b8f1c0a0734ae062101cb2bb912e962b517b8f99ee0e9911f882

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagedefensive validationcredential or privilege statemerge-commit duplicate discount
AI analysis · High 70/100

This update fixes a weakness in how Bitcoin Core talks to the Tor control port when setting up a hidden onion service. A fake or compromised Tor control endpoint could trick the node into storing a malicious private key. On a later reconnect, that bad key could be inserted into an 'ADD_ONION' command in a way that adds extra commands or arguments for Tor to run. The fix checks that any returned or cached private key has the expected format and that the returned onion address is a valid Tor v3 service ID before using or saving it.

Security candidateMerge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declarativelyby merge-script · 3b1ba022 · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declaratively

c723c37de69fd95e6ec795e848efb03d944999ba test: construct multisig_tests inputs/outputs declaratively (yuvicc)

Pull request description:

Part of #36692. This replaces the field-by-field construction of transaction inputs and outputs in `multisig_tests` with `COutPoint`, `CTxIn` and `CTxOut` constructor calls.

It keeps `CMutableTransaction` as the builder, since a `CTransaction` constructor taking inputs and outputs directly is still under discussion (#36696). If one is added, the `vin`/`vout` lists here can be passed to it directly.

This change is test-only and does not change the constructed transactions:

- The funding outputs were previously created by `vout.resize(3)` and only had their `scriptPubKey` assigned, leaving `nValue` at its null value (`-1`). The `-1` is now spelled out explicitly, which makes this previously hidden value visible
- The loop index is changed from `int` to `uint32_t` to match `COutPoint::n`

ACKs for top commit:
purpleKarrot:
ACK c723c37
maflcko:
review ACK c723c37de69fd95e6ec795e848efb03d944999ba 🍯
alexanderwiederin:
ACK c723c37

Tree-SHA512: 3122762dae1e4fbc1a4ad79ce67128e83d29da965b3c8b6009f075c39310b8f983a96e3c4f30844a57af2faca4c658149808176aa4bb67d940ebeec147031676

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a test-only code cleanup in Bitcoin Core. It changes how fake transactions are built inside unit tests, making the test code more readable without altering the actual transactions being tested. There is no effect on the live Bitcoin network or wallet software.

Security candidateMerge bitcoin/bitcoin#36539: gui: Use PSBT v0by Ava Chow · 5965d476 · Nov 4, 2026 · 8 filesMessage 86 · StrongLow 35Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36539: gui: Use PSBT v0

3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0 refactor: psbt: Don't set a default version for PSBT constructor (David Gumberg)
23dcb03a2c6b9fed84896ac4d751ba9e8034a6bf gui: wallet: Use v0 PSBT (David Gumberg)

Pull request description:

This fixes: https://github.com/bitcoin/bitcoin/issues/36518

There is no test added here for the bump fee PSBT's being v0, since there aren't any existing tests for watch only wallet feebumping in the GUI. If reviewers insist on this I can add it, but I wanted to keep the diff minimal. I have tested this manually.

AFAIU for the external signer stuff it shouldn't matter much whether it's v0 or v2, since users are very unlikely to be using HWI software that doesn't speak v0, but out of caution I've set the external signer PSBT to v0 for the GUI.

_This PR originally took the approach of adding a checkbox, ([davidgumberg/gui/2026-10-15-psbt-gui](https://github.com/davidgumberg/gui/tree/2026-10-15-psbt-gui)), but this was dropped to simplify backporting past string freeze._

_LLM Disclosure: The previous approach was drafted using an LLM, but this branch was written by me. I used an LLM to explore adding a fee bump watchonly GUI test, and decided against it._

ACKs for top commit:
Sjors:
ACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0
achow101:
ACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0
w0xlt:
crACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0

Tree-SHA512: 9f157aed7c2b3395e51322a9f7ff54879e6e3ee2913ea532922291f7ba055b8294c850b430fb0193759cdae0a041109ce57cb924bc2ed2d429e005041a8da0da

86/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 35/100

This change makes the Bitcoin Core graphical wallet produce older PSBT v0 files instead of PSBT v2 in several common user flows (creating unsigned transactions, bumping fees). PSBT v2 is newer and not supported by some older external signer tools/hardware wallet software. By defaulting to v0 in the GUI, the wallet stays compatible with more hardware signing tools. The change also removes the automatic default version from the PSBT constructor so callers must explicitly choose a version. This is a compatibility/usability fix, not a fix for theft-of-funds or remote code execution.