Bitcoin Core

Merge bitcoin/bitcoin#35630: test: Add importdescriptors rpc error test coverage

3ac8b806a699a1d518ce225b39aa504f84b4cc06 test: test the result order of a multiple import request is correct (Pol Espinasa)
e4732bf01876cbe5f8e1a02a75e08f435de1aef4 test: test invalid or missing timestamp throws importdescriptors (Pol Espinasa)
07fb58b9ef2560d2f34f4ce676bc5eb64554d2de test: Test a locked wallet rejects an empty importdescriptors request (Pol Espinasa)

Pull request description:

In addition to #35179 (already merged) this adds more missing test coverage that was detected while rebasing #34861.

The three tests added checks:
- Locked wallet throws because of being locked if giving an empty importdescriptors request.
- Invalid or missing timestamp throws as a top level RPC error and not a per-item error.
- The order of the requests and the response is the same, even if failing or succeeding.

ACKs for top commit:
nebula-21:
ACK 3ac8b806a699a1d518ce225b39aa504f84b4cc06
Bicaru20:
re-ACK 3ac8b806a699a1d518ce225b39aa504f84b4cc06
brunoerg:
reACK 3ac8b806a699a1d518ce225b39aa504f84b4cc06

Tree-SHA512: b6ba9e16bbdbefcab2529f49f9aab0ae8885bd2d381c6eec36ae442dea1aa2361e6fb339ab5bc2c51c3bef6216d8d939db53e57ec577f05fe54c07fc46f8f255

test: test the result order of a multiple import request is correct

Co-Authored-By: Bicaru20 <bicaru2@gmail.com>

test: test invalid or missing timestamp throws importdescriptors

Also adds global_error to test_importdesc to make it able to test per-item errors or global RPC errors

ci, iwyu: Enforce warning-free `src/common`

Fix all IWYU warnings in `src/common` and treat them as errors in CI.

Additionally, ensure that our drop-in header replacements are used
instead of system headers:
- `<util/check.h>` instead of `<cassert>`
- `<util/time.h>` instead of `<chrono>`

wallet: Remove meaningless bool fallback in FundTransaction

The fallback was added in commit
af4fe7fd126eff2dd1942276ea91c8ab9dd717c6, more than a decade ago.

However, it is irrelevant, given that watch-only wallet is not a concept
anymore after commit 1337c72198a7d32935431d64e9e58c12f9003abc.

So remove the code.

Can be reviewed with the --ignore-all-space option.

guix: consolidate config flags

gui: Menu action for exporting a watchonly wallet

add release notes

gui: Adds option to not load the wallet after migration

fuzz: populate wallet TXO index in wallet_create_transaction

The setup loop inserts transactions through raw mapWallet.emplace(),
which does not populate m_txos. Since AvailableCoins and
FetchSelectedInputs now look up coins through m_txos, coin
selection is structurally unreachable.

Call RefreshTXOsFromTx after each insertion so the wallet's
TXO index reflects the inserted outputs.

ipc, refactor: Update mp::g_thread_context references

Use new CurrentThread function to be compatible with windows mingw bug
workaround https://github.com/bitcoin-core/libmultiprocess/pull/318

qt, test: Enable tests on macOS with `minimal` QPA plugin

The crash source, implicit `NSApplication` instantiation with a
non-Cocoa QPA plugin, was fixed in the previous commit.

test: wallet: BnB incomplete result on attempt-limit success

BnB can return a valid selection before exhausting
the search tree, then hit TOTAL_TRIES while continuing
to look for a better one. Add a unit test for that path
using a known exhaustion fixture plus an exact-match
coin, and assert the result is marked incomplete via
GetAlgoCompleted() == false.

Co-authored-by: Murch <murch@murch.one>

bitcoin-util: replace netmagic command with getchainparams command

Co-Authored-By: ekzyis <ramdip.singhgill@gmail.com>

wallet: Show alternate wtxids in gettransaction

If a wallet tranasction has alterate witness versions, list those wtxids
in gettransaction's output.

test: Test for wallet txs with alternate wtxids

wallet: Replace CWalletTx::SetTx with Update

Instead of replacing the tx when a witness alternative appears, add it
to the set of wtxid alternates.

In order to determine whether the added transaction is the canonical
transaction, Update also needs to know how the state is changing, so it
will also update the state if it is being changed.

wallet: Store all witness variants of a transaction

A transaction can have several valid witnesses that share its txid but
differ in wtxid, e.g. when a taproot output is spent via the key path
in one variant and the script path in another.

CWalletTx now keeps all of them in a map indexed by wtxid (m_txs) and
marks one as canonical (m_canonical_wtxid): a confirmed variant if there
is one, otherwise the one with a witness and the lowest weight. GetTx()
and serialization return the canonical variant, so existing callers
don't need to change.

The other variants are stored in their own wtxvariant records keyed by
(txid, wtxid) and merged back into the CWalletTx at load. The tx record
keeps its old format, holding the canonical transaction, so older soft
versions can still read and rewrite it without dropping those records.

wallet: Remove unused CWalletTx CopyFrom and copy constructor

wallet: Make CWalletTx::tx private and use CWalletTx::GetTx to access

When CWalletTx will have multiple transactions, tx will no longer exist
and accessing the single canonical tx should be done through an getter
function.

wallet: Deserialize directly in CWalletTx's ctor

When loading a transaction, instead of constructing a CWalletTx with no
transaction, pass the DataStream into the constructor so that the
CWalletTx is RAII. This allows us to ensure that the transaction is
never a nullptr so that dereferences, especially once multiple txs are
stored, will not cause a segfault.

fuzz: Remove unused `DeserializeFromFuzzingInput` params overload

This overload has been unused since it was added in fac81affb527132945773a5315bd27fec61ec52f.

ipc, refactor: Change Protocol class field order

This just changes Protocol class field order to make sure class members are not
destroyed before the event loop thread exits. There is no change in behavior.
The change is just being made to clarify intent and avoid potential bugs.

ipc, refactor: Add SocketId type alias and use it

Use SocketId type instead of int to represent socket ids to be
compatible with an upcoming version of libmultiprocess which adds
windows support.

ipc, refactor: Add Stream type alias and use it

Use Stream type to abstract socket ids and be compatible with updated
mp::ConnectStream() and mp::ServeStream() functions that use streams
instead of socket ids in an upcoming version of libmultiprocess which
adds windows support.

Since creating Stream objects from socket ids can require the event loop
to be running, the ipc::Protocol::serve() method is also updated to
accept the server stream though a callback parameter instead of a normal
parameter.