BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 35 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`by Hennadii Stepanov · 0afaa731 · Nov 21, 2026 · 16 filesMessage 81 · StrongInformational 15Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

e8b442c76108bbe5e4496275c06054a7f6be4808 build: enable -Wdocumentation-pedantic (fanquake)
038388724f453358197ecd4075d5cabefa09660f doc: spell out escape sequences in doxygen comments (fanquake)
f3ce77ca5bdbaebd75a96523e7d517a837cb776a doc: use @param and @return in subprocess.h (fanquake)
0e9ac2cb225dcfbfe1bb08101878fab3f1e9d7b5 doc: use doxygen comments for blocks containing @param (fanquake)
68e8429bc430a3ace57a17070678f9868eeca689 doc: fix incorrect @param annotations (fanquake)

Pull request description:

Prompted by https://github.com/bitcoin/bitcoin/pull/36594#discussion_r4415881033.

ACKs for top commit:
hebasto:
ACK e8b442c76108bbe5e4496275c06054a7f6be4808.

Tree-SHA512: 18e8328f979ecc7fc94e4c4fa881cb2c1c512bf6ce953547f11b4d91a163023911eace772c84cacb7090e5ce65e70adbbdaa934610c1ffc9567673f575d9b243

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

AI review queuedMerge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbfby Ava Chow · 004cfb21 · Nov 20, 2026 · 6 filesMessage 100 · StrongLow 41Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

596dd6fd88efe92133a34a0ba8d00f5f369a4bfd Test: bumpfee does not backdate the locktime (Biel)
b1ddb7d6857668c82efefebe94f6ba224f71ab4a Wallet: Do not allow bumpfee to backdate the replacement transaction locktime (Biel)

Pull request description:

Closes https://github.com/bitcoin/bitcoin/issues/26526

Currently, in Bitcoin Core, given an original transaction A and its replacement B, we refer to **backdating** when the locktime of A is higher than the locktime of B (`A.locktime > B.locktime`). This can happen because Bitcoin Core enables **anti-fee-sniping** by default, which sets the transaction's locktime to the current block height. For privacy, 10% of the time, it instead sets a different locktime, randomly chosen between the current height and the current height minus 100 blocks. This can lead into having a replacement of a transaction with a locktime older than its original transaction. This is unrealistics and can be used as a wallet fingerprint.

You can find a functional test to reproduce the behaviour mentioned [here](https://gist.github.com/Bicaru20/9afcb878dd103369255cd81cffac86ba)

The approach proposed in this PR adds a new parameter to `CoinControl` to keep track of the previous locktime in the case of a `bumpfee`. We then pass this parameter to the DiscourageFeeSniping function through a new parameter, `minimum_height`, whose default value is set to 0.

<details>
<summary>Alternative approach:</summary>
Since the locktime of the new transaction is 0, we also considered setting it to the previous locktime value and then, inside `DiscourageFeeSniping`, saving the previous locktime and setting the transaction's locktime to the block height before applying any of the backdating logic. This way, we could avoid passing a new parameter to the function. We ultimately decided not to go with this approach, as it makes the code more difficult to follow.
</details>

The only RPC that is affected by this changes is `bumpfee`.

The pr also includes a functional test in `wallet_bumpfee.py` to test that when replacing a transation using `bumpfee` the locktime is not backdated.

<details>
<summary>We also conducted a small analysis to see how many the backdating in RBF transactions actually happen.</summary>
We have data on the replaced transactions from 2025-05-01 to 2026-06-01. With that we have been able to detect this many backdatings:
<img width="1782" height="891" alt="image" src="https://github.com/user-attachments/assets/1d2a83d5-aa61-4850-82e5-cb434b9ee958" />

_We took the date of the last transaction of the
replacement chain (A replacement chain are all the transactions that replace themselves)_

In total we have over 1,000,000 rbf transactions, but we see that on average there are only about 200-300 hundred replaccements backdating per week. Looking at the percentages we see that on average is less than 2% of all the transactions that have been replaced.

So, it is clear that backdating in replacement transactions is unusual. However, the few transactions that do exhibit backdating are easily fingerprintable as having been replaced using `bumpfee` in Bitcoin Core or Electrum.

</details>

ACKs for top commit:
achow101:
ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd
polespinasa:
ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd
nervana21:
ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd

Tree-SHA512: ce4c6a6d9e84c7f1412f6a3452909109ffc790465c5fd8f799433a70d4b59187b4160defb8e9e1891686457824575c499f36073f3d7a4ba048527735c515e675

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 41/100

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. This unusual pattern could be spotted by anyone observing the blockchain and used as a fingerprint to identify transactions created by Bitcoin Core (or Electrum). The fix ensures the replacement's locktime is never older than the original's, removing that tell.

AI review queuedMerge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugsby Ava Chow · 6090f0af · Nov 20, 2026 · 2 filesMessage 100 · StrongLow 49Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

5a699cc2539856027d2a788b9604989d553b4d30 torcontrol: send -torpassword hex-encoded to avoid escaping bugs (jpk68)

Pull request description:

The Tor password was sent as a `QuotedString` with only double quotes escaped; as Tor interprets backslash escapes inside it, any password containing a backslash was mangled (or left the string unterminated).

The Tor Control spec deliberately allows the token to be sent as unquoted hex "to avoid escaping issues", as the `SAFECOOKIE` response already is. This patch does the same for the password, and also adds a functional test covering backslashes and quotes.

ACKs for top commit:
achow101:
ACK 5a699cc2539856027d2a788b9604989d553b4d30
winterrdog:
re-ACK 5a699cc2539856027d2a788b9604989d553b4d30
sedited:
Tested ACK 5a699cc2539856027d2a788b9604989d553b4d30
fjahr:
ACK 5a699cc2539856027d2a788b9604989d553b4d30

Tree-SHA512: 2d29cc1539ece443056e5b6eb9a75768169739c0cf3ca4cb93d78fbcee598a99979ccbc0cc6b1d7db267b91f5c64c508e2ed14c3fbd71a1ad42d0a25a5d64da3

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 49/100

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret it, which could corrupt the password, fail authentication, or in theory allow command-injection-style tricks in the Tor control protocol. The fix sends the password as plain hexadecimal characters instead, which avoids escaping entirely. A new test verifies that passwords containing backslashes and quotes now work correctly.

AI review queuedMerge bitcoin/bitcoin#36087: util: Add and use AssertUnreachableby Ryan Ofsky · 3ee664ea · Nov 20, 2026 · 84 filesMessage 100 · StrongInformational 21Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

fa9a4ddbaf16d7fc8f8c336600674b3c7facca16 test: Add assert_falsy linter, And use AssertUnreachable (MarcoFalke)
fa20a5c7059c0d1cfd84a24e101d399f57771092 scripted-diff: Replace falsy assertions with AssertUnreachable (MarcoFalke)
fa6b4604e8c0cb48a13f8daa1ac61630114f35c2 test: Remove unused includes in util_tests.cpp (MarcoFalke)
fa1574cdaaeb8b0fad2eeb394a594a3534ee650c refactor: Use AssertUnreachable() and remove dead code (MarcoFalke)
fa81e4700a9495b7216580da151f36674b5affde util: Add AssertUnreachable (MarcoFalke)
fa1c93477e6ac332219af3eb4c6a5fcc9434105d refactor: Replace unreachable run-time assert with compile time assert (MarcoFalke)

Pull request description:

The current code uses assertions with falsy literal values in a few places. This is perfectly fine, but this comes with a bit of confusion sometimes:

* `assert(false)` may cause confusion when it is unclear if `NDEBUG` can disable it. (The intention is to disallow `NDEBUG` compilation). Also, it can lead to warnings when used with clang-cl.exe (GCC seems to understand it)
* `Assert(false)` hides the noreturn attribute behind a function call, which may cause GCC return-type warnings. (Clang seems to understand it)

See https://godbolt.org/z/h7PT3jh3Y for the clang-cl/GCC warning reproducer.

* When C++23 will be allowed, devs may prefer `std::unreachable`. However, this is unsafe and will invoke UB.
* There is confusion why a `CHECK_NONFATAL` macro exists, but no fatal equivalent.

Fix all those issues by:

* Adding a new `AssertUnreachable`, which directly calls the noreturn `internal_abort_helper` helper.
* Adding an `assert_falsy` linter to enforce code to use this macro.

ACKs for top commit:
jeanpablojp:
tACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16
l0rinc:
ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16
hodlinator:
re-ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16
ryanofsky:
Code review ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16. Nice cleanup making code more consistent, and I like the clever approach to updating includes in the scripted-diff

Tree-SHA512: c9c1fda9458d0fea0d9828dd48a1d58cf2000fc79d4141e004d8b15fc0ceab3835fdd7cb1ac422858739dc8cc974e40e7e2aa085d21d39a34ccbf7c91042a2dd

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathparser or protocol pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 21/100

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and avoid compiler warnings, not to fix a security bug that an attacker could exploit. The change does not alter what the program does when it reaches one of these unreachable points: it still aborts immediately.

AI review queuedMerge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional testsby merge-script · c138ff92 · Nov 20, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

b9b33544aaf17d47d27f7393d3e21d6ff8f93485 test: remove no-op -keypool=0 from wallet_hd (w0xlt)
1ac0e9cd5b02db659774ff70a055ced0572b5420 test: update wallet_backup docstring (w0xlt)
363355a72dc159783a7113f721ff1c718de0c8f6 test: remove dead multisig code from wallet_address_types (w0xlt)

Pull request description:

This PR cleans up three tests that still carry code or text from the legacy wallet:

- `wallet_address_types.py`: the send loop iterates over `do_multisigs = [False]`, so its multisig code path and the multisig cases of `test_address`/`test_desc` can't run. That code path is also broken, since it never sets the address it checks. This PR removes that code, along with the docstring section about the old `addmultisigaddress` tests.

- `wallet_backup.py`: the docstring still describes `dumpwallet`/`importwallet` and erasing wallets; the test uses `backupwallet` and `restorewallet`.

- `wallet_hd.py`: `-keypool=0` does nothing for descriptor wallets, which always keep at least one key, and the test config already sets `keypool=1`.

No coverage changes: `wallet_address_types.py` runs the same 8 send iterations before and after.

ACKs for top commit:
adezo24h1:
tACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485
fjahr:
Code review ACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485

Tree-SHA512: 8a9fd595ee8fa4f49c1fbf5dd336e20e3826e9e6f95ed798836a57ef954270a1acb4d72f8e1acd9babea41ea60e0070983432fc7ddfb6070a511bec6929178b8

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual Bitcoin Core wallet or network code that users run, so there is no security impact.

AI review queuedMerge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter testsby merge-script · 079437cc · Nov 19, 2026 · 2 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

1eeeee497e04ce3ef5ca2da5f2a6985913b61068 test: Drop hard-coded magic 3 (MarcoFalke)
fa06fd5a69a15dc4b3c557b52c5a7f7ea61275f2 test: Use generateblock with submit=False to create header (MarcoFalke)

Pull request description:

* Use generateblock with submit=False to create header, and avoid manual disconnect+reconnect
* Drop hard-coded magic `3`

ACKs for top commit:
ViniciusCestarii:
ACK 1eeeee497e04ce3ef5ca2da5f2a6985913b61068

Tree-SHA512: 21b4ac4e079f27ebe7407fd2e176619050e5ee18cb699f84722eab7e9173cc20ceb222cdcb3320fc9b3598580ae540b5d1af3919c44f1e7772667099240a8641

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor of using the actual number of test nodes. There are no changes to the live Bitcoin software that users run, and nothing that affects real funds, transactions, or network security.

AI review queuedtest: Drop hard-coded magic 3by MarcoFalke · 1eeeee49 · Nov 19, 2026 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · MarcoFalke

test: Drop hard-coded magic 3

Now that there are 3 nodes, use self.nodes directly.

82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and has no security relevance.

AI review queuedMerge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfoby merge-script · 66531447 · Nov 19, 2026 · 4 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

5b2f979c9e474a641b90902c3a87dee93c8f2899 doc: add release note for getaddressinfo iswatchonly deprecation (w0xlt)
375dc869d8bd444f7485ab0c030d793063d91a06 rpc: deprecate iswatchonly field of getaddressinfo (w0xlt)

Pull request description:

Since #32618, `getaddressinfo` returns `iswatchonly: false` for every address. It was kept and marked "(DEPRECATED)" so it could be removed later without surprising users ([review comment](https://github.com/bitcoin/bitcoin/pull/32618#discussion_r2180720302)), but it was never put behind `-deprecatedrpc`. The v30 release notes also say it was already removed from all RPCs, which isn't true for `getaddressinfo`.

This returns it only with `-deprecatedrpc=iswatchonly`, like `startingheight` in `getpeerinfo` (#34197), so it can be removed in the next release.

ACKs for top commit:
maflcko:
lgtm ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899
jonatack:
ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899
seduless:
Tested ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899

Tree-SHA512: ce9d7b6fa8229fdd11e11047cf8c147e7f8d2a6586eb4aa6f4283da99ada9753f798ac6d07048947b394a5bc57c0e9a1c832475407a865b168e2f2920e7e9f85

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or funds are protected.

AI review queuedMerge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet testsby merge-script · 0fb50460 · Nov 19, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3 test: remove duplicate restart from wallet_sendall (w0xlt)
0ba20992e8120ce33aa1fc513b167bd06a87bfce test: use one node in signrawtransactionwithwallet and derivehdkey (w0xlt)
4f0d4e11c1e999634ae5c34281ce3af402bfa879 test: remove unused node from wallet_basic (w0xlt)

Pull request description:

Some wallet functional tests start or restart nodes they never use:

- `wallet_basic.py`: node 3 hasn't been used since the `resendwallettransactions` check was removed in 2019 (f5162458cd), but the test still starts, stops and restarts it. Without it, the sync calls no longer need `self.nodes[0:3]`.

- `wallet_signrawtransactionwithwallet.py` and `wallet_derivehdkey.py` each start a second node that is never used.

- `wallet_sendall.py` restarts node 0 and reloads its wallets twice in a row with the same arguments.

No coverage changes. Each test runs a bit faster, about 0.2–0.4 s per test locally.

ACKs for top commit:
adezo24h1:
tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
ViniciusCestarii:
tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
brunoerg:
code review ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
murchandamus:
ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
maflcko:
review ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3 🍙

Tree-SHA512: 47468cdc156e689b60b06c3c27137c6f3a86f1209b5dace7c3f3f24f22c322d0d8ac5662beef57122632caf485f06fecd65acd5cea14fd1cc51635614c915d7c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network security.

AI review queuedMerge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimplsby Ryan Ofsky · 8130b3b8 · Nov 16, 2026 · 30 filesMessage 91 · StrongInformational 19Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

fa9158641839e6dbc3cab63b07929998247b1f97 refactor: Return NotNull from CreateNewBlock (MarcoFalke)
fa071a2c451d2cab12e181711b2dd64d61f3ea18 refactor: Mark pimpls as NotNull (MarcoFalke)
fa4785828e804f44726102070fb1adeacbdce6e5 util: refactor: Add and use MakeNotNullShared and MakeNotNullUnique (MarcoFalke)
faf85b0321797a811260a90f6b9a839a9ad9e3c2 test: Add some NotNull test cases (MarcoFalke)

Pull request description:

Current code uses nullable smart pointers for some stuff that is never null. This is perfectly fine, but a bit confusing:

* When reading the code, it is not clear which pointer is nullable or never null.
* Pointers that are never null still have confusing null checks (with possible error handling return branches), which are always dead in coverage reports or when applying mutation testing.
* While some places have the redundant null checks on pointers that are never null, other places do not, which adds to the confusion.

Clarify this at compile-time by using `NotNull` (or a plain reference)

ACKs for top commit:
l0rinc:
reACK fa9158641839e6dbc3cab63b07929998247b1f97
ViniciusCestarii:
reACK fa9158641839e6dbc3cab63b07929998247b1f97
enochaz:
ACK fa9158641839
ryanofsky:
Code review ACK fa9158641839e6dbc3cab63b07929998247b1f97. Nice cleanup: makes it obvious that `CreateNewBlock` can't fail and that these pimpls are always set, and removes the dead error paths that went with them.

Tree-SHA512: 7bcf67bf9f41d146e6f5db0782fb42e5ce93970ea914004f9f30d47d64f2e182a93a064c16bf1d56cc6962fdb95409bbe03eea015f6738710fdbbee8212c212f

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: unusually broad change
AI analysis · Informational 19/100

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null pointers. There is no security vulnerability being fixed here, and no behavior change to the running program.

AI review queuedMerge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.pyby merge-script · e1a27bbb · Nov 16, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

75a23e7d36afbbcfedef11bca94967b88bf40de0 test: drop flaky "server too slow" check from interface_http.py (Matthew Zipkin)

Pull request description:

Closes https://github.com/bitcoin/bitcoin/issues/36755

To cover `-rpcservertimeout` behavior our test expected the Bitcoin Core HTTP server to disconnect the test framework client after the configured duration but also *before* a somewhat arbitrary upper bound. This was helpful during development of #35182 but has led to false negatives in CI on platforms that are just plain slow.

Solve the flakiness by simply deleting the test case. Note that a regression is still caught by both the functional test and unit test suite. #36159 added a mock clock in the unit test to assert the disconnect timing. A server with no timeout would also fail the functional test which will time out during `sock.recv()` waiting for the EOF.

Both regression test failures can be observed on top of this branch by disabling rpcservertimeout:

```diff
diff --git a/src/httpserver.cpp b/src/httpserver.cpp
index 069eace507..7a090c4ca8 100644
--- a/src/httpserver.cpp
+++ b/src/httpserver.cpp
@@ -1205,7 +1205,7 @@ bool HTTPRemoteClient::ShouldDisconnect(MockableSteadyClock::time_point now, std
"HTTP client idle timeout %s (id=%llu)",
m_origin,
m_id);
- return true;
+ return false;
// Disconnect this client because the server is shutting down and we need to
// disconnect all clients... Unless the client is still being handled by a
// worker thread, in which case we'd rather continue the I/O loop (but might

```

ACKs for top commit:
maflcko:
lgtm ACK 75a23e7d36afbbcfedef11bca94967b88bf40de0
Pranav-error:
tACK 75a23e7d36afbbcfedef11bca94967b88bf40de0. Ran `interface_http.py` with the PR and it passes. With the mutant from the description, it fails with a `TimeoutError` after about 71 seconds in `recv_raw`.

Tree-SHA512: 61ad6efcc0a8dc6141f8bdd28b1a8f62d9f89b162796c4bffe605867f0b67617b764a0ff071318bbc81631fc407ea1c8e7608d533627758bf7c752df10c9a5bb

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet code, so it does not introduce or fix a security issue in the software users run.

AI review queuedMerge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecationby merge-script · 8b0b5775 · Nov 12, 2026 · 4 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

fad45cacbcac4831082d4fcf596c255fd9c5a55d rpc: wallet: Schedule mixed-case confTarget option deprecation (MarcoFalke)

Pull request description:

Since commit 91f6d2bc8ff4d4cd1b86daa370ec9d2d9662394d in 2020, the wallet accepts and documents `conf_target` for the fee bump RPC.

So it seems time to cut the confusion and properly deprecate it with the next cycle.

ACKs for top commit:
seduless:
Tested ACK fad45cacbcac4831082d4fcf596c255fd9c5a55d
willcl-ark:
ACK fad45cacbcac4831082d4fcf596c255fd9c5a55d

Tree-SHA512: e3786e103529aba807ecec208d6153e4b5fb9dbd558aa50b21ff858bdc83a63b1bf777d5769cbb1b94c1a980c56ea1f0bb72bcfb473771bc7b42f1fd39a0884c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the user explicitly turns the old name back on with a special startup flag. The change is documented in release notes and tested.

AI review queuedMerge bitcoin/bitcoin#36817: ipc: remove pre-v14 libmultiprocess compat definitionsby merge-script · 9320233a · Nov 10, 2026 · 5 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36817: ipc: remove pre-v14 libmultiprocess compat definitions

ba9c60a61da5dceb5d5e7cd0a45b6ff3e85c94b1 ipc: remove pre-v14 libmultiprocess compat definitions (fanquake)

Pull request description:

ACKs for top commit:
ryanofsky:
Code review ACK ba9c60a61da5dceb5d5e7cd0a45b6ff3e85c94b1. Just adds requested documentation update since last review. Thanks!

Tree-SHA512: 879d0031612d758e29fe2d963a48486c6b05e6f080c927748ec7b288d0fa29828f325e8ad7fd22ab3a157c16628bf33f4928db4176ee74e3597193bb01fbc6a2

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes old compatibility code that was only needed for an earlier version of a supporting library called libmultiprocess. It is a routine cleanup: the project now requires libmultiprocess v14.0 or newer, so the fallback definitions for older versions are no longer needed. There is no security fix or vulnerability patch here.

AI review queuedMerge bitcoin/bitcoin#36785: rpc: wallet: Add snake_case aliases for listunspent optionsby merge-script · 4677f884 · Nov 10, 2026 · 5 filesMessage 81 · StrongInformational 16Details
Commit message · merge-script

Merge bitcoin/bitcoin#36785: rpc: wallet: Add snake_case aliases for listunspent options

facf53acf43cb392d3af72ef837a4b825ed31406 refactor: Re-use a single GetOptionWithAlias (MarcoFalke)
fab4cb51b453817b23289ec7f33c40a6cd30e3d4 rpc: wallet: Add snake_case aliases for listunspent options (MarcoFalke)

Pull request description:

This concludes the snake_case aliases for all wallet option objects or named args.

Deprecation can be done in the future, in a few releases.

ACKs for top commit:
Zippo76:
tACK facf53acf4
willcl-ark:
ACK facf53acf43cb392d3af72ef837a4b825ed31406

Tree-SHA512: 139d85c29ce1fbb68e4d3dbc3d99de3f4dddb78588f937f6ff98878407c2c00b119722ad9fbdf4aa1af8d41c8041150b7dd9c04ad85f9c8eef27d047547c20dd

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 16/100

This change adds snake_case aliases (like minimum_amount) for existing camelCase options (like minimumAmount) in the listunspent RPC command. It also refactors some helper code so other wallet RPCs can reuse the same alias-handling logic. There is no security vulnerability here; it is a backward-compatible usability and consistency improvement.

AI review queuedMerge bitcoin/bitcoin#36805: Enclose all header content in include guardsby merge-script · 36be848e · Nov 10, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36805: Enclose all header content in include guards

ca14da90250fb5211983021a754473cde194d59e lint: Require all code in a header to be inside its include guard (Hennadii Stepanov)
00e1f35524ac52e3936db1f1d9ba44fda4911544 Enclose all header content in include guards (Hennadii Stepanov)

Pull request description:

From https://gcc.gnu.org/onlinedocs/cpp/Once-Only-Headers.html:
> If a header file happens to be included twice, the compiler will process its contents twice. This is very likely to cause an error, e.g. when the compiler sees the same structure definition twice. Even if it does not, it will certainly waste time.

This PR fixes the three headers that have content outside their guards and modifies [`test/lint/lint-include-guards.py`](https://github.com/bitcoin/bitcoin/blob/master/test/lint/lint-include-guards.py) to catch such violations in the future.

A prerequisite for https://github.com/bitcoin/bitcoin/pull/36808.

ACKs for top commit:
maflcko:
review ACK ca14da90250fb5211983021a754473cde194d59e 🖨

Tree-SHA512: 79a3e7591d4393343df9dcd39d48fe637d62b640e4dad71079fdc2bbbbcf2c01db36c3de77e82d26f90bbc0bdd2864f0e289eb45536f9df9f6e797ee7467874d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code-quality cleanup, not a security fix. It moves include guards in three header files so they wrap all content, and updates a lint script to enforce that rule going forward. Include guards prevent the compiler from accidentally processing the same header twice, which avoids build errors and wasted compile time. There is no runtime security impact.

AI review queuedMerge bitcoin/bitcoin#36810: test: construct `miner_tests` transactions declarativelyby merge-script · 0b9c2c30 · Nov 10, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36810: test: construct `miner_tests` transactions declaratively

8d33ffe47e38ebf84e2c832d426d307484a8d342 test: construct miner_tests sigops transactions declaratively (yuvicc)
b2ce6c1727e762cd63eb5353df52a529861d8af8 test: construct miner_tests package selection transactions declaratively (yuvicc)

Pull request description:

Part of #36692.

Add `MakeTx()` and use it in `TestPackageSelection` and `TestPrioritisedMining` so each transaction is fully specified where it is created, instead of overwriting the `prevout` and `nValue` of the previous one. Also build the `CreateBigSigOpsTx()` and `CreateBigSigOpsCluster()` transactions in place.

One implicit dependency is now explicit: BulkTransaction() pads the output script of hashFreeTx2, and the next two transactions inherited it. Their size matters for the fee rate checks, so the padded script is now passed to `MakeTx()` explicitly.

The txid, wtxid and fee of every transaction added to the mempool are unchanged.

ACKs for top commit:
purpleKarrot:
ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342
alexanderwiederin:
ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342
maflcko:
review ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342 🦆

Tree-SHA512: ce4a052769e3dc78e1ba2aacded671c61a226fa5e501e07e4ab2325421abae78cdc8a6e3b3731983db0cbe8cb9f8e9ba5c291bda9481ed94d4c7ce266b09d51c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit is a pure test-code cleanup. It refactors how fake transactions are built in Bitcoin Core's miner unit tests, making them more explicit and easier to read. It does not change any production code, network behavior, or transaction hashes used in the tests.

AI review queuedEnclose all header content in include guardsby Hennadii Stepanov · 00e1f355 · Nov 10, 2026 · 3 filesMessage 45 · ThinInformational 20Details
Commit message · Hennadii Stepanov

Enclose all header content in include guards

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit fixes the placement of include guards in three C++ header files. Include guards prevent the same header from being processed multiple times, which avoids compilation errors and can prevent subtle bugs from duplicate definitions. The changes are purely structural code-quality fixes with no direct security exploit path.

AI review queuedMerge bitcoin/bitcoin#36815: doc: Fix Doxygen attribution of file-level commentsby merge-script · 229e7932 · Nov 10, 2026 · 12 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36815: doc: Fix Doxygen attribution of file-level comments

c4a68cc5ceb62ac160b7adc44ebf6388aa803ed5 doc: Attach `subprocess.h` header comment to the file (Hennadii Stepanov)
4cb432772c45e791209d96d893f6f7145096b748 doc: Fix `@file` descriptions that start with the file name (Hennadii Stepanov)
c7ebbbba6c9b81e9d38ec27a79ea57be487d0b59 doc: Fix Doxygen attribution of file-level comments (Hennadii Stepanov)

Pull request description:

Doxygen attaches a comment block that lacks a `@file` command to the next declaration rather than to the file.

For example:
<img width="742" height="265" alt="image" src="https://github.com/user-attachments/assets/eb555197-eb33-41e8-abcb-3a03afa8a5ff" />

This PR fixes that.

Requested in https://github.com/bitcoin/bitcoin/pull/36805#discussion_r4511737767:
> ... they are wrong, ... it may be best to fix them instead of ignoring them?

Required for https://github.com/bitcoin/bitcoin/pull/36805.

ACKs for top commit:
fanquake:
ACK c4a68cc5ceb62ac160b7adc44ebf6388aa803ed5

Tree-SHA512: f2f1402c61c7e114b3ccd502eac90542321892bbe985b95671c3c551b8f227b9c5b07ad57364fee37b61fd7d636545264df7edb4d52acf72b166f30fcf8d568f

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes documentation comments in 12 source-code header files so that the Doxygen documentation generator correctly attributes file-level descriptions. No program logic, compiled code, or security behavior is changed. There is no security risk.

AI review queueddoc: Fix `@file` descriptions that start with the file nameby Hennadii Stepanov · 4cb43277 · Nov 9, 2026 · 7 filesMessage 73 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

doc: Fix `@file` descriptions that start with the file name

Doxygen treats the word after `@file` as the name of the documented
file and drops it from the text. Use a bare `@file` and `@brief`
instead.

Co-Authored-By: fanquake <fanquake@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a pure documentation fix. It changes how Doxygen (a tool that generates documentation from source code comments) interprets file descriptions in seven header files. There is no change to actual program code, behavior, or security.

AI review queuedMerge bitcoin/bitcoin#36744: refactor: fix mismatched and undefined declarationsby Hennadii Stepanov · c6dcda33 · Nov 7, 2026 · 7 filesMessage 81 · StrongInformational 16Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36744: refactor: fix mismatched and undefined declarations

5f972485ffd139852d5d64a38079ab500f8a4c7c http: use MockableSteadyClock::time_point in ShouldDisconnect declaration (fanquake)
bad11ff68ec276c8c1415331e4b0d67ec84766a4 qt: remove undefined BanTableModel::{start,stop}AutoRefresh (fanquake)
0ae65892445d00e9cbaebf220cc70f63140a52fb rpc: remove undefined RPCResult::ToStringObj and ToDescriptionString (fanquake)
3fa42941d16fc76e346152d690cdf96fa031d60d common: make FeeModeInfo static, remove mismatched declaration (fanquake)
410843a684d8258c57aa55d7bc2b4e53a67de9ca rpc: make AddInputs static, remove mismatched declaration (fanquake)

Pull request description:

Remove or fix function declarations that don't match any definition.

Split out of #36743. Ideally we can have the compiler enforce/flag this in future.

ACKs for top commit:
maflcko:
review ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c 🏈
sedited:
ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c
hebasto:
ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c, I have reviewed the code and it looks OK.

Tree-SHA512: aaab43a8c79834b8a55a3c40e3f6a1f07a7454dcac9e00c3a09e3d95ab26dfd93290a3f62e2f84e79ccb917b0b1bedd2f9fd04bc9c736f76430fee33174f4175

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 16/100

This is a routine code cleanup that removes or fixes function declarations which did not match any actual function definition. It does not change program behavior, fix a bug, or close a security hole. Two helper functions were made 'static' (only usable inside their own source file), two unused declarations were removed from headers, and one declaration was updated to use the exact same type as its definition. There is no security impact.

AI review queuedMerge bitcoin/bitcoin#36378: test: Add SKIP_WRITE edge case to wallet_startupby merge-script · cabee965 · Nov 6, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36378: test: Add SKIP_WRITE edge case to wallet_startup

774dd9b034b3930dd1b5eba350558acc1d9da03c test: Add SKIP_WRITE edge case to wallet_startup (Aaron Leeb)

Pull request description:

Verifies that reloading a wallet with load_on_startup=True when it is already in the startup list correctly evaluates to SKIP_WRITE and does not emit a warning under -nosettings.

This improves test coverage for the dynamic settings logic introduced in [#36176](https://github.com/bitcoin/bitcoin/pull/36176) by ensuring the C++ short-circuit logic properly evaluates the action type before checking the settings path.

This specific edge case was suggested by contributor jeanpablojp [here](https://github.com/bitcoin/bitcoin/pull/36176#discussion_r3944837660).

ACKs for top commit:
mercie-ux:
ACK 774dd9b
sedited:
ACK 774dd9b034b3930dd1b5eba350558acc1d9da03c

Tree-SHA512: 01cde53303e94dbecc9c0f69bb2c816f7faac08f4218dc81e8f37ed1b276104a7e12d212714751d60b998a3a6ca20837ef64e296932b2b7c7f23b4ab534dfd00

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new test case to Bitcoin Core's functional test suite. It checks that reloading a wallet already marked to start automatically does not trigger an unnecessary settings write or warning when settings are disabled. There is no change to production code, no bug fix, and no security-relevant behavior change.

AI review queuedMerge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19by Hennadii Stepanov · f22abab4 · Nov 6, 2026 · 10 filesMessage 81 · StrongInformational 15Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19

fa8c3c014d1eb17c69a7a286b121134a1c310e54 refactor: Remove unused include for clang-cl on Windows (MarcoFalke)
faffaeb2b66ea3573b8a37bda0154822a216c1d7 build: Drop unused clang-17 -Wno-c++23-extensions workaround (MarcoFalke)
fa31e2595569ad2c6f0f61401917ca6b42a3b45b refactor: Drop unused libc++-16 workarounds (MarcoFalke)
fa6299f87a27853a170be49b67e6e319d244928e clang-format: Use Standard: Latest (MarcoFalke)
fa909de36f3b44d3fd531a3f2f68662b0a37c718 build: Bump clang minimum supported version to 19 (MarcoFalke)

Pull request description:

Most supported operating systems ship with clang-19 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs.

(For this bump, only C++20 CTAD will become available.)

This patch will only be released in version 33.x, next year (2027).

For reference:

* https://packages.debian.org/bookworm/clang-22
* https://packages.ubuntu.com/noble/clang-20
* CentOS-like 8/9/10 ship clang-21 via Stream
* Free/Open/Net*BSD ship clang-19
* OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (clang22); leap:latest with clang-19
* macOS 14: depends/release cross-builds are unaffected and use clang-19
* macOS 14: Native builds use llvm-19-ish via XCode CLT 26.3 since https://github.com/bitcoin/bitcoin/pull/36287
* Windows: VS ships Clang 22

On operating systems where the minimum Clang version is not shipped by default, the user would have to use GCC, or install Clang in a different way. For example:

* https://packages.debian.org/bookworm/g++ (g++-12)
* https://packages.ubuntu.com/jammy/g++-12
* https://apt.llvm.org/, brew, nix, guix, or compile clang from source, ...

ACKs for top commit:
fanquake:
utACK fa8c3c014d1eb17c69a7a286b121134a1c310e54
hebasto:
re-ACK fa8c3c014d1eb17c69a7a286b121134a1c310e54, rebased and removed `-Wno-c++23-extensions` since my last [review](https://github.com/bitcoin/bitcoin/pull/36036#pullrequestreview-5777417373).

Tree-SHA512: 519f018f6b7f7f1a50e72f0f0ba53f60209ebd8a613a973cf0b91638e1bc732c1084b3a6c63cc30c4f0b8b5991d76adde24752e20cd4aead942450a1a8879c68

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit raises the minimum supported version of the Clang compiler used to build Bitcoin Core from version 17 to version 19. It also removes some old workarounds that were only needed for older compiler versions. There is no change to how Bitcoin Core processes transactions, network messages, wallets, or consensus rules. It is a routine build-system maintenance change.

AI review queuedMerge bitcoin/bitcoin#36333: wallet: Delete `removeprunedfunds` RPCby Ava Chow · fcf76ea5 · Nov 6, 2026 · 5 filesMessage 91 · StrongInformational 19Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36333: wallet: Delete `removeprunedfunds` RPC

ec7f64d02e370e04354e64fa745fca240bcb3cbe doc: release note for removeprunedfunds rpc deletion (David Gumberg)
3d8c55734e91049f50bb90637be2678bf3ab3619 wallet: rpc: Delete removeprunedfunds (David Gumberg)

Pull request description:

Deprecated in v32 (https://github.com/bitcoin/bitcoin/pull/35605), this deletes the useless and harmful `removeprunedfunds` RPC.

~~It also removes deleting of watchonly transactions from the not-watchonly migrated wallet, which in theory we should clean up, but in practice this does nothing for the user, the only observable change is that if the user knows the txid they can do `gettransaction` and the migrated wallet will return the transaction information even though it does not have keys for the transaction, AFAICT for both GUI and RPC having irrelevant transactions inside of wallet is harmless and does not affect the output of anything, since most stuff is gated behind `IsMine()` anyways.~~

~~Removing both the RPC and the deletion of watchonly tx'es allows deleting the logic for transaction removal and the associated tests.~~

Edit: This will be done in a follow-up, all this PR does is delete the `removeprunedfunds` RPC.

_LLM Disclosure: Not used to write this PR or PR description, but I recently replaced clang on my machine with gemma-4-26B directly generating machine code._

ACKs for top commit:
achow101:
ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
pablomartin4btc:
re-ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
w0xlt:
ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
polespinasa:
untested ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe

Tree-SHA512: dd9f982db05f0b74eafe0fac11e4f8b9b59ffba26a7c9d04b15dba7b6d0b070ef4115e44d9ae9c0f619b0b401c3df3a0f9181ed49e080f300406513267faee81

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit removes an old Bitcoin Core wallet RPC command called removeprunedfunds that was already marked deprecated in the previous release. The change is a planned cleanup, not a security fix. It deletes the command's code, its registration, release notes, and related tests. There is no indication in the commit that this fixes a vulnerability or that the removal itself creates a security issue.

AI review queuedMerge bitcoin/bitcoin#36775: test: wallet: BnB marks exhaustive search completeby merge-script · 80d1da3c · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36775: test: wallet: BnB marks exhaustive search complete

ac2c946d3b211e90abb48357b0cb2afadbc64a38 test: BnB marks exhaustive search complete (conradgabe)

Pull request description:

`SelectCoinsBnB` marks its result as completed when it exhausts the search space before reaching `TOTAL_TRIES`. Only the incomplete case is checked in the unit tests (`bnb_exhaustion_with_solution_test`), and the `bnb_finds_min_waste` fuzz target only reads the flag to decide whether to assert optimality, so reporting false goes unnoticed.

This PR checks `GetAlgoCompleted()` in `TestBnBSuccess` for cases that finish below the attempt limit (100,000).

Kills the following mutant (https://mutanthub.space/mutants/1096):
```diff
--- a/src/wallet/coinselection.cpp
+++ b/src/wallet/coinselection.cpp
@@ -233,7 +233,7 @@ util::Result<SelectionResult> SelectCoinsBnB(std::vector<OutputGroup>& utxo_pool
if (curr_selection.empty()) {
// Exhausted search space before running into attempt limit
is_done = true;
- result.SetAlgoCompleted(true);
+ result.SetAlgoCompleted(false);
break;
}
// Set `next_utxo` to one after last selected, then deselect last selected UTXO
```

ACKs for top commit:
yancyribbens:
ACK ac2c946d3b211e90abb48357b0cb2afadbc64a38
davidgumberg:
crACK https://github.com/bitcoin/bitcoin/commit/ac2c946d3b211e90abb48357b0cb2afadbc64a38
murchandamus:
ACK ac2c946d3b211e90abb48357b0cb2afadbc64a38

Tree-SHA512: f7c00f01fba900557fe26e2b7c6651ea6217508bd1f55202122e1b64ce1efa30f36ab474d24c61b29112b4e5594c7bed8d1e4787492dcd73ae61ca7592450d0e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new check to an existing unit test. It makes sure that when Bitcoin Core's coin-selection algorithm (called Branch-and-Bound or BnB) finishes searching all possible coin combinations, it correctly reports that the search was completed. The actual production code is unchanged; only the test is strengthened. There is no security fix or vulnerability being patched.

AI review queuedMerge bitcoin/bitcoin#36777: refactor: rpc: doc: Mark longpoll counter u32by merge-script · 83e4347e · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 21Details
Commit message · merge-script

Merge bitcoin/bitcoin#36777: refactor: rpc: doc: Mark longpoll counter u32

fa8817e6087e0d112f6421de47cb2bc7504b3ca1 refactor: rpc: doc: Mark longpoll counter u32 (MarcoFalke)

Pull request description:

The counter will only ever be a valid u32 value in normal operation, so document that without changing any behavior.

In theory, the behavior could be changed to use `LocaleIndependentAtoi<uint32_t>()`, but this is left for the future.

The change is needed to be able to fuzz the `rpc` target.

To test after compiling with `-DSANITIZERS=undefined,integer,float-divide-by-zero`:

```
$ base64 /tmp/a.crash
Z2V0YmxvY2t0ZW1wbGF0ZVyzXC1sb25ncG9sbGlkXNHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
AAAAAAAAAAAAAAAgAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAABCQkJCQkJCQkJCQkJCQkJCQkJC
QkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJC
QkJCQkJCQkJCQkJCQkLR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRZ2VsA6NjA2+pYysAmfcAuMXhQwjp7WJsXA==

$ FUZZ=rpc ./bld-cmake/test/with_sanitizer_env.py ./bld-cmake/bin/fuzz /tmp/a.crash
src/rpc/mining.cpp:842:42: runtime error: implicit conversion from type 'long' of value 9223372036854775807 (64-bit, signed) to type 'unsigned int' changed the value to 4294967295 (32-bit, unsigned)
#0 0x5603ba69a874 in getblocktemplate()::$_0::operator()(RPCMethod const&, JSONRPCRequest const&) const
...
```

Or:

```
$ UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=0:report_error_type=1" ./bld-cmake/bin/bitcoind -datadir=/tmp -regtest &

$ ./bld-cmake/bin/bitcoin-cli -datadir=/tmp -regtest getblocktemplate '{"rules":["segwit"],"longpollid":"00000000000000000000000000000000000000000000000000000000000000009223372036854775807"}'

ACKs for top commit:
sedited:
ACK fa8817e6087e0d112f6421de47cb2bc7504b3ca1
darosior:
utACK fa8817e6087e0d112f6421de47cb2bc7504b3ca1

Tree-SHA512: 607c14632d900c3a99b82560c858967bfd1475f6d274c97942428ebe2f26fb47d5086de4fb142814107a7231d2443d732addb4b27b23b01ab21202b4bf47848b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationfuzzing or regression evidencemerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 21/100

This is a small code cleanup in Bitcoin Core's getblocktemplate RPC. It changes the type of an internal counter from 'unsigned int' to the explicitly-sized 'uint32_t' and documents that the long-poll counter is expected to be a 32-bit value. The patch does not change runtime behavior; it merely makes the existing implicit truncation explicit so that fuzzing and sanitizer tools don't flag it as suspicious. There is no direct security fix here, but making the code's assumptions explicit helps future testing catch real bugs.