AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Bitcoin

Merge bitcoin/bitcoin#36176: wallet: avoid a crash when creating a wallet with -nosettings

Public commit record

What the developer wrote

Authored by Ava Chow

100/100 · Strong
Merge bitcoin/bitcoin#36176: wallet: avoid a crash when creating a wallet with -nosettings

a34fc8b11a420c1ed9877a5dd73aab57aba17cd0 wallet: handle disabled startup settings (Robert Hamilton)
b7113e6f42c220792c2a9808943b714eb72c4f3e test: characterize disabled wallet settings (Robert Hamilton)

Pull request description:

I hit a crash while creating a new wallet in Bitcoin-Qt 31.1 on an Apple silicon Mac with `nosettings=1`. After looking through the crash report and code, I traced it to saving the wallet's load-on-startup setting: the settings writer throws when dynamic settings are disabled.

Wallet RPCs report errors with `-nosettings` after changing wallet state. In Qt, the same settings write causes an uncaught exception.

Return a persistence failure when dynamic settings are disabled so wallet operations finish with their existing startup-setting warning. This avoids an uncaught exception in Qt and RPC errors after the wallet state has already changed. Keep in-memory and no-op updates unchanged.

The first commit adds functional coverage for the current behavior. The second adds the fix, updates the assertions to expect success with warnings, and documents that failed settings writes keep the in-memory changes.

### Manual Reproduction

Run on the parent commit and the fixed commit, using a fresh temporary regtest data directory each time:

```sh
{ cmake -B build-wallet-review -DBUILD_GUI=ON && cmake --build build-wallet-review -j --target bitcoin-qt; } >/dev/null 2>&1
build-wallet-review/bin/bitcoin-qt -regtest -datadir="$(mktemp -d)" -nosettings -noconnect
```

Choose `File` > `Create Wallet...`, enter `repro`, leave the defaults unchanged, and click `Create`.

Before the fix, the application terminates with:

```text
libc++abi: terminating due to uncaught exception of type std::logic_error: Attempt to write settings file when dynamic settings are disabled.
```

After the fix, the wallet is created and the application displays:

```text
Wallet load on startup setting could not be updated, so wallet may not be loaded next node startup.
```

ACKs for top commit:
l0rinc:
tested ACK a34fc8b11a420c1ed9877a5dd73aab57aba17cd0
kevkevinpal:
tACK a34fc8b11a420c1ed9877a5dd73aab57aba17cd0
achow101:
ACK a34fc8b11a420c1ed9877a5dd73aab57aba17cd0
jeanpablojp:
tACK a34fc8b11a420c1ed9877a5dd73aab57aba17cd0

Tree-SHA512: 5e43028200478f89e71ebe7e0fc28c559f15e713226124899a69eb90d413d8ecaaaca02267d5a848068d70555b3e4334993f414de2debf6a22d73a51a71d1acd
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a crash in Bitcoin Core's graphical wallet (Bitcoin-Qt) when creating a wallet while the user has disabled dynamic settings with -nosettings. Previously, the program would terminate with an uncaught exception because it tried to write to settings.json even though that file was disabled. After the fix, the wallet is created successfully and only shows a warning that the startup preference could not be saved. The same issue also caused RPC commands to return errors after the wallet state had already changed. The fix makes the settings write return a failure instead of throwing, so wallet operations complete normally and warn the user.

Recommended action

Apply the patch. It is a low-severity reliability fix that prevents a local crash and RPC inconsistency when dynamic settings are disabled. No immediate security incident response is needed, but users running -nosettings should upgrade to avoid the crash.

Security signals we found

01

Denial of service via local configuration: -nosettings triggers uncaught exception in GUI

02

Uncaught std::logic_error leading to application termination

03

RPC state inconsistency: error returned after wallet state mutation

04

Settings write failure now returns false instead of throwing

05

Functional test added for disabled dynamic settings wallet behavior

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 5/25
Stealth signal 6/15
Affected reach 7/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.