Informational 21 Bitcoin Committed Sep 19, 2026 · 15:48 UTC

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

5f05d8c5 View source ↗

Public commit record

What the developer wrote

Authored by merge-script

81/100 · Strong

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

b7f740c594ba1482344a7906b799fb62c533464f rpc: Correct OpenRPC default metadata (will)

Pull request description:

`getopenrpcinfo` emits two defaults that do not satisfy their schemas.

This changes `getdeploymentinfo.blockhash` to a default hint, since its fallback describes the current chain tip, and makes `send.options.include_watching` default to boolean `false`.

ACKs for top commit:
nervana21:
ACK b7f740c594ba1482344a7906b799fb62c533464f
sedited:
ACK b7f740c594ba1482344a7906b799fb62c533464f

Tree-SHA512: fd99c3642ff39ef13116f7f18e2a93b398e347330ea24e5bfd01744528744e5c6fbff12a56213961f8703218a6100f0ea74a10fe3b1d9a221ba8b1fa307a907a

✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference

The short version

What changed, and why it matters

This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from the string "false" to the actual value false. It does not change how Bitcoin Core processes transactions, validates blocks, or handles money. The only risk is that tools reading the OpenRPC metadata could previously receive invalid schema examples; this patch makes those examples valid.

Recommended action

No urgent action required. Treat as a normal documentation/schema correctness fix. Reviewers may verify that getopenrpcinfo now validates against the OpenRPC schema and that no functional RPC behavior changed.

Security signals we found

OpenRPC schema/default mismatch correction

RPC help metadata type correction (string 'false' to boolean false)

No executable code path changes

Technical analysis

Evidence from the diff

The commit modifies RPC argument metadata in src/rpc/blockchain.cpp, src/rpc/rawtransaction.cpp, and src/wallet/rpc/spend.cpp. It replaces RPCArg::Default{…} with RPCArg::DefaultHint{…} for arguments whose default is context-dependent or descriptive (e.g., ‘hash of current chain tip’, ‘DEFAULT for Taproot, ALL otherwise’). It also changes send.options.include_watching from RPCArg::Default{“false”} (a string) to RPCArg::Default{false} (a boolean). These changes affect the OpenRPC document emitted by getopenrpcinfo so that declared defaults satisfy their declared schemas. No consensus, networking, wallet spending, or validation logic is altered.

Changed components

RPC argument metadata generationgetopenrpcinfo outputgetdeploymentinfo help metadatasignrawtransactionwithkey help metadatadescriptorprocesspsbt help metadatasignrawtransactionwithwallet help metadatasend wallet RPC help metadatawalletprocesspsbt help metadata

Inspect captured patch +6 / −6

### src/rpc/blockchain.cpp
@@ -1548,7 +1548,7 @@ RPCMethod getdeploymentinfo()
         "Returns an object containing various state info regarding deployments of consensus changes.\n"
         "Consensus changes for which the new rules are enforced from genesis are not listed in \"deployments\".",
         {
-            {"blockhash", RPCArg::Type::STR_HEX, RPCArg::Default{"hash of current chain tip"}, "The block hash at which to query deployment state"},
+            {"blockhash", RPCArg::Type::STR_HEX, RPCArg::DefaultHint{"hash of current chain tip"}, "The block hash at which to query deployment state"},
         },
         RPCResult{
             RPCResult::Type::OBJ, "", "", {

### src/rpc/rawtransaction.cpp
@@ -743,7 +743,7 @@ static RPCMethod signrawtransactionwithkey()
                                 },
                         },
                         },
-                    {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of:\n"
+                    {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of:\n"
             "       \"DEFAULT\"\n"
             "       \"ALL\"\n"
             "       \"NONE\"\n"
@@ -2095,7 +2095,7 @@ RPCMethod descriptorprocesspsbt()
                              {"range", RPCArg::Type::RANGE, RPCArg::Default{1000}, "Up to what index HD chains should be explored (either end or [begin,end])"},
                         }},
                     }},
-                    {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
+                    {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
             "       \"DEFAULT\"\n"
             "       \"ALL\"\n"
             "       \"NONE\"\n"

### src/wallet/rpc/spend.cpp
@@ -864,7 +864,7 @@ RPCMethod signrawtransactionwithwallet()
                             },
                         },
                     },
-                    {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
+                    {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
             "       \"DEFAULT\"\n"
             "       \"ALL\"\n"
             "       \"NONE\"\n"
@@ -1207,7 +1207,7 @@ RPCMethod send()
                     {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
                     {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are " + FormatAllOutputTypes() + "."},
                     {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
-                    {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{"false"}, "(DEPRECATED) No longer used"},
+                    {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
                     {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
                         {
                           {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
@@ -1597,7 +1597,7 @@ RPCMethod walletprocesspsbt()
                 {
                     {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
                     {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
-                    {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
+                    {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
             "       \"DEFAULT\"\n"
             "       \"ALL\"\n"
             "       \"NONE\"\n"

Risk score

Why this scored 21/100

Our methodology →

Potential impact 2/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 5/15

Confidence 9/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 21/100

Community notes

Related watches

Merge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)

Merge bitcoin/bitcoin#35440: wallet: check descriptor cache xpub length before decoding

Merge bitcoin/bitcoin#35813: wallet, rpc: Add listrawtransactions RPC