Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.
This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…
Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…
Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…
Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…
Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…
No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…
This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …
Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…
This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…
This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …
This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…
This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…
This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …
Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…
Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…
This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…
No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…
This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…
This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.
AI review queuedMerge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbfby Ava Chow · 004cfb21 · Nov 20, 2026 · 6 filesMessage 100 · StrongLow 41Details
596dd6fd88efe92133a34a0ba8d00f5f369a4bfd Test: bumpfee does not backdate the locktime (Biel) b1ddb7d6857668c82efefebe94f6ba224f71ab4a Wallet: Do not allow bumpfee to backdate the replacement transaction locktime (Biel)
Currently, in Bitcoin Core, given an original transaction A and its replacement B, we refer to **backdating** when the locktime of A is higher than the locktime of B (`A.locktime > B.locktime`). This can happen because Bitcoin Core enables **anti-fee-sniping** by default, which sets the transaction's locktime to the current block height. For privacy, 10% of the time, it instead sets a different locktime, randomly chosen between the current height and the current height minus 100 blocks. This can lead into having a replacement of a transaction with a locktime older than its original transaction. This is unrealistics and can be used as a wallet fingerprint.
You can find a functional test to reproduce the behaviour mentioned [here](https://gist.github.com/Bicaru20/9afcb878dd103369255cd81cffac86ba)
The approach proposed in this PR adds a new parameter to `CoinControl` to keep track of the previous locktime in the case of a `bumpfee`. We then pass this parameter to the DiscourageFeeSniping function through a new parameter, `minimum_height`, whose default value is set to 0.
<details> <summary>Alternative approach:</summary> Since the locktime of the new transaction is 0, we also considered setting it to the previous locktime value and then, inside `DiscourageFeeSniping`, saving the previous locktime and setting the transaction's locktime to the block height before applying any of the backdating logic. This way, we could avoid passing a new parameter to the function. We ultimately decided not to go with this approach, as it makes the code more difficult to follow. </details>
The only RPC that is affected by this changes is `bumpfee`.
The pr also includes a functional test in `wallet_bumpfee.py` to test that when replacing a transation using `bumpfee` the locktime is not backdated.
<details> <summary>We also conducted a small analysis to see how many the backdating in RBF transactions actually happen.</summary> We have data on the replaced transactions from 2025-05-01 to 2026-06-01. With that we have been able to detect this many backdatings: <img width="1782" height="891" alt="image" src="https://github.com/user-attachments/assets/1d2a83d5-aa61-4850-82e5-cb434b9ee958" />
_We took the date of the last transaction of the replacement chain (A replacement chain are all the transactions that replace themselves)_
In total we have over 1,000,000 rbf transactions, but we see that on average there are only about 200-300 hundred replaccements backdating per week. Looking at the percentages we see that on average is less than 2% of all the transactions that have been replaced.
So, it is clear that backdating in replacement transactions is unusual. However, the few transactions that do exhibit backdating are easily fingerprintable as having been replaced using `bumpfee` in Bitcoin Core or Electrum.
</details>
ACKs for top commit: achow101: ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd polespinasa: ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd nervana21: ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 41/100
This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. This unusual pattern could be spotted by anyone observing the blockchain and used as a fingerprint to identify transactions created by Bitcoin Core (or Electrum). The fix ensures the replacement's locktime is never older than the original's, removing that tell.
`CreateTransaction` checks that recipient amounts aren't negative, but not that they're within `MAX_MONEY`. `CreateTransactionInternal` then sums them into `recipients_sum` (spend.cpp:1100) with no range check, and that sum can overflow.
Easiest way to hit it is `fundrawtransaction` with a raw tx that has two outputs of 2^62 sat. It can also be reached with only valid amounts through `walletcreatefundedpsbt`/`send`/`sendmany` and a few thousand 21M BTC outputs. The "Transaction too large" check only runs after coin selection, so it doesn't stop this. On master the node aborts:
``` Assertion failed: (!m_selected_inputs.empty()), function RecalculateWaste, file coinselection.cpp, line 904. ```
UBSan reports the overflow at spend.cpp:1100 first. With other values the sum wraps to a small positive number instead, and `fundrawtransaction` returns success for a tx with outputs of 46116860184 BTC each.
This checks every amount and the running sum against `MoneyRange` in the existing recipients loop of `CreateTransactionInternal`, before the amount is added to `recipients_sum`, and returns "Transaction output amount must be valid" before coin selection starts. The same check rejects negative amounts, so the separate negative check in `CreateTransaction` is removed. The new `test_outputs_above_max_money` in `wallet_fundrawtransaction.py` covers a single output above MAX_MONEY, two outputs whose sum is above it, a sum that overflows int64, and a negative output. On master the first case returns "Insufficient funds" and the overflow case crashes the node; with the fix all of them get the new error. `wallet_fundrawtransaction.py`, `wallet_send.py`, `wallet_basic.py` and `rpc_psbt.py` pass.
ACKs for top commit: maflcko: lgtm ACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8 Zippo76: tACK bab579e56a furszy: utACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8 achow101: ACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymemory safetysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 62/100
This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to more than the maximum allowed bitcoin amount (about 21 million BTC), leading to incorrect math, a failed internal assertion, or a successful but invalid transaction. The fix now rejects such oversized or overflowing amounts early with a clear error message.
AI review queuedMerge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugsby Ava Chow · 6090f0af · Nov 20, 2026 · 2 filesMessage 100 · StrongLow 49Details
Commit message · Ava Chow
Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs
5a699cc2539856027d2a788b9604989d553b4d30 torcontrol: send -torpassword hex-encoded to avoid escaping bugs (jpk68)
Pull request description:
The Tor password was sent as a `QuotedString` with only double quotes escaped; as Tor interprets backslash escapes inside it, any password containing a backslash was mangled (or left the string unterminated).
The Tor Control spec deliberately allows the token to be sent as unquoted hex "to avoid escaping issues", as the `SAFECOOKIE` response already is. This patch does the same for the password, and also adds a functional test covering backslashes and quotes.
ACKs for top commit: achow101: ACK 5a699cc2539856027d2a788b9604989d553b4d30 winterrdog: re-ACK 5a699cc2539856027d2a788b9604989d553b4d30 sedited: Tested ACK 5a699cc2539856027d2a788b9604989d553b4d30 fjahr: ACK 5a699cc2539856027d2a788b9604989d553b4d30
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret it, which could corrupt the password, fail authentication, or in theory allow command-injection-style tricks in the Tor control protocol. The fix sends the password as plain hexadecimal characters instead, which avoids escaping entirely. A new test verifies that passwords containing backslashes and quotes now work correctly.
Security candidateMerge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.by Ava Chow · f98888ef · Nov 20, 2026 · 19 filesMessage 100 · StrongLow 30Details
Encrypting existing wallets that are unencrypted is fraught with footguns and complexity both for users and for developers.
For example:
- No efforts are made to ensure that remnants of unencrypted key material are not left on the user's disk, as attempting to ensure this would be difficult and dangerous, and for some SSD's infeasible.
- Encrypting a wallet that has manually imported descriptors will cause the wallet to change the spending conditions out from under the user. (https://github.com/bitcoin/bitcoin/issues/26607)
- Because new keys are made after encryption, restoring from a backup made before encryption may result in loss of funds.
_LLM Disclosure: Used gemma4-26B and qwen3.8-next-flash as research and drafting tools, but all code and text present here were written by me._
ACKs for top commit: achow101: ACK 820120eb466ff2242d99f4c77ae6f8fa77f4bc9c w0xlt: reACK 820120eb466ff2242d99f4c77ae6f8fa77f4bc9c
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 30/100
This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bitcoins when trying to add a password to an already-created wallet. The safer path is to create a new wallet with a password from the start. This is a defensive usability change, not a fix for a remote hack.
AI review queuedMerge bitcoin/bitcoin#36087: util: Add and use AssertUnreachableby Ryan Ofsky · 3ee664ea · Nov 20, 2026 · 84 filesMessage 100 · StrongInformational 21Details
Commit message · Ryan Ofsky
Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable
fa9a4ddbaf16d7fc8f8c336600674b3c7facca16 test: Add assert_falsy linter, And use AssertUnreachable (MarcoFalke) fa20a5c7059c0d1cfd84a24e101d399f57771092 scripted-diff: Replace falsy assertions with AssertUnreachable (MarcoFalke) fa6b4604e8c0cb48a13f8daa1ac61630114f35c2 test: Remove unused includes in util_tests.cpp (MarcoFalke) fa1574cdaaeb8b0fad2eeb394a594a3534ee650c refactor: Use AssertUnreachable() and remove dead code (MarcoFalke) fa81e4700a9495b7216580da151f36674b5affde util: Add AssertUnreachable (MarcoFalke) fa1c93477e6ac332219af3eb4c6a5fcc9434105d refactor: Replace unreachable run-time assert with compile time assert (MarcoFalke)
Pull request description:
The current code uses assertions with falsy literal values in a few places. This is perfectly fine, but this comes with a bit of confusion sometimes:
* `assert(false)` may cause confusion when it is unclear if `NDEBUG` can disable it. (The intention is to disallow `NDEBUG` compilation). Also, it can lead to warnings when used with clang-cl.exe (GCC seems to understand it) * `Assert(false)` hides the noreturn attribute behind a function call, which may cause GCC return-type warnings. (Clang seems to understand it)
See https://godbolt.org/z/h7PT3jh3Y for the clang-cl/GCC warning reproducer.
* When C++23 will be allowed, devs may prefer `std::unreachable`. However, this is unsafe and will invoke UB. * There is confusion why a `CHECK_NONFATAL` macro exists, but no fatal equivalent.
Fix all those issues by:
* Adding a new `AssertUnreachable`, which directly calls the noreturn `internal_abort_helper` helper. * Adding an `assert_falsy` linter to enforce code to use this macro.
ACKs for top commit: jeanpablojp: tACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16 l0rinc: ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16 hodlinator: re-ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16 ryanofsky: Code review ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16. Nice cleanup making code more consistent, and I like the clever approach to updating includes in the scripted-diff
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathparser or protocol pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 21/100
This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and avoid compiler warnings, not to fix a security bug that an attacker could exploit. The change does not alter what the program does when it reaches one of these unreachable points: it still aborts immediately.
Build the funding output in `MakeCoin()` from `coinselection_tests` with a `CTxOut` constructor instead of `vout.resize(1)` followed by assigning `nValue`. Test-only change, the constructed txns are unchanged and the empty `scriptPubKey` that `resize()` left implicit is now explicit.
ACKs for top commit: maflcko: review ACK 77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f 🍰 alexanderwiederin: ACK 77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and the transactions being simulated are unchanged. There is no security issue.
Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master
b3dcf1931b922c916b1fedb8b985063f8037962e Squashed 'src/secp256k1/' changes from a7f264373e..659f03b076 (Hennadii Stepanov)
Pull request description:
This PR updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/a0e2e23a71bf2aaae910f81cb2bd8aa0ae49d544, which includes the following changes:
The update is prompted by: 1. New warnings introduced in Clang 24. bitcoin-core/secp256k1#1998 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36869. 2. New warnings in CMake >=4.5. bitcoin-core/secp256k1#1996 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36889.
Fixes https://github.com/bitcoin/bitcoin/issues/36913 and unlocks the CI.
ACKs for top commit: fanquake: ACK 830cca99046b880dd79ff8e09ba161decb15f572
This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes make the Silent Payments module behave better when a transaction has no relevant inputs or outputs, and make ECDH/MuSig code more careful about clearing secret intermediate values from memory. There is no evidence in the commit message or diff of an active security vulnerability being patched.
AI review queuedMerge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional testsby merge-script · c138ff92 · Nov 20, 2026 · 3 filesMessage 91 · StrongInformational 15Details
b9b33544aaf17d47d27f7393d3e21d6ff8f93485 test: remove no-op -keypool=0 from wallet_hd (w0xlt) 1ac0e9cd5b02db659774ff70a055ced0572b5420 test: update wallet_backup docstring (w0xlt) 363355a72dc159783a7113f721ff1c718de0c8f6 test: remove dead multisig code from wallet_address_types (w0xlt)
Pull request description:
This PR cleans up three tests that still carry code or text from the legacy wallet:
- `wallet_address_types.py`: the send loop iterates over `do_multisigs = [False]`, so its multisig code path and the multisig cases of `test_address`/`test_desc` can't run. That code path is also broken, since it never sets the address it checks. This PR removes that code, along with the docstring section about the old `addmultisigaddress` tests.
- `wallet_backup.py`: the docstring still describes `dumpwallet`/`importwallet` and erasing wallets; the test uses `backupwallet` and `restorewallet`.
- `wallet_hd.py`: `-keypool=0` does nothing for descriptor wallets, which always keep at least one key, and the test config already sets `keypool=1`.
No coverage changes: `wallet_address_types.py` runs the same 8 send iterations before and after.
ACKs for top commit: adezo24h1: tACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485 fjahr: Code review ACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual Bitcoin Core wallet or network code that users run, so there is no security impact.
AI review queuedMerge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter testsby merge-script · 079437cc · Nov 19, 2026 · 2 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests
1eeeee497e04ce3ef5ca2da5f2a6985913b61068 test: Drop hard-coded magic 3 (MarcoFalke) fa06fd5a69a15dc4b3c557b52c5a7f7ea61275f2 test: Use generateblock with submit=False to create header (MarcoFalke)
Pull request description:
* Use generateblock with submit=False to create header, and avoid manual disconnect+reconnect * Drop hard-coded magic `3`
ACKs for top commit: ViniciusCestarii: ACK 1eeeee497e04ce3ef5ca2da5f2a6985913b61068
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor of using the actual number of test nodes. There are no changes to the live Bitcoin software that users run, and nothing that affects real funds, transactions, or network security.
AI review queuedtest: Drop hard-coded magic 3by MarcoFalke · 1eeeee49 · Nov 19, 2026 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · MarcoFalke
test: Drop hard-coded magic 3
Now that there are 3 nodes, use self.nodes directly.
82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and has no security relevance.
AI review queuedMerge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfoby merge-script · 66531447 · Nov 19, 2026 · 4 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script
Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo
5b2f979c9e474a641b90902c3a87dee93c8f2899 doc: add release note for getaddressinfo iswatchonly deprecation (w0xlt) 375dc869d8bd444f7485ab0c030d793063d91a06 rpc: deprecate iswatchonly field of getaddressinfo (w0xlt)
Pull request description:
Since #32618, `getaddressinfo` returns `iswatchonly: false` for every address. It was kept and marked "(DEPRECATED)" so it could be removed later without surprising users ([review comment](https://github.com/bitcoin/bitcoin/pull/32618#discussion_r2180720302)), but it was never put behind `-deprecatedrpc`. The v30 release notes also say it was already removed from all RPCs, which isn't true for `getaddressinfo`.
This returns it only with `-deprecatedrpc=iswatchonly`, like `startingheight` in `getpeerinfo` (#34197), so it can be removed in the next release.
ACKs for top commit: maflcko: lgtm ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899 jonatack: ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899 seduless: Tested ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100
This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or funds are protected.
AI review queuedMerge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet testsby merge-script · 0fb50460 · Nov 19, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests
afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3 test: remove duplicate restart from wallet_sendall (w0xlt) 0ba20992e8120ce33aa1fc513b167bd06a87bfce test: use one node in signrawtransactionwithwallet and derivehdkey (w0xlt) 4f0d4e11c1e999634ae5c34281ce3af402bfa879 test: remove unused node from wallet_basic (w0xlt)
Pull request description:
Some wallet functional tests start or restart nodes they never use:
- `wallet_basic.py`: node 3 hasn't been used since the `resendwallettransactions` check was removed in 2019 (f5162458cd), but the test still starts, stops and restarts it. Without it, the sync calls no longer need `self.nodes[0:3]`.
- `wallet_signrawtransactionwithwallet.py` and `wallet_derivehdkey.py` each start a second node that is never used.
- `wallet_sendall.py` restarts node 0 and reloads its wallets twice in a row with the same arguments.
No coverage changes. Each test runs a bit faster, about 0.2–0.4 s per test locally.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network security.
Security candidateMerge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNodeby merge-script · 6832a273 · Nov 18, 2026 · 3 filesMessage 81 · StrongModerate 68Details
Commit message · merge-script
Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode
d63068c58ec9fcc94876bce30865d1a7266d64d4 net_processing: set fDisconnect instead of calling DisconnectNode (Eugene Siegel)
Pull request description:
`MaybeDiscourageAndDisconnect` calls `DisconnectNode` which creates a `CSubNet` containing only the `CNode`'s address. This will disconnect every `CNode` with the same IP address. This is normally not a problem, except for clearnet-over-tor. If a node has an honest clearnet-over-tor inbound connection, the IP of the inbound peer will be the exit node's IP address. If an attacker connects to the node through the same exit node and sends an invalid message, they can cause every inbound peer sharing the exit node's IP to get disconnected. Fix this by only disconnecting the misbehaving `CNode` rather than every `CNode` sharing the IP.
ACKs for top commit: Husteem: Approach ACK / tACK d63068c maflcko: lgtm ACK d63068c58ec9fcc94876bce30865d1a7266d64d4 ajtowns: re utACK d63068c58ec9fcc94876bce30865d1a7266d64d4 darosior: utACK d63068c58ec9fcc94876bce30865d1a7266d64d4
This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set of public 'exit nodes.' An attacker could use the same Tor exit node as honest users, send an invalid message, and get every honest inbound peer using that exit node kicked off. The fix makes the node disconnect only the specific misbehaving connection while still discouraging (reducing trust in) that IP address.
Security candidatenet_processing: set fDisconnect instead of calling DisconnectNodeby Eugene Siegel · d63068c5 · Nov 16, 2026 · 3 filesMessage 73 · AdequateModerate 62Details
Commit message · Eugene Siegel
net_processing: set fDisconnect instead of calling DisconnectNode
MaybeDiscourageAndDisconnect calls DisconnectNode which creates a CSubNet containing only the CNode's address. This will disconnect every CNode with the same IP address. This is normally not a problem, except for clearnet-over-tor. If a node has an honest clearnet-over-tor inbound connection, the IP of the inbound peer will be the exit node's IP address. If an attacker connects to the node through the same exit node and sends an invalid message, they can cause every inbound peer sharing the exit node's IP to get disconnect. Fix this by only disconnecting the misbehaving CNode rather than every CNode sharing the IP.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
explicit security language
AI analysis · Moderate 62/100
This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehave and force the node to disconnect innocent users arriving through the same Tor exit. The fix makes the node disconnect only the specific misbehaving peer instead of all peers with that IP.
Security candidateMerge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includesby merge-script · 1fbb5253 · Nov 16, 2026 · 65 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes
53561d803747567fc01ca1513ecfb280a01aa5a9 lint: Update `lint_includes_build_config` function (Hennadii Stepanov) 04108a0dbb4633a861232238a53008f15906b953 scripted-diff: Drop `IWYU pragma: keep` from build config includes (Hennadii Stepanov)
Pull request description:
This PR marks the `bitcoin-build-config.h` header with the dedicated [`IWYU pragma: always_keep`](https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#iwyu-pragma-always_keep), which makes the per-include `IWYU pragma: keep` comments redundant.
As a result, grepping for `IWYU pragma: keep` returns only the genuine use cases, each of which should be properly documented.
ACKs for top commit: l0rinc: code review and diff reACK 53561d803747567fc01ca1513ecfb280a01aa5a9 vasild: ACK 53561d803747567fc01ca1513ecfb280a01aa5a9
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. There is no functional change to Bitcoin Core, no bug fix, and no security impact.
AI review queuedMerge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimplsby Ryan Ofsky · 8130b3b8 · Nov 16, 2026 · 30 filesMessage 91 · StrongInformational 19Details
Commit message · Ryan Ofsky
Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls
fa9158641839e6dbc3cab63b07929998247b1f97 refactor: Return NotNull from CreateNewBlock (MarcoFalke) fa071a2c451d2cab12e181711b2dd64d61f3ea18 refactor: Mark pimpls as NotNull (MarcoFalke) fa4785828e804f44726102070fb1adeacbdce6e5 util: refactor: Add and use MakeNotNullShared and MakeNotNullUnique (MarcoFalke) faf85b0321797a811260a90f6b9a839a9ad9e3c2 test: Add some NotNull test cases (MarcoFalke)
Pull request description:
Current code uses nullable smart pointers for some stuff that is never null. This is perfectly fine, but a bit confusing:
* When reading the code, it is not clear which pointer is nullable or never null. * Pointers that are never null still have confusing null checks (with possible error handling return branches), which are always dead in coverage reports or when applying mutation testing. * While some places have the redundant null checks on pointers that are never null, other places do not, which adds to the confusion.
Clarify this at compile-time by using `NotNull` (or a plain reference)
ACKs for top commit: l0rinc: reACK fa9158641839e6dbc3cab63b07929998247b1f97 ViniciusCestarii: reACK fa9158641839e6dbc3cab63b07929998247b1f97 enochaz: ACK fa9158641839 ryanofsky: Code review ACK fa9158641839e6dbc3cab63b07929998247b1f97. Nice cleanup: makes it obvious that `CreateNewBlock` can't fail and that these pimpls are always set, and removes the dead error paths that went with them.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null pointers. There is no security vulnerability being fixed here, and no behavior change to the running program.
AI review queuedMerge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.pyby merge-script · e1a27bbb · Nov 16, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py
75a23e7d36afbbcfedef11bca94967b88bf40de0 test: drop flaky "server too slow" check from interface_http.py (Matthew Zipkin)
To cover `-rpcservertimeout` behavior our test expected the Bitcoin Core HTTP server to disconnect the test framework client after the configured duration but also *before* a somewhat arbitrary upper bound. This was helpful during development of #35182 but has led to false negatives in CI on platforms that are just plain slow.
Solve the flakiness by simply deleting the test case. Note that a regression is still caught by both the functional test and unit test suite. #36159 added a mock clock in the unit test to assert the disconnect timing. A server with no timeout would also fail the functional test which will time out during `sock.recv()` waiting for the EOF.
Both regression test failures can be observed on top of this branch by disabling rpcservertimeout:
```diff diff --git a/src/httpserver.cpp b/src/httpserver.cpp index 069eace507..7a090c4ca8 100644 --- a/src/httpserver.cpp +++ b/src/httpserver.cpp @@ -1205,7 +1205,7 @@ bool HTTPRemoteClient::ShouldDisconnect(MockableSteadyClock::time_point now, std "HTTP client idle timeout %s (id=%llu)", m_origin, m_id); - return true; + return false; // Disconnect this client because the server is shutting down and we need to // disconnect all clients... Unless the client is still being handled by a // worker thread, in which case we'd rather continue the I/O loop (but might
```
ACKs for top commit: maflcko: lgtm ACK 75a23e7d36afbbcfedef11bca94967b88bf40de0 Pranav-error: tACK 75a23e7d36afbbcfedef11bca94967b88bf40de0. Ran `interface_http.py` with the PR and it passes. With the mutant from the description, it fails with a `TimeoutError` after about 71 seconds in `recv_raw`.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100
This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet code, so it does not introduce or fix a security issue in the software users run.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100
This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the user explicitly turns the old name back on with a special startup flag. The change is documented in release notes and tested.
Security candidateMerge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amountby merge-script · dd9d016b · Nov 12, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount
050409b2c5522eff0dc37c00a6d1225a8a437e17 test: allow 3 bytes of fee overestimate in assert_fee_amount (Ferdinando Ametrano)
Pull request description:
The wallet sizes a transaction assuming a 71-byte low-R ECDSA signature. A signature whose r or s has leading zero bytes is shorter, so the fee can cover a few bytes more than the signed transaction needs. In #36394 the wallet estimated 219 bytes and paid 438 sat at 2 sat/vB, but the signed transaction was 216 bytes: the signature was 3 bytes short. That happens about once in 4 million signatures. `assert_fee_amount` allows only 2 bytes of overestimate, so the test failed.
I raise the allowance to 3 bytes, which makes the failure about 200 times rarer. The check that the fee is not too low is unchanged. maflcko suggested 3 bytes in #24151 and #25164.
Fixes #36394.
*Made with my usual tools: a computer, the Internet and an LLM. The mistakes, as usual, are all mine.*
ACKs for top commit: Ayoazeez26: tACK 050409b2c5522eff0dc37c00a6d1225a8a437e17 ismaelsadeeq: ACK 050409b2c5522eff0dc37c00a6d1225a8a437e17 sedited: ACK 050409b2c5522eff0dc37c00a6d1225a8a437e17
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Informational 15/100
This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare random test failure occurs.
Security candidateMerge bitcoin/bitcoin#36224: test: Add test coverage for `PartiallySignedTransaction::Merge()`by merge-script · 791173ae · Nov 12, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36224: test: Add test coverage for `PartiallySignedTransaction::Merge()`
7b124184394e016d6e3c119c50ff08d1512dfab9 test: merge PSBT `m_tx_modifiable` coverage and renaming bit positions with BIP370 flags (nebula-21) 776fb263759693a5db6aa11a8a464662d5f36da4 test: merge PSBT `fallback_locktime` coverage (nebula-21) 6fc2ebd5216975de40e9ef3b1dea1de623268794 test: only merge PSBTs with same version (nebula-21)
Pull request description:
This PR adds test coverage for `PartiallySignedTransaction::Merge()` divided into 3 tests:
Only merge PSBTs with same version: The test can be triggered with this mutant as an example:
for (unsigned int i = 0; i < inputs.size(); ++i) { ```
Merge PSBT `fallback_locktime` coverage: If the psbt has no fallback locktime, it adopts the one from the psbt it is merging. The test can be triggered with this mutant as an example:
// Set m_tx_modifiable only if either PSBT had it set if (m_tx_modifiable.has_value() || psbt.m_tx_modifiable.has_value()) { ```
While writing this test I had a question: If both PSBTs have a `fallback_locktime` value, the "this" (receiving side) wins silently. Is this the expected behavior? Why not keep the max or directly fail merging if we have two conflicting fallback_locktimes? The test can be triggered with this mutant as one of the various examples:
// Set m_tx_modifiable only if either PSBT had it set - if (m_tx_modifiable.has_value() || psbt.m_tx_modifiable.has_value()) { + if (m_tx_modifiable.has_value() && psbt.m_tx_modifiable.has_value()) { // In general, we AND the modifiable flags std::bitset<8> this_modifiable = m_tx_modifiable.value_or(0); std::bitset<8> psbt_modifiable = psbt.m_tx_modifiable.value_or(0); ```
ACKs for top commit: polespinasa: ACK 7b124184394e016d6e3c119c50ff08d1512dfab9 fametrano: reACK 7b124184394e016d6e3c119c50ff08d1512dfab9 sedited: ACK 7b124184394e016d6e3c119c50ff08d1512dfab9
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit only adds new unit tests for an existing PSBT merging function and renames some hard-coded bit numbers to named constants. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly.
Security candidateMerge bitcoin/bitcoin#36068: fuzz: reuse one fuzzed wallet across inputsby merge-script · c68583ab · Nov 11, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36068: fuzz: reuse one fuzzed wallet across inputs
fd3b09e8bcb83351c30b37505501c2a9756d907e fuzz: reuse one fuzzed wallet across inputs (brunoerg) 2553b4cd9678f9d7ba78be3573eb3cd095ab3ea6 wallet: add test-only helper to clear in-memory transaction state (brunoerg)
Pull request description:
FuzzedWallet was rebuilt for every input. That imports eight descriptors, and each address it then hands out costs a BIP32 derivation plus three separate WalletBatch transactions (see DescriptorScriptPubKeyMan::GetNewDestination) - all paid before the target reaches the code under test.
This PR changes it to build the wallet once in the target's .init hook and reset it perinput instead. I benchmarked on my Ubuntu machine without sanitizers and got a ~6x speedup.
ACKs for top commit: frankomosh: reACK fd3b09e8bcb83351c30b37505501c2a9756d907e maflcko: re-ACK fd3b09e8bcb83351c30b37505501c2a9756d907e 👕
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialdefensive validationfuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit is a performance improvement for Bitcoin Core's internal fuzz testing (automated randomized testing). It reuses a single test wallet across many fuzz inputs instead of rebuilding it each time, and adds a test-only helper to clear in-memory transaction state. There is no indication this fixes a security vulnerability or affects production wallet behavior.
Merge bitcoin/bitcoin#36556: depends: fix non-atomic reads in capnp debug assertions
6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec depends: fix non-atomic reads in capnp debug assertions (xyzconstant)
Pull request description:
KJ's debug assertions read the mutex futex word and `AtomicRefcounted` refcounts non-atomically. The TSan job builds capnp without optimization, which automatically enables these assertions, and TSan reports these reads as data races the moment KJ objects start communicating across threads.
libmultiprocess enables cross-thread communication for the first time in bitcoin-core/libmultiprocess#376, which replaces the pipe used in `EventLoop::sync()` with `kj::Executor::executeSync()`. This is what triggered the [failure](https://github.com/bitcoin-core/libmultiprocess/actions/runs/38094008438/job/114336046070?pr=376).
Patches are the upstream commits capnproto/capnproto@b91a6ba7c7 and capnproto/capnproto@cc13c8c45f, which are backports of the v2 fixes in capnproto/capnproto#2781 and capnproto/capnproto#2843 (backport PR: capnproto/capnproto#2855).
ACKs for top commit: Sjors: ACK 6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec ryanofsky: Code review ACK 6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec. Thanks for tracking down the race and getting the fix merged upstream first, which makes the patches easy to check.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Low 29/100
This commit adds two upstream patches to Bitcoin Core's build of the Cap'n Proto library. The patches fix debug-only assertions that read shared memory values without using atomic operations. These non-atomic reads were flagged by ThreadSanitizer as data races once KJ objects communicate across threads. The fix only affects debug/TSan builds and does not change release behavior; it is a correctness and testing-infrastructure improvement rather than a user-facing security bug.
ACKs for top commit: ryanofsky: Code review ACK ba9c60a61da5dceb5d5e7cd0a45b6ff3e85c94b1. Just adds requested documentation update since last review. Thanks!
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit removes old compatibility code that was only needed for an earlier version of a supporting library called libmultiprocess. It is a routine cleanup: the project now requires libmultiprocess v14.0 or newer, so the fallback definitions for older versions are no longer needed. There is no security fix or vulnerability patch here.
AI review queuedMerge bitcoin/bitcoin#36785: rpc: wallet: Add snake_case aliases for listunspent optionsby merge-script · 4677f884 · Nov 10, 2026 · 5 filesMessage 81 · StrongInformational 16Details
Commit message · merge-script
Merge bitcoin/bitcoin#36785: rpc: wallet: Add snake_case aliases for listunspent options
facf53acf43cb392d3af72ef837a4b825ed31406 refactor: Re-use a single GetOptionWithAlias (MarcoFalke) fab4cb51b453817b23289ec7f33c40a6cd30e3d4 rpc: wallet: Add snake_case aliases for listunspent options (MarcoFalke)
Pull request description:
This concludes the snake_case aliases for all wallet option objects or named args.
Deprecation can be done in the future, in a few releases.
ACKs for top commit: Zippo76: tACK facf53acf4 willcl-ark: ACK facf53acf43cb392d3af72ef837a4b825ed31406
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 16/100
This change adds snake_case aliases (like minimum_amount) for existing camelCase options (like minimumAmount) in the listunspent RPC command. It also refactors some helper code so other wallet RPCs can reuse the same alias-handling logic. There is no security vulnerability here; it is a backward-compatible usability and consistency improvement.