BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 35 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge bitcoin/bitcoin#36924: test: Speed up interface_ipc_mining.py and fix large timeout-factor bugby merge-script · 19128e8b · Nov 21, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36924: test: Speed up interface_ipc_mining.py and fix large timeout-factor bug

faa89b1ae68d8548f6288521b06c064fcfc0b50f test: Speed up interface_ipc_mining.py and fix large timeout-factor bug (MarcoFalke)
fae567777fb3d6917ea3e05009b82a775bc0e7c9 test: Rename default_ipc_timeout -> default_ipc_timeout_ms (MarcoFalke)

Pull request description:

The test would fail with a large enough timeout factor, because the ipc
times out before the delayed `generate()` call: `template2` would be `None`
and fail the assert.

Also, the test would sleep more than timeout_factor seconds in the happy
case in all test runs.

Fix both issues by sleeping for a bit longer than a single fee tick.

ACKs for top commit:
nervana21:
tACK faa89b1ae68d8548f6288521b06c064fcfc0b50f
ViniciusCestarii:
tACK faa89b1ae68d8548f6288521b06c064fcfc0b50f
mercie-ux:
Tested ACK faa89b1

Tree-SHA512: 853601ae354d4f325e961ba6f66b0722b1501ae4e62ba476d6b0060d05e102a07f7bef70977e42cd3d8acdf69febc4aec25baa81938b995097d973ea4c06ec9c

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin-core/gui#947: Update RPC console wallet when the active wallet changesby Hennadii Stepanov · 442b152c · Nov 21, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin-core/gui#947: Update RPC console wallet when the active wallet changes

9ee30341032cdd414d6b74c9ebe97fb8daf1b320 gui: Update RPC console wallet when the active wallet changes (Kyle 🐆)

Pull request description:

When multiple wallets are loaded, switching the active wallet via the main window's wallet selector doesn't update the wallet used by the RPC console. Console commands keep running against the previously selected wallet, so a wallet RPC can be sent to a different wallet than the one shown as active.

The open/create/restore/migrate paths already call `RPCConsole::setCurrentWallet()`, but the main window selector was missed. Add the call to the central `setCurrentWallet()`.

To reproduce: load two wallets, switch the active wallet in the toolbar, then run a wallet command such as `getwalletinfo` in the console.

ACKs for top commit:
polespinasa:
ACK 9ee30341032cdd414d6b74c9ebe97fb8daf1b320
jpk68:
ACK 9ee30341032cdd414d6b74c9ebe97fb8daf1b320
hebasto:
ACK 9ee30341032cdd414d6b74c9ebe97fb8daf1b320.

Tree-SHA512: 8589cb2e90752c0128ff83210e0ab0f1683c217fa8c2f5b70c771914c54d93c26d7203253d32894c16f04f6974efe549c0f3d92646520efd0e45f7e1e9a72f0a

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`by Hennadii Stepanov · 0afaa731 · Nov 21, 2026 · 16 filesMessage 81 · StrongInformational 15Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

e8b442c76108bbe5e4496275c06054a7f6be4808 build: enable -Wdocumentation-pedantic (fanquake)
038388724f453358197ecd4075d5cabefa09660f doc: spell out escape sequences in doxygen comments (fanquake)
f3ce77ca5bdbaebd75a96523e7d517a837cb776a doc: use @param and @return in subprocess.h (fanquake)
0e9ac2cb225dcfbfe1bb08101878fab3f1e9d7b5 doc: use doxygen comments for blocks containing @param (fanquake)
68e8429bc430a3ace57a17070678f9868eeca689 doc: fix incorrect @param annotations (fanquake)

Pull request description:

Prompted by https://github.com/bitcoin/bitcoin/pull/36594#discussion_r4415881033.

ACKs for top commit:
hebasto:
ACK e8b442c76108bbe5e4496275c06054a7f6be4808.

Tree-SHA512: 18e8328f979ecc7fc94e4c4fa881cb2c1c512bf6ce953547f11b4d91a163023911eace772c84cacb7090e5ce65e70adbbdaa934610c1ffc9567673f575d9b243

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

Lower-priorityMerge bitcoin/bitcoin#36912: doc: relax clang-format loop and template declaration rulesby merge-script · f5a67cf4 · Nov 21, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36912: doc: relax clang-format loop and template declaration rules

fa07938a6f5c904aecf5d7925dbaf374a9db4897 doc: clang-format: AlwaysBreakTemplateDeclarations: No (MarcoFalke)
fa90a744553f479f033184091ac30ea3d351b26e doc: clang-format: AllowShortLoopsOnASingleLine: true (MarcoFalke)

Pull request description:

I think it is clear that devs are not following the clang-format config here even in new code, and I don't want to rub this in during review, nor do I want to see clang-format edit those when I use it locally.

So relax the config to allow those.

References:

https://clang.llvm.org/docs/ClangFormatStyleOptions.html#allowshortloopsonasingleline:

```
git grep --line-number --perl-regexp '^\s*for \([^)]+\) [^{]+;$' ./src/ | wc -l
-> 111
```

https://clang.llvm.org/docs/ClangFormatStyleOptions.html#alwaysbreaktemplatedeclarations:

```
git grep --line-number --perl-regexp '^\s*template\s*<.*>\s*(?:class|struct|[A-Za-z_])' | wc -l
-> 162
```

ACKs for top commit:
l0rinc:
ACK fa07938a6f5c904aecf5d7925dbaf374a9db4897

Tree-SHA512: c1d44957fbddb26a391aeab2d91c776df1bca63224ef584c00b3c5ee6954d43d21011c6fc7066cc01a774cff027e7f7bd7d2146bbc9a199f0565c6b8bd787ab1

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbfby Ava Chow · 004cfb21 · Nov 20, 2026 · 6 filesMessage 100 · StrongLow 41Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

596dd6fd88efe92133a34a0ba8d00f5f369a4bfd Test: bumpfee does not backdate the locktime (Biel)
b1ddb7d6857668c82efefebe94f6ba224f71ab4a Wallet: Do not allow bumpfee to backdate the replacement transaction locktime (Biel)

Pull request description:

Closes https://github.com/bitcoin/bitcoin/issues/26526

Currently, in Bitcoin Core, given an original transaction A and its replacement B, we refer to **backdating** when the locktime of A is higher than the locktime of B (`A.locktime > B.locktime`). This can happen because Bitcoin Core enables **anti-fee-sniping** by default, which sets the transaction's locktime to the current block height. For privacy, 10% of the time, it instead sets a different locktime, randomly chosen between the current height and the current height minus 100 blocks. This can lead into having a replacement of a transaction with a locktime older than its original transaction. This is unrealistics and can be used as a wallet fingerprint.

You can find a functional test to reproduce the behaviour mentioned [here](https://gist.github.com/Bicaru20/9afcb878dd103369255cd81cffac86ba)

The approach proposed in this PR adds a new parameter to `CoinControl` to keep track of the previous locktime in the case of a `bumpfee`. We then pass this parameter to the DiscourageFeeSniping function through a new parameter, `minimum_height`, whose default value is set to 0.

<details>
<summary>Alternative approach:</summary>
Since the locktime of the new transaction is 0, we also considered setting it to the previous locktime value and then, inside `DiscourageFeeSniping`, saving the previous locktime and setting the transaction's locktime to the block height before applying any of the backdating logic. This way, we could avoid passing a new parameter to the function. We ultimately decided not to go with this approach, as it makes the code more difficult to follow.
</details>

The only RPC that is affected by this changes is `bumpfee`.

The pr also includes a functional test in `wallet_bumpfee.py` to test that when replacing a transation using `bumpfee` the locktime is not backdated.

<details>
<summary>We also conducted a small analysis to see how many the backdating in RBF transactions actually happen.</summary>
We have data on the replaced transactions from 2025-05-01 to 2026-06-01. With that we have been able to detect this many backdatings:
<img width="1782" height="891" alt="image" src="https://github.com/user-attachments/assets/1d2a83d5-aa61-4850-82e5-cb434b9ee958" />

_We took the date of the last transaction of the
replacement chain (A replacement chain are all the transactions that replace themselves)_

In total we have over 1,000,000 rbf transactions, but we see that on average there are only about 200-300 hundred replaccements backdating per week. Looking at the percentages we see that on average is less than 2% of all the transactions that have been replaced.

So, it is clear that backdating in replacement transactions is unusual. However, the few transactions that do exhibit backdating are easily fingerprintable as having been replaced using `bumpfee` in Bitcoin Core or Electrum.

</details>

ACKs for top commit:
achow101:
ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd
polespinasa:
ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd
nervana21:
ACK 596dd6fd88efe92133a34a0ba8d00f5f369a4bfd

Tree-SHA512: ce4c6a6d9e84c7f1412f6a3452909109ffc790465c5fd8f799433a70d4b59187b4160defb8e9e1891686457824575c499f36073f3d7a4ba048527735c515e675

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 41/100

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. This unusual pattern could be spotted by anyone observing the blockchain and used as a fingerprint to identify transactions created by Bitcoin Core (or Electrum). The fix ensures the replacement's locktime is never older than the original's, removing that tell.

Lower-priorityMerge bitcoin/bitcoin#36835: test: add BIP352 scanning to the functional test frameworkby Ava Chow · 786ba167 · Nov 20, 2026 · 4 filesMessage 91 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36835: test: add BIP352 scanning to the functional test framework

cd6d7e240bb22e5d9515bd8cf8dbc081ff471dc8 test: add BIP352 scanning to the functional test framework (Novo)
fdfd7467cf77bdbea4d2c8bfdff137172006834a test: Add `is_p2*` and witness version `script_util` (rustaceanrob)

Pull request description:

Picked from #35302 as an isolated change that can be evaluated independently. This should make #35302 a bit easier to review. This adds a Python implementation of BIP352 scanning, without labels, so the functional tests can check silent payments outputs independently of `bitcoind` support. It is tested against the BIP352 receiving test vectors.

ACKs for top commit:
Eunovo:
ReACK https://github.com/bitcoin/bitcoin/pull/36835/commits/cd6d7e240bb22e5d9515bd8cf8dbc081ff471dc8
achow101:
ACK cd6d7e240bb22e5d9515bd8cf8dbc081ff471dc8
theStack:
ACK cd6d7e240bb22e5d9515bd8cf8dbc081ff471dc8
ismaelsadeeq:
ACK cd6d7e240bb22e5d9515bd8cf8dbc081ff471dc8

Tree-SHA512: 04d69e6692f95751289705c6bf33a0e60584defafe882b44ef32932cd470f7afa202e5b44c9a40931f96dca080209b3d1e6c07fa54f2adba73238368f48ab24e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEYby Ava Chow · 8c360f08 · Nov 20, 2026 · 2 filesMessage 86 · StrongModerate 62Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

bab579e56aa8b80a6f2923285e55cbcb2a7730b8 wallet: reject recipient amounts outside MoneyRange (Bruce0X)

Pull request description:

`CreateTransaction` checks that recipient amounts aren't negative, but not that they're within `MAX_MONEY`. `CreateTransactionInternal` then sums them into `recipients_sum` (spend.cpp:1100) with no range check, and that sum can overflow.

Easiest way to hit it is `fundrawtransaction` with a raw tx that has two outputs of 2^62 sat. It can also be reached with only valid amounts through `walletcreatefundedpsbt`/`send`/`sendmany` and a few thousand 21M BTC outputs. The "Transaction too large" check only runs after coin selection, so it doesn't stop this. On master the node aborts:

```
Assertion failed: (!m_selected_inputs.empty()), function RecalculateWaste, file coinselection.cpp, line 904.
```

UBSan reports the overflow at spend.cpp:1100 first. With other values the sum wraps to a small positive number instead, and `fundrawtransaction` returns success for a tx with outputs of 46116860184 BTC each.

This checks every amount and the running sum against `MoneyRange` in the existing recipients loop of `CreateTransactionInternal`, before the amount is added to `recipients_sum`, and returns "Transaction output amount must be valid" before coin selection starts. The same check rejects negative amounts, so the separate negative check in `CreateTransaction` is removed. The new `test_outputs_above_max_money` in `wallet_fundrawtransaction.py` covers a single output above MAX_MONEY, two outputs whose sum is above it, a sum that overflows int64, and a negative output. On master the first case returns "Insufficient funds" and the overflow case crashes the node; with the fix all of them get the new error. `wallet_fundrawtransaction.py`, `wallet_send.py`, `wallet_basic.py` and `rpc_psbt.py` pass.

ACKs for top commit:
maflcko:
lgtm ACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8
Zippo76:
tACK bab579e56a
furszy:
utACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8
achow101:
ACK bab579e56aa8b80a6f2923285e55cbcb2a7730b8

Tree-SHA512: 068c3bd19e37c2c3da237ddcf28cd88f3792a23c39ab1fa0469fdef9745117edc0ca5382174c184cef82155c725aac29b44df7b1d5f90b0c48ec94a9f0087a2b

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymemory safetysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 62/100

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to more than the maximum allowed bitcoin amount (about 21 million BTC), leading to incorrect math, a failed internal assertion, or a successful but invalid transaction. The fix now rejects such oversized or overflowing amounts early with a clear error message.

AI review queuedMerge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugsby Ava Chow · 6090f0af · Nov 20, 2026 · 2 filesMessage 100 · StrongLow 49Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

5a699cc2539856027d2a788b9604989d553b4d30 torcontrol: send -torpassword hex-encoded to avoid escaping bugs (jpk68)

Pull request description:

The Tor password was sent as a `QuotedString` with only double quotes escaped; as Tor interprets backslash escapes inside it, any password containing a backslash was mangled (or left the string unterminated).

The Tor Control spec deliberately allows the token to be sent as unquoted hex "to avoid escaping issues", as the `SAFECOOKIE` response already is. This patch does the same for the password, and also adds a functional test covering backslashes and quotes.

ACKs for top commit:
achow101:
ACK 5a699cc2539856027d2a788b9604989d553b4d30
winterrdog:
re-ACK 5a699cc2539856027d2a788b9604989d553b4d30
sedited:
Tested ACK 5a699cc2539856027d2a788b9604989d553b4d30
fjahr:
ACK 5a699cc2539856027d2a788b9604989d553b4d30

Tree-SHA512: 2d29cc1539ece443056e5b6eb9a75768169739c0cf3ca4cb93d78fbcee598a99979ccbc0cc6b1d7db267b91f5c64c508e2ed14c3fbd71a1ad42d0a25a5d64da3

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 49/100

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret it, which could corrupt the password, fail authentication, or in theory allow command-injection-style tricks in the Tor control protocol. The fix sends the password as plain hexadecimal characters instead, which avoids escaping entirely. A new test verifies that passwords containing backslashes and quotes now work correctly.

Lower-priorityMerge bitcoin/bitcoin#36586: coins: warn of low disk space before chainstate compactionby Ava Chow · 3b6068ab · Nov 20, 2026 · 6 filesMessage 81 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36586: coins: warn of low disk space before chainstate compaction

2fcfa1dae75ccd11062a6e6073600e67eb20164c doc: add chainstate compaction release note (Lőrinc)
cef76701a81fde56ad143b4ea559468a6b4dc626 coins: skip compaction if disk space is low (Lőrinc)
f57a6973da92359e91b95f72905e43bbf8ea5e4b logging: share full compaction logs (Lőrinc)

Pull request description:

**Problem:** Full chainstate compaction can temporarily require nearly another copy of the database before old files are deleted.

**Fix:** Log automatic full compaction start and finish at info level. Before starting, check the free space on the chainstate filesystem, and if it is below `m_assumed_chain_state_size`, log a warning and skip this compaction. Skipping avoids the temporary extra disk use but leaves obsolete data taking up space.

Fixes #36585

ACKs for top commit:
optout21:
crACK 2fcfa1dae75ccd11062a6e6073600e67eb20164c
stickies-v:
ACK 2fcfa1dae75ccd11062a6e6073600e67eb20164c
achow101:
ACK 2fcfa1dae75ccd11062a6e6073600e67eb20164c
danielabrozzoni:
light tACK 2fcfa1dae75ccd11062a6e6073600e67eb20164c

Tree-SHA512: 95dc757f91b744fc7cd63183730337d291bac9a1f3a3dbc7137c2d95523bdf922029307abf33df7a093e45811ce6ac0e11d0ab6c5ac2199bd5a32cb2e97fe652

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.by Ava Chow · f98888ef · Nov 20, 2026 · 19 filesMessage 100 · StrongLow 30Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

820120eb466ff2242d99f4c77ae6f8fa77f4bc9c wallet: rpc: Deprecate `encryptwallet` (David Gumberg)
86c8fa615409617099b709c78f3f58204e7e8cad refactor: test: signrawtransaction isolate encrypted wallet test (David Gumberg)
8a3c12cea705c8956ca2af0e46a6191492c5e462 refactor: test: wallet_multiwallet.py use a new encrypted wallet (David Gumberg)
bb78fcca7f6590f5ef0a73a9dc914f86db55e7ee refactor: test: wallet_listdescriptors.py extract encrypted wallet test (David Gumberg)
7af91e41a050426cce9ff43e59c6f862df9dbad0 refactor: test: wallet_fundrawtransaction.py avoid encryptwallet (David Gumberg)
c9b9ff4fe4330f695f6b7c3600ad48ad99749416 refactor: test: wallet_bumpfee.py isolate encrypted wallet tests (David Gumberg)
18ca5225b048f570788da6ea6192530a13064c1a refactor: test: rpc_psbt.py extract encrypted wallet signing (David Gumberg)
2354ff7b7e81845e86b05e0c61407099e92be02a refactor: test: Avoid encryptwallet in interface_bitcoin_cli.py (David Gumberg)

Pull request description:

For more context, see: #36027

Encrypting existing wallets that are unencrypted is fraught with footguns and complexity both for users and for developers.

For example:

- No efforts are made to ensure that remnants of unencrypted key material are not left on the user's disk, as attempting to ensure this would be difficult and dangerous, and for some SSD's infeasible.

- Encrypting a wallet that has manually imported descriptors will cause the wallet to change the spending conditions out from under the user. (https://github.com/bitcoin/bitcoin/issues/26607)

- Because new keys are made after encryption, restoring from a backup made before encryption may result in loss of funds.

_LLM Disclosure: Used gemma4-26B and qwen3.8-next-flash as research and drafting tools, but all code and text present here were written by me._

ACKs for top commit:
achow101:
ACK 820120eb466ff2242d99f4c77ae6f8fa77f4bc9c
w0xlt:
reACK 820120eb466ff2242d99f4c77ae6f8fa77f4bc9c

Tree-SHA512: 9ab4bb4c70510e9d16634b40f8a1e1339510c58147d554d3261050b64a524e25cee00930cbc5a9d08ba58b8396d4d461e6cbc7a3dbcfb3fffe7e51a47a2a8629

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 30/100

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bitcoins when trying to add a password to an already-created wallet. The safer path is to create a new wallet with a password from the start. This is a defensive usability change, not a fix for a remote hack.

Lower-priorityMerge bitcoin/bitcoin#36501: refactor : Reorder CBlockIndex members to save 8 bytesby Ava Chow · 570cef9b · Nov 20, 2026 · 1 fileMessage 93 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36501: refactor : Reorder CBlockIndex members to save 8 bytes

14edee63b643a96d7588897f0d00002228082178 Reorder CBlockIndex members to save 8 bytes (bartoli)

Pull request description:

It seems we can save 8 bytes per CBlockIndex instance by reordering one class member. Moving one 8-byte field seems to avoid losing 2x 4 bytes to structure padding on a 64-bit build (on a 32-bit build, there is no gain).

I could not exactly measure the runtime gain from just this (smaller than RAM usage variation between 2 launches), but I confirmed there was about as many instances of CBlockIndex as blocks in the chain (increasing CBlockIndex size by 320 bytes increases RAM usage by ~300MB), so saving 8 bytes per instance should save about 8MB of RAM at current block height.

The gain is small, but it seems like it has no cost/risk, since that structure is not used for serialization, and just reordering here should have no side effects.

I saw a few other types that could gain a few bytes in size by doing something similar (for example, CTxIn), but they have far fewer instances in memory to make the change worth it.

ACKs for top commit:
l0rinc:
ACK 14edee63b643a96d7588897f0d00002228082178
maflcko:
lgtm ACK 14edee63b643a96d7588897f0d00002228082178
achow101:
ACK 14edee63b643a96d7588897f0d00002228082178
jonatack:
Hesitant ACK 14edee63b643a96d7588897f0d00002228082178
sedited:
ACK 14edee63b643a96d7588897f0d00002228082178

Tree-SHA512: fb137095aee78b0d875c9440ee9a1e292beb6437ecc13361c62c5b0ce0d009c593a640eac069262900528bfda3dd880bb5e0493b889a56cda4aab4b1467ca2fc

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36087: util: Add and use AssertUnreachableby Ryan Ofsky · 3ee664ea · Nov 20, 2026 · 84 filesMessage 100 · StrongInformational 21Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

fa9a4ddbaf16d7fc8f8c336600674b3c7facca16 test: Add assert_falsy linter, And use AssertUnreachable (MarcoFalke)
fa20a5c7059c0d1cfd84a24e101d399f57771092 scripted-diff: Replace falsy assertions with AssertUnreachable (MarcoFalke)
fa6b4604e8c0cb48a13f8daa1ac61630114f35c2 test: Remove unused includes in util_tests.cpp (MarcoFalke)
fa1574cdaaeb8b0fad2eeb394a594a3534ee650c refactor: Use AssertUnreachable() and remove dead code (MarcoFalke)
fa81e4700a9495b7216580da151f36674b5affde util: Add AssertUnreachable (MarcoFalke)
fa1c93477e6ac332219af3eb4c6a5fcc9434105d refactor: Replace unreachable run-time assert with compile time assert (MarcoFalke)

Pull request description:

The current code uses assertions with falsy literal values in a few places. This is perfectly fine, but this comes with a bit of confusion sometimes:

* `assert(false)` may cause confusion when it is unclear if `NDEBUG` can disable it. (The intention is to disallow `NDEBUG` compilation). Also, it can lead to warnings when used with clang-cl.exe (GCC seems to understand it)
* `Assert(false)` hides the noreturn attribute behind a function call, which may cause GCC return-type warnings. (Clang seems to understand it)

See https://godbolt.org/z/h7PT3jh3Y for the clang-cl/GCC warning reproducer.

* When C++23 will be allowed, devs may prefer `std::unreachable`. However, this is unsafe and will invoke UB.
* There is confusion why a `CHECK_NONFATAL` macro exists, but no fatal equivalent.

Fix all those issues by:

* Adding a new `AssertUnreachable`, which directly calls the noreturn `internal_abort_helper` helper.
* Adding an `assert_falsy` linter to enforce code to use this macro.

ACKs for top commit:
jeanpablojp:
tACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16
l0rinc:
ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16
hodlinator:
re-ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16
ryanofsky:
Code review ACK fa9a4ddbaf16d7fc8f8c336600674b3c7facca16. Nice cleanup making code more consistent, and I like the clever approach to updating includes in the scripted-diff

Tree-SHA512: c9c1fda9458d0fea0d9828dd48a1d58cf2000fc79d4141e004d8b15fc0ceab3835fdd7cb1ac422858739dc8cc974e40e7e2aa085d21d39a34ccbf7c91042a2dd

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathparser or protocol pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 21/100

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and avoid compiler warnings, not to fix a security bug that an attacker could exploit. The change does not alter what the program does when it reaches one of these unreachable points: it still aborts immediately.

Security candidateMerge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declarativelyby merge-script · a690300e · Nov 20, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f test: construct coinselection_tests output declaratively (yuvicc)

Pull request description:

Part of #36692:

Build the funding output in `MakeCoin()` from `coinselection_tests` with a `CTxOut` constructor instead of `vout.resize(1)` followed by assigning `nValue`. Test-only change, the constructed txns are unchanged and the empty `scriptPubKey` that `resize()` left implicit is now explicit.

ACKs for top commit:
maflcko:
review ACK 77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f 🍰
alexanderwiederin:
ACK 77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f

Tree-SHA512: 1898d76fd6bad8d6ae92cebdd99472cc8b01504a6f348775d9695ff60e11eb32d1b3af1c77e07b6bc8fbc8eb0c1ff9698d233c07c9519869b86545cd6a4e45de

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and the transactions being simulated are unchanged. There is no security issue.

Lower-priorityMerge bitcoin/bitcoin#36742: lint: shellcheck files with shell shebangby merge-script · f498a5a6 · Nov 20, 2026 · 8 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36742: lint: shellcheck files with shell shebang

fa2028daaa461accf93737ae82e513068c715d47 lint: Remove global shellcheck exclude of SC2162 (MarcoFalke)
faf5cc398bbc874e61910d96c5d9d6349fb3da0c lint: shellcheck files with shell shebang (MarcoFalke)

Pull request description:

The current shellcheck lint silently ignores all files with a shell shebang that are not ending in `.sh`.

Fix it by linting them, which also simplifies the script, because manually appending of guix scripts can be dropped.

Also, remove global shellcheck exclude of SC2162 (read -r).

ACKs for top commit:
hebasto:
ACK fa2028daaa461accf93737ae82e513068c715d47.

Tree-SHA512: de6266c753f0affddd5ba8e3cb1a40ee20a651e36df8837bc99c6a5161044a0483c5a391ac03970d7bd370ef266f0475d616ae54f68ee0dd610441de6b8b85b5

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest masterby merge-script · c3d1b4c0 · Nov 20, 2026 · 34 filesMessage 81 · StrongLow 35Details
Commit message · merge-script

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

b3dcf1931b922c916b1fedb8b985063f8037962e Squashed 'src/secp256k1/' changes from a7f264373e..659f03b076 (Hennadii Stepanov)

Pull request description:

This PR updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/a0e2e23a71bf2aaae910f81cb2bd8aa0ae49d544, which includes the following changes:

- bitcoin-core/secp256k1#1893
- bitcoin-core/secp256k1#1935
- bitcoin-core/secp256k1#1918
- bitcoin-core/secp256k1#1840
- bitcoin-core/secp256k1#1934
- bitcoin-core/secp256k1#1942
- bitcoin-core/secp256k1#1947
- bitcoin-core/secp256k1#1948
- bitcoin-core/secp256k1#1949
- bitcoin-core/secp256k1#1933
- bitcoin-core/secp256k1#1946
- bitcoin-core/secp256k1#1950
- bitcoin-core/secp256k1#1953
- bitcoin-core/secp256k1#1963
- bitcoin-core/secp256k1#1866
- bitcoin-core/secp256k1#1929
- bitcoin-core/secp256k1#1943
- bitcoin-core/secp256k1#1952
- bitcoin-core/secp256k1#1965
- bitcoin-core/secp256k1#1975
- bitcoin-core/secp256k1#1961
- bitcoin-core/secp256k1#1978
- bitcoin-core/secp256k1#1937
- bitcoin-core/secp256k1#1983
- bitcoin-core/secp256k1#1974
- bitcoin-core/secp256k1#1986
- bitcoin-core/secp256k1#1992
- bitcoin-core/secp256k1#1972
- bitcoin-core/secp256k1#1995
- bitcoin-core/secp256k1#1999
- bitcoin-core/secp256k1#1898
- bitcoin-core/secp256k1#1998
- bitcoin-core/secp256k1#1996

The update is prompted by:
1. New warnings introduced in Clang 24. bitcoin-core/secp256k1#1998 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36869.
2. New warnings in CMake >=4.5. bitcoin-core/secp256k1#1996 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36889.

Fixes https://github.com/bitcoin/bitcoin/issues/36913 and unlocks the CI.

ACKs for top commit:
fanquake:
ACK 830cca99046b880dd79ff8e09ba161decb15f572

Tree-SHA512: 952a2d30e17abc81f006904b03a88481b02b9b1f1aabf1281bba1200c004643cd4417c825b2e9059955fec376bbe277a86f861703a7fdde93e3d7f8d46022298

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 35/100

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes make the Silent Payments module behave better when a transaction has no relevant inputs or outputs, and make ECDH/MuSig code more careful about clearing secret intermediate values from memory. There is no evidence in the commit message or diff of an active security vulnerability being patched.

AI review queuedMerge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional testsby merge-script · c138ff92 · Nov 20, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

b9b33544aaf17d47d27f7393d3e21d6ff8f93485 test: remove no-op -keypool=0 from wallet_hd (w0xlt)
1ac0e9cd5b02db659774ff70a055ced0572b5420 test: update wallet_backup docstring (w0xlt)
363355a72dc159783a7113f721ff1c718de0c8f6 test: remove dead multisig code from wallet_address_types (w0xlt)

Pull request description:

This PR cleans up three tests that still carry code or text from the legacy wallet:

- `wallet_address_types.py`: the send loop iterates over `do_multisigs = [False]`, so its multisig code path and the multisig cases of `test_address`/`test_desc` can't run. That code path is also broken, since it never sets the address it checks. This PR removes that code, along with the docstring section about the old `addmultisigaddress` tests.

- `wallet_backup.py`: the docstring still describes `dumpwallet`/`importwallet` and erasing wallets; the test uses `backupwallet` and `restorewallet`.

- `wallet_hd.py`: `-keypool=0` does nothing for descriptor wallets, which always keep at least one key, and the test config already sets `keypool=1`.

No coverage changes: `wallet_address_types.py` runs the same 8 send iterations before and after.

ACKs for top commit:
adezo24h1:
tACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485
fjahr:
Code review ACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485

Tree-SHA512: 8a9fd595ee8fa4f49c1fbf5dd336e20e3826e9e6f95ed798836a57ef954270a1acb4d72f8e1acd9babea41ea60e0070983432fc7ddfb6070a511bec6929178b8

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual Bitcoin Core wallet or network code that users run, so there is no security impact.

AI review queuedMerge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter testsby merge-script · 079437cc · Nov 19, 2026 · 2 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

1eeeee497e04ce3ef5ca2da5f2a6985913b61068 test: Drop hard-coded magic 3 (MarcoFalke)
fa06fd5a69a15dc4b3c557b52c5a7f7ea61275f2 test: Use generateblock with submit=False to create header (MarcoFalke)

Pull request description:

* Use generateblock with submit=False to create header, and avoid manual disconnect+reconnect
* Drop hard-coded magic `3`

ACKs for top commit:
ViniciusCestarii:
ACK 1eeeee497e04ce3ef5ca2da5f2a6985913b61068

Tree-SHA512: 21b4ac4e079f27ebe7407fd2e176619050e5ee18cb699f84722eab7e9173cc20ceb222cdcb3320fc9b3598580ae540b5d1af3919c44f1e7772667099240a8641

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor of using the actual number of test nodes. There are no changes to the live Bitcoin software that users run, and nothing that affects real funds, transactions, or network security.

AI review queuedtest: Drop hard-coded magic 3by MarcoFalke · 1eeeee49 · Nov 19, 2026 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · MarcoFalke

test: Drop hard-coded magic 3

Now that there are 3 nodes, use self.nodes directly.

82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and has no security relevance.

Lower-prioritytest: Use generateblock with submit=False to create headerby MarcoFalke · fa06fd5a · Nov 19, 2026 · 1 fileMessage 87 · StrongTriage 0Details
Commit message · MarcoFalke

test: Use generateblock with submit=False to create header

This is shorter than manual disconnect+reconnect

87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
AI review queuedMerge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfoby merge-script · 66531447 · Nov 19, 2026 · 4 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

5b2f979c9e474a641b90902c3a87dee93c8f2899 doc: add release note for getaddressinfo iswatchonly deprecation (w0xlt)
375dc869d8bd444f7485ab0c030d793063d91a06 rpc: deprecate iswatchonly field of getaddressinfo (w0xlt)

Pull request description:

Since #32618, `getaddressinfo` returns `iswatchonly: false` for every address. It was kept and marked "(DEPRECATED)" so it could be removed later without surprising users ([review comment](https://github.com/bitcoin/bitcoin/pull/32618#discussion_r2180720302)), but it was never put behind `-deprecatedrpc`. The v30 release notes also say it was already removed from all RPCs, which isn't true for `getaddressinfo`.

This returns it only with `-deprecatedrpc=iswatchonly`, like `startingheight` in `getpeerinfo` (#34197), so it can be removed in the next release.

ACKs for top commit:
maflcko:
lgtm ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899
jonatack:
ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899
seduless:
Tested ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899

Tree-SHA512: ce9d7b6fa8229fdd11e11047cf8c147e7f8d2a6586eb4aa6f4283da99ada9753f798ac6d07048947b394a5bc57c0e9a1c832475407a865b168e2f2920e7e9f85

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or funds are protected.

AI review queuedMerge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet testsby merge-script · 0fb50460 · Nov 19, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3 test: remove duplicate restart from wallet_sendall (w0xlt)
0ba20992e8120ce33aa1fc513b167bd06a87bfce test: use one node in signrawtransactionwithwallet and derivehdkey (w0xlt)
4f0d4e11c1e999634ae5c34281ce3af402bfa879 test: remove unused node from wallet_basic (w0xlt)

Pull request description:

Some wallet functional tests start or restart nodes they never use:

- `wallet_basic.py`: node 3 hasn't been used since the `resendwallettransactions` check was removed in 2019 (f5162458cd), but the test still starts, stops and restarts it. Without it, the sync calls no longer need `self.nodes[0:3]`.

- `wallet_signrawtransactionwithwallet.py` and `wallet_derivehdkey.py` each start a second node that is never used.

- `wallet_sendall.py` restarts node 0 and reloads its wallets twice in a row with the same arguments.

No coverage changes. Each test runs a bit faster, about 0.2–0.4 s per test locally.

ACKs for top commit:
adezo24h1:
tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
ViniciusCestarii:
tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
brunoerg:
code review ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
murchandamus:
ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
maflcko:
review ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3 🍙

Tree-SHA512: 47468cdc156e689b60b06c3c27137c6f3a86f1209b5dace7c3f3f24f22c322d0d8ac5662beef57122632caf485f06fecd65acd5cea14fd1cc51635614c915d7c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network security.

Lower-priorityMerge bitcoin/bitcoin#36889: cmake: Switch `include_directories` -> `target_include_directories`by merge-script · d55f55ed · Nov 18, 2026 · 3 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36889: cmake: Switch `include_directories` -> `target_include_directories`

435d5b227748a0ac5d6d2887050acf02304576f2 cmake: Remove `WarnAboutGlobalProperties` module (Hennadii Stepanov)
460f877fac200ccfde265d12613b352def903cf0 cmake: Switch `include_directories` -> `target_include_directories` (Hennadii Stepanov)
4ef05d6f45620254417fe6be701bebbf1a42619a cmake: Link `bitcoin_ipc` against `core_interface` (Hennadii Stepanov)

Pull request description:

Use of non-target directives is not recommended. As of CMake 4.5.0, such use triggers `-Wnon-target-directive` warnings:
```console
$ cmake -B build -Wnon-target-directive
<snip>
CMake Warning (non-target-directive) at src/CMakeLists.txt:8 (include_directories):
Use of non-target directives is not recommended. Consider
target_include_directories instead.
This warning is for project developers. Use -Wno-author or
-Wno-non-target-directive to suppress it.

<snip>
```

This PR:
1. Links `bitcoin_ipc` against `core_interface`, so that `ipc/stub.cpp` is compiled with the project-wide build flags.

2. Replaces the `include_directories()` call in `src/CMakeLists.txt` with `target_include_directories()`.

3. Removes the custom [`WarnAboutGlobalProperties`](https://github.com/bitcoin/bitcoin/blob/29f7e30d547c30ddb7a637bc3a2dbc7c0e3f5469/cmake/module/WarnAboutGlobalProperties.cmake) module, which is superseded by the new CMake warning.

---

The counterpart for the `secp256k1` repo is https://github.com/bitcoin-core/secp256k1/pull/1996.

ACKs for top commit:
fanquake:
ACK 435d5b227748a0ac5d6d2887050acf02304576f2 - going to merge this now, given it was mentioned on IRC that devs are seeing local build breakage (after updating CMake).

Tree-SHA512: 92400cca2315c5b145a8c70687fa3c58e44ffd9ab2ec2cb6c1fb7579316b5cc81897b1cc4f41ae4a35096f53139c7b9075ce617d68399807c87462d630665699

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36903: doc: archive release notesby merge-script · 95dcec43 · Nov 18, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36903: doc: archive release notes

2733c24a09a947cd84970283153e0ce59a2ccaba doc: archive release notes for v30.5 (fanquake)
90c684c28e673f9a490362f6f5adafc32b1b5cbc doc: archive release notes for v31.3 (fanquake)

Pull request description:

Archive release notes for `v31.3` and `v30.5`.

ACKs for top commit:
instagibbs:
clACK https://github.com/bitcoin/bitcoin/pull/36903/commits/2733c24a09a947cd84970283153e0ce59a2ccaba
willcl-ark:
ACK 2733c24a09a947cd84970283153e0ce59a2ccaba

Tree-SHA512: 8ea039489ee1572adc54984107d5407ca0192e4753df1620c7859eb518fd713d3f48536e5b5129dc1f4e3017897ec40c65d8c3f9a64f09a4e332b387b3c09770

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNodeby merge-script · 6832a273 · Nov 18, 2026 · 3 filesMessage 81 · StrongModerate 68Details
Commit message · merge-script

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

d63068c58ec9fcc94876bce30865d1a7266d64d4 net_processing: set fDisconnect instead of calling DisconnectNode (Eugene Siegel)

Pull request description:

`MaybeDiscourageAndDisconnect` calls `DisconnectNode` which creates a `CSubNet` containing only the `CNode`'s address. This will disconnect every `CNode` with the same IP address. This is normally not a problem, except for clearnet-over-tor. If a node has an honest clearnet-over-tor inbound connection, the IP of the inbound peer will be the exit node's IP address. If an attacker connects to the node through the same exit node and sends an invalid message, they can cause every inbound peer sharing the exit node's IP to get disconnected. Fix this by only disconnecting the misbehaving `CNode` rather than every `CNode` sharing the IP.

ACKs for top commit:
Husteem:
Approach ACK / tACK d63068c
maflcko:
lgtm ACK d63068c58ec9fcc94876bce30865d1a7266d64d4
ajtowns:
re utACK d63068c58ec9fcc94876bce30865d1a7266d64d4
darosior:
utACK d63068c58ec9fcc94876bce30865d1a7266d64d4

Tree-SHA512: 4001678d95b70ca26992e46bf3211abceb12b60e51b6852741f01b1a41203a7bb6f3e89c8141aa940209d4f8a32fbcf0d72c7e8b0bfd091e4713f1e5d9426f16

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languagemerge-commit duplicate discount
AI analysis · Moderate 68/100

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set of public 'exit nodes.' An attacker could use the same Tor exit node as honest users, send an invalid message, and get every honest inbound peer using that exit node kicked off. The fix makes the node disconnect only the specific misbehaving connection while still discouraging (reducing trust in) that IP address.

Security candidatenet_processing: set fDisconnect instead of calling DisconnectNodeby Eugene Siegel · d63068c5 · Nov 16, 2026 · 3 filesMessage 73 · AdequateModerate 62Details
Commit message · Eugene Siegel

net_processing: set fDisconnect instead of calling DisconnectNode

MaybeDiscourageAndDisconnect calls DisconnectNode which creates a
CSubNet containing only the CNode's address. This will disconnect
every CNode with the same IP address. This is normally not a problem,
except for clearnet-over-tor. If a node has an honest clearnet-over-tor
inbound connection, the IP of the inbound peer will be the exit node's
IP address. If an attacker connects to the node through the same exit
node and sends an invalid message, they can cause every inbound peer
sharing the exit node's IP to get disconnect. Fix this by only
disconnecting the misbehaving CNode rather than every CNode sharing
the IP.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
explicit security language
AI analysis · Moderate 62/100

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehave and force the node to disconnect innocent users arriving through the same Tor exit. The fix makes the node disconnect only the specific misbehaving peer instead of all peers with that IP.