AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3 test: remove duplicate restart from wallet_sendall (w0xlt)
0ba20992e8120ce33aa1fc513b167bd06a87bfce test: use one node in signrawtransactionwithwallet and derivehdkey (w0xlt)
4f0d4e11c1e999634ae5c34281ce3af402bfa879 test: remove unused node from wallet_basic (w0xlt)

Pull request description:

Some wallet functional tests start or restart nodes they never use:

- `wallet_basic.py`: node 3 hasn't been used since the `resendwallettransactions` check was removed in 2019 (f5162458cd), but the test still starts, stops and restarts it. Without it, the sync calls no longer need `self.nodes[0:3]`.

- `wallet_signrawtransactionwithwallet.py` and `wallet_derivehdkey.py` each start a second node that is never used.

- `wallet_sendall.py` restarts node 0 and reloads its wallets twice in a row with the same arguments.

No coverage changes. Each test runs a bit faster, about 0.2–0.4 s per test locally.

ACKs for top commit:
adezo24h1:
tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
ViniciusCestarii:
tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
brunoerg:
code review ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
murchandamus:
ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3
maflcko:
review ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3 🍙

Tree-SHA512: 47468cdc156e689b60b06c3c27137c6f3a86f1209b5dace7c3f3f24f22c322d0d8ac5662beef57122632caf485f06fecd65acd5cea14fd1cc51635614c915d7c
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network security.

Recommended action

No security action needed. This is a routine test-maintenance change; review can be limited to confirming no functional assertions were accidentally removed.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.