AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

Public commit record

What the developer wrote

Authored by merge-script

81/100 · Strong
Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

b3dcf1931b922c916b1fedb8b985063f8037962e Squashed 'src/secp256k1/' changes from a7f264373e..659f03b076 (Hennadii Stepanov)

Pull request description:

This PR updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/a0e2e23a71bf2aaae910f81cb2bd8aa0ae49d544, which includes the following changes:

- bitcoin-core/secp256k1#1893
- bitcoin-core/secp256k1#1935
- bitcoin-core/secp256k1#1918
- bitcoin-core/secp256k1#1840
- bitcoin-core/secp256k1#1934
- bitcoin-core/secp256k1#1942
- bitcoin-core/secp256k1#1947
- bitcoin-core/secp256k1#1948
- bitcoin-core/secp256k1#1949
- bitcoin-core/secp256k1#1933
- bitcoin-core/secp256k1#1946
- bitcoin-core/secp256k1#1950
- bitcoin-core/secp256k1#1953
- bitcoin-core/secp256k1#1963
- bitcoin-core/secp256k1#1866
- bitcoin-core/secp256k1#1929
- bitcoin-core/secp256k1#1943
- bitcoin-core/secp256k1#1952
- bitcoin-core/secp256k1#1965
- bitcoin-core/secp256k1#1975
- bitcoin-core/secp256k1#1961
- bitcoin-core/secp256k1#1978
- bitcoin-core/secp256k1#1937
- bitcoin-core/secp256k1#1983
- bitcoin-core/secp256k1#1974
- bitcoin-core/secp256k1#1986
- bitcoin-core/secp256k1#1992
- bitcoin-core/secp256k1#1972
- bitcoin-core/secp256k1#1995
- bitcoin-core/secp256k1#1999
- bitcoin-core/secp256k1#1898
- bitcoin-core/secp256k1#1998
- bitcoin-core/secp256k1#1996

The update is prompted by:
1. New warnings introduced in Clang 24. bitcoin-core/secp256k1#1998 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36869.
2. New warnings in CMake >=4.5. bitcoin-core/secp256k1#1996 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: https://github.com/bitcoin/bitcoin/pull/36889.

Fixes https://github.com/bitcoin/bitcoin/issues/36913 and unlocks the CI.

ACKs for top commit:
fanquake:
ACK 830cca99046b880dd79ff8e09ba161decb15f572

Tree-SHA512: 952a2d30e17abc81f006904b03a88481b02b9b1f1aabf1281bba1200c004643cd4417c825b2e9059955fec376bbe277a86f861703a7fdde93e3d7f8d46022298
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes make the Silent Payments module behave better when a transaction has no relevant inputs or outputs, and make ECDH/MuSig code more careful about clearing secret intermediate values from memory. There is no evidence in the commit message or diff of an active security vulnerability being patched.

Recommended action

Treat as a normal dependency update. Reviewers should verify that Bitcoin Core's own build still links the new INTERFACE targets correctly and that downstream projects using the secp256k1 subtree are not relying on the old global compile definitions. No urgent security patch is indicated by the supplied materials.

Security signals we found

01

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behavior

02

Silent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handled

03

ecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage

04

ECDH and silentpayments shared-secret paths updated to use the new clearing variant

05

CMake compile definitions moved from global add_compile_definitions to target-specific INTERFACE targets

06

modinv32/modinv64 volatile-variable usage adjusted to avoid unsequenced-read UB

07

Public-key parsing split into size-specific helpers (parse33, parse65, parse_with_hybrid65)

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.