AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

b9b33544aaf17d47d27f7393d3e21d6ff8f93485 test: remove no-op -keypool=0 from wallet_hd (w0xlt)
1ac0e9cd5b02db659774ff70a055ced0572b5420 test: update wallet_backup docstring (w0xlt)
363355a72dc159783a7113f721ff1c718de0c8f6 test: remove dead multisig code from wallet_address_types (w0xlt)

Pull request description:

This PR cleans up three tests that still carry code or text from the legacy wallet:

- `wallet_address_types.py`: the send loop iterates over `do_multisigs = [False]`, so its multisig code path and the multisig cases of `test_address`/`test_desc` can't run. That code path is also broken, since it never sets the address it checks. This PR removes that code, along with the docstring section about the old `addmultisigaddress` tests.

- `wallet_backup.py`: the docstring still describes `dumpwallet`/`importwallet` and erasing wallets; the test uses `backupwallet` and `restorewallet`.

- `wallet_hd.py`: `-keypool=0` does nothing for descriptor wallets, which always keep at least one key, and the test config already sets `keypool=1`.

No coverage changes: `wallet_address_types.py` runs the same 8 send iterations before and after.

ACKs for top commit:
adezo24h1:
tACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485
fjahr:
Code review ACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485

Tree-SHA512: 8a9fd595ee8fa4f49c1fbf5dd336e20e3826e9e6f95ed798836a57ef954270a1acb4d72f8e1acd9babea41ea60e0070983432fc7ddfb6070a511bec6929178b8
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual Bitcoin Core wallet or network code that users run, so there is no security impact.

Recommended action

No action required; this is a routine test-maintenance change with no security relevance.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.