Merge bitcoin/bitcoin#36783: Update minisketch subtree to latest master
What changed, and why it matters
This is a routine update of an internal math library (minisketch) used by Bitcoin Core. The visible code change removes an unreachable 'break' statement that followed a 'return' inside a switch case. That kind of cleanup is cosmetic and does not change program behavior. There is no indication in the commit message or diff that this fixes a security vulnerability.
No security action required. Treat as a normal dependency/subtree maintenance update.
Security signals we found
No security-relevant keywords in commit title or message
Diff is a single dead-code removal in a math helper library
No memory safety, cryptographic, or consensus code is modified
Change does not alter observable program behavior
Evidence from the diff
The merge commit updates the src/minisketch subtree to a newer revision. The only visible diff in the squashed subtree is the deletion of a ‘break;’ statement after a ‘return nullptr;’ in the Construct() factory function’s default switch case. Because ‘return’ already exits the function, the ‘break’ is dead code. The change is therefore a compiler warning / code-quality cleanup with no functional effect. The referenced upstream minisketch PR #106 is not described in the commit as security-relevant.
Changed components
src/minisketch/src/minisketch.cppminisketch subtreeInspect captured patch +0 / −1
### src/minisketch/src/minisketch.cpp
@@ -101,7 +101,6 @@ Sketch* Construct(int bits, int impl)
default:
return nullptr;
}
- break;
#ifdef HAVE_CLMUL
case FieldImpl::CLMUL:
if (EnableClmul()) {Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.