AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

Merge bitcoin/bitcoin#36539: gui: Use PSBT v0

Public commit record

What the developer wrote

Authored by Ava Chow

86/100 · Strong
Merge bitcoin/bitcoin#36539: gui: Use PSBT v0

3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0 refactor: psbt: Don't set a default version for PSBT constructor (David Gumberg)
23dcb03a2c6b9fed84896ac4d751ba9e8034a6bf gui: wallet: Use v0 PSBT (David Gumberg)

Pull request description:

This fixes: https://github.com/bitcoin/bitcoin/issues/36518

There is no test added here for the bump fee PSBT's being v0, since there aren't any existing tests for watch only wallet feebumping in the GUI. If reviewers insist on this I can add it, but I wanted to keep the diff minimal. I have tested this manually.

AFAIU for the external signer stuff it shouldn't matter much whether it's v0 or v2, since users are very unlikely to be using HWI software that doesn't speak v0, but out of caution I've set the external signer PSBT to v0 for the GUI.

_This PR originally took the approach of adding a checkbox, ([davidgumberg/gui/2026-10-15-psbt-gui](https://github.com/davidgumberg/gui/tree/2026-10-15-psbt-gui)), but this was dropped to simplify backporting past string freeze._

_LLM Disclosure: The previous approach was drafted using an LLM, but this branch was written by me. I used an LLM to explore adding a fee bump watchonly GUI test, and decided against it._

ACKs for top commit:
Sjors:
ACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0
achow101:
ACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0
w0xlt:
crACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0

Tree-SHA512: 9f157aed7c2b3395e51322a9f7ff54879e6e3ee2913ea532922291f7ba055b8294c850b430fb0193759cdae0a041109ce57cb924bc2ed2d429e005041a8da0da
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change makes the Bitcoin Core graphical wallet produce older PSBT v0 files instead of PSBT v2 in several common user flows (creating unsigned transactions, bumping fees). PSBT v2 is newer and not supported by some older external signer tools/hardware wallet software. By defaulting to v0 in the GUI, the wallet stays compatible with more hardware signing tools. The change also removes the automatic default version from the PSBT constructor so callers must explicitly choose a version. This is a compatibility/usability fix, not a fix for theft-of-funds or remote code execution.

Recommended action

Treat as a compatibility/usability fix rather than a critical security patch. Backport to affected release branches if users are encountering unusable PSBTs with external signers. No urgent deployment required for security reasons, but verify that downstream GUI users with hardware wallets no longer receive unsupported PSBT v2 files for normal unsigned/fee-bump flows.

Security signals we found

01

Constructor default version removed, making version choice explicit at every call site

02

GUI unsigned transaction creation switched from implicit PSBT v2 to explicit PSBT v0

03

GUI fee-bump PSBT switched from implicit PSBT v2 to explicit PSBT v0

04

External-signer code paths deliberately keep PSBT v2 with explanatory comments

05

Release note added stating external signer software must support PSBTv2 / HWI >= 2.1.0

06

No cryptographic, consensus, or network-layer changes observed

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.