AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declaratively

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declaratively

c723c37de69fd95e6ec795e848efb03d944999ba test: construct multisig_tests inputs/outputs declaratively (yuvicc)

Pull request description:

Part of #36692. This replaces the field-by-field construction of transaction inputs and outputs in `multisig_tests` with `COutPoint`, `CTxIn` and `CTxOut` constructor calls.

It keeps `CMutableTransaction` as the builder, since a `CTransaction` constructor taking inputs and outputs directly is still under discussion (#36696). If one is added, the `vin`/`vout` lists here can be passed to it directly.

This change is test-only and does not change the constructed transactions:

- The funding outputs were previously created by `vout.resize(3)` and only had their `scriptPubKey` assigned, leaving `nValue` at its null value (`-1`). The `-1` is now spelled out explicitly, which makes this previously hidden value visible
- The loop index is changed from `int` to `uint32_t` to match `COutPoint::n`

ACKs for top commit:
purpleKarrot:
ACK c723c37
maflcko:
review ACK c723c37de69fd95e6ec795e848efb03d944999ba 🍯
alexanderwiederin:
ACK c723c37

Tree-SHA512: 3122762dae1e4fbc1a4ad79ce67128e83d29da965b3c8b6009f075c39310b8f983a96e3c4f30844a57af2faca4c658149808176aa4bb67d940ebeec147031676
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a test-only code cleanup in Bitcoin Core. It changes how fake transactions are built inside unit tests, making the test code more readable without altering the actual transactions being tested. There is no effect on the live Bitcoin network or wallet software.

Recommended action

No security action needed; this is a routine test refactor.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.