Merge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertions
What changed, and why it matters
This commit is a routine cleanup of Bitcoin Core's fuzz test files. It adds the include for util/check.h (which provides the project's own Assert macro) and removes or reorders some standard C assert includes. The changes only affect test/fuzz code, not the live Bitcoin node software, and the commit message explicitly says the goal is to reduce developer confusion and improve automated include checking. There is no security fix or vulnerability here.
No action required. This is a benign refactoring commit in test-only code. It can be treated as normal maintenance.
Security signals we found
No security signal: change is purely include additions/removals in test code
No vulnerability fixed: no functional code modified
No attack surface introduced: fuzz tests are not part of shipped node runtime
No change to consensus, networking, wallet, or cryptographic code
Evidence from the diff
A scripted-diff merge that adds #include
Changed components
src/test/fuzz/*src/wallet/test/fuzz/*src/ipc/test/fuzz/*Inspect captured patch +175 / −98
### src/ipc/test/fuzz/ipc.cpp
@@ -2,20 +2,21 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <primitives/transaction.h>
#include <capnp/capability.h>
#include <capnp/rpc.h>
+#include <ipc/test/fuzz/ipc_fuzz.capnp.h>
+#include <ipc/test/fuzz/ipc_fuzz.capnp.proxy.h>
+#include <ipc/test/fuzz/ipc_fuzz.h>
#include <ipc/util.h>
#include <kj/memory.h>
#include <mp/proxy-io.h>
#include <mp/proxy.h>
+#include <primitives/transaction.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
-#include <ipc/test/fuzz/ipc_fuzz.capnp.h>
-#include <ipc/test/fuzz/ipc_fuzz.capnp.proxy.h>
-#include <ipc/test/fuzz/ipc_fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
+#include <util/check.h>
#include <future>
#include <memory>
### src/test/fuzz/addition_overflow.cpp
@@ -5,6 +5,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <util/overflow.h>
#include <cstdint>
### src/test/fuzz/addrman.cpp
@@ -2,8 +2,9 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <addrdb.h>
#include <addrman.h>
+
+#include <addrdb.h>
#include <addrman_impl.h>
#include <chainparams.h>
#include <common/args.h>
@@ -17,8 +18,8 @@
#include <test/util/time.h>
#include <util/asmap.h>
#include <util/chaintype.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <ctime>
#include <optional>
### src/test/fuzz/asmap.cpp
@@ -2,10 +2,12 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <util/asmap.h>
+
#include <netaddress.h>
#include <netgroup.h>
#include <test/fuzz/fuzz.h>
-#include <util/asmap.h>
+#include <util/check.h>
#include <util/strencodings.h>
#include <cstdint>
### src/test/fuzz/asmap_direct.cpp
@@ -3,14 +3,14 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <netaddress.h>
-#include <util/asmap.h>
#include <test/fuzz/fuzz.h>
+#include <util/asmap.h>
+#include <util/check.h>
#include <cstdint>
#include <optional>
#include <vector>
-#include <cassert>
std::vector<std::byte> BitsToBytes(std::span<const uint8_t> bits) noexcept
{
### src/test/fuzz/banman.cpp
@@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <banman.h>
+
#include <common/args.h>
#include <netaddress.h>
#include <test/fuzz/FuzzedDataProvider.h>
@@ -11,10 +12,10 @@
#include <test/fuzz/util/net.h>
#include <test/util/setup_common.h>
#include <test/util/time.h>
+#include <util/check.h>
#include <util/fs.h>
#include <util/readwritefile.h>
-#include <cassert>
#include <cstdint>
#include <limits>
#include <string>
### src/test/fuzz/base_encode_decode.cpp
@@ -2,19 +2,18 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <test/fuzz/fuzz.h>
-
#include <base58.h>
#include <psbt.h>
#include <span.h>
#include <test/fuzz/FuzzedDataProvider.h>
+#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <util/strencodings.h>
#include <util/string.h>
-#include <cassert>
+#include <ranges>
#include <string>
#include <vector>
-#include <ranges>
using util::TrimStringView;
### src/test/fuzz/bech32.cpp
@@ -3,11 +3,12 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <bech32.h>
-#include <test/fuzz/fuzz.h>
+
#include <test/fuzz/FuzzedDataProvider.h>
+#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <util/strencodings.h>
-#include <cassert>
#include <cstdint>
#include <string>
#include <vector>
### src/test/fuzz/bip324.cpp
@@ -3,12 +3,14 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <bip324.h>
+
#include <chainparams.h>
#include <random.h>
#include <span.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <algorithm>
#include <cstdint>
### src/test/fuzz/bitdeque.cpp
@@ -2,10 +2,12 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <util/bitdeque.h>
+
#include <random.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/util.h>
-#include <util/bitdeque.h>
+#include <util/check.h>
#include <deque>
#include <vector>
### src/test/fuzz/bitset.cpp
@@ -2,10 +2,12 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <util/bitset.h>
+
#include <random.h>
#include <span.h>
#include <test/fuzz/util.h>
-#include <util/bitset.h>
+#include <util/check.h>
#include <bitset>
#include <vector>
### src/test/fuzz/block.cpp
@@ -2,19 +2,20 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <primitives/block.h>
+
#include <chainparams.h>
#include <consensus/merkle.h>
#include <consensus/validation.h>
#include <core_io.h>
#include <core_memusage.h>
-#include <primitives/block.h>
#include <pubkey.h>
#include <streams.h>
#include <test/fuzz/fuzz.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <validation.h>
-#include <cassert>
#include <string>
void initialize_block()
### src/test/fuzz/block_header.cpp
@@ -7,8 +7,8 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <uint256.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <optional>
#include <string>
### src/test/fuzz/block_index.cpp
@@ -11,6 +11,7 @@
#include <test/util/setup_common.h>
#include <txdb.h>
#include <util/byte_units.h>
+#include <util/check.h>
#include <validation.h>
using kernel::CBlockFileInfo;
### src/test/fuzz/block_index_tree.cpp
@@ -14,6 +14,7 @@
#include <test/util/setup_common.h>
#include <test/util/time.h>
#include <test/util/validation.h>
+#include <util/check.h>
#include <validation.h>
#include <ranges>
### src/test/fuzz/bloom_filter.cpp
@@ -8,8 +8,8 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <uint256.h>
+#include <util/check.h>
-#include <cassert>
#include <limits>
#include <optional>
#include <vector>
### src/test/fuzz/cluster_linearize.cpp
@@ -3,13 +3,15 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <cluster_linearize.h>
+
#include <random.h>
#include <serialize.h>
#include <streams.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/util/cluster_linearize.h>
#include <util/bitset.h>
+#include <util/check.h>
#include <util/feefrac.h>
#include <algorithm>
### src/test/fuzz/coins_view.cpp
@@ -19,10 +19,10 @@
#include <test/util/coins.h>
#include <test/util/setup_common.h>
#include <txdb.h>
+#include <util/check.h>
#include <util/hasher.h>
#include <util/threadpool.h>
-#include <cassert>
#include <algorithm>
#include <cstdint>
#include <functional>
### src/test/fuzz/coinscache_sim.cpp
@@ -11,9 +11,9 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
+#include <util/check.h>
#include <util/threadpool.h>
-#include <cassert>
#include <cstdint>
#include <memory>
#include <optional>
### src/test/fuzz/connect_block.cpp
@@ -24,6 +24,7 @@
#include <test/util/time.h>
#include <txmempool.h>
#include <uint256.h>
+#include <util/check.h>
#include <validation.h>
#include <validationinterface.h>
### src/test/fuzz/connman.cpp
@@ -16,6 +16,7 @@
#include <test/fuzz/util/threadinterrupt.h>
#include <test/util/setup_common.h>
#include <test/util/time.h>
+#include <util/check.h>
#include <util/translation.h>
#include <cstdint>
### src/test/fuzz/crypto_aes256.cpp
@@ -6,8 +6,8 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <vector>
### src/test/fuzz/crypto_aes256cbc.cpp
@@ -6,8 +6,8 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <vector>
### src/test/fuzz/crypto_chacha20.cpp
@@ -7,6 +7,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <array>
#include <cstddef>
### src/test/fuzz/crypto_chacha20poly1305.cpp
@@ -8,6 +8,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstddef>
#include <cstdint>
### src/test/fuzz/crypto_common.cpp
@@ -6,9 +6,9 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <array>
-#include <cassert>
#include <cstdint>
#include <cstring>
#include <vector>
### src/test/fuzz/crypto_diff_fuzz_chacha20.cpp
@@ -6,6 +6,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstdint>
#include <vector>
### src/test/fuzz/crypto_poly1305.cpp
@@ -6,6 +6,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstdint>
#include <vector>
### src/test/fuzz/cuckoocache.cpp
@@ -3,12 +3,14 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <cuckoocache.h>
+
#include <script/sigcache.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
#include <util/byte_units.h>
+#include <util/check.h>
#include <cstdint>
#include <string>
### src/test/fuzz/dbwrapper.cpp
@@ -19,7 +19,6 @@
#include <leveldb/helpers/memenv/memenv.h>
#include <algorithm>
-#include <cassert>
#include <cstdint>
#include <deque>
#include <functional>
### src/test/fuzz/decode_tx.cpp
@@ -5,9 +5,9 @@
#include <core_io.h>
#include <primitives/transaction.h>
#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <util/strencodings.h>
-#include <cassert>
#include <cstdint>
#include <string>
#include <vector>
### src/test/fuzz/descriptor_parse.cpp
@@ -9,6 +9,7 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util/descriptor.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <util/strencodings.h>
//! The converter of mocked descriptors, needs to be initialized when the target is.
### src/test/fuzz/deserialize.cpp
@@ -29,6 +29,7 @@
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
#include <undo.h>
+#include <util/check.h>
#include <cstdint>
#include <exception>
### src/test/fuzz/difference_formatter.cpp
@@ -3,9 +3,10 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <blockencodings.h>
-#include <streams.h>
#include <random.h>
+#include <streams.h>
#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <vector>
### src/test/fuzz/fee_rate.cpp
@@ -7,6 +7,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstdint>
#include <limits>
### src/test/fuzz/feefrac.cpp
@@ -2,15 +2,17 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <util/feefrac.h>
+
#include <arith_uint256.h>
#include <policy/feerate.h>
-#include <util/feefrac.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
-#include <compare>
#include <cmath>
+#include <compare>
#include <cstdint>
#include <iostream>
### src/test/fuzz/feeratediagram.cpp
@@ -2,17 +2,15 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <cstdint>
-
-#include <vector>
-
-#include <util/feefrac.h>
#include <policy/rbf.h>
-
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
+#include <util/feefrac.h>
+
+#include <cstdint>
+#include <vector>
-#include <cassert>
namespace {
### src/test/fuzz/fees.cpp
@@ -2,13 +2,15 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <util/fees.h>
+
#include <common/messages.h>
#include <consensus/amount.h>
#include <policy/fees/block_policy_estimator.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
-#include <util/fees.h>
+#include <util/check.h>
#include <cstdint>
#include <string>
### src/test/fuzz/flatfile.cpp
@@ -3,11 +3,12 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <flatfile.h>
+
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <optional>
#include <string>
### src/test/fuzz/float.cpp
@@ -6,9 +6,9 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <util/serfloat.h>
-#include <cassert>
#include <cmath>
#include <limits>
#include <optional>
### src/test/fuzz/golomb_rice.cpp
@@ -10,10 +10,10 @@
#include <test/fuzz/util.h>
#include <test/util/random.h>
#include <util/bytevectorhash.h>
+#include <util/check.h>
#include <util/golombrice.h>
#include <algorithm>
-#include <cassert>
#include <cstdint>
#include <iosfwd>
#include <unordered_set>
### src/test/fuzz/headerssync.cpp
@@ -2,16 +2,18 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or https://opensource.org/license/mit.
+#include <headerssync.h>
+
#include <arith_uint256.h>
#include <chain.h>
#include <chainparams.h>
-#include <headerssync.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
#include <test/util/time.h>
#include <uint256.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <util/time.h>
#include <validation.h>
### src/test/fuzz/hex.cpp
@@ -10,10 +10,10 @@
#include <test/fuzz/fuzz.h>
#include <uint256.h>
#include <univalue.h>
+#include <util/check.h>
#include <util/strencodings.h>
#include <algorithm>
-#include <cassert>
#include <cstdint>
#include <string>
#include <vector>
### src/test/fuzz/http_request.cpp
@@ -13,7 +13,6 @@
#include <util/signalinterrupt.h>
#include <util/strencodings.h>
-#include <cassert>
#include <cstdint>
#include <memory>
#include <string>
### src/test/fuzz/integer.cpp
@@ -34,7 +34,6 @@
#include <util/strencodings.h>
#include <util/string.h>
-#include <cassert>
#include <chrono>
#include <limits>
#include <set>
### src/test/fuzz/key.cpp
@@ -2,8 +2,9 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <chainparams.h>
#include <key.h>
+
+#include <chainparams.h>
#include <key_io.h>
#include <outputtype.h>
#include <policy/policy.h>
@@ -20,10 +21,10 @@
#include <test/fuzz/util.h>
#include <test/util/random.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <util/strencodings.h>
#include <array>
-#include <cassert>
#include <cstddef>
#include <cstdint>
#include <numeric>
### src/test/fuzz/key_io.cpp
@@ -2,12 +2,13 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <chainparams.h>
#include <key_io.h>
+
+#include <chainparams.h>
#include <test/fuzz/fuzz.h>
#include <util/chaintype.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <string>
#include <vector>
### src/test/fuzz/locale.cpp
@@ -2,16 +2,17 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <locale>
+
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <tinyformat.h>
+#include <util/check.h>
#include <util/strencodings.h>
#include <util/string.h>
-#include <cassert>
#include <clocale>
#include <cstdint>
-#include <locale>
#include <string>
#include <vector>
### src/test/fuzz/merkle.cpp
@@ -3,14 +3,15 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <consensus/merkle.h>
-#include <test/fuzz/fuzz.h>
+
+#include <hash.h>
#include <test/fuzz/FuzzedDataProvider.h>
+#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/str.h>
+#include <util/check.h>
#include <util/strencodings.h>
-#include <hash.h>
-#include <cassert>
#include <cstdint>
#include <vector>
### src/test/fuzz/message.cpp
@@ -9,9 +9,9 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <util/strencodings.h>
-#include <cassert>
#include <cstdint>
#include <iostream>
#include <string>
### src/test/fuzz/miniscript.cpp
@@ -2,16 +2,18 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <script/miniscript.h>
+
#include <core_io.h>
#include <hash.h>
#include <key.h>
-#include <script/miniscript.h>
#include <script/script.h>
#include <script/signingprovider.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/fuzz/util/descriptor.h>
+#include <util/check.h>
#include <util/strencodings.h>
#include <algorithm>
### src/test/fuzz/muhash.cpp
@@ -2,13 +2,15 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <arith_uint256.h>
#include <crypto/muhash.h>
+
+#include <arith_uint256.h>
#include <span.h>
-#include <uint256.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <uint256.h>
+#include <util/check.h>
#include <algorithm>
#include <array>
### src/test/fuzz/multiplication_overflow.cpp
@@ -5,6 +5,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstdint>
#include <string>
### src/test/fuzz/net.cpp
@@ -2,8 +2,9 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <chainparams.h>
#include <net.h>
+
+#include <chainparams.h>
#include <net_permissions.h>
#include <netaddress.h>
#include <protocol.h>
@@ -17,6 +18,7 @@
#include <test/util/time.h>
#include <util/asmap.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <util/time.h>
#include <cstdint>
### src/test/fuzz/net_permissions.cpp
@@ -3,14 +3,15 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <net_permissions.h>
+
#include <netbase.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/fuzz/util/net.h>
+#include <util/check.h>
#include <util/translation.h>
-#include <cassert>
#include <cstdint>
#include <string>
#include <vector>
### src/test/fuzz/netaddress.cpp
@@ -3,12 +3,13 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <netaddress.h>
+
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util/net.h>
#include <test/util/random.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <vector>
### src/test/fuzz/netbase_dns_lookup.cpp
@@ -7,6 +7,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util/net.h>
+#include <util/check.h>
#include <cstdint>
#include <string>
### src/test/fuzz/node_eviction.cpp
@@ -8,9 +8,9 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/fuzz/util/net.h>
+#include <util/check.h>
#include <algorithm>
-#include <cassert>
#include <cstdint>
#include <optional>
#include <vector>
### src/test/fuzz/p2p_headers_presync.cpp
@@ -16,6 +16,7 @@
#include <test/util/setup_common.h>
#include <test/util/time.h>
#include <uint256.h>
+#include <util/check.h>
#include <validation.h>
namespace {
### src/test/fuzz/p2p_private_broadcast.cpp
@@ -15,6 +15,7 @@
#include <test/util/setup_common.h>
#include <test/util/time.h>
#include <test/util/validation.h>
+#include <util/check.h>
#include <util/time.h>
#include <validationinterface.h>
### src/test/fuzz/p2p_transport_serialization.cpp
@@ -12,9 +12,9 @@
#include <test/fuzz/util.h>
#include <test/fuzz/util/reachability.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <algorithm>
-#include <cassert>
#include <cstdint>
#include <limits>
#include <optional>
### src/test/fuzz/parse_hd_keypath.cpp
@@ -6,8 +6,8 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <util/bip32.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <vector>
### src/test/fuzz/parse_iso8601.cpp
@@ -4,9 +4,9 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <util/time.h>
-#include <cassert>
#include <cstdint>
#include <string>
#include <vector>
### src/test/fuzz/parse_numbers.cpp
@@ -3,11 +3,11 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <util/moneystr.h>
#include <util/strencodings.h>
#include <util/string.h>
-#include <cassert>
#include <cstdint>
#include <optional>
#include <string>
### src/test/fuzz/poolresource.cpp
@@ -10,6 +10,7 @@
#include <test/fuzz/util.h>
#include <test/util/poolresourcetester.h>
#include <util/byte_units.h>
+#include <util/check.h>
#include <cstdint>
#include <tuple>
### src/test/fuzz/prevector.cpp
@@ -3,10 +3,12 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <prevector.h>
+
#include <serialize.h>
#include <streams.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <ranges>
#include <vector>
### src/test/fuzz/primitives_transaction.cpp
@@ -6,6 +6,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstdint>
#include <optional>
### src/test/fuzz/private_broadcast.cpp
@@ -2,17 +2,19 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <private_broadcast.h>
+
#include <consensus/tx_check.h>
#include <consensus/validation.h>
#include <net.h>
#include <primitives/transaction.h>
-#include <private_broadcast.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/fuzz/util/net.h>
#include <test/util/setup_common.h>
#include <test/util/time.h>
+#include <util/check.h>
#include <util/overflow.h>
#include <util/time.h>
### src/test/fuzz/rolling_bloom_filter.cpp
@@ -8,8 +8,8 @@
#include <test/fuzz/util.h>
#include <test/util/random.h>
#include <uint256.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <optional>
#include <string>
### src/test/fuzz/rpc.cpp
@@ -20,12 +20,12 @@
#include <tinyformat.h>
#include <uint256.h>
#include <univalue.h>
+#include <util/check.h>
#include <util/strencodings.h>
#include <util/string.h>
#include <util/time.h>
#include <algorithm>
-#include <cassert>
#include <cstdint>
#include <cstdlib>
#include <exception>
### src/test/fuzz/script.cpp
@@ -2,6 +2,8 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <script/script.h>
+
#include <chainparams.h>
#include <compressor.h>
#include <core_io.h>
@@ -12,7 +14,6 @@
#include <rpc/util.h>
#include <script/descriptor.h>
#include <script/interpreter.h>
-#include <script/script.h>
#include <script/script_error.h>
#include <script/sign.h>
#include <script/signingprovider.h>
@@ -23,9 +24,9 @@
#include <test/fuzz/util.h>
#include <univalue.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <algorithm>
-#include <cassert>
#include <cstdint>
#include <optional>
#include <string>
### src/test/fuzz/script_descriptor_cache.cpp
@@ -8,6 +8,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstdint>
#include <optional>
### src/test/fuzz/script_flags.cpp
@@ -9,8 +9,8 @@
#include <streams.h>
#include <test/fuzz/fuzz.h>
#include <test/util/script.h>
+#include <util/check.h>
-#include <cassert>
#include <ios>
#include <utility>
#include <vector>
### src/test/fuzz/script_sign.cpp
@@ -15,9 +15,9 @@
#include <test/fuzz/util.h>
#include <test/util/transaction_utils.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <util/translation.h>
-#include <cassert>
#include <cstdint>
#include <iostream>
#include <map>
### src/test/fuzz/scriptnum_ops.cpp
@@ -6,8 +6,8 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <limits>
#include <vector>
### src/test/fuzz/secp256k1_ec_seckey_import_export_der.cpp
@@ -7,6 +7,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <cstdint>
#include <vector>
### src/test/fuzz/span.cpp
@@ -7,7 +7,6 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
-#include <cassert>
#include <cstddef>
#include <cstdint>
#include <string>
### src/test/fuzz/string.cpp
@@ -2,6 +2,8 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <util/string.h>
+
#include <blockfilter.h>
#include <clientversion.h>
#include <common/args.h>
@@ -23,12 +25,11 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
+#include <util/check.h>
#include <util/fees.h>
#include <util/strencodings.h>
-#include <util/string.h>
#include <util/translation.h>
-#include <cassert>
#include <cstdint>
#include <cstdlib>
#include <ios>
### src/test/fuzz/threadpool.cpp
@@ -2,11 +2,12 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-#include <logging.h>
#include <util/threadpool.h>
+#include <logging.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
+#include <util/check.h>
#include <atomic>
#include <future>
### src/test/fuzz/transaction.cpp
@@ -2,6 +2,8 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <primitives/transaction.h>
+
#include <chainparams.h>
#include <coins.h>
#include <consensus/tx_check.h>
@@ -11,16 +13,15 @@
#include <core_memusage.h>
#include <policy/policy.h>
#include <policy/settings.h>
-#include <primitives/transaction.h>
#include <streams.h>
#include <test/fuzz/fuzz.h>
#include <test/util/random.h>
#include <univalue.h>
#include <util/chaintype.h>
+#include <util/check.h>
#include <util/rbf.h>
#include <validation.h>
-#include <cassert>
void initialize_transaction()
{
### src/test/fuzz/tx_in.cpp
@@ -8,7 +8,6 @@
#include <streams.h>
#include <test/fuzz/fuzz.h>
-#include <cassert>
FUZZ_TARGET(tx_in)
{
### src/test/fuzz/tx_out.cpp
@@ -9,6 +9,7 @@
#include <primitives/transaction.h>
#include <streams.h>
#include <test/fuzz/fuzz.h>
+#include <util/check.h>
FUZZ_TARGET(tx_out)
{
### src/test/fuzz/txdownloadman.cpp
@@ -2,11 +2,12 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <node/txdownloadman.h>
+
#include <consensus/validation.h>
#include <node/context.h>
#include <node/mempool_args.h>
#include <node/miner.h>
-#include <node/txdownloadman.h>
#include <node/txdownloadman_impl.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
@@ -18,6 +19,7 @@
#include <test/util/time.h>
#include <test/util/txmempool.h>
#include <txmempool.h>
+#include <util/check.h>
#include <util/hasher.h>
#include <util/rbf.h>
#include <util/time.h>
### src/test/fuzz/txgraph.cpp
@@ -2,13 +2,15 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <txgraph.h>
+
#include <cluster_linearize.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/util/cluster_linearize.h>
#include <test/util/random.h>
-#include <txgraph.h>
#include <util/bitset.h>
+#include <util/check.h>
#include <util/feefrac.h>
#include <algorithm>
### src/test/fuzz/txrequest.cpp
@@ -2,12 +2,14 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <txrequest.h>
+
#include <crypto/common.h>
#include <crypto/sha256.h>
#include <crypto/siphash.h>
#include <primitives/transaction.h>
#include <test/fuzz/fuzz.h>
-#include <txrequest.h>
+#include <util/check.h>
#include <bitset>
#include <cstdint>
### src/test/fuzz/util.h
@@ -21,6 +21,7 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <uint256.h>
+#include <util/check.h>
#include <validation.h>
#include <algorithm>
### src/test/fuzz/util/mempool.cpp
@@ -2,15 +2,16 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <test/fuzz/util/mempool.h>
+
#include <consensus/amount.h>
#include <consensus/consensus.h>
#include <kernel/mempool_entry.h>
#include <primitives/transaction.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/util.h>
-#include <test/fuzz/util/mempool.h>
+#include <util/check.h>
-#include <cassert>
#include <cstdint>
#include <limits>
### src/test/fuzz/util/net.cpp
@@ -11,11 +11,11 @@
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/util.h>
#include <test/util/net.h>
+#include <util/check.h>
#include <util/sock.h>
#include <util/time.h>
#include <array>
-#include <cassert>
#include <cerrno>
#include <cstdint>
#include <cstdlib>
### src/test/fuzz/util/wallet.h
@@ -5,10 +5,11 @@
#ifndef BITCOIN_TEST_FUZZ_UTIL_WALLET_H
#define BITCOIN_TEST_FUZZ_UTIL_WALLET_H
+#include <policy/policy.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
-#include <policy/policy.h>
+#include <util/check.h>
#include <wallet/coincontrol.h>
#include <wallet/fees.h>
#include <wallet/spend.h>
### src/test/fuzz/vecdeque.cpp
@@ -2,10 +2,12 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <util/vecdeque.h>
+
#include <random.h>
#include <span.h>
#include <test/fuzz/util.h>
-#include <util/vecdeque.h>
+#include <util/check.h>
#include <cstdint>
#include <deque>
### src/test/fuzz/versionbits.cpp
@@ -2,19 +2,20 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <versionbits.h>
+
#include <chain.h>
#include <chainparams.h>
#include <common/args.h>
#include <consensus/params.h>
#include <primitives/block.h>
-#include <util/chaintype.h>
-#include <versionbits.h>
-#include <versionbits_impl.h>
-
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/versionbits.h>
+#include <util/chaintype.h>
+#include <util/check.h>
+#include <versionbits_impl.h>
#include <cstdint>
#include <limits>
### src/wallet/test/fuzz/coincontrol.cpp
@@ -2,11 +2,13 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <wallet/coincontrol.h>
+
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
-#include <wallet/coincontrol.h>
+#include <util/check.h>
#include <wallet/test/util.h>
namespace wallet {
### src/wallet/test/fuzz/coinselection.cpp
@@ -2,14 +2,16 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <wallet/coinselection.h>
+
#include <policy/feerate.h>
#include <policy/policy.h>
#include <primitives/transaction.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
-#include <wallet/coinselection.h>
+#include <util/check.h>
#include <numeric>
#include <span>
### src/wallet/test/fuzz/spend.cpp
@@ -2,6 +2,8 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <wallet/spend.h>
+
#include <addresstype.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
@@ -10,11 +12,11 @@
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <test/util/time.h>
+#include <util/check.h>
#include <util/time.h>
#include <validation.h>
#include <wallet/coincontrol.h>
#include <wallet/context.h>
-#include <wallet/spend.h>
#include <wallet/test/util.h>
#include <wallet/wallet.h>
### src/wallet/test/fuzz/wallet_bdb_parser.cpp
@@ -6,6 +6,7 @@
#include <test/fuzz/fuzz.h>
#include <test/fuzz/util.h>
#include <test/util/setup_common.h>
+#include <util/check.h>
#include <util/fs.h>
#include <util/time.h>
#include <util/translation.h>Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.