AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertions

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertions

fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4 scripted-diff: [test] Sort includes (MarcoFalke)
fa3d6b0cf1e37f87b063edc6a159f96b35701884 scripted-diff: [fuzz] Add util/check.h includes for Assert (MarcoFalke)

Pull request description:

In test code, `assert` is used. This is perfectly fine, but sometimes confusion arises, when it is unclear whether `NDEBUG` can disable the assertions, or whether to use `assert` or `Assert`.

Avoid that confusion in test code with a scripted replacement to add the util/check.h include. The changes here will also make it easier to run IWYU.

Scope: This change is only about test code (fuzz), other code can be done later, if there is need to.

ACKs for top commit:
hebasto:
ACK fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4.

Tree-SHA512: ca0d180adc67ddff2e571393dbd35345917137699e44a8b67da653e6b75419593c4b7f78229c4cd46a48973af0cae64887ae5fcb0fdade5d9f1e5415dbe288d1
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit is a routine cleanup of Bitcoin Core's fuzz test files. It adds the include for util/check.h (which provides the project's own Assert macro) and removes or reorders some standard C assert includes. The changes only affect test/fuzz code, not the live Bitcoin node software, and the commit message explicitly says the goal is to reduce developer confusion and improve automated include checking. There is no security fix or vulnerability here.

Recommended action

No action required. This is a benign refactoring commit in test-only code. It can be treated as normal maintenance.

Security signals we found

01

No security signal: change is purely include additions/removals in test code

02

No vulnerability fixed: no functional code modified

03

No attack surface introduced: fuzz tests are not part of shipped node runtime

04

No change to consensus, networking, wallet, or cryptographic code

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.