Monero

This is a small performance cleanup in Monero's wallet code. It replaces two unnecessary copies of transaction lists with references, and switches one lookup from a two-step 'check then fetch' to a single map lookup. There is no security issue visible in the change.

This commit adds a small convenience feature to Monero's remote procedure call (RPC) interface: the get_version response now tells callers which network the node is running on (mainnet, testnet, stagenet, fakechain, or unknown). It also refactors an existing inline network-name lookup into a reusable helper function. There is no security fix or behavior change that would allow an attacker to harm users or the network.

This commit adds stricter limits during deserialization of Monero transactions. It prevents attackers from sending malformed transactions with absurdly large numbers of inputs, outputs, or ring-member references, which could previously exhaust memory or CPU during parsing. The change moves some safety checks earlier in the process and makes them mandatory for all deserialization paths, not just the main transaction-parsing helpers.

This commit removes attacker-controlled HTTP header text from error and debug log messages in Monero's epee networking code. Before the change, a malicious peer or server could put fake log lines, terminal escape codes, or misleading text into HTTP headers, and those characters would be written verbatim into application logs. That could trick administrators, hide real alerts, or in some terminal setups manipulate display output. The patch replaces the raw header content in log messages with just the byte size of the offending data, so the malicious bytes are no longer echoed into logs.

This commit fixes a bug in the Monero wallet where it would partially change account tags even when some requested account numbers did not exist. Previously, the wallet checked each account number one at a time and applied the tag immediately, so an invalid account number appearing after a valid one could leave tags changed. Now all account numbers are checked first, and only if they are all valid are any tags changed. The included test confirms that an out-of-bounds account index now causes an error and leaves existing tags untouched.

This is a large code cleanup commit that reorganizes Monero's cryptographic headers to reduce how much code gets pulled in when including crypto.h. It removes a custom 'POD_CLASS' macro in favor of plain C++ structs, moves some hash-related functions from header files into a new source file, and updates many files to include only the headers they actually need. There is no direct security fix here, but the change touches sensitive cryptographic code and could in principle introduce subtle compilation or behavior differences.

This commit fixes a bug in Monero's cryptographic code where a specific function could return an uninitialized result when both input numbers (scalars) are zero. The fix explicitly sets the result to the point-at-infinity (the elliptic-curve equivalent of zero) before doing any work. The included test verifies this behavior. In cryptographic software, using an uninitialized or incorrect point could lead to wrong signatures, verification failures, or in some designs, security weaknesses, though the commit itself does not describe an active exploit.

This Monero wallet update adds safety checks when a multisig wallet imports data shared by other signers. Before, the code trusted the size and claimed signer of imported multisig data too much; now it rejects blobs with the wrong number of partial key images, wrong number of signing nonces, or a signer that does not match the file header. The change is defensive and prevents malformed or mismatched data from being processed further, but the commit message does not call it a security fix and no exploit is demonstrated.

This Monero commit hardens the multisig wallet code that combines partial key images from multiple signers. Previously, the code could silently build an incomplete or wrong composite key image if it received too few, too many, or duplicate partial components. The patch now rejects mismatched counts and duplicate/identity partial key images during import, and validates imported multisig data before it replaces the wallet's trusted state. A bad key image could let a malicious or buggy signer interfere with spending or detection of funds, so the change is a defensive security fix.

This Monero code change fixes a bookkeeping bug in how the node keeps track of which blockchain chunks (called 'spans') it has already asked other nodes to download. Before the fix, the code could reserve the same span twice for different peers, even with different block hashes, which could confuse download tracking and potentially allow a malicious peer to interfere with another peer's download reservation. After the fix, the node rejects any new reservation that conflicts with an existing one.

This Monero wallet commit adds stronger safety checks when handling unsigned, partially signed, and fully signed transactions before they are signed or broadcast. It prevents several risky situations: reusing the same coin across multiple transactions, sending change to an address that does not belong to the wallet, mismatched destination address types, and a byte-order bug when verifying encrypted payment amounts. These are defensive hardening fixes in transaction validation code paths that handle sensitive user funds.

This change stops users from starting the Monero wallet RPC server with both a global wallet password and a wallet directory mode. When running with --wallet-dir, the server can manage multiple wallets, each with its own password. Supplying a single --password in that mode could have caused the password to be applied to all wallets or otherwise weaken security expectations. The patch now rejects that combination and updates shell tab-completion to reflect the restriction.

This change moves an error check earlier in the Monero wallet's 'generate wallet from keys' RPC command. Previously, the code would create a wallet file before checking whether the requested seed language was valid. Now it checks the language first and refuses to proceed if it's invalid. The main risk is that a user or attacker could supply a bad language and leave behind a partially-created wallet file or trigger unexpected behavior. The fix is straightforward and defensive, and the test confirms the invalid language is now rejected before any file is written.

This commit changes one line in Monero's wallet API. When recovering a wallet from a hardware device fails, the code now marks the error as 'critical' rather than just a regular error. This is a status/severity classification change, not a fix for a code vulnerability. It may help downstream callers notice recovery failures more clearly, but it does not by itself prevent or enable any attack.

This is a tiny code cleanup in Monero's wallet RPC server. The code was accidentally reusing the wrong response variable when checking whether background mining started successfully. The fix makes it use the correct response variable, so error messages and status checks are accurate. There is no security vulnerability here—just a bug fix that prevents misleading log output.

This commit adds a safety check in the Monero wallet software. When the wallet asks a remote node (daemon) for specific transaction data, it now verifies that the daemon actually returned the exact transactions that were requested, in the correct order. Before this change, a malicious or buggy daemon could potentially return the wrong transactions, which the wallet might then process as if they were the right ones. This could lead to incorrect balance calculations, failed transactions, or other wallet confusion.