What changed, and why it matters
This tiny change stops Monero nodes from cutting off network peers when a previously accepted transaction expires from the memory pool. Before the patch, an expired transaction could be treated as a peer offense and trigger a peer drop, which could be abused to isolate or partition nodes from the network. The fix marks the transaction validation result as 'no drop offense' so the peer connection is preserved.
Apply the patch. Monitor for related follow-up fixes in peer-disconnection logic, and consider whether other tvc failure paths should also set m_no_drop_offense to avoid similar peer-drop side effects.
Security signals we found
Peer-disconnection suppression for non-malicious transaction expiration
Potential network-partitioning / eclipse-attack vector if peers are dropped for expired transactions
Single-line behavioral change in transaction validation result handling
Evidence from the diff
In src/cryptonote_core/tx_pool.cpp, when a transaction in the pool expires and is later re-evaluated, the code sets tvc.m_verifivation_failed = true. That failure path could be interpreted by peer-handling logic as a reason to drop the peer that relayed the transaction. The patch adds tvc.m_no_drop_offense = true to the same validation context, suppressing peer disconnection for this specific timeout case. This is a hardening/network-stability fix rather than a cryptographic or consensus bug.
Changed components
src/cryptonote_core/tx_pool.cppMonero transaction pool / mempoolPeer connection managementInspect captured patch +1 / −0
### src/cryptonote_core/tx_pool.cpp
@@ -185,6 +185,7 @@ namespace cryptonote
// not clear if we should set that, since verifivation (sic) did not fail before, since
// the tx was accepted before timing out.
tvc.m_verifivation_failed = true;
+ tvc.m_no_drop_offense = true;
return false;
}
Why this scored 38/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.