AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 51 Cryptographic libraries

Merge pull request #11388

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11388

742bc14 src: fix more cases of missing memory wipes (jpk68)

ACKs: selsta, SNeedlewoods
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes places where sensitive secret data (private key material and one-time derivation scalars) was left in memory after use instead of being securely erased. In three files, the patch adds explicit memory wipes or switches a temporary buffer to a locked, auto-scrubbing container. If an attacker could read the process's memory or capture a core dump, leftover secret values could leak. The patch is defensive and partial—it addresses additional cases beyond an earlier fix, suggesting the project is still finding spots that were missed.

Recommended action

Treat as a security-hardening fix with defensive value. Review whether all other secret-holding local variables in these call paths are wiped, and consider static analysis or code review for remaining missing memwipe() sites. No immediate emergency response is indicated because exploitation requires memory-read access, but the fix should be included in releases promptly.

Security signals we found

01

Adds memwipe() for secret scalars after cryptographic use

02

Replaces stack buffer with mlocked+scrubbed container for subaddress secret derivation input

03

Wipes Borromean signature ai nonces after proof generation

04

Commit message frames change as 'fix more cases of missing memory wipes', implying prior incomplete remediation

05

Touches private-key derivation paths in crypto.cpp and device_default.cpp

Risk score

Why this scored 51/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 10/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.