BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3170 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

318security candidates668second-pass queue3006AI analyses
148commits · 30 days
328commits · 60 days
1301commits · 180 days
2862commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
1175Strong · 80–100
1206Adequate · 60–79
701Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script2024588389
Antoine Poinsot22422170
Ava Chow19868191069
MarcoFalke41421408074
fanquake23121228058
Lőrinc18121177081
Hennadii Stepanov22316211064
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 31 minutes ago

Low 32 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…

Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
ed7dd7cfby Ava Chow+36−203 files
No security note in commit
Low 28 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…

New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
f80aaf4bby Ava Chow+303−7930 files
No security note in commit
Moderate 64 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding output

This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …

Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
e19f83e9by Ava Chow+37−82 files
Vendor flagged security relevance
Low 35 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35696: i2p: update leaseset encryption types

This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…

Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
65e075f8by Ava Chow+2−21 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35948: init: correct first-run disk space estimate

This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…

d26f19c7by Ava Chow+5−42 files
No security note in commit
Low 44 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …

Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
e8e7e91aby Ava Chow+43−14 files
No security note in commit
Informational 18 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md

This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…

No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
bfdcd979by merge-script+2−21 file
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35675: mining: add block template manager

This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…

Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
5c726f20by Ryan Ofsky+561−44926 files
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)

This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …

New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
be5d0b55by Ava Chow+6951−010 files
No security note in commit
Low 45 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35440: wallet: check descriptor cache xpub length before decoding

This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…

Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
b3f846ecby Ava Chow+225−8511 files
Vendor flagged security relevance
Informational 20 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35813: wallet, rpc: Add listrawtransactions RPC

This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…

No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
2b95b45aby Ava Chow+334−276 files
No security note in commit
Moderate 68 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35752: wallet: make encryption state updates atomic

This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …

Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
7ee3d622by Ava Chow+379−16418 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35619: test: ExtendedPrivateKey follow-ups

This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …

248ce46fby merge-script+18−244 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36261: test: cover PSBT unknown field merging

This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…

bbc40edeby merge-script+130−01 file
No security note in commit
Informational 18 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36230: wallet: Improve `HasWalletDescriptor` performance and other canonical descriptor string followups

This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…

No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
4a583f38by merge-script+97−429 files
No security note in commit
Informational 21 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…

OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
5f05d8c5by merge-script+6−63 files
No security note in commit
Informational 20 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

rpc: Correct OpenRPC default metadata

This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…

No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
b7f740c5by will+6−63 files
No security note in commit
Informational 24 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36286: crypto: Fix MuHash3072 division by itself

This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…

Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
d48e76e6by merge-script+11−13 files
No security note in commit
Informational 18 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36285: refactor: Use static const over inline const to work around ld64 bug

This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures…

No security-relevant code logic changedChange is a linker bug workaround, not a vulnerability fixConstants remain read-only; no new attack surface introduced
ad97933aby merge-script+8−82 files
No security note in commit
Informational 23 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34861: wallet: Add importdescriptors interface

This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the mini…

Refactor of security-sensitive wallet import code into shared CWallet pathNew input validation: negative timestamps rejected for importdescriptorsCentralization of descriptor range bound checks in CheckDescriptorRangeBounds
2bbbeaa6by Ava Chow+619−26415 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityqa: Support `get_bind_addrs` and `feature_bind_extra` on illumosby Hennadii Stepanov · f4a6d079 · Jun 29, 2026 · 1 fileMessage 65 · AdequateInformational 16Details
Commit message · Hennadii Stepanov

qa: Support `get_bind_addrs` and `feature_bind_extra` on illumos

This extends support for `get_bind_addrs` and `feature_bind_extra` to
illumos-based OSes.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 16/100

This is a small test-only change that lets Bitcoin Core's internal test tools recognize the illumos operating system (reported as 'sunos5') when listing network addresses and interfaces. It does not change the Bitcoin node software itself, does not touch wallet or consensus code, and has no direct security relevance.

Lower-priorityqa: Drop OpenBSD from supported platforms in `get_bind_addrs` functionby Hennadii Stepanov · 4cb7f39c · Jun 29, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

qa: Drop OpenBSD from supported platforms in `get_bind_addrs` function

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a small test-only change. A helper function used by Bitcoin Core's automated tests is being updated to no longer claim OpenBSD as a supported platform, because OpenBSD does not include the 'lsof' tool that the function relies on. It does not change the Bitcoin Core software that users run, nor does it fix or introduce a security vulnerability.

Lower-prioritydoc: Add `lsof` to Test Suite Dependencies on FreeBSDby Hennadii Stepanov · 1c173556 · Jun 29, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

doc: Add `lsof` to Test Suite Dependencies on FreeBSD

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply updates the FreeBSD build documentation to add the `lsof` utility to the list of packages needed to run the test suite. It is a documentation-only change with no code modifications and no security implications.

Lower-priorityqa: Add `skip_if_no_lsof_on_nonlinux` helper and use it where neededby Hennadii Stepanov · 8a982eea · Jun 29, 2026 · 3 filesMessage 83 · StrongInformational 15Details
Commit message · Hennadii Stepanov

qa: Add `skip_if_no_lsof_on_nonlinux` helper and use it where needed

Some functional tests on non-Linux platforms rely on the `lsof` utility.
However, we treat all other functional test dependencies, such as
additional Python modules, as optional, and skip dependent tests if
those are unavailable.

This change makes `lsof` optional as well.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a harmless test-suite maintenance change. It adds a helper that skips certain Bitcoin Core functional tests on non-Linux systems when the 'lsof' tool is missing. It does not change the actual Bitcoin node software, network rules, wallet handling, or any code that processes untrusted data.

AI review queuedtest: ensure HTTPServer race condition is fixedby Matthew Zipkin · f595daf1 · Jun 29, 2026 · 1 fileMessage 90 · StrongLow 42Details
Commit message · Matthew Zipkin

test: ensure HTTPServer race condition is fixed

The result of WriteReply() losing the race condition would prevent any
new requests being read from the socket. The socket error test
sent 3 requests all at once after connecting, so in this commit
we separate the the third request to make the losing race
condition more likely, and make its effect more obvious.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Low 42/100

This commit only changes a test file. It strengthens an existing test for the Bitcoin Core HTTP server so it can better catch a race condition where the server might stop reading new requests from a connection. The commit itself does not change the actual server code, so it is not a fix—it is a test that checks whether a previously suspected race condition is truly fixed.

Lower-prioritytest: introduce a worker thread in http socket error testby Matthew Zipkin · b98b10c0 · Jun 29, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Matthew Zipkin

test: introduce a worker thread in http socket error test

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This is a test-only change. It updates a single unit test file to run the HTTP request handler on a separate worker thread instead of handling it synchronously. There is no change to production code, no security fix, and no vulnerability.

Lower-prioritytest: socket error handling in HTTPServer using ErrorSock mock socketby Matthew Zipkin · 922b08d3 · Jun 29, 2026 · 3 filesMessage 100 · StrongInformational 14Details
Commit message · Matthew Zipkin

test: socket error handling in HTTPServer using ErrorSock mock socket

Implements a child class of DynSock which is used as the mock
socket for HTTPServer unit tests. The ErrorSock::Send() method
raises a non-permanent error on the first HTTPRequest::WriteReply()
and then succeeds after the second.

In httpserver_tests.cpp use this mechanism to ensure that the
server retries a send operation if such an error is encountered,
and cover both optimistic (worker thread WriteReply()) and
non-optimistic (I/O thread SocketHandlerConnected()) send paths.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 14/100

This commit only adds new unit tests for the Bitcoin Core HTTP server. It creates a fake network socket that sometimes returns a 'try again' error, then verifies the server retries and still sends all replies. No production code is changed, so it cannot introduce a security vulnerability or fix one in running software.

AI review queuedhttp: prevent race condition between worker thread and I/O threadby Matthew Zipkin · 73da2a8a · Jun 29, 2026 · 2 filesMessage 73 · AdequateModerate 62Details
Commit message · Matthew Zipkin

http: prevent race condition between worker thread and I/O thread

This prevents a losing race condition that could prevent the server
from reading requests from an HTTP client.

A connected socket can either be written to or read from based on the
result of GenerateWaitSockets(). That method checks the HTTPRemoteClient
flag m_send_ready. If it's `true` the implication is that there is
data in the client's send buffer ready to go. Once that data is sent
and the buffer is empty, MaybeSendBytesFromBuffer() sets it `false` again.

The sad case was when a worker thread calling WriteReply() adds
data to the send buffer, but before it sets m_send_ready to `true`,
the I/O thread sends that data and empties the buffer. With the
buffer unexpectedly empty, WriteReply() sets m_send_ready to `true`.

The effect of this is that the socket will stay in "write" mode
with nothing to write. With nothing to write, MaybeSendBytesFromBuffer()
never sets it back to `false` and the socket is stuck forever.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 62/100

This commit fixes a subtle timing bug in Bitcoin Core's built-in HTTP server. Under a specific race between a worker thread preparing a response and the I/O thread sending data, a connection could get permanently stuck waiting to write even though there was nothing left to send. Once stuck, the server would stop reading new requests from that client, effectively hanging the connection. The fix moves the 'ready to send' flag update under the same lock as the send buffer and protects reads of that flag with a separate lock to avoid deadlocks.

AI review queueddepends: add openbsd_LDFLAGSby fanquake · 5404b620 · Jun 29, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · fanquake

depends: add openbsd_LDFLAGS

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adds an empty placeholder for OpenBSD linker flags in the dependency build system. It is a build configuration change with no functional or security effect visible in the diff.

Lower-priorityci: add openBSD cross CI jobby fanquake · d64ea158 · Jun 29, 2026 · 3 filesMessage 57 · ThinInformational 15Details
Commit message · fanquake

ci: add openBSD cross CI job

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds a new automated build test for Bitcoin Core that cross-compiles for OpenBSD. It downloads official OpenBSD system files from the OpenBSD project's own download server and sets up the build environment. There is no change to the Bitcoin Core software itself, no user-facing feature, and no security fix or vulnerability.

AI review queuedwallet: Replace CWalletTx's vOrderForm with specific fieldsby Ava Chow · fed3cf6f · Jun 27, 2026 · 6 filesMessage 73 · AdequateInformational 18Details
Commit message · Ava Chow

wallet: Replace CWalletTx's vOrderForm with specific fields

vOrderForm contained 2 kinds of strings: BIP 21 messages, and BIP 70
Payment Requests. Instead of having both inside of a single vOrderForm
field that is opaque, split them into separate std::vector<std::string>
to contain this metadata.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit is a straightforward internal cleanup in Bitcoin Core's wallet code. It replaces a single mixed-purpose data field called vOrderForm with two clearer fields: one for BIP 21 payment messages and one for BIP 70 payment requests. The change preserves existing wallet data and behavior, and does not appear to fix or introduce a security vulnerability.

AI review queuedwallet: Drop vOrderForm from CommitTransactionby Ava Chow · 4f8823e8 · Jun 27, 2026 · 8 filesMessage 68 · AdequateInformational 18Details
Commit message · Ava Chow

wallet: Drop vOrderForm from CommitTransaction

This parameter is only used to pass in the "Messages" from the GUI.
Instead of making it opaque by putting those into vOrderForm, use a
specific dedicated parameter for providing the messages.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This is a routine code cleanup in Bitcoin Core's wallet. It changes how optional 'message' fields from payment URIs are passed through the wallet when committing a transaction, replacing a generic 'order form' container with explicit named parameters. There is no security fix or vulnerability here.

Lower-priorityfuzz: restore CreateSock in PCP targetsby Hao Xu · a0e5e300 · Jun 27, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · Hao Xu

fuzz: restore CreateSock in PCP targets

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit fixes a small cleanup issue in Bitcoin Core's internal fuzz testing code. Fuzz tests are automated tools that feed random data into functions to find bugs; they are not part of the live Bitcoin network software. The change saves the original socket-creating function before replacing it with a fake one, then restores it afterward. This prevents one fuzz test from accidentally leaving its fake socket in place for later tests. There is no indication this affects real users, wallets, nodes, or the live Bitcoin network.

Security candidatescripted-diff: Rename `StatusLevel::{INFO,WARN,ERR}`by Hennadii Stepanov · 41ceea40 · Jun 27, 2026 · 2 filesMessage 83 · StrongInformational 17Details
Commit message · Hennadii Stepanov

scripted-diff: Rename `StatusLevel::{INFO,WARN,ERR}`

The `ERR` macro is defined on illumos-based systems in the `regset.h`
header included by the Boost.Test framework, which may cause a
compilation error.

-BEGIN VERIFY SCRIPT-

ren() { sed -i "s/\<$1\>/$2/g" $( git grep -l "$1" ./src/qt/psbtoperationsdialog.* ) ; }
ren StatusLevel::INFO StatusLevel::Info
ren INFO Info
ren StatusLevel::WARN StatusLevel::Warn
ren WARN Warn
ren StatusLevel::ERR StatusLevel::Error
ren ERR Error

-END VERIFY SCRIPT-

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 17/100

This is a straightforward code cleanup change that renames three internal status labels (INFO, WARN, ERR) to different capitalisation (Info, Warn, Error) because one of those names clashed with a system macro on illumos operating systems when running tests. It does not change program logic, user-facing behaviour, or security properties. It only prevents a possible build failure on an uncommon platform.

Lower-priorityscripted-diff: Rename `Sock::{RECV,SEND,ERR}`by Hennadii Stepanov · f395acde · Jun 27, 2026 · 13 filesMessage 78 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

scripted-diff: Rename `Sock::{RECV,SEND,ERR}`

The `ERR` macro is defined on illumos-based systems in the `regset.h`
header included by the Boost.Test framework, which causes a compilation
error.

-BEGIN VERIFY SCRIPT-

ren1() { sed -i "s/\<$1\>/$2/g" $( git grep -l "$1" ./src/util/sock.* ./src/httpserver.h ) ; }
ren1 RECV RecvEvent
ren1 SEND SendEvent
ren1 ERR ErrorEvent

ren2() { sed -i "s/\<$1\>/$2/g" $( git grep -l "$1" ./src/ ) ; }
ren2 Sock::RECV Sock::RecvEvent
ren2 Sock::SEND Sock::SendEvent
ren2 Sock::ERR Sock::ErrorEvent

-END VERIFY SCRIPT-

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit is a simple rename of three internal constants used by Bitcoin Core's socket-handling code. The old names (RECV, SEND, ERR) clashed with a macro named ERR on illumos-based operating systems, preventing the software from compiling. The new names (RecvEvent, SendEvent, ErrorEvent) avoid that clash. There is no change to program logic, behavior, or security.

Lower-priorityutil, refactor: Rename local `ERR` in `Sock::Accept`by Hennadii Stepanov · 7ac25c91 · Jun 26, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

util, refactor: Rename local `ERR` in `Sock::Accept`

The local `static constexpr auto ERR` shadowed the `Sock::ERR` static
data member. Rename it to `accept_error`, per the Developer Notes'
shadowing guidance.

Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a simple code cleanup change: a local constant named ERR inside one function was renamed to accept_error because it happened to have the same name as a class-level constant. The rename avoids confusion for programmers but does not change any program behavior or fix a security problem.

Lower-priorityci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCEby MarcoFalke · bbbbab86 · Jun 26, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · MarcoFalke

ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This is a routine Continuous Integration (CI) configuration update. It changes the version of the Linux container used for one automated test job and adds a compiler flag to work around a known build issue. There is no change to the Bitcoin Core software that users run, and no security vulnerability is being fixed or introduced.

Lower-prioritylog: expose -logratelimit optionby Lőrinc · 095596dd · Jun 26, 2026 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · Lőrinc

log: expose -logratelimit option

The existing `-logratelimit` option can disable log rate limiting, but it is hidden from ordinary help because it is registered as `DEBUG_ONLY`.
Expose it in normal help so users affected by log suppression can discover the supported runtime knob.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit simply makes an existing command-line option, -logratelimit, visible in the normal help output. It does not change how the option works, what it protects against, or any code behavior. It is a documentation/usability change only.

AI review queuedscript: qa: Improve Key::Fingerprint type safetyby David Gumberg · c9a70f93 · Jun 26, 2026 · 11 filesMessage 45 · ThinInformational 18Details
Commit message · David Gumberg

script: qa: Improve Key::Fingerprint type safety

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit is a code-quality refactor, not a security fix. It replaces raw 4-byte fingerprint arrays with a named std::array type (KeyFingerprint) and adds helper methods to copy fingerprints safely. The behavior of fingerprint handling is unchanged; the change only makes the code easier to maintain and less prone to future mistakes.

Lower-prioritynanobench: fix perf counter buffer initby Lőrinc · b6b1d065 · Jun 26, 2026 · 1 fileMessage 88 · StrongInformational 18Details
Commit message · Lőrinc

nanobench: fix perf counter buffer init

The perf counter read buffer comment says the vectors start with three metadata slots, but brace initialization creates one element with value 3.
Normal benchmark construction usually hides this because successful `monitor()` calls resize the buffers before `updateResults()`, while failed setup sets `mHasError` before the indexed reads.
Initialize the vectors with the size constructor so a default-constructed `LinuxPerformanceCounters` object satisfies the `read_format` invariant instead of relying on that construction path.
Reproducer: https://godbolt.org/z/scE8rMd8Y

88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 18/100

This is a small bug fix in Bitcoin Core's internal benchmarking header (nanobench). The code intended to create three empty placeholder slots in some performance-counter buffers, but accidentally created a single slot containing the number 3. Under normal use this gets corrected before it matters, but a default-constructed object could read past the single element. It is a correctness/reliability fix in benchmark tooling, not a network-facing security vulnerability.

Lower-prioritytest: add interface_gui.py to test bitcoin-gui startup via RPCby Ryan Ofsky · aa01721c · Jun 25, 2026 · 8 filesMessage 95 · StrongInformational 15Details
Commit message · Ryan Ofsky

test: add interface_gui.py to test bitcoin-gui startup via RPC

Adds a functional test that starts bitcoin-gui (via the bitcoin wrapper
with "gui" subcommand) using QT_QPA_PLATFORM=minimal for headless
operation, then verifies it responds to a stop RPC call. This catches
startup regressions in the GUI that have no CI coverage today.

Extends the test framework to support use_gui=True in TestNode, which
invokes "bitcoin gui" instead of "bitcoin node" and automatically sets
QT_QPA_PLATFORM=minimal. Adds BUILD_GUI to test/config.ini.in and
is_gui_compiled()/skip_if_no_gui() helpers to BitcoinTestFramework.

Co-Authored-By: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit adds a new automated test that starts the Bitcoin GUI in a headless mode and checks it can be shut down by a remote command. It also makes a small code change so the GUI does not try to load custom fonts when running in the minimal headless Qt platform. There is no security vulnerability here; it is purely a testing and robustness improvement.

Lower-prioritycmake: Remove `SelectLibraryConfigurations` from `FindQRencode` moduleby Hennadii Stepanov · 829255c8 · Jun 25, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

cmake: Remove `SelectLibraryConfigurations` from `FindQRencode` module

Co-authored-by: Daniel Pfeifer <daniel@pfeifer-mail.de>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a minor cleanup of the CMake build script used to locate the QR code encoding library. It removes an unnecessary helper function and simplifies how the library target is created. There is no indication this change fixes or introduces a security problem.

Lower-prioritydepends: Remove unused `lib/pkgconfig` in `qrencode` packageby Hennadii Stepanov · 5c55606d · Jun 25, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

depends: Remove unused `lib/pkgconfig` in `qrencode` package

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a minor cleanup change in Bitcoin Core's build system. It removes an unused 'pkgconfig' metadata directory left over after building the qrencode (QR code generation) dependency. There is no security issue here.

Lower-prioritycmake: Drop optional `PkgConfig` use in `FindQRencode` moduleby Hennadii Stepanov · 402ba10b · Jun 25, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

cmake: Drop optional `PkgConfig` use in `FindQRencode` module

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit removes an optional way CMake can locate the QR code library (libqrencode). Previously, the build system could use pkg-config to find the library's location and version. Now it will rely only on CMake's standard search paths. There is no security-relevant change here; it is a build-system simplification.

Lower-prioritydoc: add send RPC release noteby Sjors Provoost · 8ebfff0f · Jun 25, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Sjors Provoost

doc: add send RPC release note

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is a documentation-only release note. It announces that two wallet commands, `send` and `sendall`, are no longer considered experimental. There is no code change, no bug fix, and no security issue in the commit itself.