clusterlin: reserve the suboptimal-chunk queue up front
What the developer wrote
Authored by Pieter Wuille
clusterlin: reserve the suboptimal-chunk queue up front
Reserve capacity for one entry per transaction in m_suboptimal_chunks at
construction time, avoiding repeated reallocations while MakeTopological
and StartOptimizing fill the queue.
What changed, and why it matters
This is a routine performance improvement, not a security fix. It pre-allocates memory for an internal queue so the program doesn't waste time repeatedly resizing it while building a data structure. There is no user-facing or security-relevant change.
No security action needed; treat as a normal performance/refactoring commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit adds a single reserve() call for m_suboptimal_chunks in the constructor of a cluster-linearization data structure in Bitcoin Core. This reserves capacity equal to the number of transactions up front, avoiding repeated vector reallocations as MakeTopological and StartOptimizing populate the queue. It is a pure optimization with no functional or security behavior change.
Changed components
src/cluster_linearize.hInspect captured patch +1 / −0
diff --git a/src/cluster_linearize.h b/src/cluster_linearize.h
index eb9da60a..aa28d046 100644
--- a/src/cluster_linearize.h
+++ b/src/cluster_linearize.h
@@ -1183,6 +1183,7 @@ public:
m_tx_data.resize(depgraph.PositionRange());
m_set_info.resize(num_transactions);
m_reachable.resize(num_transactions);
+ m_suboptimal_chunks.reserve(num_transactions);
size_t num_chunks = 0;
size_t num_deps = 0;
for (auto tx_idx : m_transaction_idxs) {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.