fuzz: Remove unused `DeserializeFromFuzzingInput` params overload
What the developer wrote
Authored by Hennadii Stepanov
fuzz: Remove unused `DeserializeFromFuzzingInput` params overload
This overload has been unused since it was added in fac81affb527132945773a5315bd27fec61ec52f.
What changed, and why it matters
This commit simply removes an unused helper function inside Bitcoin Core's fuzz testing code. Fuzz tests are internal developer tools used to find bugs, not code that runs on live Bitcoin nodes or wallets. There is no security-relevant change to production behavior.
No action needed; routine cleanup of unused fuzz-test code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The deleted overload of DeserializeFromFuzzingInput accepted a params object and called params(obj). It was only reachable from fuzz harnesses in src/test/fuzz/deserialize.cpp and had no callers since it was introduced. Removing dead code reduces maintenance surface but does not alter consensus, networking, wallet, or serialization logic used in production.
Changed components
src/test/fuzz/deserialize.cppInspect captured patch +0 / −11
diff --git a/src/test/fuzz/deserialize.cpp b/src/test/fuzz/deserialize.cpp
index 8e8ab53e..63db20b6 100644
--- a/src/test/fuzz/deserialize.cpp
+++ b/src/test/fuzz/deserialize.cpp
@@ -73,17 +73,6 @@ T Deserialize(DataStream&& ds, const P& params)
return obj;
}
-template <typename T, typename P>
-void DeserializeFromFuzzingInput(FuzzBufferType buffer, T&& obj, const P& params)
-{
- try {
- SpanReader{buffer} >> params(obj);
- } catch (const std::ios_base::failure&) {
- throw invalid_fuzzing_input_exception();
- }
- assert(buffer.empty() || !Serialize(obj, params).empty());
-}
-
template <typename T>
DataStream Serialize(const T& obj)
{
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.