TZ
← All projectsTrezor

Trezor firmware

Firmware monorepo for Trezor One, Model T, and Safe devices.

BitcoinHardware walletsNormal
Repository coverage

3237 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

1126security candidates372second-pass queue2926AI analyses
286commits · 30 days
706commits · 60 days
1648commits · 180 days
2690commits · 365 days
Backfill bands
Aug 5 → Feb 61298 seen115 candidatesComplete
Feb 6 → Jun 6775 seen58 candidatesComplete
Jun 6 → Jul 6217 seen13 candidatesComplete
Jul 6 → Aug 5360 seen54 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

67/100 average clarity
639Strong · 80–100
1553Adequate · 60–79
1038Thin · 40–59
7Opaque · 0–39
1security candidate with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
tychovrahe343134322564
Roman Zeyde676214620372
obrusvit25796236364
PrisionMike10866106272
Andrew Kozlik833481268
Petr Susil202299
Jakub Janků591838180
Martin Pastyřík26823173
cepetr264106222059
M1nd3r24689227071
Ioan Bizău23076230059
Lukas Bielesch856784067
Analysis record

Published AI watches

Last scanned 54 minutes ago

Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): improvements to English copy

This commit is a routine text cleanup for the Trezor hardware wallet's on-screen English messages. It fixes punctuation, removes unnecessary line breaks, and makes small wording tweaks (for example, changing 'PIN will be required' to 'A PI…

1dbc2c3cby Michal Kazda+22−422 files
No security note in commit
Moderate 59 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(core): app root packet downgrade protection

This commit adds downgrade protection for a new 'app root packet' system in Trezor firmware. Previously, the code had a TODO note saying downgrade protection needed to be considered. The change makes the device remember the timestamps of p…

Replaces a TODO comment ('!@# TODO: Consider downgrade protection') with concrete timestamp-based anti-downgrade checksAdds per-ring timestamp state to prevent rollback of root-of-trust packetsAdds chain_timestamp field and 90-day drift bound to root packet format
4a9cf168by cepetr+335−3112 files
No security note in commit
Moderate 67 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(core/rust): discard low-order keys in THP handshake

This commit fixes a cryptographic edge case in Trezor's THP (Trezor Host Protocol) handshake. It now rejects Curve25519 public keys that are all zeros or that produce an all-zero shared secret. A zero public key can cause the Diffie-Hellma…

Curve25519 zero/low-order public key rejection added to DHZero shared-secret output rejected after scalar multiplicationHandshake state machine now transitions to Failed on initiation-response error
429a283dby M1nd3r+45−74 files
No security note in commit
Informational 11 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(core): enable `ward` with `miniscript`

This commit changes one line in a build configuration file for the Trezor hardware wallet firmware. It adds the 'ward' feature to the existing 'miniscript' feature set. There is no direct evidence in the commit that this is a security fix;…

Single-line Cargo.toml feature flag changeNo code logic modificationNo changelog or security note in commit message
d434a636by Jakub Janků+1−11 file
No security note in commit
Informational 15 AI analysisMessage 80 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(core): add `ward` feature flag

This commit adds a new disabled-by-default feature flag called 'ward' to the Trezor firmware build system. It does not change any production firmware behavior; it only wires up a placeholder MicroPython module and build options so that fut…

New feature flag is disabled by default and gated behind optional Cargo featuresCommit message explicitly states intent to exclude WARD from production firmware buildsNew MicroPython module is a stub with no exported functions beyond __name__
7b58e75aby Jakub Janků+55−018 files
No security note in commit
Low 27 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(core): enable -Wsign-compare

This commit turns on a compiler warning (-Wsign-compare) that catches places where signed and unsigned numbers are compared, and fixes the resulting warnings across the Trezor firmware. Most changes are clean-up casts and loop-index type c…

Compiler warning -Wsign-compare enabled, indicating prior signed/unsigned comparison issuesI/O return-value checks hardened against negative ssize_t values being treated as successPython binding offset/length validation tightened in Monero crypto module
1cc940a4by cepetr+162−15247 files
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core): merge passphrase__access_hidden_wallet into passphrase__access_wallet

This commit is a simple user-interface cleanup. It removes one duplicate translation label ('Access hidden wallet') and makes the device use a single, consistent label ('Access wallet') when asking the user to confirm opening a passphrase-…

65402aecby Michal Kazda+2−103 files
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core): merge passphrase__hidden_wallet into passphrase__wallet

This commit is a simple user-interface cleanup. It merges two translation labels that both meant 'Passphrase wallet' into a single label, and updates the screens that used the old duplicate label. There is no security-relevant behavior cha…

7ce6887fby Michal Kazda+5−184 files
No security note in commit
Low 45 AI analysisMessage 85 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(core/bootloader): keep the full block length for block-0 retries

This commit fixes a bug in the Trezor bootloader's firmware-update code. When updating firmware, the first block of data is fetched in two pieces: a small initial 'header prefetch,' then the rest. If a communication error happened and the …

Firmware update reliability bug in bootloaderBlock-0 retry path truncated data before hash verificationHash mismatch caused by buffer offset/size mismatch, not by attacker
dc937ba2by tychovrahe+81−711 file
No security note in commit
Informational 12 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core/bootloader): separate image upload and image checks

This commit is a code cleanup in the Trezor bootloader. It moves the generic, image-type-agnostic parts of firmware upload (chunk receiving, retry logic, flash erasing/writing, timeouts) into a new reusable module called wf_image_upload.c,…

Refactor only: logic moved, not changed in security-relevant waysSame signature/version/model/downgrade checks remain in firmware-specific handlerSame flash erase/write sequence preserved in generic engine
caab7d9eby tychovrahe+772−4834 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove unused trezor_lib/ui feature

This commit removes an unused Rust Cargo feature flag called 'ui' from the Trezor firmware build configuration. It is a cleanup change: the feature was always enabled in practice, so the code now compiles unconditionally. There is no secur…

1436fbc6by cepetr+2−158 files
No security note in commit
Low 27 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(core/caesar): change confirm middle button

This commit changes how users confirm an Ethereum authorization screen on Trezor's 'Caesar' layout. Previously, the user had to hold down a button to approve; now a simple tap is enough. The change only affects the user-interface interacti…

UI confirmation gesture changed from hold-to-confirm to tap-to-confirmOnly affects EIP-7702 authorization flow on Caesar (T3B1) layoutTest fixture hashes updated for all supported languages
e231cc94by obrusvit+50−502 files
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core): merge firmware and unix cargo packages

This commit is a routine internal cleanup that merges two separate build packages (one for real hardware firmware and one for the desktop emulator) into a single package. It moves source files into subdirectories and updates build scripts …

6be32440by cepetr+48−32025 files
No security note in commit
Informational 15 AI analysisMessage 67 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): test aes gcm only if enabled

This commit is a minor build/test maintenance change. It adds a feature flag (USE_AES_GCM) so that AES-GCM tests are only run when the feature is actually enabled in a particular firmware build. There is no security fix or vulnerability be…

890aca93by cepetr+13−14 files
No security note in commit
Informational 15 AI analysisMessage 95 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(python, tests): add and update GNU licence headers

This commit only adds or updates copyright and GNU license header comments in Python test and tooling files. It makes no changes to executable code, so it cannot introduce a security vulnerability or fix one.

6dc781c2by M1nd3r+1202−203250 files
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core): move the multisig XPUB title into a translation template

This commit is a straightforward code cleanup: it moves the on-screen title for multisig XPUB screens from hard-coded English text into the device's translation system. The visible text remains essentially the same, and there is no securit…

6d69df16by Michal Kazda+20279−2023911 files
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core/bolt): remove unneeded `use` statements

This commit simply removes two unused Rust import statements (called `use` statements). It does not change any actual code behavior, logic, or security properties of the Trezor firmware.

a56f8c3dby Roman Zeyde+0−22 files
No security note in commit
Informational 18 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(core): add missing colon in Tron

This commit fixes a UI formatting bug in the Tron cryptocurrency flow on Trezor hardware wallets. A missing colon was added to account information labels shown on the device screen. The change is cosmetic and does not appear to affect cryp…

UI label formatting fix onlyNo changes to signature verification, key handling, or transaction authorizationNo buffer size, memory allocation, or input validation changes observed
739c2968by Michal Kazda+19332−193364 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(core): combine path/account with labels

This commit is a straightforward user-interface refactoring. It bundles an account/path label together with its corresponding value into a single tuple, instead of passing them as four separate arguments. There is no security-relevant chan…

c66f6f4dby Michal Kazda+51−7413 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidaterefactor(core/rust/crypto: introduce testing harness and zkp supportby matejcik · 410d40d3 · Sep 2, 2026 · 6 filesMessage 100 · StrongInformational 18Details
Commit message · matejcik

refactor(core/rust/crypto: introduce testing harness and zkp support

moves the test-only `rand` insecure PRNG into a dedicated test-only
module `testutil`

implements `random_buffer` extern "C" export that delegates to the
insecure PRNG
and applies a xor with a masking string <PRNG-Rust-Tests> so that its
presence can be detected within a compiled artifact
(required for secp256-zkp EC arithmetic even for verification because
curve_to_jacobian needs random data for FIH masking)

explicitly runs the test harness and initializes the zkp context before
start (also required by secp256-zkp)

moves the secp256-zkp default error handlers from modtrezorcrypto.c to
the crypto crate, so that they're properly set for any user of crypto,
not just firmware.
(this removes the "raise ValueError" feature for illegal arguments --
that shouldn't matter too much, these are checks on "is the function
called properly", not on validity of user provided input)

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnessdefensive validationcryptography-sensitive path
AI analysis · Informational 18/100

This commit reorganizes how a test-only random number generator and certain Bitcoin-related cryptographic error handlers are wired up in the Trezor firmware's Rust crypto code. It moves an insecure PRNG used only in unit tests into its own module and exports it under a detectable name so test builds can find it. It also moves default error callbacks for the secp256k1-zkp library from the Python module layer into the core crypto crate so all users of the crate share them. The change removes a Python ValueError raise for illegal library arguments, replacing it with a system error shutdown. There is no direct evidence in the commit of a vulnerability being fixed; it reads as a refactoring to support testing and a new cryptographic feature (zero-knowledge proofs).

Security candidatefeat(core/rust): introduce rtl::CSliceMutby matejcik · c511a1a2 · Sep 2, 2026 · 5 filesMessage 80 · StrongLow 29Details
Commit message · matejcik

feat(core/rust): introduce rtl::CSliceMut

a counterpart to CSlice for mutable slices

Necessitated a refactor of previous CSlice code to use a shared internal
helper. I also took the opportunity to change as_slice / as_slice_mut to
always return a slice that may be empty, collapsing the NULL/empty
distinction on the Rust side too.

Fun had been had on all sides, esp. with obscure provenance bugs and the
correct safety properties.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
boot or update path
AI analysis · Low 29/100

This commit is a code-quality refactor in the Trezor firmware's Rust layer. It introduces a new mutable-slice helper (CSliceMut) and changes the existing CSlice so that empty/NULL slices return an empty Rust slice instead of an optional value that callers had to unwrap. The change is described by the developer as fixing 'obscure provenance bugs' and aligning safety properties. There is no direct evidence in the commit of an exploitable vulnerability; it reads as defensive hardening of the boundary between C and Rust code.

AI review queuedchore(core): sign translationsby Roman Zeyde · 2763e22f · Sep 1, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Roman Zeyde

chore(core): sign translations

[no changelog]

(cherry picked from commit b40aaefea2cfea8128370809107fb6c56aaba0ec)

62/100 · AdequateMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathtranslation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply adds a new digital signature entry to a JSON file that records approved translation bundles for the Trezor hardware wallet. It is a routine metadata update with no code changes and no apparent security relevance.

Security candidatedocs(storage): document the public storage APIby tychovrahe · ee7c5efb · Sep 1, 2026 · 1 fileMessage 92 · StrongInformational 15Details
Commit message · tychovrahe

docs(storage): document the public storage API

Add doxygen comments to `storage.h` in the style used across core,
covering all public functions and the UI callback.

The NULL contract of every pointer argument is stated explicitly, matched
against the syscall and smcall verifiers so that the header and the
privilege boundary agree on which arguments are optional.

The only deliberate divergence is `storage_get()`, whose `val` ignores
`max_len` when NULL, while the verifiers require `max_len` to be 0 in
that case. The header documents the stricter rule.

Comments only, no functional change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

[no changelog]

92/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
credential or privilege state
AI analysis · Informational 15/100

This commit only adds documentation comments to a C header file. No program code was changed, so it cannot introduce or fix a security bug by itself. The comments describe how the storage API is already supposed to behave, including rules about which pointer arguments may be NULL.

Security candidatefix(core): unify MAX_LENGTH for SimpleChoiceby Vojtěch Nevřela · ecdd6c2a · Sep 1, 2026 · 5 filesMessage 57 · ThinLow 35Details
Commit message · Vojtěch Nevřela

fix(core): unify MAX_LENGTH for SimpleChoice

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Low 35/100

This commit tightens a safety check in the Trezor hardware wallet's user-interface code. It makes sure that a small on-screen menu component can hold at least as many items as the firmware might ever ask it to display, preventing a capacity mismatch that could crash the device when a user is choosing recovery-seed word counts or similar options. There is no direct evidence in the commit that this crash was exploitable to steal funds or bypass security.

Security candidaterefactor(core): separate norcow config from flash layoutby tychovrahe · bbbfa2af · Sep 1, 2026 · 3 filesMessage 95 · StrongInformational 15Details
Commit message · tychovrahe

refactor(core): separate norcow config from flash layout

`norcow_config.h` lived in the flash module and was pulled in by
`sys/flash.h`, while storage's `norcow.h` includes `norcow_config.h`,
which itself includes `sys/flash.h` — a cycle between the two modules.

Split it along its natural seam:

- `STORAGE_AREAS` / `STORAGE_AREAS_COUNT` are flash layout (defined by
`flash_layout.c`, used by `flash_utils.c` and the bootloader emulator),
so they join the other area declarations in `sys/flash.h`.
- The norcow parameters move to `sec/storage/inc/norcow_config.h`, next
to the module that needs them, and `NORCOW_SECTOR_COUNT` is now derived
from `STORAGE_AREAS_COUNT` so the two cannot disagree.

`projects/unix/main_main.c` uses `MODEL_INTERNAL_NAME` but reached
`trezor_model.h` only through the removed include chain, so it now
includes it directly.

Legacy and `storage/tests` are unaffected: each supplies its own
`norcow_config.h`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

[no changelog]

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
update trust
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup. It moves two configuration constants between header files to remove a circular include dependency between the flash and storage modules. There is no user-facing change, no bug fix, and no security-sensitive behavior change.

Security candidatefix(core/rust): adjust menu item limits to prevent overflow errorsby Vojtěch Nevřela · c81e063e · Sep 1, 2026 · 3 filesMessage 79 · AdequateLow 42Details
Commit message · Vojtěch Nevřela

fix(core/rust): adjust menu item limits to prevent overflow errors

[no changelog]

79/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
memory safetyboot or update path
AI analysis · Low 42/100

This commit fixes a capacity mismatch in the Trezor hardware wallet's on-screen menus. A global limit allowed up to 6 menu entries, but the internal storage for two menu layouts only held 5. When a 6-item menu was built, the code would panic (crash) instead of showing the menu. The patch raises both storage capacities to 6 and adds compile-time checks so the bug cannot silently recur if the global limit is changed again. The crash is a denial-of-service issue for the device UI, not a direct theft-of-funds vulnerability.

AI review queuedfeat(core): report `Ethereum_EIP7702` from `GetFeatures`by Roman Zeyde · e4a7d054 · Sep 1, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · Roman Zeyde

feat(core): report `Ethereum_EIP7702` from `GetFeatures`

1st part of https://github.com/trezor/trezor-firmware/issues/7693.

[no changelog]

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply advertises that Trezor Model T / Core devices support a new Ethereum feature called EIP-7702 when a host asks the device for its capabilities. It does not change how transactions are signed, authorized, or validated. There is no security-relevant behavior change.

AI review queuedfix(core): avoid panic on sentinel glyph lookupby obrusvit · 79d2aa73 · Aug 31, 2026 · 1 fileMessage 57 · ThinLow 37Details
Commit message · obrusvit

fix(core): avoid panic on sentinel glyph lookup

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
translation-only discountsecond-pass: broader security terminology
AI analysis · Low 37/100

This commit fixes a bug in the Trezor firmware's translation system where looking up a special 'sentinel' (end-marker) value could cause the device to crash (panic). The fix changes the code to safely check whether the next entry exists before reading it, returning 'not found' instead of crashing. A test was added to confirm the sentinel lookup no longer panics.

Security candidatechore: use ruff instead of black and isortby obrusvit · 724737f5 · Aug 31, 2026 · 136 filesMessage 72 · AdequateInformational 15Details
Commit message · obrusvit

chore: use ruff instead of black and isort

- reducing the number of tools in the repo
- in the future, we may replace also pylint and pyright

[no changelog]

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Informational 15/100

This commit is a routine housekeeping change that swaps the Python code-formatting tools used in the project from `black` and `isort` to `ruff`. It updates configuration files, build scripts, and reformats many source files to match the new tool's style. There is no change to what the software actually does, no new features, and no indication of any security problem or fix.

Security candidatefix(core): cleanup menu handling irregularitiesby Vojtěch Nevřela · 1601205f · Aug 31, 2026 · 12 filesMessage 57 · ThinInformational 17Details
Commit message · Vojtěch Nevřela

fix(core): cleanup menu handling irregularities

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Informational 17/100

This commit is a code cleanup in the Trezor firmware's user-interface layer. It moves a small 'menu item intent' type to a better location, fixes a minor error-handling inconsistency, and reorders some on-screen menu entries so the cancel option appears first. There is no direct evidence this fixes an exploitable security vulnerability, but the reordering could be a defensive usability improvement to prevent accidental destructive actions.

Security candidatefix(core): refuse an emulator BLE read that cannot take a whole packetby tychovrahe · 6999d093 · Aug 31, 2026 · 1 fileMessage 85 · StrongLow 45Details
Commit message · tychovrahe

fix(core): refuse an emulator BLE read that cannot take a whole packet

The socket is SOCK_DGRAM, so `recvfrom()` consumes the datagram whole and
discards whatever does not fit the buffer it is given. Passing
`MIN(max_len, sizeof(buf))` therefore let a caller with a short buffer destroy
part of a received packet and get only its own length back - the emulator's
version of the defect just fixed in the hardware driver, reached through UDP
truncation rather than a queue dequeue.

Reject a `max_len` below the packet size before reading, as the hardware
driver now does, and read a whole buffer unconditionally: with the check above
it, the MIN could only ever pick `sizeof(buf)`.

No caller is affected. `py_iface_read()` requires a buffer at least
`RX_PACKET_SIZE` long and the bootloader wire layer requires an exact size;
only a direct `ble_read` syscall could ask for less.

[no changelog]

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
update trust
AI analysis · Low 45/100

This commit fixes a bug in the Trezor emulator's Bluetooth-over-UDP code. Previously, if a caller asked to read a Bluetooth packet into a buffer smaller than a full packet, the emulator would silently throw away the leftover data. Now it refuses short reads up front, matching a fix already made in the real hardware driver. The commit message says no real callers were affected because all normal callers use full-size buffers.

Security candidatefix(core): stop ble_read() consuming a packet it cannot returnby tychovrahe · f9c35369 · Aug 31, 2026 · 1 fileMessage 95 · StrongLow 45Details
Commit message · tychovrahe

fix(core): stop ble_read() consuming a packet it cannot return

`ble_read()` dequeued from the RX queue and only then checked that the caller's
buffer was big enough. `tsqueue_dequeue()` resets the entry and advances the
read index unconditionally, and there is no re-enqueue on the error path, so a
buffer below `BLE_RX_PACKET_SIZE` silently destroyed a received packet and
reported zero bytes - indistinguishable to the caller from an empty queue.

The size test never needed the dequeued data. Once `read_len` is known to be
`BLE_DATA_SIZE`, `max_len < read_len - BLE_DATA_HEADER_SIZE` is just
`max_len < BLE_RX_PACKET_SIZE`, so hoist it above the dequeue. That also
retires an expression that was only in bounds thanks to the `||`
short-circuit ordering.

`py_iface_read()` rejects a short buffer before it gets here and the bootloader
wire layer requires an exact size, so the only way in is an applet calling the
`ble_read` syscall directly - which loses packets addressed to itself. No
caller changes behaviour: for every `max_len` at or above the packet size the
function does exactly what it did.

[no changelog]

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
update trust
AI analysis · Low 45/100

This commit fixes a bug in the Bluetooth code of Trezor hardware wallets. When a program asked to read a Bluetooth packet using a buffer that was too small, the code would first remove the packet from the receive queue and only then realize the buffer was too small. Because the removed packet was not put back, it was silently lost. The fix checks the buffer size before removing the packet, so an undersized read now simply reports 'nothing available' instead of destroying data. The commit notes that the only realistic way to trigger this is an applet making a direct system call with a too-small buffer, which would cause that applet to lose packets meant for it.

Security candidatefix(core): tie ble::read()'s length to its bufferby tychovrahe · 8b6adf43 · Aug 31, 2026 · 2 filesMessage 85 · StrongModerate 58Details
Commit message · tychovrahe

fix(core): tie ble::read()'s length to its buffer

`read()` took the buffer and the length the caller claims for it as separate
arguments, and passed the length straight to `ble_read()`. `ble_read()` writes
a full `BLE_RX_PACKET_SIZE` packet whenever the length it is given is at least
that big, so a caller passing a length larger than its buffer gets 244 bytes
written into something shorter.

The one caller, `py_iface_read()`, hands `read()` a Python-supplied buffer of
arbitrary size and passed the constant `RX_PACKET_SIZE`. It checks
`buf.len() < RX_PACKET_SIZE` first, so nothing is wrong today - but that check
is the only thing standing between a short bytearray and an overflow.

Derive the length from the buffer so the two cannot disagree. `ble_read()`
then refuses to write at all when the buffer is too small, and the check in
`py_iface_read()` is left to produce a clearer error rather than to keep us in
bounds. Saturate rather than fail the conversion: the length is only compared
against the packet size, so a buffer above 65535 bytes must keep working.

[no changelog]

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

85/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Moderate 58/100

This commit fixes a potential buffer overflow in the Bluetooth Low Energy (BLE) read function of the Trezor hardware wallet firmware. Previously, the function trusted the caller's claim about how large the buffer was, which could allow more data to be written into a smaller memory area than intended. The fix makes the function use the actual buffer size instead, removing that trust relationship and preventing a possible overflow.

Security candidatefix(core): validate length in the nRF service callbacksby tychovrahe · a3fd85a0 · Aug 31, 2026 · 2 filesMessage 85 · StrongModerate 62Details
Commit message · tychovrahe

fix(core): validate length in the nRF service callbacks

`nrf_management_rx_cb()` and `nrf_test_cb()` select on `data[0]` without
checking that a byte is present, and the two management handlers went further
on the same assumption, computing `len - 1` and clamping the result with
MIN(). A zero-length frame turned that subtraction into 4294967295, so the
clamp always picked the full struct size.

The reads stayed inside the SPI frame buffer, so nothing was out of bounds.
The defect is that a truncated response was accepted as a complete one:

- a one-byte MGMT_RESP_INFO set `info_valid` while leaving `drv->info`
holding whatever a previous exchange left there,
- a one-byte MGMT_RESP_AUTH_RESPONSE set `auth_data_valid` with `auth_data`
still zeroed, which `nrf_authenticate()` then fed to the MAC comparison.

Both fail closed, but `nrf_authenticate()` gates boot in production builds and
has no business deciding anything from a frame the nRF never filled in.

Require the whole payload before marking the state valid, and set the flag
after the copy rather than before. The minimums match what the nRF sends:
`send_info()` transmits `1 + sizeof(nrf_info_t)` bytes and
`mgmt_process_challenge()` more than the digest we read. An older nRF that
sent less would now fail `nrf_get_info()` and fall through to the SMP path,
which forces an update - the outcome we want.

This is the same defect class as the recent fix to
`ble_process_rx_msg_mac()`; these were the remaining callbacks.

[no changelog]

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
memory safetydefensive validation
AI analysis · Moderate 62/100

This commit fixes a bug in the Trezor hardware wallet's code that talks to the nRF wireless chip over SPI. The code read the first byte of a received message to decide what kind of response it was, without first checking whether any bytes had actually been received. For two important response types—device info and authentication data—it then marked the data as 'valid' before copying it. A zero-length or truncated message could therefore make the device believe it had received valid authentication data when it had not. The device 'fails closed' (it does not unlock anything from bad data), but the bug could still let an empty or truncated frame influence the boot-time authentication check, which is not a safe design. The fix requires the full expected payload length before marking anything valid and moves the 'valid' flag to after the copy.

Security candidatefix(core/fido2): use a static counter when returning a bogus signatureby Roman Zeyde · bd8c3eed · Aug 31, 2026 · 1 fileMessage 67 · AdequateLow 35Details
Commit message · Roman Zeyde

fix(core/fido2): use a static counter when returning a bogus signature

[no changelog]

67/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundaryauthentication path
AI analysis · Low 35/100

This commit changes how the Trezor hardware wallet handles FIDO2/WebAuthn 'silent authentication' attempts. When a website asks for authentication without user confirmation (user presence=false), Trezor now returns a fake signature and a fixed counter value of 0, instead of advancing the real signature counter. Previously, the code advanced the real counter even when returning a fake signature. The change prevents the real counter from leaking or being consumed during silent authentication attempts, which is a minor privacy and state-consistency improvement.

Security candidatefix(core): fix nrf tlv offset calculatiion wrapby tychovrahe · dcdb96bc · Aug 31, 2026 · 1 fileMessage 57 · ThinModerate 61Details
Commit message · tychovrahe

fix(core): fix nrf tlv offset calculatiion wrap

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Moderate 61/100

This commit fixes a bug in the Trezor hardware wallet's firmware update code for the nRF wireless chip. The code reads update image headers from an untrusted source and calculates where to look for a SHA-256 hash inside the image. Before the fix, the calculation used a signed offset type and did not check whether the claimed image size was larger than the actual buffer. A malicious or malformed update image could make the offset wrap around (become a small number due to integer overflow), bypassing later safety checks and potentially causing the device to read memory outside the intended buffer. The fix rejects images whose claimed size exceeds the buffer and uses an unsigned type for the offset calculation.

Security candidatefeat(core/caesar): use Marquee in Homescreen labelby obrusvit · 659d5ada · Aug 31, 2026 · 2 filesMessage 62 · AdequateInformational 15Details
Commit message · obrusvit

feat(core/caesar): use Marquee in Homescreen label

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit is a user-interface polish change for the Trezor hardware wallet. It replaces a static text label on the device homescreen with a scrolling 'marquee' label so that longer text (such as a wallet name) can be read even if it does not fit in the available space. There is no security-relevant change here.

AI review queuedrefactor(core): RIIR definitionsby obrusvit · c7dc4897 · Aug 29, 2026 · 13 filesMessage 47 · ThinLow 28Details
Commit message · obrusvit

refactor(core): RIIR definitions

[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit rewrites the handling of externally downloaded coin/network definitions from Python into Rust. It moves parsing, signature verification, and protobuf decoding into a new Rust module. The change is described by the vendor as a non-security refactor ('RIIR' = 'Rewrite It In Rust') with no changelog entry. The diff itself does not introduce obvious new vulnerabilities, but it is a partial refactor: the Python side now delegates most validation to Rust, and some safety comments rely on assumptions about MicroPython not mutating buffers. There is no vendor statement that this is a security fix or that it addresses a reported vulnerability.

Security candidatestyle: run make styleby obrusvit · 9a50f41d · Aug 29, 2026 · 2 filesMessage 28 · OpaqueInformational 15Details
Commit message · obrusvit

style: run make style

[no changelog]

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
seed or entropy path
AI analysis · Informational 15/100

This commit is purely a code-style cleanup. It replaces older Python type-hint syntax (t.Dict, t.Tuple, typing.Iterable) with newer built-in equivalents (dict, tuple, collections.abc.Iterable). No behavior, logic, or security properties of the code were changed.

Security candidatefix(core): check group thresholds of super-shamirby obrusvit · be0cd19b · Aug 29, 2026 · 3 filesMessage 80 · StrongLow 44Details
Commit message · obrusvit

fix(core): check group thresholds of super-shamir

- check the individual group thresholds before comitting the backup
flags
- this prevents a malformed param msg to get the device into the state
of "Backup failed"

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Low 44/100

This update fixes a validation gap in the Trezor hardware wallet's Advanced Shamir backup setup. Previously, the device could accept malformed backup settings (such as too many groups or invalid member counts) and end up stuck in a 'Backup failed' state. The fix adds earlier checks so bad settings are rejected before the device commits to the backup process.

Security candidatefeat(core): add `miniscript` feature flagby Roman Zeyde · 3277c744 · Aug 28, 2026 · 18 filesMessage 90 · StrongInformational 15Details
Commit message · Roman Zeyde

feat(core): add `miniscript` feature flag

Will be used to incrementally introduce Miniscript-related features
into the codebase, while excluding them from production FW builds:

- add `miniscript` feature to both firmware and unix builds
- add `trezorminiscript` MicroPython module
- add miniscript-enabled emulator device tests on one model (T3T1)

[no changelog]

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
boot or update path
AI analysis · Informational 15/100

This commit adds a new build-time feature flag called 'miniscript' to the Trezor firmware. It does not implement any actual Miniscript functionality yet; it only creates the scaffolding (a new MicroPython module placeholder, build options, and CI test configurations) so future Miniscript work can be developed without affecting production firmware builds. There is no security-relevant code change here.

Security candidatetest(core): reveal passphrase during {Bolt,Delizia,Eckhart} click testsby Roman Zeyde · f0b7ee37 · Aug 28, 2026 · 4 filesMessage 95 · StrongInformational 15Details
Commit message · Roman Zeyde

test(core): reveal passphrase during {Bolt,Delizia,Eckhart} click tests

Following https://github.com/trezor/trezor-firmware/pull/6851.

[no changelog]

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlcryptography-sensitive pathauthentication path
AI analysis · Informational 15/100

This commit only changes automated test code for Trezor hardware wallets. It updates passphrase tests to use the widest keyboard character ('W' instead of 'a') and adds a step to reveal the hidden passphrase during testing. There is no change to the actual wallet firmware or production code, so it does not create a security vulnerability or fix one in shipped software.

AI review queuedchore(l10n): change Eckhart send__cancel_sign to a questionby Michal Kazda · cb528ee0 · Aug 28, 2026 · 8 filesMessage 62 · AdequateInformational 15Details
Commit message · Michal Kazda

chore(l10n): change Eckhart send__cancel_sign to a question
[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathtranslation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes the wording of one on-screen message in the Trezor firmware. For the 'Eckhart' design theme, the text 'Cancel sign.' is changed to 'Cancel sign?' (and equivalent changes in Czech, German, Spanish, French, and Portuguese). It is a cosmetic localization tweak with no security effect.

Security candidatefix(core): Avoid raising IndexError during cash address decodingby Fabien · e7ea48d8 · Aug 28, 2026 · 3 filesMessage 100 · StrongLow 39Details
Commit message · Fabien

fix(core): Avoid raising IndexError during cash address decoding

It is possible to craft an invalid cash address that would raise an IndexError and return a confusing error message.

Fill the gap and add tests to ensure a proper ValueError is returned.

Fixes #7749.

[no changelog]

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Low 39/100

This commit fixes a bug in how Trezor hardware wallets decode Bitcoin Cash-style 'cashaddr' addresses. Previously, a malformed address could cause the device to hit an internal 'IndexError' and show a confusing message. The fix ensures the address is properly validated and returns a clear 'invalid address' error instead. There is no direct evidence in the commit that this could be used to steal funds, but it improves robustness against bad or maliciously crafted addresses.