fix(core/caesar): hold to confirm firmware update
What changed, and why it matters
This commit changes how a user confirms a firmware update on the Trezor Safe 3 (Caesar layout). Previously, pressing the right button once could confirm the update; now the user must hold a button for a short period. The change prevents accidental or malicious confirmations when the right-button press is part of a different navigation gesture, and it avoids conflict with the new 'Shift' action that uses both buttons.
Treat as a minor hardening/UI-safety fix. Review whether the hold duration is sufficient to prevent unintended confirmation, and verify that the change is included in release notes for transparency even though the commit marks [no changelog].
Security signals we found
UI gesture change from single press to hold-to-confirm
Prevents accidental/malicious firmware update confirmation
Avoids conflict with new 'Shift' two-button gesture
No changelog entry provided
Evidence from the diff
In core/embed/rust/src/ui/layout_caesar/ui_firmware.rs, the firmware-update confirmation screen for the Caesar UI was updated. The confirm button text changed from buttons__install to buttons__hold_to_confirm and now uses with_default_duration(), which requires a press-and-hold gesture instead of a single right-button press. The commit message explains that the previous single right press was an unintended regression after the new menu navigation, which used both buttons for confirmation, and that both buttons now conflict with the ‘Shift’ function, so hold-to-confirm was chosen.
Changed components
Trezor firmware core UI (Caesar layout)Firmware update confirmation flow on Trezor Safe 3Inspect captured patch +5 / −2
### core/embed/rust/src/ui/layout_caesar/ui_firmware.rs
@@ -297,11 +297,14 @@ impl FirmwareUI for UICaesar {
description: TString<'static>,
_fingerprint: TString<'static>,
) -> Result<impl LayoutMaybeTrace, Error> {
- // The fingerprint is shown in the context menu.
+ // The fingerprint is shown in the context menu. Installing is confirmed
+ // by holding (pressing both buttons would clash with "Shift").
let paragraphs = Paragraph::new(&theme::TEXT_NORMAL, description).into_paragraphs();
let content = ButtonPage::new(paragraphs, theme::BG)
.with_menu_nav(MenuNav::Menu)
- .with_confirm_btn(Some(ButtonDetails::text(TR::buttons__install.into())));
+ .with_confirm_btn(Some(
+ ButtonDetails::text(TR::buttons__hold_to_confirm.into()).with_default_duration(),
+ ));
let frame = ScrollableFrame::new(content).with_title(TR::firmware_update__title.into());
Ok(RootComponent::new(frame))
}Why this scored 28/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.