What changed, and why it matters
This is a routine GitHub Actions workflow fix. It changes which Slack webhook secret is used for nightly test failure notifications and removes a now-unnecessary safety check. There is no security vulnerability in the change itself.
No security action needed. This is a CI configuration cleanup. Reviewers may optionally verify that SLACK_HW_TESTS_WEBHOOK is correctly configured in repository secrets and that the receiving Slack channel is appropriate for clear-signing nightly failures.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/workflows/core-clear-signing.yml to reuse the existing SLACK_HW_TESTS_WEBHOOK secret instead of a separate SLACK_CLEAR_SIGNING_WEBHOOK that was never configured. It also removes the conditional that skipped Slack notification when the old secret was absent. The webhook secret is still passed to an env var (not directly into a shell argument), and the change aligns this workflow with core-hw.yml. No code handling secrets, cryptography, user input, or device firmware is touched.
Changed components
.github/workflows/core-clear-signing.ymlInspect captured patch +1 / −5
### .github/workflows/core-clear-signing.yml
@@ -209,12 +209,8 @@ jobs:
GITHUB_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
COMMIT_URL: ${{ github.server_url }}/${{ github.repository }}/commit/${{ github.sha }}
COMMIT_SHA: ${{ github.sha }}
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CLEAR_SIGNING_WEBHOOK }} # zizmor: ignore[secrets-outside-env] a repository secret, like SLACK_HW_TESTS_WEBHOOK in core-hw.yml
+ SLACK_WEBHOOK_URL: ${{ secrets.SLACK_HW_TESTS_WEBHOOK }} # zizmor: ignore[secrets-outside-env] a repository secret, shared with core-hw.yml
run: |
- if [ -z "$SLACK_WEBHOOK_URL" ]; then
- echo "::warning::SLACK_CLEAR_SIGNING_WEBHOOK is not set, not notifying Slack"
- exit 0
- fi
JOBS=$(gh api "repos/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID/attempts/$GITHUB_RUN_ATTEMPT/jobs?per_page=100")
# cancelled also covers jobs that hit timeout-minutes
FAILED=$(jq -r '.jobs[] | select(.conclusion == "failure" or .conclusion == "cancelled") | "• <\(.html_url)|\(.name)>"' <<< "$JOBS")Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.