chore: remove 'confidential_assets' entry from coin definitions
What changed, and why it matters
This commit simply removes an unused configuration field called 'confidential_assets' from cryptocurrency definition files and from the code that reads them. The field was never active in the firmware, so this is a cleanup change with no security impact.
No action needed. This is a benign cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the ‘confidential_assets’ key from 58 JSON coin definition files and removes the corresponding parameter from the CoinInfo class and its code generator template. The commit message explicitly states this field was never used because the feature it supported was never merged. No runtime behavior changes.
Changed components
common/defs/bitcoin/*.jsoncore/src/apps/common/coininfo.pycore/src/apps/common/coininfo.py.makoInspect captured patch +58 / −463
### common/defs/bitcoin/actinium.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/axe.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bcash.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bcash_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bgold.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bgold_testnet.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bitcoin.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bitcoin_regtest.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bitcoin_signet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bitcoin_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bitcore.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/bprivate.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/cpuchain.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/crown.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/dash.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/dash_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/decred.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/decred_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/digibyte.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/dogecoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/ecash.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/elements.json
@@ -39,9 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": {
- "address_prefix": 4,
- "blech32_prefix": "el"
- }
+ "timestamp": false
}
### common/defs/bitcoin/feathercoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/firo.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/firo_testnet.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/florincoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/fujicoin.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/groestlcoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/groestlcoin_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/komodo.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": true,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/koto.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": true,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/litecoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/litecoin_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/monacoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/namecoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/particl.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/particl_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/peercoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": true,
- "confidential_assets": null
+ "timestamp": true
}
### common/defs/bitcoin/peercoin_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": true,
- "confidential_assets": null
+ "timestamp": true
}
### common/defs/bitcoin/primecoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/qtum.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/qtum_testnet.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/ravencoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/ravencoin_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/ritocoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/smartcash.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/smartcash_testnet.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/stakenet.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/syscoin.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/terracoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/unobtanium.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/verge.json
@@ -38,7 +38,6 @@
"negative_fee": false,
"cooldown": 100,
"overwintered": false,
- "confidential_assets": null,
"timestamp": true,
"extra_data": false
}
### common/defs/bitcoin/vertcoin.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/viacoin.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/vipstarcoin.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/xrhodium.json
@@ -42,6 +42,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/zcash.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": true,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/zcash_testnet.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": true,
"extra_data": true,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### common/defs/bitcoin/zcore.json
@@ -39,6 +39,5 @@
"cooldown": 100,
"overwintered": false,
"extra_data": false,
- "timestamp": false,
- "confidential_assets": null
+ "timestamp": false
}
### core/src/apps/common/coininfo.py
[binary or diff unavailable]
### core/src/apps/common/coininfo.py.mako
@@ -41,7 +41,6 @@ class CoinInfo:
extra_data: bool,
timestamp: bool,
overwintered: bool,
- confidential_assets: dict[str, Any] | None,
) -> None:
self.coin_name = coin_name
self.coin_shortcut = coin_shortcut
@@ -68,7 +67,6 @@ class CoinInfo:
self.extra_data = extra_data
self.timestamp = timestamp
self.overwintered = overwintered
- self.confidential_assets = confidential_assets
if curve_name == "secp256k1-groestl":
self.b58_hash = groestl512d_32
self.sign_hash_double = False
@@ -131,7 +129,6 @@ ATTRIBUTES = (
("extra_data", bool),
("timestamp", bool),
("overwintered", bool),
- ("confidential_assets", optional_dict),
)
btc_names = ["Bitcoin", "Testnet", "Regtest", "Signet"]Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.