chore(core): adapt to mldsa-native v2.0.0
What changed, and why it matters
This is a routine maintenance update that adapts Trezor's firmware code to version 2.0.0 of an external cryptographic library called mldsa-native. It mainly renames configuration constants, removes an unnecessary signature-length parameter from function calls, and adds a signature-size check in the production-test verification path. There is no direct evidence in the commit that this fixes an active security vulnerability.
Treat as a dependency/API-sync patch. Review whether the new mldsa-native v2.0.0 release contains any security fixes or behavioral changes that should be noted, since the commit itself does not disclose security relevance. Validate that the added sig_size check in prodtest covers all verification entry points and that mldsa44_verify still enforces the correct fixed signature size internally.
Security signals we found
Signature-size validation added in prodtest verify_signature path
API migration to new major version of external cryptographic library
Static assertions updated for renamed parameter-set macro
No changelog entry provided by vendor
Evidence from the diff
The commit updates the Trezor firmware to be compatible with mldsa-native v2.0.0. Changes include: renaming MLD_CONFIG_API_PARAMETER_SET to MLD_CONFIG_PARAMETER_SET; removing the siglen output parameter from mldsa_signature_internal and the sig_size parameter from mldsa_verify; adding src/polyvec_lazy.c to the build; and moving signature-size validation into prodtest’s verify_signature before calling mldsa_verify. The mcu_attestation and mldsa44 wrapper layers are updated accordingly. The change is framed as a chore with [no changelog].
Changed components
core/embed/crypto/build.rscore/embed/projects/prodtest/cmd/common.ccore/embed/projects/prodtest/cmd/prodtest_secrets.ccore/embed/sec/mcu_attestation/inc/sec/mcu_attestation.hcore/embed/sec/mcu_attestation/mcu_attestation.ccore/embed/sec/mldsa44/mldsa44.cInspect captured patch +19 / −22
### core/embed/crypto/build.rs
@@ -361,6 +361,7 @@ fn add_mldsa(lib: &mut CLibrary, attrs: &CompileAttrs) -> Result<()> {
"src/poly.c",
"src/poly_kl.c",
"src/polyvec.c",
+ "src/polyvec_lazy.c",
"src/sign.c",
],
Some(attrs.clone()),
### core/embed/projects/prodtest/cmd/common.c
@@ -355,12 +355,12 @@ static bool verify_signature(alg_id_t alg_id, const uint8_t* pub_key,
#ifdef USE_MCU_ATTESTATION
if (alg_id == ALG_ID_MLDSA44) {
- if (pub_key_size != MCU_ATTESTATION_PUBKEY_SIZE) {
+ if (pub_key_size != MCU_ATTESTATION_PUBKEY_SIZE ||
+ sig_size != MCU_ATTESTATION_SIG_SIZE) {
return false;
}
- if (mldsa_verify(sig, sig_size, msg, msg_size, (const uint8_t*)"", 0,
- pub_key) != 0) {
+ if (mldsa_verify(sig, msg, msg_size, (const uint8_t*)"", 0, pub_key) != 0) {
return false;
}
### core/embed/projects/prodtest/cmd/prodtest_secrets.c
@@ -245,17 +245,16 @@ static bool check_device_cert_chain(cli_t* cli, const uint8_t* chain,
const uint8_t ENCODED_EMPTY_CONTEXT_STRING[] = {0, 0};
uint8_t challenge[CHALLENGE_SIZE] = {0};
uint8_t signature[MCU_ATTESTATION_SIG_SIZE] = {0};
- size_t siglen = 0;
- if (mldsa_signature_internal(signature, &siglen, challenge, sizeof(challenge),
- ENCODED_EMPTY_CONTEXT_STRING,
- sizeof(ENCODED_EMPTY_CONTEXT_STRING), rnd,
- mcu_private, 0) != 0) {
+ if (mldsa_signature_internal(
+ signature, challenge, sizeof(challenge), ENCODED_EMPTY_CONTEXT_STRING,
+ sizeof(ENCODED_EMPTY_CONTEXT_STRING), rnd, mcu_private, 0) != 0) {
cli_error(cli, PRODTEST_ERR_SECRETS_SIGN_SIGNATURE,
"`mldsa_signature_internal()` failed.");
goto cleanup;
}
- if (!check_cert_chain(cli, chain, chain_size, signature, siglen, challenge)) {
+ if (!check_cert_chain(cli, chain, chain_size, signature, sizeof(signature),
+ challenge)) {
// Error returned by check_cert_chain().
goto cleanup;
}
### core/embed/sec/mcu_attestation/inc/sec/mcu_attestation.h
@@ -25,11 +25,11 @@
#include <trezor_model.h>
#include <trezor_types.h>
-#define MCU_ATTESTATION_SIG_SIZE MLDSA_BYTES(MLD_CONFIG_API_PARAMETER_SET)
+#define MCU_ATTESTATION_SIG_SIZE MLDSA_BYTES(MLD_CONFIG_PARAMETER_SET)
#define MCU_ATTESTATION_PUBKEY_SIZE \
- MLDSA_PUBLICKEYBYTES(MLD_CONFIG_API_PARAMETER_SET)
+ MLDSA_PUBLICKEYBYTES(MLD_CONFIG_PARAMETER_SET)
#define MCU_ATTESTATION_PRIVKEY_SIZE \
- MLDSA_SECRETKEYBYTES(MLD_CONFIG_API_PARAMETER_SET)
+ MLDSA_SECRETKEYBYTES(MLD_CONFIG_PARAMETER_SET)
#define MCU_ATTESTATION_MAX_CERT_SIZE (SECRET_MCU_DEVICE_CERT_SIZE - 2)
/**
### core/embed/sec/mcu_attestation/mcu_attestation.c
@@ -79,11 +79,9 @@ secbool mcu_attestation_sign(const uint8_t *challenge, size_t challenge_size,
rng_fill_buffer(rnd, sizeof(rnd));
const uint8_t ENCODED_EMPTY_CONTEXT_STRING[] = {0, 0};
- size_t siglen = 0;
- if (mldsa_signature_internal(signature, &siglen, challenge, challenge_size,
- ENCODED_EMPTY_CONTEXT_STRING,
- sizeof(ENCODED_EMPTY_CONTEXT_STRING), rnd,
- mcu_private, 0) != 0) {
+ if (mldsa_signature_internal(
+ signature, challenge, challenge_size, ENCODED_EMPTY_CONTEXT_STRING,
+ sizeof(ENCODED_EMPTY_CONTEXT_STRING), rnd, mcu_private, 0) != 0) {
goto cleanup;
}
### core/embed/sec/mldsa44/mldsa44.c
@@ -26,11 +26,10 @@
#include <mldsa_native.h>
_Static_assert(MLDSA44_PUBLICKEY_SIZE ==
- MLDSA_PUBLICKEYBYTES(MLD_CONFIG_API_PARAMETER_SET),
+ MLDSA_PUBLICKEYBYTES(MLD_CONFIG_PARAMETER_SET),
"MLDSA44_PUBLICKEY_SIZE mismatch");
-_Static_assert(MLDSA44_SIGNATURE_SIZE ==
- MLDSA_BYTES(MLD_CONFIG_API_PARAMETER_SET),
+_Static_assert(MLDSA44_SIGNATURE_SIZE == MLDSA_BYTES(MLD_CONFIG_PARAMETER_SET),
"MLDSA44_SIGNATURE_SIZE mismatch");
ts_t mldsa44_verify(const mldsa44_signature_t *sig, const void *m, size_t mlen,
@@ -44,8 +43,8 @@ ts_t mldsa44_verify(const mldsa44_signature_t *sig, const void *m, size_t mlen,
TSH_CHECK_ARG(m != NULL);
TSH_CHECK_ARG(pk != NULL);
- if (mldsa_verify(sig->bytes, MLDSA44_SIGNATURE_SIZE, m, mlen,
- (const uint8_t *)"", 0, pk->bytes) == 0) {
+ if (mldsa_verify(sig->bytes, m, mlen, (const uint8_t *)"", 0, pk->bytes) ==
+ 0) {
*valid = sectrue;
}
Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.