AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 39 Bitcoin

fix(core): fix solana priority fee calculation

Public commit record

What the developer wrote

Authored by obrusvit

72/100 · Adequate
fix(core): fix solana priority fee calculation

(cherry picked from commit 23578abef19de557c60423755a9903ec79624c74)
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
The short version

What changed, and why it matters

This commit fixes how Trezor hardware wallets estimate Solana transaction priority fees when the user does not set an explicit compute-unit limit. Previously the code always assumed a flat 200,000 compute units, which could make the displayed fee much lower or much higher than what the Solana network would actually charge. The patch now follows Solana's real rules: built-in programs cost 3,000 units each, unknown programs cost 200,000 units each, and the total is capped at 1.4 million units. It also rejects duplicate compute-budget instructions, matching what the Solana runtime does. The main risk is that a user might approve a transaction based on an incorrect fee estimate, but the actual funds moved still depend on the transaction's instructions, not the estimate.

Recommended action

Treat as a functional correctness fix with user-safety implications. Review whether the new default-unit accounting and duplicate-instruction rejection match the referenced Solana Agave implementation. Consider whether any previously signed transaction could have been displayed with a materially wrong fee, and whether user-facing release notes should mention the improved fee accuracy.

Security signals we found

01

Incorrect fee estimation could mislead users about transaction cost

02

Added duplicate compute-budget instruction validation prevents parsing ambiguity

03

Aligns Trezor fee model with Solana runtime defaults and limits

04

Fixes over/under-estimation of priority fees for transactions without explicit compute unit limits

Risk score

Why this scored 39/100

Our methodology →
Potential impact 8/30
Exploitability 6/25
Stealth signal 7/15
Affected reach 8/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.