EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Repository coverage

1153 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

92security candidates261second-pass queue1007AI analyses
127commits · 30 days
262commits · 60 days
545commits · 180 days
1002commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
220Strong · 80–100
549Adequate · 60–79
340Thin · 40–59
44Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
ThomasV137891162
SomberNight39330362063
f321x40325387070
Sander van Grieken10910101057
ghost4342517069
Felix25410072
user323062
ekzyis222053
accumulator613071
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 6 minutes ago

Low 29 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10992 from f321x/dedup_is_seed_wizard

This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes dupli…

Refactor of seed-validation logic in wallet creation wizardRemoval of duplicated seed-type checks in favor of centralized validationAdded assertion constraining seed type to 'electrum'
554daca6by ghost43+2−81 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10982 from spesmilo/wizard_2fa_seed_redirect

This commit changes Electrum's wallet creation wizard so that if a user tries to restore a normal 'standard' wallet but pastes a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard automatically redire…

UX-level safety fix preventing wallet-type/seed mismatchState mutation: wizard_data['wallet_type'] changed from 'standard' to '2fa' based on seed typeNo cryptographic, network, or privilege changes
310c9dd0by Felix+102−133 files
No security note in commit
Informational 12 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: wizard: dedup seed validation rules

This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a secur…

89d0de06by f321x+2−81 file
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

tests: wizard: cover standard -> 2fa redirection

This commit only adds and reorganizes automated test code for Electrum's wallet creation wizard. It does not change any production wallet logic, cryptography, or network handling. The tests verify that when a user tries to restore a 'stand…

70b4d27cby f321x+68−91 file
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10988 from f321x/update_security_review_ci_model

This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…

CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
638fbba8by Felix+75−111 file
No security note in commit
Informational 12 AI analysisMessage 90 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

ci: security review: warn if the model got downgraded

This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…

CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
ace2ca7aby f321x+74−101 file
No security note in commit
Low 44 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10987 from spesmilo/fix_10986

This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…

Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
bef80421by ghost43+11−02 files
No security note in commit
Low 35 AI analysisMessage 81 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

transaction: treat native segwit input with non-empty witness as complete

This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …

Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
e9bb42e6by ThomasV+11−02 files
No security note in commit
Moderate 68 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness

This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…

Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
9da4c342by ThomasV+10−21 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10974 from SomberNight/202609_nostr_psbt_xpub

This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…

Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
46408a78by ThomasV+13−01 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions

This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…

Exception swallowing bug fixedNetwork/transaction input enrichment logic changedSilent failure mode removed
bb9d3280by ghost43+1−11 file
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10970 from f321x/fix_bolt11_bugs_2

This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…

Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
4b92c0f2by ghost43+82−939 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

add_info_from_network: do not swallow exceptions

Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…

Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
3f67b21bby ThomasV+1−11 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: remove tag arg from get_routing_info

This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …

e78fba28by f321x+12−127 files
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10940 from accumulator/fix_10937

This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…

Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
a57ef6e7by Felix+707−9610 files
No security note in commit
Low 40 AI analysisMessage 36 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: followup #10940

This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…

Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
3026fbdbby f321x+14−232 files
No security note in commit
Low 32 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak

This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…

Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
5b77ca46by Felix+9−22 files
No security note in commit
Informational 23 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10958 from SomberNight/202609_deps

This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…

Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
8bd8c3fbby ghost43+57−5612 files
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10965 from SomberNight/202609_header_checkpoints

This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…

Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
9e0b7e64by ghost43+276−04 files
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

update block header checkpoints

This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…

e11c579bby SomberNight+276−04 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritytests: json_db: add more asserts for clarityby SomberNight · afc87fea · Dec 1, 2025 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · SomberNight

tests: json_db: add more asserts for clarity

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds extra checks to existing automated tests and slightly expands test data. It does not change any production code, wallet logic, or network behavior. There is no security issue here.

Lower-priorityjson_db: add some type hints and assertsby SomberNight · 1119cb9a · Dec 1, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · SomberNight

json_db: add some type hints and asserts

- fix some incorrect type hints
- add many new type hints
- add asserts re types

no functional changes intended

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit only adds Python type hints and runtime assertions to Electrum's JSON database helper code. The author explicitly states 'no functional changes intended'. There is no change to how the wallet stores, encrypts, or validates data, and no security vulnerability is introduced or fixed.

Lower-prioritylnworker: allow overwriting amount of sent payment infoby f321x · df612fa0 · Dec 1, 2025 · 1 fileMessage 73 · AdequateLow 29Details
Commit message · f321x

lnworker: allow overwriting amount of sent payment info

Allows replacing a saved `PaymentInfo` of `SENT` direction if the old
one is not yet paid.
This allows the user to retry paying a 0 amount invoice with different
amount if the previous attempt failed.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 29/100

This commit loosens the rules for saving Lightning payment details when a user is retrying a failed or unpaid outgoing payment. It allows the wallet to overwrite the payment amount and status for a previously saved sent payment, specifically so users can retry paying an invoice that has no fixed amount (a '0 amount invoice') with a different amount. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a usability improvement for retrying payments.

AI review queuedlnworker: differentiate PaymentInfo by directionby f321x · 923d48f9 · Dec 1, 2025 · 12 filesMessage 68 · AdequateLow 36Details
Commit message · f321x

lnworker: differentiate PaymentInfo by direction

Allows storing two different payment info of the same payment hash by
including the direction into the db key.
We create and store PaymentInfo for sending attempts and for requests (receiving),
if we try to pay ourself (e.g. through a channel rebalance) the checks
in `save_payment_info` would prevent this and throw an exception.
By storing the PaymentInfos of outgoing and incoming payments separately in
the db this collision is avoided and it makes it easier to reason about
which PaymentInfo belongs where.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 36/100

This commit changes how Electrum stores Lightning payment records. Previously, outgoing and incoming payments sharing the same payment hash (for example, when rebalancing your own channels) could collide in the database and cause errors. The fix adds a direction flag to the database key so both sides can be stored separately. It is a bug-fix and robustness improvement, not an obvious security vulnerability, though the original collision could have caused crashes or inconsistent state in self-payment scenarios.

Lower-prioritycommands: version_info: include openssl versionby SomberNight · 828fc569 · Nov 30, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · SomberNight

commands: version_info: include openssl version

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply adds the installed OpenSSL version string to Electrum's existing `version_info` diagnostic command. It is a minor information-gathering improvement with no apparent security relevance.

Lower-prioritylnsweep: factor out "maybe_reveal_preimage_for_htlc"by SomberNight · ef8fd03e · Nov 28, 2025 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · SomberNight

lnsweep: factor out "maybe_reveal_preimage_for_htlc"

no functional changes

40/100 · ThinMessage clarity
✓ Specific, descriptive subject! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a simple code cleanup in Electrum's Lightning Network sweep logic. It moves a repeated block of code into a new helper function without changing what the code actually does. There is no security fix or behavior change visible in the diff.

Lower-priorityqt: update tabs on exit of SettingsDialogby f321x · c575abc8 · Nov 28, 2025 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · f321x

qt: update tabs on exit of SettingsDialog

Update the tabs after the SettingsDialog gets closed, some values might
have to be updated according to the new configuration.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a minor user-interface fix. After closing the Settings dialog, Electrum's main window now refreshes its tabs so that displayed information (for example, whether a Lightning payment can be sent) reflects any changed settings. There is no security issue here.

Lower-prioritylnworker: use config lightning fee for estimateby f321x · af4dc24d · Nov 28, 2025 · 3 filesMessage 80 · StrongInformational 20Details
Commit message · f321x

lnworker: use config lightning fee for estimate

I was unable to do a "Max" amount submarine swap because the
`fee_estimate` method used by `LNWallet.num_sats_can_send()` uses a
hardcoded `fee_proportional_millionths` to estimate the fee for the
lightning payment.
When the actual fee determined later is higher
than the estimated fee the payment fails as the channel is unable to add
the htlc sum including the real fees as the amount exceeds the balance of
the channel.
Using the fees the maximum fees user has configured and estimate the
potential fee as inverse of PaymentFeeBudget is more
reliable/conservative as we definitely aren't going to pay more fees
than this amount.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 20/100

This commit fixes a bug in Electrum's Lightning wallet where the app guessed Lightning routing fees using hardcoded values. The old guess could be too low, causing 'Max' amount submarine swaps and similar payments to fail because the real fee later exceeded the reserved amount. The patch now uses the user's own configured maximum fee settings to make a more conservative estimate, so the wallet reserves enough for fees upfront.

Lower-prioritySwapProvidersButton classby ThomasV · 128026a4 · Nov 28, 2025 · 2 filesMessage 40 · ThinInformational 15Details
Commit message · ThomasV

SwapProvidersButton class

factorize code that is used in both SwapDialog and Submarine payments

40/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body! Too few words to establish purpose
AI analysis · Informational 15/100

This commit is a routine code cleanup in Electrum's Qt graphical user interface. It creates a reusable 'SwapProvidersButton' widget so that two different parts of the app (the swap dialog and submarine/on-chain payment flow) share the same code for showing and selecting swap providers. There is no security-relevant change visible in the diff.

Lower-priorityswaps dialog: in callbacks, update either send or receive field, depending on which one followsby ThomasV · 8bec3eaf · Nov 28, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · ThomasV

swaps dialog: in callbacks, update either send or receive field, depending on which one follows

before this, the content of the non-following field could be modified by callbacks

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit fixes a UI behavior bug in Electrum's swap dialog. Previously, when certain events happened (like fee updates), the dialog would recalculate both the 'send' and 'receive' fields, which could overwrite a value the user had just typed. Now it only updates the field that is supposed to automatically follow from the other, leaving the user's manual input alone. There is no direct evidence this is a security vulnerability.

Lower-priorityqt: SettingsDialog: update ln fee config on slider movedby f321x · 088f273d · Nov 28, 2025 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · f321x

qt: SettingsDialog: update ln fee config on slider moved

When moving the lightning fee slider in the SettingsDialog by clicking
on the range instead of pulling the slider the new fee value wouldn't
get stored in the config as the sliderRelased signal is only emitted
when the slider is pulled.
This change updates it on valueChanged.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This commit fixes a small user-interface bug in Electrum's Qt settings window. When users adjusted the Lightning Network fee slider by clicking on the slider track (rather than dragging the handle), the chosen fee wasn't saved because the app only saved it when the slider was released after dragging. The fix saves the fee whenever the slider value changes. It is a usability/configuration bug, not a security vulnerability.

Lower-prioritytests: lnpeer: add test_payment_with_malformed_onionby f321x · 59586d6f · Nov 27, 2025 · 1 fileMessage 65 · AdequateInformational 12Details
Commit message · f321x

tests: lnpeer: add test_payment_with_malformed_onion

Adds a simple forwarding test where the receiver fails a malformed onion with
`update_fail_malformed_htlc`.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum's Lightning networking code. It simulates a multi-hop payment where the final receiver intentionally reports a malformed onion packet. There is no change to production code, no bug fix, and no security patch.

Lower-prioritylnpeer: use INVALID_ONION_VERSION for unparsable onionsby f321x · 16ed7e66 · Nov 27, 2025 · 2 filesMessage 73 · AdequateLow 29Details
Commit message · f321x

lnpeer: use INVALID_ONION_VERSION for unparsable onions

Use the `OnionFailureCode.INVALID_ONION_VERSION` (BADONION | PERM | 4)
code when sending back `update_fail_malformed_htlc` as just sending a plain
`BADONION` is not explicitly mentioned as correct in the spec.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 29/100

This commit tightens how Electrum's Lightning code reports a failed onion packet. Previously it used a generic 'BADONION' flag; now it uses the more specific 'INVALID_ONION_VERSION' code when telling the peer the onion could not be parsed. The change is mainly about following the Lightning specification more precisely and is unlikely to be a security fix for an exploitable bug.

Lower-prioritytests: lnpeer: test_dont_expire_htlcsby f321x · 1fd5458b · Nov 27, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · f321x

tests: lnpeer: test_dont_expire_htlcs

Adds unittest to test the dont_expire_htlcs logic

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new automated test for an existing feature called 'dont_expire_htlcs' in Electrum's Lightning code. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. It is purely a test-file addition.

Lower-prioritytests: test_lnpeer: add test_dont_settle_htlcsby f321x · 4f2e1b65 · Nov 27, 2025 · 1 fileMessage 60 · AdequateInformational 12Details
Commit message · f321x

tests: test_lnpeer: add test_dont_settle_htlcs

Adds test for the dont_settle_htlcs functionality of lnworker used by
Just-In-Time channels.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum's Lightning code. It does not change any production code, so it cannot by itself introduce a security vulnerability or fix one. The test checks that a special internal flag called 'dont_settle_htlcs' correctly prevents Lightning payments from being finalized until the flag is removed, which is used for Just-In-Time channels.

Lower-prioritylnworker: split dont_settle_htlcsby f321x · abc469c8 · Nov 27, 2025 · 5 filesMessage 58 · ThinLow 32Details
Commit message · f321x

lnworker: split dont_settle_htlcs

Splits `LNWallet.dont_settle_htlcs` into `LNWallet.dont_settle_htlcs`
and `LNWallet.dont_expire_htlcs`.

Registering a payment hash in dont_settle_htlcs will prevent it from
getting fulfilled if we have the preimage stored. The preimage will not
be released before the the payment hash gets removed from
dont_settle_htlcs. Htlcs can still get expired as usual or failed if no
preimage is known.
This is only used by Just-in-time channel openings.

Registering a payment hash in dont_expire_htlcs allows to overwrite the
minimum final cltv delta value after which htlcs would usually get
expired. This allows to delay expiry of htlcs or, if the value in the
dont_settle_htlcs dict is None, completely prevent expiry and let the
htlc get expired onchain.

Splitting this up in two different dicts makes it more explicit and
easier to reason about what they are actually doing.

Please enter the commit message for your changes. Lines starting

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Low 32/100

This commit refactors how Electrum handles special Lightning payment hashes used for 'hold invoices' and 'just-in-time channel openings.' It splits one internal control list into two separate lists: one that prevents automatic settlement (releasing the secret that completes a payment) and one that prevents automatic expiry of pending payments. The change is described by the author as making the code easier to reason about and safer, but it also alters the timing rules for when pending payments can be cancelled. There is no direct evidence in the commit that this fixes a known exploitable bug, but the change touches security-sensitive payment logic.

Lower-prioritytests: test_lnpeer: add test_payment_bundle_with_hold_invoiceby f321x · b1e58450 · Nov 27, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · f321x

tests: test_lnpeer: add test_payment_bundle_with_hold_invoice

Adds test_payment_bundle_with_hold_invoice to simulate the use of a
payment bundle in which one invoice of the bundle needs to trigger a hold invoice
callback (similar to submarine swaps).
Also modifies the test helper _test_simple_payment() to compare the
results of all payment attempts instead of just returning after the
first (of multiple) payments raises its result causing the test to miss
if all payments were successful or not.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds and improves automated tests for Electrum's Lightning payment logic. It does not change any production wallet or network code, so it cannot introduce a security vulnerability in the software users run. The test changes make the test suite better at catching failures when multiple bundled payments are attempted.

AI review queuedlnpeer: report htlc_switch exceptions to crash reporterby f321x · 95729a08 · Nov 27, 2025 · 1 fileMessage 73 · AdequateInformational 18Details
Commit message · f321x

lnpeer: report htlc_switch exceptions to crash reporter

It seems useful to report exceptions happening in the htlc_switch to the
crash reporter as it shouldn't raise exceptions in theory and this could
help catch subtle bugs.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 18/100

This commit adds automatic crash reporting for a specific internal Lightning payment-routing function. When that function hits an unexpected error, the app now sends a redacted copy of the error to Electrum's crash reporter before re-raising it. It is a diagnostic/logging improvement, not a fix for a known security flaw, and it does not change how errors are handled.

Lower-prioritytests: test_lnpeer: test_htlc_switch_iteration_benchmarkby f321x · 042557da · Nov 27, 2025 · 2 filesMessage 65 · AdequateInformational 15Details
Commit message · f321x

tests: test_lnpeer: test_htlc_switch_iteration_benchmark

Benchmark how long a call to _run_htlc_switch_iteration takes with 10
trampoline mpp sets of 1 htlc each.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new automated test that measures how fast a specific internal Lightning Network routine runs. It does not change any production wallet code, user-facing behavior, or network protocol handling. There is no security fix or vulnerability introduced here.

Lower-prioritytests: test_lnpeer: test_hold_invoice_set_doesnt_get_expby f321x · f56b13b6 · Nov 27, 2025 · 1 fileMessage 73 · AdequateInformational 12Details
Commit message · f321x

tests: test_lnpeer: test_hold_invoice_set_doesnt_get_exp

Add test `test_hold_invoice_set_doesnt_get_expired` to test_lnpeer to
ensure a mpp set on which a hold invoice callback doesn't get expired
automatically if the cltv_abs falls below MIN_FINAL_CLTV_DELTA_ACCEPTED
as these sets should only get failed if the htlcs are safe to fail by
the target of the hold invoice callback (e.g. swap got refunded
successfully).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum's Lightning code. It does not change any production wallet or server code, so it cannot by itself introduce a security vulnerability or fix one in shipped software. The test verifies that 'hold invoices' used in features like submarine swaps are not prematurely expired while a callback is still active.

Lower-prioritytests: test_lnpeer: test compare trampoline onionsby f321x · bb828097 · Nov 27, 2025 · 1 fileMessage 83 · StrongInformational 12Details
Commit message · f321x

tests: test_lnpeer: test compare trampoline onions

Adds test_forwarder_fails_for_inconsistent_trampoline_onions
which checks that a forwarder compares the trampoline onions of a mpp
set and fails the set if the onions are not similar.
In the test alice sends a mpp through bob with 2 htlcs, in one
trampoline onion amt_to_forward is off by 1 msat so bob fails the htlc
set instead of initiating the trampoline forwarding.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum's Lightning networking code. It does not change any production behavior. The test verifies that a forwarding node (Bob) rejects a multi-part trampoline payment when the hidden 'trampoline onions' inside the payment parts disagree on the amount. This is a defensive correctness check, not a fix or vulnerability patch.

Lower-prioritytests: lnpeer: test_trampoline_mpp_consolidation_forwarding_amountby f321x · 447d91d7 · Nov 27, 2025 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · f321x

tests: lnpeer: test_trampoline_mpp_consolidation_forwarding_amount

Add sanity check that bob is not forwarding more sats to carol if than
he receives from alice. (he only forwards once and doesn't try to
forward multiple times).
This should get caught by asserts in lnworker/lnpeer, nevertheless it
seems to make sense to just add this test to prevent regressions of this
kind.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new automated test to Electrum's Lightning networking code. It does not change any production code, fix a bug, or introduce a vulnerability. The test checks that in a specific multi-part trampoline payment scenario, an intermediate node (Bob) does not forward more money to the next hop than he received from the previous hop. It is a regression test to help catch a potential bug in the future, not a patch for an existing security issue.

Lower-prioritytests: lnpeer: test_mpp_cleanup_after_expiryby f321x · f35b3538 · Nov 27, 2025 · 1 fileMessage 68 · AdequateInformational 12Details
Commit message · f321x

tests: lnpeer: test_mpp_cleanup_after_expiry

1. Alice sends two HTLCs to Bob, not reaching total_msat,
and eventually they MPP_TIMEOUT
2. Bob fails both HTLCs
3. Alice then retries and sends HTLCs again to Bob, for the same RHASH,
this time reaching total_msat, and the payment succeeds

Test that the sets are properly cleaned up after MPP_TIMEOUT
and the sender gets a second chance to pay the same invoice.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test for the Electrum Lightning wallet. It checks that when a multi-part payment times out because not enough money arrived, the leftover payment records are cleaned up so the sender can try paying the same invoice again. There is no change to production code, so users are not directly affected by this commit.

Lower-prioritytests: lnpeer: test_dont_settle_partial_mpp_trigger_with_invalid_cltv_htlcby f321x · a91f7c51 · Nov 27, 2025 · 1 fileMessage 65 · AdequateInformational 12Details
Commit message · f321x

tests: lnpeer: test_dont_settle_partial_mpp_trigger_with_invalid_cltv_htlc

Adds unittest to verify that lnpeer doesn't settle any htlcs of
incomplete mpp.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum's Lightning code. It does not change any production code, so it cannot by itself introduce or fix a security vulnerability in running software. The test checks a corner case in multi-part Lightning payments to make sure a bug (settling part of an incomplete payment) does not occur.

Lower-prioritytests: lnpeer: test_reject_multiple_payments_of_same_invoiceby f321x · a7de8de5 · Nov 27, 2025 · 1 fileMessage 65 · AdequateInformational 12Details
Commit message · f321x

tests: lnpeer: test_reject_multiple_payments_of_same_invoice

Test that lnpeer rejects incoming htlcs for payments that have already
been paid so invoices cannot be paid twice.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum's Lightning code. It checks that the software rejects attempts to pay the same invoice twice. There is no change to the actual wallet or Lightning logic, so by itself this commit does not fix or introduce a security issue. It may be related to a prior bug fix, but the commit message and diff do not describe one.