AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

qml: crash reporter: handle threading.excepthook arguments

Public commit record

What the developer wrote

Authored by Sander van Grieken

73/100 · Adequate
qml: crash reporter: handle threading.excepthook arguments

Exception_Hook.handler is installed as both sys.excepthook, which passes
(type, value, traceback), and threading.excepthook, which passes a single
ExceptHookArgs. For uncaught exceptions in threads the logger could not format
exc_info and get_traceback_groupid_hash() raised a TypeError, so the crash
reporter showed that TypeError instead of the actual exception. Unpack
ExceptHookArgs first.

Also include the exception in the log message.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one bundled object. As a result, users would see a confusing secondary error instead of the real crash details. The fix unpacks the bundled object correctly and also logs the actual exception message. It is a reliability/usability fix, not a security vulnerability.

Recommended action

Treat as a normal bug-fix commit. No security response required. Ensure the QML crash reporter is exercised with a failing background thread to confirm the real exception is now reported.

Security signals we found

01

Crash reporter failure could hide or obscure real runtime errors in background threads

02

No input validation, privilege boundary, or cryptographic issue present

03

Fix improves diagnostic fidelity but does not close an attack vector

Risk score

Why this scored 19/100

Our methodology →
Potential impact 3/30
Exploitability 0/25
Stealth signal 2/15
Affected reach 2/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.