AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 40 Bitcoin

Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

Public commit record

What the developer wrote

Authored by ThomasV

73/100 · Adequate
Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

make_unsigned_transaction: do not require coins if there is a base_tx
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already contained inputs. The fix removes that requirement and adds a safety check to ensure the final transaction still has at least one input. In plain terms: it stops the wallet from refusing to build certain valid transactions and makes sure it cannot accidentally build a transaction with no inputs, which the Bitcoin network would reject anyway.

Recommended action

Review callers of make_unsigned_transaction() that pass base_tx to confirm they cannot reach the PartialTransaction constructor with tx_inputs empty, and verify the new assertion cannot be triggered through any code path. No urgent patch is indicated, but treat as a hardening change worth including in release notes.

Security signals we found

01

Relaxation of input-source precondition

02

Addition of consensus-level invariant assertion (at least one input)

03

Addition of empty-input guard before PartialTransaction construction

04

Potential for previously thrown NotEnoughFunds to be bypassed when base_tx is present

Risk score

Why this scored 40/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 5/15
Affected reach 6/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.