AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

qml: enforce use of existing password for wallet creation

Public commit record

What the developer wrote

Authored by f321x

73/100 · Adequate
qml: enforce use of existing password for wallet creation

When creating a new wallet in a Electrum instance with existing wallets
this change forces the user to reuse a password of any existing wallet
if `SimpleConfig.WALLET_USE_SINGLE_PASSWORD` is True.
This prevents the amount of different passwords from increasing and
guides the user towards a single wallet password (the intended default).
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit is a hardening and usability change for Electrum's mobile/QML wallet creation wizard. When the app is configured to prefer a single password across wallets, it now forces the user to reuse an existing wallet password when creating a new wallet, instead of allowing a new password. It also renames an internal configuration flag and exposes helper functions to check how many wallets a password can unlock. There is no direct security vulnerability being patched; it is a defensive measure to reduce password fragmentation.

Recommended action

No immediate action required. Reviewers may want to confirm that the password comparison timer does not leak timing information and that check_password_for_directory cannot be invoked in a way that allows unauthenticated password guessing beyond the existing threat model. Consider whether rate limiting or logging is appropriate for repeated calls to numWalletsWithPassword.

Security signals we found

01

Renames configuration flag from WALLET_USE_SINGLE_PASSWORD to WALLET_SHOULD_USE_SINGLE_PASSWORD

02

Makes password-directory check public and returns unlockable wallet paths

03

Adds QML bindings to count wallets unlockable with a candidate password

04

Enforces password reuse during new-wallet creation in QML wizard when single-password mode is enabled

05

Adds user-facing guidance text about password unification

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.