AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 29 Bitcoin

make_unsigned_transaction: do not require coins if there is a base_tx

Public commit record

What the developer wrote

Authored by ThomasV

73/100 · Adequate
make_unsigned_transaction: do not require coins if there is a base_tx

The inputs of base_tx can pay for its replacement, by lowering its
change, so we should not rause NotEnoughFunds even with no coin and
no inputs.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base transaction' is provided, because the new transaction can re-use the inputs from that base transaction (for example, to create a replacement transaction or bump the fee). The commit also adds a safety check that the final transaction still has at least one input. It appears to be a bug fix for a legitimate wallet workflow rather than a security vulnerability.

Recommended action

No immediate security action required. Reviewers should verify that all code paths constructing a transaction from base_tx correctly populate tx_inputs from base_tx.inputs() and that the new assertion cannot be bypassed. Consider whether any caller can reach the assertion with zero inputs due to an empty base_tx, which would raise an AssertionError rather than the previous NotEnoughFunds exception.

Security signals we found

01

Relaxation of input/coin availability guard

02

Addition of post-construction input count assertion

03

Potential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs

Risk score

Why this scored 29/100

Our methodology →
Potential impact 5/30
Exploitability 5/25
Stealth signal 5/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.